45199 2010-09-03 14:22:26 -0700 Uninitialized member variable in PolicyCallback 2011-03-08 16:02:24 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham ap oldest_to_newest 274174 0 bfulgham 2010-09-03 14:22:26 -0700 BoundsChecker noticed several copy operations for PolicyCallback where the m_argument member was uninitialized. Proposed patch: $ svn diff PolicyCallback.cpp Index: PolicyCallback.cpp =================================================================== --- PolicyCallback.cpp (revision 66733) +++ PolicyCallback.cpp (working copy) @@ -42,6 +42,7 @@ : m_navigationFunction(0) , m_newWindowFunction(0) , m_contentFunction(0) + , m_argument(0) { } 364207 1 85104 bfulgham 2011-03-08 15:57:43 -0800 Created attachment 85104 Resolve uninitialized variable. Correct an old uninitialized variable found during a BoundsChecker run. 364209 2 bfulgham 2011-03-08 16:02:24 -0800 Landed in http://trac.webkit.org/changeset/80601. 85104 2011-03-08 15:57:43 -0800 2011-03-08 15:58:54 -0800 Resolve uninitialized variable. boundschecker.patch text/plain 1084 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwNjAwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMDggIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENvcnJlY3QgdW5pbml0aWFsaXplZCB2YXJpYWJsZSBpbiBQ b2xpY3lDYWxsYmFjayBmb3VuZCB3aGlsZQorICAgICAgICBydW5uaW5nIFdlYktpdCBpbiBCb3Vu ZHNDaGVja2VyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDUxOTkuCisKKyAgICAgICAgKiBsb2FkZXIvUG9saWN5Q2FsbGJhY2suY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UG9saWN5Q2FsbGJhY2s6OlBvbGljeUNhbGxiYWNrKTogSW5pdGlhbGl6ZQor ICAgICAgICBtX2FyZ3VtZW50LgorCiAyMDExLTAzLTA4ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdo YW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBNb3JlIGJ1aWxkIGJ1c3RhZ2UgZml4LgpJbmRleDog U291cmNlL1dlYkNvcmUvbG9hZGVyL1BvbGljeUNhbGxiYWNrLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9sb2FkZXIvUG9saWN5Q2FsbGJhY2suY3BwCShyZXZpc2lvbiA4MDU5NikK KysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Qb2xpY3lDYWxsYmFjay5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTQyLDYgKzQyLDcgQEAgUG9saWN5Q2FsbGJhY2s6OlBvbGljeUNhbGxiYWNrKCkKICAg ICA6IG1fbmF2aWdhdGlvbkZ1bmN0aW9uKDApCiAgICAgLCBtX25ld1dpbmRvd0Z1bmN0aW9uKDAp CiAgICAgLCBtX2NvbnRlbnRGdW5jdGlvbigwKQorICAgICwgbV9hcmd1bWVudCgwKQogewogfQog Cg==