45175 2010-09-03 08:07:43 -0700 [WebView unmarkAllTextMatches] will crash if the webview is already closed 2010-09-03 08:34:03 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 sullivan sullivan oldest_to_newest 273945 0 sullivan 2010-09-03 08:07:43 -0700 [WebView unmarkAllTextMatches] should be robust if it's called when the webview is already closed. Radar bug 8391230 is a case where this crash can occur. 273947 1 66495 sullivan 2010-09-03 08:12:41 -0700 Created attachment 66495 Bail out if WebView is closed 273957 2 sullivan 2010-09-03 08:34:03 -0700 Landed in r66733. 66495 2010-09-03 08:12:41 -0700 2010-09-03 08:25:47 -0700 Bail out if WebView is closed unmarkAllTextMatches_patch.txt text/plain 2378 sullivan SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA2NjczMSkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMDktMDMgIEpvaG4gU3VsbGl2YW4gIDxzdWxs aXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisg ICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDUxNzUKKyAgICAgICAgW1dlYlZpZXcgdW5tYXJrQWxsVGV4dE1hdGNoZXNdIHdpbGwgY3Jhc2gg aWYgdGhlIHdlYnZpZXcgaXMgYWxyZWFkeSBjbG9zZWQKKworICAgICAgICBNYWRlIHRoaXMgYW5k IHJlbGF0ZWQgbWV0aG9kcyByb2J1c3QgYWdhaW5zdCBiZWluZyBjYWxsZWQgd2hlbiB0aGUgV2Vi VmlldyBpcyBjbG9zZWQuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubW06CisgICAgICAg ICgtW1dlYlZpZXcgbWFya0FsbE1hdGNoZXNGb3JUZXh0OmNhc2VTZW5zaXRpdmU6aGlnaGxpZ2h0 OmxpbWl0Ol0pOgorICAgICAgICBCYWlsIG91dCBpZiB0aGUgV2ViVmlldyBpcyBjbG9zZWQuCisg ICAgICAgICgtW1dlYlZpZXcgY291bnRNYXRjaGVzRm9yVGV4dDpjYXNlU2Vuc2l0aXZlOmhpZ2hs aWdodDpsaW1pdDptYXJrTWF0Y2hlczpdKToKKyAgICAgICAgRGl0dG8uCisgICAgICAgICgtW1dl YlZpZXcgdW5tYXJrQWxsVGV4dE1hdGNoZXNdKToKKyAgICAgICAgRGl0dG8uCisgICAgICAgICgt W1dlYlZpZXcgcmVjdHNGb3JUZXh0TWF0Y2hlc10pOgorICAgICAgICBEaXR0by4KKwogMjAxMC0w OS0wMyAgSGlyb25vcmkgQm9ubyAgPGhib25vQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBLZW50IFRhbXVyYS4KSW5kZXg6IFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCShyZXZpc2lvbiA2 NjczMSkKKysrIFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBA IC00MzgwLDExICs0MzgwLDE3IEBAIC0gKEJPT0wpY2FuTWFya0FsbFRleHRNYXRjaGVzCiAKIC0g KE5TVUludGVnZXIpbWFya0FsbE1hdGNoZXNGb3JUZXh0OihOU1N0cmluZyAqKXN0cmluZyBjYXNl U2Vuc2l0aXZlOihCT09MKWNhc2VGbGFnIGhpZ2hsaWdodDooQk9PTCloaWdobGlnaHQgbGltaXQ6 KE5TVUludGVnZXIpbGltaXQKIHsKKyAgICBpZiAoX3ByaXZhdGUtPmNsb3NlZCkKKyAgICAgICAg cmV0dXJuIDA7CisKICAgICByZXR1cm4gW3NlbGYgY291bnRNYXRjaGVzRm9yVGV4dDpzdHJpbmcg Y2FzZVNlbnNpdGl2ZTpjYXNlRmxhZyBoaWdobGlnaHQ6aGlnaGxpZ2h0IGxpbWl0OmxpbWl0IG1h cmtNYXRjaGVzOllFU107CiB9CiAKIC0gKE5TVUludGVnZXIpY291bnRNYXRjaGVzRm9yVGV4dDoo TlNTdHJpbmcgKilzdHJpbmcgY2FzZVNlbnNpdGl2ZTooQk9PTCljYXNlRmxhZyBoaWdobGlnaHQ6 KEJPT0wpaGlnaGxpZ2h0IGxpbWl0OihOU1VJbnRlZ2VyKWxpbWl0IG1hcmtNYXRjaGVzOihCT09M KW1hcmtNYXRjaGVzCiB7CisgICAgaWYgKF9wcml2YXRlLT5jbG9zZWQpCisgICAgICAgIHJldHVy biAwOworCiAgICAgV2ViRnJhbWUgKmZyYW1lID0gW3NlbGYgbWFpbkZyYW1lXTsKICAgICB1bnNp Z25lZCBtYXRjaENvdW50ID0gMDsKICAgICBkbyB7CkBAIC00NDA5LDYgKzQ0MTUsOSBAQCAtIChO U1VJbnRlZ2VyKWNvdW50TWF0Y2hlc0ZvclRleHQ6KE5TU3RyCiAKIC0gKHZvaWQpdW5tYXJrQWxs VGV4dE1hdGNoZXMKIHsKKyAgICBpZiAoX3ByaXZhdGUtPmNsb3NlZCkKKyAgICAgICAgcmV0dXJu OworCiAgICAgV2ViRnJhbWUgKmZyYW1lID0gW3NlbGYgbWFpbkZyYW1lXTsKICAgICBkbyB7CiAg ICAgICAgIGlkIDxXZWJEb2N1bWVudFZpZXc+IHZpZXcgPSBbW2ZyYW1lIGZyYW1lVmlld10gZG9j dW1lbnRWaWV3XTsKQEAgLTQ0MjEsNiArNDQzMCw5IEBAIC0gKHZvaWQpdW5tYXJrQWxsVGV4dE1h dGNoZXMKIAogLSAoTlNBcnJheSAqKXJlY3RzRm9yVGV4dE1hdGNoZXMKIHsKKyAgICBpZiAoX3By aXZhdGUtPmNsb3NlZCkKKyAgICAgICAgcmV0dXJuIFtOU0FycmF5IGFycmF5XTsKKwogICAgIE5T TXV0YWJsZUFycmF5ICpyZXN1bHQgPSBbTlNNdXRhYmxlQXJyYXkgYXJyYXldOwogICAgIFdlYkZy YW1lICpmcmFtZSA9IFtzZWxmIG1haW5GcmFtZV07CiAgICAgZG8gewo=