45172 2010-09-03 06:36:05 -0700 Web Inspector: cleanup inspector api. getChildNodes should return children nodes as an output value. 2010-09-03 12:31:22 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 45195 45184 1 loislo loislo bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 273905 0 loislo 2010-09-03 06:36:05 -0700 current implementation of the inspector api has some unnecessary complexity. As example WebInspector is requesting children nodes of a node by getChildNodes but DOM agent is actually pushing the child nodes via setChildNodes event call and send back an empty response message. 273912 1 66488 loislo 2010-09-03 06:48:57 -0700 Created attachment 66488 [patch] initial version. 273950 2 66488 commit-queue 2010-09-03 08:18:08 -0700 Comment on attachment 66488 [patch] initial version. Clearing flags on attachment: 66488 Committed r66732: <http://trac.webkit.org/changeset/66732> 273951 3 commit-queue 2010-09-03 08:18:12 -0700 All reviewed patches have been landed. Closing bug. 274034 4 66488 pfeldman 2010-09-03 10:58:07 -0700 Comment on attachment 66488 [patch] initial version. I don't think it is good idea and would vote to rolling this back. It is important that all the information is pushed to the DOMAgent.js by means of the same pushChildren method. Otherwise DOMAgent.js and InspectorDOMAgent may get easily our of sync. I do realize that API needs to be brushed up, but I'd start with pushDocument refactorings so that there is no DOM-related traffic unless requested. 66488 2010-09-03 06:48:57 -0700 2010-09-03 10:58:07 -0700 [patch] initial version. patch text/plain 7287 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2JmNjdiOS4uM2Q1MzNlMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOSBAQAorMjAxMC0wOS0wMyAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogY2xlYW51cCBpbnNwZWN0b3IgYXBp LiBnZXRDaGlsZE5vZGVzIHNob3VsZCByZXR1cm4gYXJyYXkgb2YgY2hpbGQgbm9kZXMgYXMgYW4g b3V0cHV0IHZhbHVlLgorCisgICAgICAgIFRoZSBjdXJyZW50IGltcGxlbWVudGF0aW9uIG9mIHRo ZSBpbnNwZWN0b3IgYXBpIGhhcyBzb21lIHVubmVjZXNzYXJ5IGNvbXBsZXhpdHkuIAorICAgICAg ICBBcyBleGFtcGxlIFdlYkluc3BlY3RvciBpcyByZXF1ZXN0aW5nIGNoaWxkIG5vZGVzIG9mIGEg bm9kZSBieSBnZXRDaGlsZE5vZGVzCisgICAgICAgIGJ1dCBET00gYWdlbnQgaXMgYWN0dWFsbHkg cHVzaGluZyB0aGUgY2hpbGQgbm9kZXMgdmlhIHNldENoaWxkTm9kZXMgZXZlbnQgY2FsbCBhbmQK KyAgICAgICAgc2VuZCBiYWNrIGFuIGVtcHR5IHJlc3BvbnNlIG1lc3NhZ2UuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1MTcyCisKKyAgICAgICAg KiBpbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5wbToKKyAgICAgICAgKiBpbnNwZWN0 b3IvSW5zcGVjdG9yLmlkbDoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6OmdldENoaWxkTm9kZXNB cnJheSk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01BZ2VudDo6cHVzaENoaWxkTm9k ZXNUb0Zyb250ZW5kKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRPTUFnZW50OjpnZXRD aGlsZE5vZGVzKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuaDoKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RPTUFnZW50LmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkRPTUFnZW50LnByb3RvdHlwZS5nZXRDaGlsZE5vZGVzQXN5bmMubXljYWxsYmFjayk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NQWdlbnQucHJvdG90eXBlLmdldENoaWxkTm9kZXNB c3luYyk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Xb3JrZXJzU2lkZWJhclBhbmUu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuV29ya2Vyc1NpZGViYXJQYW5lLnByb3RvdHlwZS5y ZXNldCk6CisKIDIwMTAtMDgtMzEgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3RldmUgQmxvY2suCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2luc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnBtIGIvV2ViQ29yZS9pbnNwZWN0b3Iv Q29kZUdlbmVyYXRvckluc3BlY3Rvci5wbQppbmRleCBkNzZmYmQzLi5kZjNmY2M0IDEwMDY0NAot LS0gYS9XZWJDb3JlL2luc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnBtCisrKyBiL1dl YkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucG0KQEAgLTUzNyw4ICs1Mzcs OCBAQCBXZWJJbnNwZWN0b3IuSW5zcGVjdG9yQmFja2VuZFN0dWIucHJvdG90eXBlID0gewogICAg ICAgICAgICAgICAgIGNvbnNvbGUuZXJyb3IoIlByb3RvY29sIEVycm9yOiBPcHRpb25hbCBjYWxs YmFjayBhcmd1bWVudCBmb3IgJ0luc3BlY3RvckJhY2tlbmQuJXMnIGNhbGwgc2hvdWxkIGJlIGEg ZnVuY3Rpb24gYnV0IGl0cyB0eXBlIGlzICclcycuIiwgcmVxdWVzdC5jb21tYW5kLCB0eXBlb2Yg YXJnc1swXSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQotICAgICAg ICAgICAgcmVxdWVzdC5zZXEgPSBXZWJJbnNwZWN0b3IuQ2FsbGJhY2sud3JhcChhcmdzWzBdKTsK ICAgICAgICAgfQorICAgICAgICByZXF1ZXN0LnNlcSA9IFdlYkluc3BlY3Rvci5DYWxsYmFjay53 cmFwKGFyZ3NbMF0gPyBhcmdzWzBdIDogZnVuY3Rpb24oKSB7IH0pOwogCiAgICAgICAgIHZhciBt ZXNzYWdlID0gSlNPTi5zdHJpbmdpZnkocmVxdWVzdCk7CiAgICAgICAgIEluc3BlY3RvckZyb250 ZW5kSG9zdC5zZW5kTWVzc2FnZVRvQmFja2VuZChtZXNzYWdlKTsKZGlmZiAtLWdpdCBhL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3Rvci5pZGwgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3Iu aWRsCmluZGV4IDFmMDM0YjIuLmZmYzVhYjEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3Rvci5pZGwKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLmlkbApAQCAt MTYxLDcgKzE2MSw3IEBAIG1vZHVsZSBjb3JlIHsKICAgICAgICAgW2hhbmRsZXI9Q29udHJvbGxl cl0gdm9pZCBhZGRTY3JpcHRUb0V2YWx1YXRlT25Mb2FkKGluIFN0cmluZyBzY3JpcHRTb3VyY2Up OwogICAgICAgICBbaGFuZGxlcj1Db250cm9sbGVyXSB2b2lkIHJlbW92ZUFsbFNjcmlwdHNUb0V2 YWx1YXRlT25Mb2FkKCk7CiAKLSAgICAgICAgW2hhbmRsZXI9RE9NXSB2b2lkIGdldENoaWxkTm9k ZXMoaW4gbG9uZyBub2RlSWQpOworICAgICAgICBbaGFuZGxlcj1ET01dIHZvaWQgZ2V0Q2hpbGRO b2RlcyhpbiBsb25nIG5vZGVJZCwgb3V0IEFycmF5IG5vZGVzKTsKICAgICAgICAgW2hhbmRsZXI9 RE9NXSB2b2lkIHNldEF0dHJpYnV0ZShpbiBsb25nIGVsZW1lbnRJZCwgaW4gU3RyaW5nIG5hbWUs IGluIFN0cmluZyB2YWx1ZSwgb3V0IGJvb2xlYW4gc3VjY2Vzcyk7CiAgICAgICAgIFtoYW5kbGVy PURPTV0gdm9pZCByZW1vdmVBdHRyaWJ1dGUoaW4gbG9uZyBlbGVtZW50SWQsIGluIFN0cmluZyBu YW1lLCBvdXQgYm9vbGVhbiBzdWNjZXNzKTsKICAgICAgICAgW2hhbmRsZXI9RE9NXSB2b2lkIHNl dFRleHROb2RlVmFsdWUoaW4gbG9uZyBub2RlSWQsIGluIFN0cmluZyB2YWx1ZSwgb3V0IGJvb2xl YW4gc3VjY2Vzcyk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01B Z2VudC5jcHAgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKaW5kZXgg ZDI3NjBlNC4uNTNmNjU0NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y RE9NQWdlbnQuY3BwCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNw cApAQCAtMzYwLDE4ICszNjAsMjYgQEAgYm9vbCBJbnNwZWN0b3JET01BZ2VudDo6cHVzaERvY3Vt ZW50VG9Gcm9udGVuZCgpCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLXZvaWQgSW5zcGVjdG9yRE9N QWdlbnQ6OnB1c2hDaGlsZE5vZGVzVG9Gcm9udGVuZChsb25nIG5vZGVJZCkKK1Bhc3NSZWZQdHI8 SW5zcGVjdG9yQXJyYXk+IEluc3BlY3RvckRPTUFnZW50OjpnZXRDaGlsZE5vZGVzQXJyYXkobG9u ZyBub2RlSWQpCiB7CiAgICAgTm9kZSogbm9kZSA9IG5vZGVGb3JJZChub2RlSWQpOwogICAgIGlm ICghbm9kZSB8fCAobm9kZS0+bm9kZVR5cGUoKSAhPSBOb2RlOjpFTEVNRU5UX05PREUgJiYgbm9k ZS0+bm9kZVR5cGUoKSAhPSBOb2RlOjpET0NVTUVOVF9OT0RFICYmIG5vZGUtPm5vZGVUeXBlKCkg IT0gTm9kZTo6RE9DVU1FTlRfRlJBR01FTlRfTk9ERSkpCi0gICAgICAgIHJldHVybjsKKyAgICAg ICAgcmV0dXJuIDA7CisKKyAgICBOb2RlVG9JZE1hcCogbm9kZU1hcCA9IG1faWRUb05vZGVzTWFw LmdldChub2RlSWQpOworICAgIHJldHVybiBidWlsZEFycmF5Rm9yQ29udGFpbmVyQ2hpbGRyZW4o bm9kZSwgMSwgbm9kZU1hcCk7Cit9CisKK3ZvaWQgSW5zcGVjdG9yRE9NQWdlbnQ6OnB1c2hDaGls ZE5vZGVzVG9Gcm9udGVuZChsb25nIG5vZGVJZCkKK3sKICAgICBpZiAobV9jaGlsZHJlblJlcXVl c3RlZC5jb250YWlucyhub2RlSWQpKQogICAgICAgICByZXR1cm47CiAKLSAgICBOb2RlVG9JZE1h cCogbm9kZU1hcCA9IG1faWRUb05vZGVzTWFwLmdldChub2RlSWQpOwotICAgIFJlZlB0cjxJbnNw ZWN0b3JBcnJheT4gY2hpbGRyZW4gPSBidWlsZEFycmF5Rm9yQ29udGFpbmVyQ2hpbGRyZW4obm9k ZSwgMSwgbm9kZU1hcCk7Ci0gICAgbV9jaGlsZHJlblJlcXVlc3RlZC5hZGQobm9kZUlkKTsKLSAg ICBtX2Zyb250ZW5kLT5zZXRDaGlsZE5vZGVzKG5vZGVJZCwgY2hpbGRyZW4ucmVsZWFzZSgpKTsK KyAgICBQYXNzUmVmUHRyPEluc3BlY3RvckFycmF5PiBub2RlcyA9IGdldENoaWxkTm9kZXNBcnJh eShub2RlSWQpOworICAgIGlmIChub2RlcykgeworICAgICAgICBtX2Zyb250ZW5kLT5zZXRDaGls ZE5vZGVzKG5vZGVJZCwgbm9kZXMpOworICAgICAgICBtX2NoaWxkcmVuUmVxdWVzdGVkLmFkZChu b2RlSWQpOworICAgIH0KIH0KIAogbG9uZyBJbnNwZWN0b3JET01BZ2VudDo6aW5zcGVjdGVkTm9k ZSh1bnNpZ25lZCBsb25nIG51bSkKQEAgLTQwMiw5ICs0MTAsMTIgQEAgTm9kZSogSW5zcGVjdG9y RE9NQWdlbnQ6Om5vZGVGb3JJZChsb25nIGlkKQogICAgIHJldHVybiAwOwogfQogCi12b2lkIElu c3BlY3RvckRPTUFnZW50OjpnZXRDaGlsZE5vZGVzKGxvbmcgbm9kZUlkKQordm9pZCBJbnNwZWN0 b3JET01BZ2VudDo6Z2V0Q2hpbGROb2Rlcyhsb25nIG5vZGVJZCwgUmVmUHRyPEluc3BlY3RvckFy cmF5Piogbm9kZXMpCiB7Ci0gICAgcHVzaENoaWxkTm9kZXNUb0Zyb250ZW5kKG5vZGVJZCk7Cisg ICAgUGFzc1JlZlB0cjxJbnNwZWN0b3JBcnJheT4gY2hpbGROb2RlcyA9IGdldENoaWxkTm9kZXNB cnJheShub2RlSWQpOworICAgIGlmIChjaGlsZE5vZGVzKQorICAgICAgICAqbm9kZXMgPSBjaGls ZE5vZGVzOworICAgIG1fY2hpbGRyZW5SZXF1ZXN0ZWQuYWRkKG5vZGVJZCk7CiB9CiAKIGxvbmcg SW5zcGVjdG9yRE9NQWdlbnQ6OnB1c2hOb2RlUGF0aFRvRnJvbnRlbmQoTm9kZSogbm9kZVRvUHVz aCkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmggYi9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5oCmluZGV4IGZkM2M1YjUuLjMwMDYy NzMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmgKKysr IGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuaApAQCAtMTAwLDcgKzEwMCw3 IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdmlydHVhbCBib29sIG9wZXJhdG9yPT0o Y29uc3QgRXZlbnRMaXN0ZW5lciYgb3RoZXIpOwogCiAgICAgICAgIC8vIE1ldGhvZHMgY2FsbGVk IGZyb20gdGhlIGZyb250ZW5kIGZvciBET00gbm9kZXMgaW5zcGVjdGlvbi4KLSAgICAgICAgdm9p ZCBnZXRDaGlsZE5vZGVzKGxvbmcgbm9kZUlkKTsKKyAgICAgICAgdm9pZCBnZXRDaGlsZE5vZGVz KGxvbmcgbm9kZUlkLCBSZWZQdHI8SW5zcGVjdG9yQXJyYXk+KiBub2Rlcyk7CiAgICAgICAgIHZv aWQgc2V0QXR0cmlidXRlKGxvbmcgZWxlbWVudElkLCBjb25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0 IFN0cmluZyYgdmFsdWUsIGJvb2wqIHN1Y2Nlc3MpOwogICAgICAgICB2b2lkIHJlbW92ZUF0dHJp YnV0ZShsb25nIGVsZW1lbnRJZCwgY29uc3QgU3RyaW5nJiBuYW1lLCBib29sKiBzdWNjZXNzKTsK ICAgICAgICAgdm9pZCByZW1vdmVOb2RlKGxvbmcgbm9kZUlkLCBsb25nKiBvdXROb2RlSWQpOwpA QCAtMTQ2LDYgKzE0Niw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCBjb3B5 Tm9kZShsb25nIG5vZGVJZCk7CiAKICAgICBwcml2YXRlOgorICAgICAgICBQYXNzUmVmUHRyPElu c3BlY3RvckFycmF5PiBnZXRDaGlsZE5vZGVzQXJyYXkobG9uZyBub2RlSWQpOwogICAgICAgICBz dGF0aWMgQ1NTU3R5bGVTaGVldCogZ2V0UGFyZW50U3R5bGVTaGVldChDU1NTdHlsZURlY2xhcmF0 aW9uKik7CiAgICAgICAgIHZvaWQgc3RhcnRMaXN0ZW5pbmcoRG9jdW1lbnQqIGRvY3VtZW50KTsK ICAgICAgICAgdm9pZCBzdG9wTGlzdGVuaW5nKERvY3VtZW50KiBkb2N1bWVudCk7CmRpZmYgLS1n aXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NQWdlbnQuanMgYi9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvRE9NQWdlbnQuanMKaW5kZXggOWIzODZjMy4uNTc5NzUwMiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RPTUFnZW50LmpzCisrKyBiL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2VudC5qcwpAQCAtMzQxLDcgKzM0MSw5IEBA IFdlYkluc3BlY3Rvci5ET01BZ2VudC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBjYWxsYmFj ayhjaGlsZHJlbik7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KLSAgICAgICAgZnVu Y3Rpb24gbXljYWxsYmFjaygpIHsKKyAgICAgICAgZnVuY3Rpb24gbXljYWxsYmFjayhub2Rlcykg eworICAgICAgICAgICAgcGFyZW50Ll9zZXRDaGlsZHJlblBheWxvYWQobm9kZXMpOworICAgICAg ICAgICAgV2ViSW5zcGVjdG9yLmRvbUFnZW50Ll9iaW5kTm9kZXMocGFyZW50LmNoaWxkcmVuKTsK ICAgICAgICAgICAgIGNhbGxiYWNrKHBhcmVudC5jaGlsZHJlbik7CiAgICAgICAgIH0KICAgICAg ICAgSW5zcGVjdG9yQmFja2VuZC5nZXRDaGlsZE5vZGVzKHBhcmVudC5pZCwgbXljYWxsYmFjayk7 CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvV29ya2Vyc1NpZGViYXJQ YW5lLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1dvcmtlcnNTaWRlYmFyUGFuZS5q cwppbmRleCA3ZDZhMDBmLi5iZThiODZmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvV29ya2Vyc1NpZGViYXJQYW5lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9Xb3JrZXJzU2lkZWJhclBhbmUuanMKQEAgLTgwLDcgKzgwLDYgQEAgV2ViSW5zcGVj dG9yLldvcmtlcnNTaWRlYmFyUGFuZS5wcm90b3R5cGUgPSB7CiAKICAgICByZXNldDogZnVuY3Rp b24oKQogICAgIHsKLSAgICAgICAgSW5zcGVjdG9yQmFja2VuZC5yZW1vdmVBbGxTY3JpcHRzVG9F dmFsdWF0ZU9uTG9hZCgpOwogICAgICAgICB0aGlzLnNldEluc3RydW1lbnRhdGlvbih0aGlzLl9l bmFibGVXb3JrZXJzQ2hlY2tib3guY2hlY2tlZCk7CiAgICAgICAgIHRoaXMuX3RyZWVPdXRsaW5l LnJlbW92ZUNoaWxkcmVuKCk7CiAgICAgICAgIHRoaXMuX3dvcmtlcnMgPSB7fTsK