45133 2010-09-02 14:34:21 -0700 [chromium] Make a public flag for how DRT generates bitmaps on Linux 2010-09-07 15:21:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony fishd oldest_to_newest 273581 0 tony 2010-09-02 14:34:21 -0700 [chromium] Make a public flag for how DRT generates bitmaps on Linux 273583 1 66413 tony 2010-09-02 14:36:44 -0700 Created attachment 66413 Patch 273584 2 tony 2010-09-02 14:42:47 -0700 I'm trying to fix http://code.google.com/p/chromium/issues/detail?id=21386. Here is my plan: 1) Expose a variable in WebKit that determines whether or not to call makeOpaque (this patch). 2) In Chromium, switch test_shell to use that flag. 3) In WebKit, flip the flag and checkin a bunch of new checksums. 4) In Chromium, remove the flag in test_shell and have us always call makeOpaque on Linux and Windows. 5) In WebKit, remove the flag in DRT and remove the variable added in (1). I'm not too excited about where I put the variable or how I named it. Suggestions welcome. 273604 3 66413 fishd 2010-09-02 15:18:34 -0700 Comment on attachment 66413 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66413&action=prettypatch > WebKit/chromium/public/DumpRenderTreeDefaults.h:36 > +extern const bool makeLinuxChecksumOpaque; it seems like this would be better done without a globally exported variable. how about a setter and a getter in the usual fashion? also, why the DumpRenderTree namespace in the WebKit API's public directory? can you just place these methods in WebKit.h next to setLayoutTestMode/layoutTestMode? 273626 4 66424 tony 2010-09-02 15:44:39 -0700 Created attachment 66424 Patch 273628 5 tony 2010-09-02 15:45:44 -0700 (In reply to comment #3) > can you just place these methods in WebKit.h next to setLayoutTestMode/layoutTestMode? I didn't see WebKit.h. Yes, this is a much better place for this. 275274 6 tony 2010-09-07 14:03:11 -0700 Darin, can you take a look at the revised patch? 275300 7 66424 fishd 2010-09-07 14:34:53 -0700 Comment on attachment 66424 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66424&action=prettypatch > WebKit/chromium/public/WebKit.h:60 > +WEBKIT_API bool makeLinuxChecksumOpaque(); this method name sounds like something that is a command. hey you, go make it opaque. but the signature looks more like a getter. how about "isLinuxChecksumOpaque"? that said, i'm not sure what it means for a checksum to be opaque. hmm... how about "areLayoutTestImagesOpaque"? R=me modulo this re-naming suggestion 275302 8 fishd 2010-09-07 14:35:58 -0700 Also, if the comment could say that this flag describes the format of layout test image baselines that would be helpful. 275332 9 tony 2010-09-07 15:21:14 -0700 Committed r66914: <http://trac.webkit.org/changeset/66914> 66413 2010-09-02 14:36:44 -0700 2010-09-02 15:44:35 -0700 Patch bug-45133-20100902143535.patch text/plain 8440 tony ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDUyN2U4ZWZjY2FlMzkwNDVmZDk4NWRlZDNiZjIwZDcxNjZhZmM2OWQu LjY1NTk3NzgwMTEwNWRlOTU2OWZlZTVmMTIwNTcyNmYyY2E1ZjU2MmMgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE4IEBACisyMDEwLTA5LTAyICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSBNYWtlIGEgcHVibGljIGZsYWcgZm9yIGhvdyBEUlQgZ2VuZXJhdGVzIGJpdG1hcHMg b24gTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ1MTMzCisKKyAgICAgICAgVGhpcyBpcyBzbyBpdCdzIHBvc3NpYmxlIGZvciBtZSB0byBmaXgK KyAgICAgICAgaHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/ aWQ9MjEzODYgLgorCisgICAgICAgICogREVQUzogUm9sbCB0byBpbmNsdWRlIHNraWEgY2hhbmdl LgorICAgICAgICAqIFdlYktpdC5neXA6IEFkZCBuZXcgZmlsZXMKKyAgICAgICAgKiBwdWJsaWMv RHVtcFJlbmRlclRyZWVEZWZhdWx0cy5oOiBBZGRlZC4KKyAgICAgICAgKiBzcmMvRHVtcFJlbmRl clRyZWVEZWZhdWx0cy5jcHA6IEFkZGVkLgorCiAyMDEwLTA5LTAyICBJbHlhIFNoZXJtYW4gIDxp c2hlcm1hbkBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpk aWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL0RFUFMgYi9XZWJLaXQvY2hyb21pdW0vREVQUwpp bmRleCA2MjUyZjA4ZWQ4M2RjYmQ3M2JjYTdiNDBmOWI3YWVjZjBjMTg1NTEwLi4zODU4YmRkN2Y3 ZjNkMzNkOWU5ZTUxYjg0ZDA1YTJmZmEwMTAxYjZkIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21p dW0vREVQUworKysgYi9XZWJLaXQvY2hyb21pdW0vREVQUwpAQCAtMzIsNyArMzIsNyBAQAogCiB2 YXJzID0gewogICAnY2hyb21pdW1fc3ZuJzogJ2h0dHA6Ly9zcmMuY2hyb21pdW0ub3JnL3N2bi90 cnVuay9zcmMnLAotICAnY2hyb21pdW1fcmV2JzogJzU3ODIzJywKKyAgJ2Nocm9taXVtX3Jldic6 ICc1ODI3NCcsCiB9CiAKIGRlcHMgPSB7CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vV2Vi S2l0Lmd5cCBiL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCmluZGV4IGM3NWNhYzcyN2EzM2Zh NDZmNTc3NTBhNTUxNjJiNjE0MWFkN2NlOWMuLjQ1MjRhMmQzZjQxNTVkMGM4MTVmMmQ5OGVhMjhm YTZkMGNlZThmYWQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCisrKyBi L1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCkBAIC05Myw3ICs5Myw2IEBACiAgICAgICAgICAg ICAgICAgJ3B1YmxpYy9saW51eC9XZWJGb250UmVuZGVyaW5nLmgnLAogICAgICAgICAgICAgICAg ICdwdWJsaWMvbGludXgvV2ViRm9udFJlbmRlclN0eWxlLmgnLAogICAgICAgICAgICAgICAgICdw dWJsaWMvbGludXgvV2ViUmVuZGVyVGhlbWUuaCcsCi0gICAgICAgICAgICAgICAgJ3B1YmxpYy94 MTEvV2ViU2NyZWVuSW5mb0ZhY3RvcnkuaCcsCiAgICAgICAgICAgICAgICAgJ3B1YmxpYy9tYWMv V2ViSW5wdXRFdmVudEZhY3RvcnkuaCcsCiAgICAgICAgICAgICAgICAgJ3B1YmxpYy9tYWMvV2Vi U2FuZGJveFN1cHBvcnQuaCcsCiAgICAgICAgICAgICAgICAgJ3B1YmxpYy9tYWMvV2ViU2NyZWVu SW5mb0ZhY3RvcnkuaCcsCkBAIC0yNzUsNiArMjc0LDcgQEAKICAgICAgICAgICAgICAgICAncHVi bGljL3dpbi9XZWJTYW5kYm94U3VwcG9ydC5oJywKICAgICAgICAgICAgICAgICAncHVibGljL3dp bi9XZWJTY3JlZW5JbmZvRmFjdG9yeS5oJywKICAgICAgICAgICAgICAgICAncHVibGljL3dpbi9X ZWJTY3JlZW5JbmZvRmFjdG9yeS5oJywKKyAgICAgICAgICAgICAgICAncHVibGljL3gxMS9XZWJT Y3JlZW5JbmZvRmFjdG9yeS5oJywKICAgICAgICAgICAgICAgICAnc3JjL0FwcGxpY2F0aW9uQ2Fj aGVIb3N0LmNwcCcsCiAgICAgICAgICAgICAgICAgJ3NyYy9BcHBsaWNhdGlvbkNhY2hlSG9zdElu dGVybmFsLmgnLAogICAgICAgICAgICAgICAgICdzcmMvQXNzZXJ0TWF0Y2hpbmdFbnVtcy5jcHAn LApAQCAtNTMxLDYgKzUzMSwxMCBAQAogICAgICAgICAgICAgICAgICdzcmMvV3JhcHBlZFJlc291 cmNlUmVzcG9uc2UuaCcsCiAgICAgICAgICAgICAgICAgJ3NyYy93aW4vV2ViSW5wdXRFdmVudEZh Y3RvcnkuY3BwJywKICAgICAgICAgICAgICAgICAnc3JjL3dpbi9XZWJTY3JlZW5JbmZvRmFjdG9y eS5jcHAnLAorCisgICAgICAgICAgICAgICAgIyBUaGVzZSBhcmUgdGVtcG9yYXJ5IGFuZCB3aWxs IGdvIGF3YXkgc29vbi4KKyAgICAgICAgICAgICAgICAncHVibGljL0R1bXBSZW5kZXJUcmVlRGVm YXVsdHMuaCcsCisgICAgICAgICAgICAgICAgJ3NyYy9EdW1wUmVuZGVyVHJlZURlZmF1bHRzLmNw cCcsCiAgICAgICAgICAgICBdLAogICAgICAgICAgICAgJ2NvbmRpdGlvbnMnOiBbCiAgICAgICAg ICAgICAgICAgWydpbnNpZGVfY2hyb21pdW1fYnVpbGQ9PTEgYW5kIE9TPT0id2luIicsIHsKZGlm ZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvRHVtcFJlbmRlclRyZWVEZWZhdWx0cy5o IGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9EdW1wUmVuZGVyVHJlZURlZmF1bHRzLmgKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uZWQ0OTdhOGJhYmZiOGQ1NWU2Y2I5MGYxMGI5N2EwN2ViODJlMjg1MgotLS0gL2Rldi9u dWxsCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvRHVtcFJlbmRlclRyZWVEZWZhdWx0cy5o CkBAIC0wLDAgKzEsMzkgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTAgR29vZ2xlIEluYy4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNv dXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwg YXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUK KyAqIG1ldDoKKyAqCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVz dCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29u ZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogICAgICogUmVkaXN0cmli dXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorICogY29weXJp Z2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlz Y2xhaW1lcgorICogaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBw cm92aWRlZCB3aXRoIHRoZQorICogZGlzdHJpYnV0aW9uLgorICogICAgICogTmVpdGhlciB0aGUg bmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0cworICogY29udHJpYnV0b3Jz IG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20K KyAqIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Np b24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhP TERFUlMgQU5EIENPTlRSSUJVVE9SUworICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1Q TElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8sIFRIRSBJ TVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgorICog QSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRI RSBDT1BZUklHSFQKKyAqIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBE SVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAorICogU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBD T05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywg UFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0Us CisgKiBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIg Q0FVU0VEIEFORCBPTiBBTlkKKyAqIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09O VFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5D RSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0Yg VEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNI IERBTUFHRS4KKyAqLworCisjaWZuZGVmIER1bXBSZW5kZXJUcmVlRGVmYXVsdHNfaAorI2RlZmlu ZSBEdW1wUmVuZGVyVHJlZURlZmF1bHRzX2gKKworbmFtZXNwYWNlIER1bXBSZW5kZXJUcmVlIHsK KworZXh0ZXJuIGNvbnN0IGJvb2wgbWFrZUxpbnV4Q2hlY2tzdW1PcGFxdWU7CisKK30KKyNlbmRp ZiAvLyBEdW1wUmVuZGVyVHJlZURlZmF1bHRzX2gKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1 bS9zcmMvRHVtcFJlbmRlclRyZWVEZWZhdWx0cy5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0R1 bXBSZW5kZXJUcmVlRGVmYXVsdHMuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjU4NWVlYzQ2MTQ3Y2M3Y2M0YmZh MjMxM2QzYzUyZDEwMTgyNTY4MDMKLS0tIC9kZXYvbnVsbAorKysgYi9XZWJLaXQvY2hyb21pdW0v c3JjL0R1bXBSZW5kZXJUcmVlRGVmYXVsdHMuY3BwCkBAIC0wLDAgKzEsMzggQEAKKy8qCisgKiBD b3B5cmlnaHQgKEMpIDIwMTAgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisg KiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRo IG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0 IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyAqIG1ldDoKKyAqCisgKiAgICAgKiBSZWRp c3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdo dAorICogbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBk aXNjbGFpbWVyLgorICogICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3Qg cmVwcm9kdWNlIHRoZSBhYm92ZQorICogY29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNv bmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorICogaW4gdGhlIGRvY3VtZW50 YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQorICogZGlzdHJp YnV0aW9uLgorICogICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhl IG5hbWVzIG9mIGl0cworICogY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3Ig cHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KKyAqIHRoaXMgc29mdHdhcmUgd2l0aG91dCBz cGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJ UyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUworICog IkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcs IEJVVCBOT1QKKyAqIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hB TlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgorICogQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJ U0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyAqIE9XTkVSIE9SIENP TlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFM LAorICogU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xV RElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBH T09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisgKiBEQVRBLCBPUiBQUk9GSVRTOyBPUiBC VVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyAqIFRIRU9S WSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9S IFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4g QU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJ U0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaW5jbHVkZSAi Y29uZmlnLmgiCisjaW5jbHVkZSAiRHVtcFJlbmRlclRyZWVEZWZhdWx0cy5oIgorCituYW1lc3Bh Y2UgRHVtcFJlbmRlclRyZWUgeworCitjb25zdCBib29sIG1ha2VMaW51eENoZWNrc3VtT3BhcXVl ID0gZmFsc2U7CisKK30KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktp dFRvb2xzL0NoYW5nZUxvZwppbmRleCBhNTkxZDkyNjU0ZWM2MzIxNDhmYjU1NmE0NDg5Yjg4Mjk3 ZDJmMTc2Li5jYzMyYjk4MjIwY2I2Njk5OGQ0NTk5MTU3YmUwYzgxMDRiNTg1ZTljIDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMDIgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hy b21pdW1dIE1ha2UgYSBwdWJsaWMgZmxhZyBmb3IgaG93IERSVCBnZW5lcmF0ZXMgYml0bWFwcyBv biBMaW51eAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDUxMzMKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHA6 CisgICAgICAgIChUZXN0U2hlbGw6OmR1bXBJbWFnZSk6CisKIDIwMTAtMDktMDIgIFN0ZXZlIEJs b2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0g QmFydGguCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9U ZXN0U2hlbGwuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNo ZWxsLmNwcAppbmRleCAyMWExNTNkZDQ3ZWIxY2I1Y2EwNmNmODUyMzU1MWYyZTgzNGRlNGExLi5l MWNkZDcwMmZkNzAwNWI0YjkxYTQyMjVjZGIzZTJkZTNlMjllZDY5IDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwCisrKyBiL1dlYktp dFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAKQEAgLTM3LDYgKzM3 LDcgQEAKICNpbmNsdWRlICJXZWJWaWV3SG9zdC5oIgogI2luY2x1ZGUgImJhc2Uvc3RyaW5nMTYu aCIKICNpbmNsdWRlICJnZngvY29kZWMvcG5nX2NvZGVjLmgiIC8vIEZJWE1FOiBSZW1vdmUgZGVw ZW5kZWN5LiBXZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWVuY29kZXIgaXMgYmV0dGVyPworI2luY2x1 ZGUgInB1YmxpYy9EdW1wUmVuZGVyVHJlZURlZmF1bHRzLmgiCiAjaW5jbHVkZSAicHVibGljL1dl YkRhdGFTb3VyY2UuaCIKICNpbmNsdWRlICJwdWJsaWMvV2ViRG9jdW1lbnQuaCIKICNpbmNsdWRl ICJwdWJsaWMvV2ViRWxlbWVudC5oIgpAQCAtNTg3LDYgKzU4OCw4IEBAIHZvaWQgVGVzdFNoZWxs OjpkdW1wSW1hZ2Uoc2tpYTo6UGxhdGZvcm1DYW52YXMqIGNhbnZhcykgY29uc3QKICAgICBib29s IGRpc2NhcmRUcmFuc3BhcmVuY3kgPSBmYWxzZTsKICNlbGlmIE9TKFVOSVgpCiAgICAgYm9vbCBk aXNjYXJkVHJhbnNwYXJlbmN5ID0gdHJ1ZTsKKyAgICBpZiAoRHVtcFJlbmRlclRyZWU6Om1ha2VM aW51eENoZWNrc3VtT3BhcXVlKQorICAgICAgICBkZXZpY2UubWFrZU9wYXF1ZSgwLCAwLCBzb3Vy Y2VCaXRtYXAud2lkdGgoKSwgc291cmNlQml0bWFwLmhlaWdodCgpKTsKICNlbmRpZgogCiAgICAg Ly8gQ29tcHV0ZSBNRDUgc3VtLiAgV2Ugc2hvdWxkIGhhdmUgZG9uZSB0aGlzIGJlZm9yZSBjYWxs aW5nCg== 66424 2010-09-02 15:44:39 -0700 2010-09-07 14:34:53 -0700 Patch bug-45133-20100902154329.patch text/plain 3937 tony ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDUyN2U4ZWZjY2FlMzkwNDVmZDk4NWRlZDNiZjIwZDcxNjZhZmM2OWQu LmFhYTM3NjU5OTlmM2Y1YjM3NGNlN2QwYzEzZWNiMTE4ZjVjMDRiN2YgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE4IEBACisyMDEwLTA5LTAyICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSBNYWtlIGEgcHVibGljIGZsYWcgZm9yIGhvdyBEUlQgZ2VuZXJhdGVzIGJpdG1hcHMg b24gTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ1MTMzCisKKyAgICAgICAgVGhpcyBpcyBzbyBpdCdzIHBvc3NpYmxlIGZvciBtZSB0byBmaXgK KyAgICAgICAgaHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/ aWQ9MjEzODYgLgorCisgICAgICAgICogREVQUzogUm9sbCB0byBpbmNsdWRlIHNraWEgY2hhbmdl LgorICAgICAgICAqIHB1YmxpYy9XZWJLaXQuaDogQWRkIG1ha2VMaW51eENoZWNrc3VtT3BhcXVl KCkKKyAgICAgICAgKiBzcmMvV2ViS2l0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6bWFrZUxpbnV4 Q2hlY2tzdW1PcGFxdWUpOgorCiAyMDEwLTA5LTAyICBJbHlhIFNoZXJtYW4gIDxpc2hlcm1hbkBn b29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0L2Nocm9taXVtL0RFUFMgYi9XZWJLaXQvY2hyb21pdW0vREVQUwppbmRleCA2MjUy ZjA4ZWQ4M2RjYmQ3M2JjYTdiNDBmOWI3YWVjZjBjMTg1NTEwLi4zODU4YmRkN2Y3ZjNkMzNkOWU5 ZTUxYjg0ZDA1YTJmZmEwMTAxYjZkIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vREVQUwor KysgYi9XZWJLaXQvY2hyb21pdW0vREVQUwpAQCAtMzIsNyArMzIsNyBAQAogCiB2YXJzID0gewog ICAnY2hyb21pdW1fc3ZuJzogJ2h0dHA6Ly9zcmMuY2hyb21pdW0ub3JnL3N2bi90cnVuay9zcmMn LAotICAnY2hyb21pdW1fcmV2JzogJzU3ODIzJywKKyAgJ2Nocm9taXVtX3Jldic6ICc1ODI3NCcs CiB9CiAKIGRlcHMgPSB7CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktp dC5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQuaAppbmRleCA3MzJjYWM2NTM3ZGRk NzQ0M2U2ZjRhODViMzgxMGUwZThhNDMyMDkxLi4zNGMzYjUwZDZlMjU2Mjk3YTA5YWFhNzAwZGU3 ZGEyNWZjZjkyMDY2IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdC5o CisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0LmgKQEAgLTU1LDYgKzU1LDEwIEBA IFdFQktJVF9BUEkgV2ViS2l0Q2xpZW50KiB3ZWJLaXRDbGllbnQoKTsKIFdFQktJVF9BUEkgdm9p ZCBzZXRMYXlvdXRUZXN0TW9kZShib29sKTsKIFdFQktJVF9BUEkgYm9vbCBsYXlvdXRUZXN0TW9k ZSgpOwogCisvLyBUaGlzIGlzIGEgdGVtcG9yYXJ5IGZsYWcgd2hpbGUgd2UgdHJ5IHRvIGdldCBM aW51eCB0byBtYXRjaCBXaW5kb3dzJworLy8gY2hlY2tzdW0gY29tcHV0YXRpb24uCitXRUJLSVRf QVBJIGJvb2wgbWFrZUxpbnV4Q2hlY2tzdW1PcGFxdWUoKTsKKwogLy8gRW5hYmxlcyB0aGUgbmFt ZWQgbG9nIGNoYW5uZWwuICBTZWUgV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmggZm9yIGRldGFp bHMuCiBXRUJLSVRfQVBJIHZvaWQgZW5hYmxlTG9nQ2hhbm5lbChjb25zdCBjaGFyKik7CiAKZGlm ZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcCBiL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViS2l0LmNwcAppbmRleCBjYWRjYjZjMmU4ODJhOTM4YzllMzRiZmExMzE3YWUxODAx NjQwMTc0Li5mOWZmN2E2ZGQ4MmUxNWJkNGFhNTQ0Njc3NGIxN2Q1MzhhZjlmY2Y4IDEwMDY0NAot LS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYktpdC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJLaXQuY3BwCkBAIC0xMDMsNiArMTAzLDExIEBAIGJvb2wgbGF5b3V0VGVzdE1vZGUo KQogICAgIHJldHVybiBzX2xheW91dFRlc3RNb2RlOwogfQogCitib29sIG1ha2VMaW51eENoZWNr c3VtT3BhcXVlKCkKK3sKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKIHZvaWQgZW5hYmxlTG9nQ2hh bm5lbChjb25zdCBjaGFyKiBuYW1lKQogewogICAgIFdURkxvZ0NoYW5uZWwqIGNoYW5uZWwgPSBX ZWJDb3JlOjpnZXRDaGFubmVsRnJvbU5hbWUobmFtZSk7CmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggYTU5MWQ5MjY1NGVjNjMy MTQ4ZmI1NTZhNDQ4OWI4ODI5N2QyZjE3Ni4uY2MzMmI5ODIyMGNiNjY5OThkNDU5OTE1N2JlMGM4 MTA0YjU4NWU5YyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktp dFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA5LTAyICBUb255IENoYW5n ICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBNYWtlIGEgcHVibGljIGZsYWcgZm9yIGhvdyBEUlQg Z2VuZXJhdGVzIGJpdG1hcHMgb24gTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ1MTMzCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJv bWl1bS9UZXN0U2hlbGwuY3BwOgorICAgICAgICAoVGVzdFNoZWxsOjpkdW1wSW1hZ2UpOgorCiAy MDEwLTA5LTAyICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJU cmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAKaW5kZXggMjFhMTUzZGQ0N2ViMWNiNWNhMDZjZjg1 MjM1NTFmMmU4MzRkZTRhMS4uMDAwMzgzOTczMzk0ZDE5Njg0Mzc0ZjQ1ZmU5ZWM5MDQ1N2MyMzVl YyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNo ZWxsLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hl bGwuY3BwCkBAIC00Miw2ICs0Miw3IEBACiAjaW5jbHVkZSAicHVibGljL1dlYkVsZW1lbnQuaCIK ICNpbmNsdWRlICJwdWJsaWMvV2ViRnJhbWUuaCIKICNpbmNsdWRlICJwdWJsaWMvV2ViSGlzdG9y eUl0ZW0uaCIKKyNpbmNsdWRlICJwdWJsaWMvV2ViS2l0LmgiCiAjaW5jbHVkZSAicHVibGljL1dl YlJ1bnRpbWVGZWF0dXJlcy5oIgogI2luY2x1ZGUgInB1YmxpYy9XZWJTY3JpcHRDb250cm9sbGVy LmgiCiAjaW5jbHVkZSAicHVibGljL1dlYlNldHRpbmdzLmgiCkBAIC01ODcsNiArNTg4LDggQEAg dm9pZCBUZXN0U2hlbGw6OmR1bXBJbWFnZShza2lhOjpQbGF0Zm9ybUNhbnZhcyogY2FudmFzKSBj b25zdAogICAgIGJvb2wgZGlzY2FyZFRyYW5zcGFyZW5jeSA9IGZhbHNlOwogI2VsaWYgT1MoVU5J WCkKICAgICBib29sIGRpc2NhcmRUcmFuc3BhcmVuY3kgPSB0cnVlOworICAgIGlmIChtYWtlTGlu dXhDaGVja3N1bU9wYXF1ZSgpKQorICAgICAgICBkZXZpY2UubWFrZU9wYXF1ZSgwLCAwLCBzb3Vy Y2VCaXRtYXAud2lkdGgoKSwgc291cmNlQml0bWFwLmhlaWdodCgpKTsKICNlbmRpZgogCiAgICAg Ly8gQ29tcHV0ZSBNRDUgc3VtLiAgV2Ugc2hvdWxkIGhhdmUgZG9uZSB0aGlzIGJlZm9yZSBjYWxs aW5nCg==