45129 2010-09-02 14:01:25 -0700 [GTK] ignore po~ files in .gitignore 2010-09-07 02:12:37 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 a.renevier webkit-unassigned alex commit-queue gustavo mrobinson oldest_to_newest 273561 0 a.renevier 2010-09-02 14:01:25 -0700 Hi, after building webkit-gtk, a few .po~ files are reported as untracked by git status file WebKit/gtk/po/webkit-2.0.pot is also reported as untracked by git status 273562 1 66409 a.renevier 2010-09-02 14:07:08 -0700 Created attachment 66409 patch v1 273979 2 mrobinson 2010-09-03 09:49:37 -0700 If possible it would be great to get these to generate in the build directory. 274367 3 a.renevier 2010-09-04 11:14:45 -0700 I can't find how those .po~ are created I think that must be in WebKit/gtk/po/GNUmakefile.am but which command create them ? 274368 4 mrobinson 2010-09-04 11:19:03 -0700 I've CC'd Alex, who has done some work with the po files in the past. 274712 5 gustavo 2010-09-06 11:00:50 -0700 Two ideas: why not ignore all *~ files, given those are usually generated by popular editors such as Emacs? Also, we should ignore WebKit/gtk/po/*.pot, because the name of the pot file may change depending on the version of the library that is being build (with gtk2 or 3) 274714 6 mrobinson 2010-09-06 11:04:02 -0700 (In reply to comment #5) > Two ideas: why not ignore all *~ files, given those are usually generated by popular editors such as Emacs? I think this is a great idea. > Also, we should ignore WebKit/gtk/po/*.pot, because the name of the pot file may change depending on the version of the library that is being build (with gtk2 or 3) Agree with this as well, though I believe we can get it to generate in WebKitBuild still. For now I think it's probably fine to ignore it where it is. 274757 7 66666 a.renevier 2010-09-06 12:52:08 -0700 Created attachment 66666 patch v1.1 (In reply to comment #5) > Two ideas: why not ignore all *~ files, given those are usually generated by popular editors such as Emacs? Also, we should ignore WebKit/gtk/po/*.pot, because the name of the pot file may change depending on the version of the library that is being build (with gtk2 or 3) Should we ignore *~ globally or just for gtk ? here is an updated patch ignoring *~ globally. 274875 8 66666 zecke 2010-09-07 00:55:50 -0700 Comment on attachment 66666 patch v1.1 Looks good. Nice patch number. 274916 9 66666 commit-queue 2010-09-07 02:12:33 -0700 Comment on attachment 66666 patch v1.1 Clearing flags on attachment: 66666 Committed r66870: <http://trac.webkit.org/changeset/66870> 274917 10 commit-queue 2010-09-07 02:12:37 -0700 All reviewed patches have been landed. Closing bug. 66409 2010-09-02 14:07:08 -0700 2010-09-06 12:52:08 -0700 patch v1 45129.patch text/plain 1003 a.renevier ZGlmZiAtLWdpdCBhLy5naXRpZ25vcmUgYi8uZ2l0aWdub3JlCmluZGV4IGEyYzc4OWIuLmJiNGZk NjEgMTAwNjQ0Ci0tLSBhLy5naXRpZ25vcmUKKysrIGIvLmdpdGlnbm9yZQpAQCAtNzUsMTEgKzc1 LDEzIEBAIExheW91dFRlc3RzL2phdmEvKi5jbGFzcwogL2F1dG90b29scy9sdHN1Z2FyLm00CiAv YXV0b3Rvb2xzL2x0dmVyc2lvbi5tNAogL2F1dG90b29scy9sdH5vYnNvbGV0ZS5tNAogL2F1dG90 b29scy9taXNzaW5nCiAvYXV0b3Rvb2xzY29uZmlnLmguaW4KIC9jb25maWd1cmUKIC9HTlVtYWtl ZmlsZS5pbgogL1dlYktpdC9ndGsvZG9jcy9HTlVtYWtlZmlsZS5pbgorL1dlYktpdC9ndGsvcG8v Ki5wb34KKy9XZWJLaXQvZ3RrL3BvL3dlYmtpdC0yLjAucG90CiAvZ3RrLWRvYy5tYWtlCiAvSU5T VEFMTAogL1JFQURNRQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGM3 NWNjODcuLjRhMmNkMDEgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAg LTEsOCArMSwxNyBAQAorMjAxMC0wOS0wMiAgQXJubyBSZW5ldmllciAgPGFybm9AcmVuZXZpZXIu bmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGln bm9yZSBndGsgLnBvfiBmaWxlcyBhbmQgZ3RrIHdlYmtpdC0yLjAucG90IGZpbGVzIGluIC5naXRp Z25vcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1 MTI5CisKKyAgICAgICAgKiAuZ2l0aWdub3JlOgorCiAyMDEwLTA5LTAxICBSeXVhbiBDaG9pICA8 cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdv bWVzLgogCiAgICAgICAgIFtFRkxdIE5lZWQgdG8gY2hlY2sgTGliU291cCB2ZXJzaW9uCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDY1OAogCiAgICAg ICAgIEFkZCB2ZXJzaW9uIGNoZWNrIG9mIExpYlNvdXAuCg== 66666 2010-09-06 12:52:08 -0700 2010-09-07 02:12:32 -0700 patch v1.1 0001-bug-45129.patch text/plain 1251 a.renevier RnJvbSA5MTQ4ZjdkOTFhZGU2OTBkODVmNzlmYzdkYmU0NWRhMDkxZGVhYzliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBcm5vIFJlbmV2aWVyIDxhcm5vQHJlbmV2aWVyLm5ldD4KRGF0 ZTogTW9uLCA2IFNlcCAyMDEwIDIxOjUwOjAyICswMjAwClN1YmplY3Q6IFtQQVRDSF0gYnVnICM0 NTEyOQoKLS0tCiAuZ2l0aWdub3JlIHwgICAgMiArKwogQ2hhbmdlTG9nICB8ICAgIDkgKysrKysr KysrCiAyIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvLmdpdGlnbm9yZSBiLy5naXRpZ25vcmUKaW5kZXggYTJjNzg5Yi4uNWQ5NmFk MiAxMDA2NDQKLS0tIGEvLmdpdGlnbm9yZQorKysgYi8uZ2l0aWdub3JlCkBAIC0xMCw2ICsxMCw3 IEBAIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9hdXRvaW5zdGFsbGVk CiAjIElnbm9yZSBjb21tb24gdG9vbCBhdXRvLWdlbmVyYXRlZCBmaWxlcy4KIC5nZGJfaGlzdG9y eQogdGFncworKn4KIAogIyBJZ25vcmUgQ2hyb21pdW0gcHJvamVjdHMgYXV0by1nZW5lcmF0ZWQg ZnJvbSAuZ3lwIGZpbGVzOgogSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZ3lwLyouTWFr ZWZpbGUKQEAgLTgwLDYgKzgxLDcgQEAgTGF5b3V0VGVzdHMvamF2YS8qLmNsYXNzCiAvY29uZmln dXJlCiAvR05VbWFrZWZpbGUuaW4KIC9XZWJLaXQvZ3RrL2RvY3MvR05VbWFrZWZpbGUuaW4KKy9X ZWJLaXQvZ3RrL3BvLyoucG90CiAvZ3RrLWRvYy5tYWtlCiAvSU5TVEFMTAogL1JFQURNRQpkaWZm IC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDQzNmU0ODUuLmIxNjE0ZDEgMTAw NjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAx MC0wOS0wMiAgQXJubyBSZW5ldmllciAgPGFybm9AcmVuZXZpZXIubmV0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGdpdGlnbm9yZSAqfiBmaWxlcyBh bmQgZ3RrICoucG90IGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00NTEyOQorCisgICAgICAgICogLmdpdGlnbm9yZToKKwogMjAxMC0wOS0wNCAg THVjYXMgRGUgTWFyY2hpICA8bHVjYXMuZGVtYXJjaGlAcHJvZnVzaW9uLm1vYmk+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCi0tIAoxLjcuMQoK