45123 2010-09-02 12:52:32 -0700 Markup.waitUntilDone does not call Markup.noAutoDump without LayoutTestController 2010-09-07 18:27:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 rniwa webkit-unassigned abarth eric ojan tony oldest_to_newest 273509 0 rniwa 2010-09-02 12:52:32 -0700 At dump-as-markup.js#L90 we have: Markup.waitUntilDone = function() { layoutTestController.waitUntilDone(); Markup.noAutoDump(); } But if layoutTestController was undefined, we would error at L92 and will never call noAutoDump(). 275474 1 66810 ojan 2010-09-07 17:58:09 -0700 Created attachment 66810 Patch 275506 2 ojan 2010-09-07 18:27:05 -0700 Committed r66944: <http://trac.webkit.org/changeset/66944> 66810 2010-09-07 17:58:09 -0700 2010-09-07 18:03:08 -0700 Patch bug-45123-20100908105806.patch text/plain 1151 ojan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2ZWNjOWYzOGM4OTgwYjNhNmQ0OWZlY2RlNmEyMTI2ZjM4NmRmYzRmLi44Y2Y2MDY4 ZDg3NjhhNmM2ODY2NjI5ZThiZTBkYjU2ZjM3ZmQwOTRlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDktMDcgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYXJrdXAud2FpdFVudGlsRG9u ZSBkb2VzIG5vdCBjYWxsIE1hcmt1cC5ub0F1dG9EdW1wIHdpdGhvdXQgTGF5b3V0VGVzdENvbnRy b2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1 MTIzCisKKyAgICAgICAgKiByZXNvdXJjZXMvZHVtcC1hcy1tYXJrdXAuanM6CisgICAgICAgIChN YXJrdXAud2FpdFVudGlsRG9uZSk6CisKIDIwMTAtMDktMDYgIEp1c3RpbiBTY2h1aCAgPGpzY2h1 aEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQnVpbGQgZml4LgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcmVzb3VyY2VzL2R1bXAtYXMtbWFya3VwLmpzIGIvTGF5b3V0VGVz dHMvcmVzb3VyY2VzL2R1bXAtYXMtbWFya3VwLmpzCmluZGV4IGVhZmNjODA5Mjk1MmI4NDdjNTQ2 YzczYTQ4MWFlZjk2ZDVlMDg5MmUuLjRkNTMwNmVjYzRjNmU4ZTIyZWVkMTg2MDRmZjBhYzEwN2E1 MWQ0Y2MgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Jlc291cmNlcy9kdW1wLWFzLW1hcmt1cC5q cworKysgYi9MYXlvdXRUZXN0cy9yZXNvdXJjZXMvZHVtcC1hcy1tYXJrdXAuanMKQEAgLTg5LDcg Kzg5LDggQEAgTWFya3VwLm5vQXV0b0R1bXAgPSBmdW5jdGlvbigpCiAKIE1hcmt1cC53YWl0VW50 aWxEb25lID0gZnVuY3Rpb24oKQogewotICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRp bERvbmUoKTsKKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBs YXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CiAgICAgTWFya3VwLm5vQXV0b0R1 bXAoKTsKIH0KIAo=