45122 2010-09-02 12:33:37 -0700 [EFL] Fix double addition of -fPIC 2010-09-02 22:42:08 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 lucas.de.marchi lucas.de.marchi barbieri commit-queue kenneth tonikitoo oldest_to_newest 273503 0 lucas.de.marchi 2010-09-02 12:33:37 -0700 [EFL] Fix double addition of -fPIC 273507 1 66399 lucas.de.marchi 2010-09-02 12:45:02 -0700 Created attachment 66399 Patch 273577 2 66399 tonikitoo 2010-09-02 14:29:11 -0700 Comment on attachment 66399 Patch * cmake/WebKitHelpers.cmake: Add -fPIC flags iff SHARED_CORE=ON. "iff" :# 273610 3 lucas.de.marchi 2010-09-02 15:21:09 -0700 (In reply to comment #2) > (From update of attachment 66399 [details]) > * cmake/WebKitHelpers.cmake: Add -fPIC flags iff SHARED_CORE=ON. > > > "iff" :# It was intentional, meaning "if and only if". Setting cq+. 273792 4 66399 commit-queue 2010-09-02 22:42:04 -0700 Comment on attachment 66399 Patch Clearing flags on attachment: 66399 Committed r66714: <http://trac.webkit.org/changeset/66714> 273793 5 commit-queue 2010-09-02 22:42:08 -0700 All reviewed patches have been landed. Closing bug. 66399 2010-09-02 12:45:02 -0700 2010-09-02 22:42:04 -0700 Patch bug-45122-20100902164509.patch text/plain 2163 lucas.de.marchi ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwNmQ0YjQ4NGQ5NWUzYmM1 YWFlZmRkYWE4NDIxZmI2NTg3Mjk3NDJlLi4wZWFjZGIxOTdjZDI0MDUzYjQyMjVmMmNkNjc4OWVl ZDc4ODcxOWEyIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTggQEAKKzIwMTAtMDktMDIgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hpQHBy b2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtFRkxdIEZpeCBkb3VibGUgYWRkaXRpb24gb2YgLWZQSUMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1MTIyCisKKyAgICAgICAgIFdoZW4g U0hBUkVEX0NPUkU9T04sIC1mUElDIGlzIGF1dG9tYXRpY2FsbHkgYWRkZWQgYmVjYXVzZSBhbGwK KyAgICAgICAgIGxpYnJhcmllcyBhcmUgZHluYW1pYy4gT25seSB3aGVuIHN0YXRpYyBsaWJyYXJp ZXMgYXJlIGJ1aWx0IHRoYXQKKyAgICAgICAgIC1mUElDIG5lZWRzIHRvIGJlIG1hbnVhbGx5IGlu c2VydGVkIChiZWNhdXNlIHRoZSBmaW5hbCBsaWJyYXJ5LAorICAgICAgICAgbGliZXdlYmtpdC5z bywgaXMgZHluYW1pYykuCisKKyAgICAgICAgKiBjbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOiBS ZW1vdmUgLWZQSUMgZmxhZy4KKyAgICAgICAgKiBjbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlOiBB ZGQgLWZQSUMgZmxhZ3MgaWZmIFNIQVJFRF9DT1JFPU9OLgorCiAyMDEwLTA4LTMxICBHdXN0YXZv IE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL2NtYWtlL09wdGlv bnNDb21tb24uY21ha2UgYi9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4IDhiMGI5YzM2 YTBhNTRiZDNiMDlhZGU4ZjY4M2E5MDA5YTc4NGE2NTMuLjMyMzU4MTY1ZTgwYTBmZWM3NGYxZTZm ZWZiZDQ4NDdlM2EzNGM3NmQgMTAwNjQ0Ci0tLSBhL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2UK KysrIGIvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQpAQCAtMSwxMSArMSw2IEBACiBBRERfREVG SU5JVElPTlMoLURCVUlMRElOR19XSVRIX0NNQUtFPTEpCiBBRERfREVGSU5JVElPTlMoLURIQVZF X0NPTkZJR19IPTEpCiAKLUlGIChDTUFLRV9DT01QSUxFUl9JU19HTlVDQykKLSAgICBTRVQoQ01B S0VfQ1hYX0ZMQUdTICItZlBJQyAke0NNQUtFX0NYWF9GTEFHU30iKQotICAgIFNFVChDTUFLRV9D X0ZMQUdTICItZlBJQyAke0NNQUtFX0NfRkxBR1N9IikKLUVORElGICgpCi0KIFNFVChXVEZfSU5D TFVERV9ESVJFQ1RPUklFUwogICAgICIke0pBVkFTQ1JJUFRDT1JFX0RJUn0iCiAgICAgIiR7SkFW QVNDUklQVENPUkVfRElSfS93dGYiCmRpZmYgLS1naXQgYS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNt YWtlIGIvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQppbmRleCA1NTU0OWQ2YTMwY2RhMGExYzZl ZDhhNzAzZmQ2ZjVjYjBmOWU5ZmEzLi4xZTY5ZDQ5MDgyZGJmMjY4MDlmOTQ5YjRlN2FlOThlNzk5 ZWUzY2VlIDEwMDY0NAotLS0gYS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCisrKyBiL2NtYWtl L1dlYktpdEhlbHBlcnMuY21ha2UKQEAgLTE5LDcgKzE5LDcgQEAgTUFDUk8oV0VCS0lUX1NFVF9F WFRSQV9DT01QSUxFUl9GTEFHUyBfdGFyZ2V0KQogICAgICAgICAgICAgQ09NUElMRV9GTEFHUyAi LWZuby1leGNlcHRpb25zIC1mc3RyaWN0LWFsaWFzaW5nICR7T0xEX0NPTVBJTEVfRkxBR1N9IikK ICAgICBFTFNFICgpCiAgICAgICAgIFNFVF9UQVJHRVRfUFJPUEVSVElFUyAoJHtfdGFyZ2V0fSBQ Uk9QRVJUSUVTCi0gICAgICAgICAgICBDT01QSUxFX0ZMQUdTICItZm5vLWV4Y2VwdGlvbnMgLWZz dHJpY3QtYWxpYXNpbmcgLWZ2aXNpYmlsaXR5PWhpZGRlbiAke09MRF9DT01QSUxFX0ZMQUdTfSIp CisgICAgICAgICAgICBDT01QSUxFX0ZMQUdTICItZlBJQyAtZm5vLWV4Y2VwdGlvbnMgLWZzdHJp Y3QtYWxpYXNpbmcgLWZ2aXNpYmlsaXR5PWhpZGRlbiAke09MRF9DT01QSUxFX0ZMQUdTfSIpCiAg ICAgRU5ESUYgKCkKICAgICBVTlNFVChPTERfQ09NUElMRV9GTEFHUykKICAgRU5ESUYgKCkK