45102 2010-09-02 03:52:09 -0700 [Chromium] media/media-can-play-mpeg4-video.html fails under Chromium 2010-09-10 06:35:17 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 antonm webkit-unassigned commit-queue dglazkov pnormand scherkus oldest_to_newest 273312 0 antonm 2010-09-02 03:52:09 -0700 Test added in http://trac.webkit.org/changeset/66646/ fails for Chromium. Diff is: --- /b/slave/webkit-rel-mac-webkit-org/build/src/webkit/Release/../../../layout-test-results/media/media-can-play-mpeg4-video-expected.txt +++ /b/slave/webkit-rel-mac-webkit-org/build/src/webkit/Release/../../../layout-test-results/media/media-can-play-mpeg4-video-actual.txt @@ -1,5 +1,5 @@ Test HTMLMediaElement canPlayType() method with multiple video mpeg4 MIME types. -EXPECTED (video.canPlayType('video/x-m4v') == 'maybe') OK -EXPECTED (video.canPlayType('video/mp4') == 'maybe') OK +EXPECTED (video.canPlayType('video/x-m4v') == 'maybe'), OBSERVED '' FAIL +EXPECTED (video.canPlayType('video/mp4') == 'maybe'), OBSERVED '' FAIL END OF TEST (see also http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&useWebKitCanary=true&tests=media%2Fmedia-can-play-mpeg4-video.html) Apparently it's a genuine failure and I shouldn't just rebaseline expectations. 273318 1 pnormand 2010-09-02 04:04:01 -0700 Can it be skipped then? 273319 2 antonm 2010-09-02 04:05:37 -0700 (In reply to comment #1) > Can it be skipped then? That's precisely what I do for now, but ideally we'd have it resolved. BTW, if you think the diff is fine, I'll just rebaseline. 273341 3 pnormand 2010-09-02 04:46:58 -0700 (In reply to comment #2) > (In reply to comment #1) > > Can it be skipped then? > > That's precisely what I do for now, but ideally we'd have it resolved. > > BTW, if you think the diff is fine, I'll just rebaseline. Well you should return something i think. Be it "maybe" or "probably". Thanks for skipping it anyway. 276556 4 scherkus 2010-09-09 10:32:05 -0700 this is expected as the Chromium port only supports Ogg+Theora/Vorbis and WebM+VP8/Vorbis this test explicitly checks for support for a format that Chromium doesn't support -- so it's safe to mark as SKIP there's already a section in test_expectations.txt for tests like these (look for some media tests marked as SKIP with a comment that explains the situation) 276596 5 67064 antonm 2010-09-09 11:06:53 -0700 Created attachment 67064 Patch 277129 6 67064 commit-queue 2010-09-10 05:28:39 -0700 Comment on attachment 67064 Patch Clearing flags on attachment: 67064 Committed r67192: <http://trac.webkit.org/changeset/67192> 277130 7 commit-queue 2010-09-10 05:28:44 -0700 All reviewed patches have been landed. Closing bug. 277161 8 antonm 2010-09-10 06:35:17 -0700 Thanks a lot, Kent and Andrew. 67064 2010-09-09 11:06:53 -0700 2010-09-10 05:28:39 -0700 Patch bug-45102-20100909220651.patch text/plain 1547 antonm ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1YTJlZDI4ZWQzMTk5NjgzYWJiZGNiOTg0ZTQ0OWVjYmI5Y2ZlMGY4Li45MjVhMDc4 MDVlY2M4YjcxYzgyYmI2ZjkyMWIxN2MzNmY2NWJlZWRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDktMDkgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIG1lZGlh L21lZGlhLWNhbi1wbGF5LW1wZWc0LXZpZGVvLmh0bWwgZmFpbHMgdW5kZXIgQ2hyb21pdW0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1MTAyCisKKyAg ICAgICAgQ2hyb21pdW0gaXMgbm90IGdvaW5nIHRvIHN1cHBvcnQgbXBlZywgc28gbWVkaWEvbWVk aWEtY2FuLXBsYXktbXBlZzQtdmlkZW8uaHRtbAorICAgICAgICBpcyBleHBlY3RlZCB0byBmYWls LgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0Ogor CiAyMDEwLTA5LTA5ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgS2lsemVyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0IGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CmluZGV4IDZlMTE4N2ZlM2EwZjEz ZjU1Y2NhNDUwOTkwMzM4YTIyYWNjOWYyN2QuLjE0MmQ4MWFkZGNlYjU0ZDA2MWUwMDk1ZDVjMTU0 YzJjODkzMTFlY2QgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rl c3RfZXhwZWN0YXRpb25zLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90 ZXN0X2V4cGVjdGF0aW9ucy50eHQKQEAgLTc2Miw2ICs3NjIsNyBAQCBCVUcxNjc3OSBXT05URklY IFNLSVAgOiBtZWRpYS9tZWRpYS1jYW4tcGxheS1tcGVnLWF1ZGlvLmh0bWwgPSBURVhUCiBCVUcx Njc3OSBXT05URklYIFNLSVAgOiBtZWRpYS92aWRlby1jYW4tcGxheS10eXBlLmh0bWwgPSBGQUlM IFRJTUVPVVQKIEJVRzE2Nzc5IFdPTlRGSVggU0tJUCA6IG1lZGlhL3ZpZGVvLWRvY3VtZW50LXR5 cGVzLmh0bWwgPSBGQUlMIFRJTUVPVVQKIEJVRzE2Nzc5IFdPTlRGSVggU0tJUCA6IG1lZGlhL3Zp ZGVvLXNpemUtaW50cmluc2ljLXNjYWxlLmh0bWwgPSBGQUlMIFRJTUVPVVQKK0JVR1dLNDUxMDIg V09OVEZJWCBTS0lQIDogbWVkaWEvbWVkaWEtY2FuLXBsYXktbXBlZzQtdmlkZW8uaHRtbCA9IFRF WFQKIAogLy8gV2UgaGF2ZW4ndCBpbXBsZW1lbnRlZCB0aGUgV2ViS2l0IGZ1bGxzY3JlZW4gZXh0 ZW5zaW9uLgogQlVHMTY3MzUgOiBtZWRpYS9tZWRpYS1mdWxsc2NyZWVuLWlubGluZS5odG1sID0g VElNRU9VVAo=