45098 2010-09-02 03:21:08 -0700 Web Inspector: Timeline instrumentation code can crash browser. 2010-09-02 10:11:08 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 273296 0 loislo 2010-09-02 03:21:08 -0700 sample url: http://vkontakte.ru/gsearch.php?section=audio&c[q]=Billy's%20Band 1) load the site 2) open inspector 3) start timeline recording 4) reload inspected page got NPE 273299 1 66346 loislo 2010-09-02 03:31:44 -0700 Created attachment 66346 [patch] initial version. 273301 2 66346 yurys 2010-09-02 03:35:26 -0700 Comment on attachment 66346 [patch] initial version. Would be nice to have a test for this. 273434 3 66346 commit-queue 2010-09-02 10:11:03 -0700 Comment on attachment 66346 [patch] initial version. Clearing flags on attachment: 66346 Committed r66674: <http://trac.webkit.org/changeset/66674> 273435 4 commit-queue 2010-09-02 10:11:08 -0700 All reviewed patches have been landed. Closing bug. 66346 2010-09-02 03:31:44 -0700 2010-09-02 10:11:03 -0700 [patch] initial version. patch text/plain 3122 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmFkMTBkZi4uYTNhNDdkYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wOS0wMiAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBUaW1lbGluZSBpbnN0cnVtZW50YXRp b24gY29kZSBjYW4gY3Jhc2ggYnJvd3Nlci4KKworICAgICAgICBTdGVwczoKKyAgICAgICAgMSkg bG9hZCB0aGUgc2l0ZQorICAgICAgICAyKSBvcGVuIGluc3BlY3RvcgorICAgICAgICAzKSBzdGFy dCB0aW1lbGluZSByZWNvcmRpbmcKKyAgICAgICAgNCkgcmVsb2FkIGluc3BlY3RlZCBwYWdlCisg ICAgICAgIGdvdCBOUEUKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDUwOTgKKworICAgICAgICAqIGxvYWRlci9SZXNvdXJjZUxvYWRlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKToKKyAg ICAgICAgKFdlYkNvcmU6OlJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlRGF0YSk6CisKIDIwMTAt MDktMDIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNl TG9hZGVyLmNwcCBiL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcAppbmRleCBjNzMw OGI5Li43M2RhY2Q2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5j cHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCkBAIC00MDEsNyArNDAx LDcgQEAgdm9pZCBSZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKFJlc291cmNlSGFu ZGxlKiwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYKIHsKICNpZiBFTkFCTEUoSU5TUEVDVE9SKQog ICAgIGlmIChJbnNwZWN0b3JUaW1lbGluZUFnZW50OjppbnN0YW5jZUNvdW50KCkpIHsKLSAgICAg ICAgSW5zcGVjdG9yVGltZWxpbmVBZ2VudCogdGltZWxpbmVBZ2VudCA9IG1fZnJhbWUtPnBhZ2Uo KSA/IG1fZnJhbWUtPnBhZ2UoKS0+aW5zcGVjdG9yVGltZWxpbmVBZ2VudCgpIDogMDsKKyAgICAg ICAgSW5zcGVjdG9yVGltZWxpbmVBZ2VudCogdGltZWxpbmVBZ2VudCA9IChtX2ZyYW1lICYmIG1f ZnJhbWUtPnBhZ2UoKSkgPyBtX2ZyYW1lLT5wYWdlKCktPmluc3BlY3RvclRpbWVsaW5lQWdlbnQo KSA6IDA7CiAgICAgICAgIGlmICh0aW1lbGluZUFnZW50KQogICAgICAgICAgICAgdGltZWxpbmVB Z2VudC0+d2lsbFJlY2VpdmVSZXNvdXJjZVJlc3BvbnNlKGlkZW50aWZpZXIoKSwgcmVzcG9uc2Up OwogICAgIH0KQEAgLTQxMyw3ICs0MTMsNyBAQCB2b2lkIFJlc291cmNlTG9hZGVyOjpkaWRSZWNl aXZlUmVzcG9uc2UoUmVzb3VyY2VIYW5kbGUqLCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJgogICAg IGRpZFJlY2VpdmVSZXNwb25zZShyZXNwb25zZSk7CiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKICAg ICBpZiAoSW5zcGVjdG9yVGltZWxpbmVBZ2VudDo6aW5zdGFuY2VDb3VudCgpKSB7Ci0gICAgICAg IEluc3BlY3RvclRpbWVsaW5lQWdlbnQqIHRpbWVsaW5lQWdlbnQgPSBtX2ZyYW1lLT5wYWdlKCkg PyBtX2ZyYW1lLT5wYWdlKCktPmluc3BlY3RvclRpbWVsaW5lQWdlbnQoKSA6IDA7CisgICAgICAg IEluc3BlY3RvclRpbWVsaW5lQWdlbnQqIHRpbWVsaW5lQWdlbnQgPSAobV9mcmFtZSAmJiBtX2Zy YW1lLT5wYWdlKCkpID8gbV9mcmFtZS0+cGFnZSgpLT5pbnNwZWN0b3JUaW1lbGluZUFnZW50KCkg OiAwOwogICAgICAgICBpZiAodGltZWxpbmVBZ2VudCkKICAgICAgICAgICAgIHRpbWVsaW5lQWdl bnQtPmRpZFJlY2VpdmVSZXNvdXJjZVJlc3BvbnNlKCk7CiAgICAgfQpAQCAtNDI0LDcgKzQyNCw3 IEBAIHZvaWQgUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVEYXRhKFJlc291cmNlSGFuZGxlKiwg Y29uc3QgY2hhciogZGF0YSwgaW50IGxlbmd0CiB7CiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKICAg ICBpZiAoSW5zcGVjdG9yVGltZWxpbmVBZ2VudDo6aW5zdGFuY2VDb3VudCgpKSB7Ci0gICAgICAg IEluc3BlY3RvclRpbWVsaW5lQWdlbnQqIHRpbWVsaW5lQWdlbnQgPSBtX2ZyYW1lLT5wYWdlKCkg PyBtX2ZyYW1lLT5wYWdlKCktPmluc3BlY3RvclRpbWVsaW5lQWdlbnQoKSA6IDA7CisgICAgICAg IEluc3BlY3RvclRpbWVsaW5lQWdlbnQqIHRpbWVsaW5lQWdlbnQgPSAobV9mcmFtZSAmJiBtX2Zy YW1lLT5wYWdlKCkpID8gbV9mcmFtZS0+cGFnZSgpLT5pbnNwZWN0b3JUaW1lbGluZUFnZW50KCkg OiAwOwogICAgICAgICBpZiAodGltZWxpbmVBZ2VudCkKICAgICAgICAgICAgIHRpbWVsaW5lQWdl bnQtPndpbGxSZWNlaXZlUmVzb3VyY2VEYXRhKGlkZW50aWZpZXIoKSk7CiAgICAgfQpAQCAtNDMy LDcgKzQzMiw3IEBAIHZvaWQgUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVEYXRhKFJlc291cmNl SGFuZGxlKiwgY29uc3QgY2hhciogZGF0YSwgaW50IGxlbmd0CiAgICAgZGlkUmVjZWl2ZURhdGEo ZGF0YSwgbGVuZ3RoLCBsZW5ndGhSZWNlaXZlZCwgZmFsc2UpOwogI2lmIEVOQUJMRShJTlNQRUNU T1IpCiAgICAgaWYgKEluc3BlY3RvclRpbWVsaW5lQWdlbnQ6Omluc3RhbmNlQ291bnQoKSkgewot ICAgICAgICBJbnNwZWN0b3JUaW1lbGluZUFnZW50KiB0aW1lbGluZUFnZW50ID0gbV9mcmFtZS0+ cGFnZSgpID8gbV9mcmFtZS0+cGFnZSgpLT5pbnNwZWN0b3JUaW1lbGluZUFnZW50KCkgOiAwOwor ICAgICAgICBJbnNwZWN0b3JUaW1lbGluZUFnZW50KiB0aW1lbGluZUFnZW50ID0gKG1fZnJhbWUg JiYgbV9mcmFtZS0+cGFnZSgpKSA/IG1fZnJhbWUtPnBhZ2UoKS0+aW5zcGVjdG9yVGltZWxpbmVB Z2VudCgpIDogMDsKICAgICAgICAgaWYgKHRpbWVsaW5lQWdlbnQpCiAgICAgICAgICAgICB0aW1l bGluZUFnZW50LT5kaWRSZWNlaXZlUmVzb3VyY2VEYXRhKCk7CiAgICAgfQo=