45097 2010-09-02 02:38:10 -0700 Snow Leopard Release Tests buildslave failing on fast/css/display-none-inline-style-change-crash 2010-09-02 13:45:39 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.6 RESOLVED FIXED P2 Normal --- 1 lilmatt webkit-unassigned ap eric hyatt sam timothy oldest_to_newest 273282 0 lilmatt 2010-09-02 02:38:10 -0700 The Snow Leopard Release Tests buildslave has been failing on fast/css/display-none-inline-style-change-crash since Tuesday night. http://build.webkit.org/waterfall?show=SnowLeopard%20Intel%20Release%20(Tests)&last_time=1283326000 The test is failing, not because the original bug for which it was written has returned, but because of this now (unexpectedly) appearing in the output. > ALERT: 1 rule(s) were returned from getMatchedCSSRules, expected zero. build 16778 appears to work and 16779 doesn't. There's a pretty major change w/r/t CSS in r66577. 273284 1 lilmatt 2010-09-02 02:39:05 -0700 (In reply to comment #0) > build 16778 appears to work and 16779 doesn't. Clarification: build 16778 passes the test and 16779 doesn't. The builds otherwise "work". 273291 2 lilmatt 2010-09-02 03:12:16 -0700 I searched the code base for the string found in the output > were returned from getMatchedCSSRules I only found it in fast/css/disabled-author-styles.html However the test that's failing is fast/css/display-none-inline-style-change-crash.html There don't appear to be any common tag IDs or function names. Somehow the output from one test is leaking into the other, and with some frequency! 273293 3 lilmatt 2010-09-02 03:15:08 -0700 Note that the tests are adjacent to each other in alpha order, so perhaps one test's output is being attributed to the following test. Perhaps the FIRST test is the one that's failing, and there's a bug in the testing framework that is letting the output "leak" into the next test. 273306 4 lilmatt 2010-09-02 03:43:25 -0700 eseidel suggested CCing the authors of the two tests (hyatt and mitz) Link to actual failed test output diff (cause it sucked to find it): http://bit.ly/agx1fs 273510 5 66400 lilmatt 2010-09-02 12:54:36 -0700 Created attachment 66400 Attempt to fix flaky test by adding layoutTestController.waitUntilDone() and ...notifyDone() 273516 6 eric 2010-09-02 13:07:02 -0700 Hmm.. I suspect it's a more recent regression. The timeout, if anything, will just make it fail more consistently as the right test instead of bleeding into the next test. 273518 7 66400 eric 2010-09-02 13:07:51 -0700 Comment on attachment 66400 Attempt to fix flaky test by adding layoutTestController.waitUntilDone() and ...notifyDone() I'm all for making this test more reliable. So lets give this a shot. 273534 8 66400 eric 2010-09-02 13:45:34 -0700 Comment on attachment 66400 Attempt to fix flaky test by adding layoutTestController.waitUntilDone() and ...notifyDone() Clearing flags on attachment: 66400 Committed r66684: <http://trac.webkit.org/changeset/66684> 273535 9 eric 2010-09-02 13:45:39 -0700 All reviewed patches have been landed. Closing bug. 66400 2010-09-02 12:54:36 -0700 2010-09-02 13:45:34 -0700 Attempt to fix flaky test by adding layoutTestController.waitUntilDone() and ...notifyDone() wk45097r0.patch text/plain 1713 lilmatt SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY2NjgwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMDIgIE1hdHRoZXcgV2lsbGlzICA8 bGlsbWF0dEBmbG9jay5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQXR0ZW1wdCB0byBmaXggZmxheHkgdGVzdCB0aGF0IGNvbnRhaW5zIHNldFRp bWVvdXQoKSBieSBhZGRpbmcKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGls RG9uZSgpIGFuZCAuLi5ub3RpZnlEb25lKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ1MDk3CisKKyAgICAgICAgKiBmYXN0L2Nzcy9kaXNhYmxlZC1h dXRob3Itc3R5bGVzLmh0bWw6CisKIDIwMTAtMDktMDIgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCB1cGRhdGUgY2hyb21pdW0gdGVzdCBleHBl Y3RhdGlvbnMuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9kaXNhYmxlZC1hdXRob3Itc3R5 bGVzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MvZGlzYWJsZWQtYXV0 aG9yLXN0eWxlcy5odG1sCShyZXZpc2lvbiA2NjY0MCkKKysrIExheW91dFRlc3RzL2Zhc3QvY3Nz L2Rpc2FibGVkLWF1dGhvci1zdHlsZXMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNyw3ICs3LDcg QEAKICAgICAgICAgICAgICAgIGFsZXJ0KCJUaGlzIHRlc3QgbXVzdCBiZSBydW4gaW4gdGhlIER1 bXBSZW5kZXJUcmVlIHRvIHdvcmsuIik7CiAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAg ICAgICB9Ci0KKyAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUo KTsKICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLnNldEF1dGhvckFuZFVzZXJTdHls ZXNFbmFibGVkKGZhbHNlKTsKIAogICAgICAgICAgICAgLy8gQ2hlY2sgdGhlIG1hdGNoZWQgcnVs ZXMgYWZ0ZXIgYSB0aW1lb3V0IHRvIGdpdmUgdGltZSBmb3IgV2ViUHJlZmVyZW5jZXMgdG8gdXBk YXRlIFdlYkNvcmU6OlNldHRpbmdzLgpAQCAtMTksNiArMTksMTAgQEAKICAgICAgICAgICAgIHZh ciBtYXRjaGVkUnVsZXMgPSBnZXRNYXRjaGVkQ1NTUnVsZXMoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoInRlc3QiKSwgIiIsIHRydWUpOwogICAgICAgICAgICAgaWYgKG1hdGNoZWRSdWxlcyAmJiBt YXRjaGVkUnVsZXMubGVuZ3RoKQogICAgICAgICAgICAgICAgIGFsZXJ0KG1hdGNoZWRSdWxlcy5s ZW5ndGggKyAiIHJ1bGUocykgd2VyZSByZXR1cm5lZCBmcm9tIGdldE1hdGNoZWRDU1NSdWxlcywg ZXhwZWN0ZWQgemVyby4iKTsKKworICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikgeworICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURv bmUoKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIDwvc2NyaXB0PgogICAgIDxzdHls ZT4K