45095 2010-09-02 02:07:40 -0700 absolutely positioned list in inline element crashes 2010-10-20 00:45:03 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P1 Normal --- 1 hamaji webkit-unassigned abarth commit-queue mitz yuzo oldest_to_newest 273264 0 hamaji 2010-09-02 02:07:40 -0700 WebKit crashes for <span> <li> <li style="position: absolute; list-style-type: upper-roman;"> The render tree for this HTML is layer at (0,0) size 800x600 RenderView at (0,0) size 800x600 layer at (0,0) size 800x600 RenderBlock {HTML} at (0,0) size 800x600 RenderBody {BODY} at (8,8) size 784x584 RenderBlock (anonymous) at (0,0) size 784x0 RenderInline {SPAN} at (0,0) size 0x0 RenderText {#text} at (0,0) size 0x0 RenderBlock (anonymous) at (0,0) size 784x18 RenderListItem {LI} at (0,0) size 784x18 RenderListMarker at (-1,0) size 7x18: bullet RenderBlock (anonymous) at (0,18) size 784x0 RenderInline {SPAN} at (0,0) size 0x0 layer at (8,26) size 18x18 RenderListItem {LI} at (8,26) size 18x18 RenderListMarker at (0,0) size 18x18: "II" This crash happens because enclosingList in RenderListItem.cpp returns different nodes for the two <li> elements. Using only block element in enclosingList would fix this issue, I'm not 100% sure if this is the best fix though. A patch will come soon later. (CCing mitz as he seemed to touch this code recently in http://trac.webkit.org/changeset/53868) 273265 1 66340 hamaji 2010-09-02 02:09:35 -0700 Created attachment 66340 Patch v1 273272 2 66340 mitz 2010-09-02 02:25:41 -0700 Comment on attachment 66340 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=66340&action=prettypatch > WebCore/rendering/RenderListItem.cpp:100 > // If there's no actual <ul> or <ol> list element, then the first found > // node acts as our list for purposes of determining what other list items > // should be numbered as part of the same list. > - return firstNode; > + return firstBlockNode; The comment says the the first found node is used, but you changed it to be the first found node that is rendered as a block. Why is this the right thing to do? What if the document element itself is not a RenderBlock? Can this function return 0? 273399 3 66373 hamaji 2010-09-02 08:29:36 -0700 Created attachment 66373 Patch v2 (minor comment change) 273400 4 hamaji 2010-09-02 08:29:55 -0700 Thanks for your review! > The comment says the the first found node is used, but you changed it to be the first found node that is rendered as a block. Why is this the right thing to do? What if the document element itself is not a RenderBlock? Can this function return 0? I think we still have <html> as the last block element? Can this be missing or inline? I think I've never seen the case where the HTML element is inline, but of course I may be wrong. If I'm wrong, Could you tell me how I can make the root element inline? I've updated the comment for now. By the way, I don't really know what we should do when there are no <ul> and <ol>. I guess this case is not specified well. FYI, Firefox seems to output "0", not "II" for the test case. If we should prefer Firefox's behavior, I'll update my patch. I like the current WebKit's behavior though. Thanks! 273413 5 mitz 2010-09-02 09:12:23 -0700 (In reply to comment #4) > Thanks for your review! > > > The comment says the the first found node is used, but you changed it to be the first found node that is rendered as a block. Why is this the right thing to do? What if the document element itself is not a RenderBlock? Can this function return 0? > > I think we still have <html> as the last block element? Can this be missing or inline? I think I've never seen the case where the HTML element is inline, but of course I may be wrong. If I'm wrong, Could you tell me how I can make the root element inline? I've updated the comment for now. I was wrong. The document element is indeed forced to be a block. However, according to the comment in <http://trac.webkit.org/browser/trunk/WebCore/rendering/RenderView.cpp#L211> this may not always be the case. > By the way, I don't really know what we should do when there are no <ul> and <ol>. I guess this case is not specified well. FYI, Firefox seems to output "0", not "II" for the test case. If we should prefer Firefox's behavior, I'll update my patch. I like the current WebKit's behavior though. > > Thanks! Can you explain the significance of returning a node that is rendered as a block? 273940 6 hamaji 2010-09-03 07:49:26 -0700 > Can you explain the significance of returning a node that is rendered as a block? In the test case, the first <li> considers <body> is its enclosing node and the second <li>'s enclosing node is <span>. If we ignore <span>, the second <li> also consider's <body> as its enclosing node, so the two <li>s have the same enclosing node and previousListItem returns <body> before it touches a NULL renderer. Also, given <ul> and <ol> are blocks, I couldn't imagine the case where having always block enclosing nodes, though it's not good if the document element can be inline. Anyway, as I wrote, I'm not sure if this fix is the best. Perhaps we need to change the position of the continued <span>, but I'm not sure if it's easy to fix this bug this way. The current render tree is like RenderView 0x11477fc #document 0x886f000 RenderBlock 0x11af77c HTML 0x1161150 RenderBody 0x114302c BODY 0x11a4460 RenderBlock (anonymous) 0x11a8d0c RenderInline 0x11a74bc SPAN 0x11afca0 RenderText 0x11ab47c #text 0x1154e60 "\n" RenderBlock (anonymous) 0x11abccc RenderListItem 0x11afe0c LI 0x11a95d0 RenderBlock (anonymous) 0x11a8b8c RenderInline 0x11a85ec SPAN 0x11afca0 RenderListItem 0x11a845c LI 0x11a87b0 STYLE=position:absolute The above render tree isn't good and it should be like the following? RenderView 0x11477fc #document 0x886f000 RenderBlock 0x11af77c HTML 0x1161150 RenderBody 0x114302c BODY 0x11a4460 RenderBlock (anonymous) 0x11a8d0c RenderInline 0x11a74bc SPAN 0x11afca0 RenderText 0x11ab47c #text 0x1154e60 "\n" RenderBlock (anonymous) 0x11abccc RenderListItem 0x11afe0c LI 0x11a95d0 RenderBlock (anonymous) 0x11a8b8c RenderListItem 0x11a845c LI 0x11a87b0 STYLE=position:absolute RenderBlock (anonymous) 0x11a8bXX RenderInline 0x11a85ec SPAN 0x11afca0 288058 7 hamaji 2010-09-30 22:27:17 -0700 Ping? Please let me know if my description is unclear. Thanks, 290704 8 yuzo 2010-10-06 17:08:42 -0700 Ping? (on behalf of Shinichiro) 293998 9 70714 hamaji 2010-10-14 00:24:27 -0700 Created attachment 70714 Patch only for NULL crash 294000 10 hamaji 2010-10-14 00:26:21 -0700 OK, I guess Dan is busy these days. So, as a crash bug is somewhat serious, let's fix the crash first then try fixing wrong numbering later. The patch I've just submitted has a failing layout test, but at least it doesn't crash. If this patch is accepted, I'll file another bug for the failing test. 296030 11 70714 tkent 2010-10-19 00:35:01 -0700 Comment on attachment 70714 Patch only for NULL crash Looks ok. 296676 12 commit-queue 2010-10-20 00:41:31 -0700 The commit-queue encountered the following flaky tests while processing attachment 70714: http/tests/security/xssAuditor/script-tag-with-source-double-quote.html Please file bugs against the tests. The author(s) of the test(s) have been CCed on this bug. The commit-queue is continuing to process your patch. 296679 13 70714 commit-queue 2010-10-20 00:44:57 -0700 Comment on attachment 70714 Patch only for NULL crash Clearing flags on attachment: 70714 Committed r70132: <http://trac.webkit.org/changeset/70132> 296680 14 commit-queue 2010-10-20 00:45:03 -0700 All reviewed patches have been landed. Closing bug. 66340 2010-09-02 02:09:35 -0700 2010-09-02 08:29:31 -0700 Patch v1 bug-45095-20100902020933.patch text/plain 3777 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2NjAyZTcxMWUwZDdhODlmYzc2YTljNjVhM2VkMGEwMzAxNjRkMjUyLi4xYTc4ZjU5 OWEyODBmMDgxZDNkOTA4NGUyZjM4NTY3N2VhYjJmMDVmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDktMDIgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBhYnNvbHV0ZWx5 IHBvc2l0aW9uZWQgbGlzdCBpbiBpbmxpbmUgZWxlbWVudCBjcmFzaGVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTA5NQorCisgICAgICAgICogZmFz dC9saXN0cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9saXN0cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLmh0bWw6IEFkZGVkLgorCiAy MDEwLTA4LTMwICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkLCByb2xsaW5nIG91dCByNjY0MTguCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2xpc3RzL3Bvc2l0aW9uZWQtY291bnQtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZmFzdC9saXN0cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li4xNDcyZWQxZTczNDE3MDMxMWM3MjBkZDA3ZGRhOWFlYTdjOTFjZDNkCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9saXN0cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLWV4cGVj dGVkLnR4dApAQCAtMCwwICsxLDQgQEAKK0lJCitGb3IgbWFudWFsIHRlc3Q6IElmIHlvdSBzZWUg bm8gY3Jhc2ggYW5kICJJSSBJSSIsIGl0IG1lYW5zIHRoaXMgdGVzdCBQQVNTLgorUEFTUyBsaXN0 IG1hcmtlciBpcyBJSS4KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9saXN0cy9wb3Np dGlvbmVkLWNvdW50LWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2xpc3RzL3Bvc2l0aW9u ZWQtY291bnQtY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41MWM3YzYwODdhYzBkNTQ4M2Q3NmUyYmM2 MDhlNzlkNDg5OTkyNDIwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9saXN0 cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLmh0bWwKQEAgLTAsMCArMSwxNyBAQAorPGRpdj4KKzxz cGFuPgorPGxpPgorPGxpIGlkPSJ0ZXN0IiBzdHlsZT0icG9zaXRpb246IGFic29sdXRlO2xpc3Qt c3R5bGUtdHlwZTogdXBwZXItcm9tYW47Ij5JSQorPC9kaXY+CisKKzxkaXY+CitGb3IgbWFudWFs IHRlc3Q6IElmIHlvdSBzZWUgbm8gY3Jhc2ggYW5kICJJSSBJSSIsIGl0IG1lYW5zIHRoaXMgdGVz dCBQQVNTLgorPC9kaXY+CisKKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvZHVtcC1saXN0LmpzIj48 L3NjcmlwdD4KKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikg eworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGRv Y3VtZW50LndyaXRlKHRlc3RMaXN0SXRlbU1hcmtlckVxdWFsc0xpc3RJdGVtVGV4dChkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgidGVzdCIpKSk7CisgICAgfQorPC9zY3JpcHQ+CmRpZmYgLS1naXQg YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGU4NzRjZDNiNjhl NWY0OTM3ZjM0YmMwNTA4YzljOGNhZGNlY2E5NDIuLjkzZTAxNTI0NWVhY2Q5MjdjODgyZDJlYTY1 NzBiMjA4MmRiMjc4NGEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMDIgIFNoaW5pY2hpcm8gSGFt YWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBhYnNvbHV0ZWx5IHBvc2l0aW9uZWQgbGlzdCBpbiBpbmxpbmUg ZWxlbWVudCBjcmFzaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NTA5NQorCisgICAgICAgIFVzZSBvbmx5IGJsb2NrIGVsZW1lbnRzIGFzIGVuY2xv c2luZyBsaXN0LgorCisgICAgICAgIFRlc3Q6IGZhc3QvbGlzdHMvcG9zaXRpb25lZC1jb3VudC1j cmFzaC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6ZW5jbG9zaW5nTGlzdCk6CisKIDIwMTAtMDgtMzAgIEVyaWMgU2VpZGVs ICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI2 NjQxOC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RJdGVtLmNwcCBi L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RJdGVtLmNwcAppbmRleCAyMzY2YTM0YWI2Mjdk NzllNmUyMzIxYzAxYjIyNGUwMTI2ZjdiZjM5Li5kNzc0YjM3ZmRmOWRiOWM5ZmZlMzMzNTZiYmVm ZWZkY2E0MTBmY2E5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0SXRl bS5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3BwCkBAIC04Miwy MiArODIsMjIgQEAgc3RhdGljIGJvb2wgaXNMaXN0KE5vZGUqIG5vZGUpCiAKIHN0YXRpYyBOb2Rl KiBlbmNsb3NpbmdMaXN0KGNvbnN0IFJlbmRlckxpc3RJdGVtKiBsaXN0SXRlbSkKIHsKLSAgICBO b2RlKiBmaXJzdE5vZGUgPSAwOworICAgIE5vZGUqIGZpcnN0QmxvY2tOb2RlID0gMDsKIAogICAg IGZvciAoY29uc3QgUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IGxpc3RJdGVtLT5wYXJlbnQoKTsg cmVuZGVyZXI7IHJlbmRlcmVyID0gcmVuZGVyZXItPnBhcmVudCgpKSB7CiAgICAgICAgIE5vZGUq IG5vZGUgPSByZW5kZXJlci0+bm9kZSgpOwogICAgICAgICBpZiAobm9kZSkgewogICAgICAgICAg ICAgaWYgKGlzTGlzdChub2RlKSkKICAgICAgICAgICAgICAgICByZXR1cm4gbm9kZTsKLSAgICAg ICAgICAgIGlmICghZmlyc3ROb2RlKQotICAgICAgICAgICAgICAgIGZpcnN0Tm9kZSA9IG5vZGU7 CisgICAgICAgICAgICBpZiAoIWZpcnN0QmxvY2tOb2RlICYmIHJlbmRlcmVyLT5pc1JlbmRlckJs b2NrKCkpCisgICAgICAgICAgICAgICAgZmlyc3RCbG9ja05vZGUgPSBub2RlOwogICAgICAgICB9 CiAgICAgfQogCiAgICAgLy8gSWYgdGhlcmUncyBubyBhY3R1YWwgPHVsPiBvciA8b2w+IGxpc3Qg ZWxlbWVudCwgdGhlbiB0aGUgZmlyc3QgZm91bmQKICAgICAvLyBub2RlIGFjdHMgYXMgb3VyIGxp c3QgZm9yIHB1cnBvc2VzIG9mIGRldGVybWluaW5nIHdoYXQgb3RoZXIgbGlzdCBpdGVtcwogICAg IC8vIHNob3VsZCBiZSBudW1iZXJlZCBhcyBwYXJ0IG9mIHRoZSBzYW1lIGxpc3QuCi0gICAgcmV0 dXJuIGZpcnN0Tm9kZTsKKyAgICByZXR1cm4gZmlyc3RCbG9ja05vZGU7CiB9CiAKIHN0YXRpYyBS ZW5kZXJMaXN0SXRlbSogcHJldmlvdXNMaXN0SXRlbShOb2RlKiBsaXN0LCBjb25zdCBSZW5kZXJM aXN0SXRlbSogaXRlbSkK 66373 2010-09-02 08:29:36 -0700 2010-10-14 00:24:22 -0700 Patch v2 (minor comment change) bug-45095-20100902082934.patch text/plain 3916 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2NjAyZTcxMWUwZDdhODlmYzc2YTljNjVhM2VkMGEwMzAxNjRkMjUyLi4xYTc4ZjU5 OWEyODBmMDgxZDNkOTA4NGUyZjM4NTY3N2VhYjJmMDVmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDktMDIgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBhYnNvbHV0ZWx5 IHBvc2l0aW9uZWQgbGlzdCBpbiBpbmxpbmUgZWxlbWVudCBjcmFzaGVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTA5NQorCisgICAgICAgICogZmFz dC9saXN0cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9saXN0cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLmh0bWw6IEFkZGVkLgorCiAy MDEwLTA4LTMwICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkLCByb2xsaW5nIG91dCByNjY0MTguCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2xpc3RzL3Bvc2l0aW9uZWQtY291bnQtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZmFzdC9saXN0cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li4xNDcyZWQxZTczNDE3MDMxMWM3MjBkZDA3ZGRhOWFlYTdjOTFjZDNkCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9saXN0cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLWV4cGVj dGVkLnR4dApAQCAtMCwwICsxLDQgQEAKK0lJCitGb3IgbWFudWFsIHRlc3Q6IElmIHlvdSBzZWUg bm8gY3Jhc2ggYW5kICJJSSBJSSIsIGl0IG1lYW5zIHRoaXMgdGVzdCBQQVNTLgorUEFTUyBsaXN0 IG1hcmtlciBpcyBJSS4KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9saXN0cy9wb3Np dGlvbmVkLWNvdW50LWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2xpc3RzL3Bvc2l0aW9u ZWQtY291bnQtY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41MWM3YzYwODdhYzBkNTQ4M2Q3NmUyYmM2 MDhlNzlkNDg5OTkyNDIwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9saXN0 cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLmh0bWwKQEAgLTAsMCArMSwxNyBAQAorPGRpdj4KKzxz cGFuPgorPGxpPgorPGxpIGlkPSJ0ZXN0IiBzdHlsZT0icG9zaXRpb246IGFic29sdXRlO2xpc3Qt c3R5bGUtdHlwZTogdXBwZXItcm9tYW47Ij5JSQorPC9kaXY+CisKKzxkaXY+CitGb3IgbWFudWFs IHRlc3Q6IElmIHlvdSBzZWUgbm8gY3Jhc2ggYW5kICJJSSBJSSIsIGl0IG1lYW5zIHRoaXMgdGVz dCBQQVNTLgorPC9kaXY+CisKKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvZHVtcC1saXN0LmpzIj48 L3NjcmlwdD4KKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikg eworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGRv Y3VtZW50LndyaXRlKHRlc3RMaXN0SXRlbU1hcmtlckVxdWFsc0xpc3RJdGVtVGV4dChkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgidGVzdCIpKSk7CisgICAgfQorPC9zY3JpcHQ+CmRpZmYgLS1naXQg YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGU4NzRjZDNiNjhl NWY0OTM3ZjM0YmMwNTA4YzljOGNhZGNlY2E5NDIuLjkzZTAxNTI0NWVhY2Q5MjdjODgyZDJlYTY1 NzBiMjA4MmRiMjc4NGEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMDIgIFNoaW5pY2hpcm8gSGFt YWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBhYnNvbHV0ZWx5IHBvc2l0aW9uZWQgbGlzdCBpbiBpbmxpbmUg ZWxlbWVudCBjcmFzaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NTA5NQorCisgICAgICAgIFVzZSBvbmx5IGJsb2NrIGVsZW1lbnRzIGFzIGVuY2xv c2luZyBsaXN0LgorCisgICAgICAgIFRlc3Q6IGZhc3QvbGlzdHMvcG9zaXRpb25lZC1jb3VudC1j cmFzaC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6ZW5jbG9zaW5nTGlzdCk6CisKIDIwMTAtMDgtMzAgIEVyaWMgU2VpZGVs ICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI2 NjQxOC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RJdGVtLmNwcCBi L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RJdGVtLmNwcAppbmRleCAyMzY2YTM0YWI2Mjdk NzllNmUyMzIxYzAxYjIyNGUwMTI2ZjdiZjM5Li44MjI3MzY1MGUxYTg4Mzc5YTYwZmZhZWQ3MmYw MjkyY2E0MDdiYTc0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0SXRl bS5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3BwCkBAIC04Miwy MiArODIsMjIgQEAgc3RhdGljIGJvb2wgaXNMaXN0KE5vZGUqIG5vZGUpCiAKIHN0YXRpYyBOb2Rl KiBlbmNsb3NpbmdMaXN0KGNvbnN0IFJlbmRlckxpc3RJdGVtKiBsaXN0SXRlbSkKIHsKLSAgICBO b2RlKiBmaXJzdE5vZGUgPSAwOworICAgIE5vZGUqIGZpcnN0QmxvY2tOb2RlID0gMDsKIAogICAg IGZvciAoY29uc3QgUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IGxpc3RJdGVtLT5wYXJlbnQoKTsg cmVuZGVyZXI7IHJlbmRlcmVyID0gcmVuZGVyZXItPnBhcmVudCgpKSB7CiAgICAgICAgIE5vZGUq IG5vZGUgPSByZW5kZXJlci0+bm9kZSgpOwogICAgICAgICBpZiAobm9kZSkgewogICAgICAgICAg ICAgaWYgKGlzTGlzdChub2RlKSkKICAgICAgICAgICAgICAgICByZXR1cm4gbm9kZTsKLSAgICAg ICAgICAgIGlmICghZmlyc3ROb2RlKQotICAgICAgICAgICAgICAgIGZpcnN0Tm9kZSA9IG5vZGU7 CisgICAgICAgICAgICBpZiAoIWZpcnN0QmxvY2tOb2RlICYmIHJlbmRlcmVyLT5pc1JlbmRlckJs b2NrKCkpCisgICAgICAgICAgICAgICAgZmlyc3RCbG9ja05vZGUgPSBub2RlOwogICAgICAgICB9 CiAgICAgfQogCiAgICAgLy8gSWYgdGhlcmUncyBubyBhY3R1YWwgPHVsPiBvciA8b2w+IGxpc3Qg ZWxlbWVudCwgdGhlbiB0aGUgZmlyc3QgZm91bmQKLSAgICAvLyBub2RlIGFjdHMgYXMgb3VyIGxp c3QgZm9yIHB1cnBvc2VzIG9mIGRldGVybWluaW5nIHdoYXQgb3RoZXIgbGlzdCBpdGVtcwotICAg IC8vIHNob3VsZCBiZSBudW1iZXJlZCBhcyBwYXJ0IG9mIHRoZSBzYW1lIGxpc3QuCi0gICAgcmV0 dXJuIGZpcnN0Tm9kZTsKKyAgICAvLyBibG9jayBub2RlIGFjdHMgYXMgb3VyIGxpc3QgZm9yIHB1 cnBvc2VzIG9mIGRldGVybWluaW5nIHdoYXQgb3RoZXIKKyAgICAvLyBsaXN0IGl0ZW1zIHNob3Vs ZCBiZSBudW1iZXJlZCBhcyBwYXJ0IG9mIHRoZSBzYW1lIGxpc3QuCisgICAgcmV0dXJuIGZpcnN0 QmxvY2tOb2RlOwogfQogCiBzdGF0aWMgUmVuZGVyTGlzdEl0ZW0qIHByZXZpb3VzTGlzdEl0ZW0o Tm9kZSogbGlzdCwgY29uc3QgUmVuZGVyTGlzdEl0ZW0qIGl0ZW0pCg== 70714 2010-10-14 00:24:27 -0700 2010-10-20 00:44:57 -0700 Patch only for NULL crash bug-45095-20101014002426.patch text/plain 3542 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5MzBlODAzYTFmNjI1NGI0MGViYTZhOWJiMjIxZjBhYmZhYTNmZDU0Li5kZTNkZGY5 ODBhZjg2YjZhMDNmZGU2OGRiN2VkYTk1ZDgzNjY5NmY5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTAtMTQgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBhYnNvbHV0ZWx5 IHBvc2l0aW9uZWQgbGlzdCBpbiBpbmxpbmUgZWxlbWVudCBjcmFzaGVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTA5NQorCisgICAgICAgICogZmFz dC9saXN0cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9saXN0cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLmh0bWw6IEFkZGVkLiBOb3Rl IHRoYXQgdGhpcyB0ZXN0IGlzIGZhaWxpbmcgZm9yIG5vdy4KKwogMjAxMC0xMC0xMyAgU2hpbmlj aGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVwZGF0ZSBjaHJv bWl1bSdzIHRlc3QgZXhwZWN0YXRpb25zLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9s aXN0cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zh c3QvbGlzdHMvcG9zaXRpb25lZC1jb3VudC1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u OWZjMDY2ZDVkMTFmMWUwNzg4NDcxMTAxMTRlNzdlMjAxMGExNjdkMAotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvbGlzdHMvcG9zaXRpb25lZC1jb3VudC1jcmFzaC1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSw2IEBACitJSQorCisKK0ZvciBtYW51YWwgdGVzdDogSWYgeW91IHNl ZSBubyBjcmFzaCBhbmQgIklJIElJIiwgaXQgbWVhbnMgdGhpcyB0ZXN0IFBBU1MuCitGQUlMIGxp c3QgbWFya2VyIHNob3VsZCBiZSBJSS4gV2FzIEkuCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvbGlzdHMvcG9zaXRpb25lZC1jb3VudC1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZmFz dC9saXN0cy9wb3NpdGlvbmVkLWNvdW50LWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYTYyNTY4YTA4 ODMwZDJkNTE2ZGM2NDE5OGZiNTIzOTAzNWQxZmEzNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvbGlzdHMvcG9zaXRpb25lZC1jb3VudC1jcmFzaC5odG1sCkBAIC0wLDAgKzEs MTkgQEAKKzxkaXY+Cis8c3Bhbj4KKzxsaT4KKzxsaSBpZD0idGVzdCIgc3R5bGU9InBvc2l0aW9u OiBhYnNvbHV0ZTtsaXN0LXN0eWxlLXR5cGU6IHVwcGVyLXJvbWFuOyI+SUkKKzwvZGl2PgorCis8 ZGl2PgorPGJyPgorPGJyPgorRm9yIG1hbnVhbCB0ZXN0OiBJZiB5b3Ugc2VlIG5vIGNyYXNoIGFu ZCAiSUkgSUkiLCBpdCBtZWFucyB0aGlzIHRlc3QgUEFTUy4KKzwvZGl2PgorCis8c2NyaXB0IHNy Yz0icmVzb3VyY2VzL2R1bXAtbGlzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIuZHVtcEFzVGV4dCgpOworICAgICAgICBkb2N1bWVudC53cml0ZSh0ZXN0TGlzdEl0ZW1NYXJr ZXJFcXVhbHNMaXN0SXRlbVRleHQoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3QiKSkpOwor ICAgIH0KKzwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA3OGJjYzM1MTlmOTRlZWU5MzQzNmZhNzVmY2Q0N2U2MmQ0ZTYxNDVm Li4yZjBmOGQwY2ZjOTU5NDgzOWIyYTc4MTQ0MzM4NGM5YzkyNjc0M2I1IDEwMDY0NAotLS0gYS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDEwLTEwLTE0ICBTaGluaWNoaXJvIEhhbWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYWJzb2x1dGVs eSBwb3NpdGlvbmVkIGxpc3QgaW4gaW5saW5lIGVsZW1lbnQgY3Jhc2hlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUwOTUKKworICAgICAgICBBZGQg YSBOVUxMIGNoZWNrIHRvIGF2b2lkIGNyYXNoLiBUaGUgcmVuZGVyaW5nIHJlc3VsdCBpc24ndCBp ZGVhbCB5ZXQuCisKKyAgICAgICAgVGVzdDogZmFzdC9saXN0cy9wb3NpdGlvbmVkLWNvdW50LWNy YXNoLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMaXN0SXRlbS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpwcmV2aW91c0xpc3RJdGVtKToKKwogMjAxMC0xMC0xMiAgQWJoaXNoZWsg QXJ5YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3Bw IGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3BwCmluZGV4IGMyNDhjNWYzODc3 YjE3YTFhNGFkMGY4YTFlMzgzNmUyMDg3MmVmODguLjFmNjAwZmVjYTBjNDVkNGRiODNmMTMzYzZi ZDRmNTM1YTM4MjQxMjggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RJ dGVtLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0SXRlbS5jcHAKQEAgLTEw Miw3ICsxMDIsNyBAQCBzdGF0aWMgTm9kZSogZW5jbG9zaW5nTGlzdChjb25zdCBSZW5kZXJMaXN0 SXRlbSogbGlzdEl0ZW0pCiAKIHN0YXRpYyBSZW5kZXJMaXN0SXRlbSogcHJldmlvdXNMaXN0SXRl bShOb2RlKiBsaXN0LCBjb25zdCBSZW5kZXJMaXN0SXRlbSogaXRlbSkKIHsKLSAgICBmb3IgKFJl bmRlck9iamVjdCogcmVuZGVyZXIgPSBpdGVtLT5wcmV2aW91c0luUHJlT3JkZXIoKTsgcmVuZGVy ZXIgIT0gbGlzdC0+cmVuZGVyZXIoKTsgcmVuZGVyZXIgPSByZW5kZXJlci0+cHJldmlvdXNJblBy ZU9yZGVyKCkpIHsKKyAgICBmb3IgKFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBpdGVtLT5wcmV2 aW91c0luUHJlT3JkZXIoKTsgcmVuZGVyZXIgJiYgcmVuZGVyZXIgIT0gbGlzdC0+cmVuZGVyZXIo KTsgcmVuZGVyZXIgPSByZW5kZXJlci0+cHJldmlvdXNJblByZU9yZGVyKCkpIHsKICAgICAgICAg aWYgKCFyZW5kZXJlci0+aXNMaXN0SXRlbSgpKQogICAgICAgICAgICAgY29udGludWU7CiAgICAg ICAgIE5vZGUqIG90aGVyTGlzdCA9IGVuY2xvc2luZ0xpc3QodG9SZW5kZXJMaXN0SXRlbShyZW5k ZXJlcikpOwo=