45081 2010-09-01 19:09:44 -0700 Crash rendering <meter/> with percent padding 2011-01-18 22:01:30 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 koz koz commit-queue jamesr morrita noel.gordon tkent webkit.review.bot oldest_to_newest 273157 0 66312 koz 2010-09-01 19:09:44 -0700 Created attachment 66312 Reproduction WebKit crashes when trying to render a <meter> element that has percentage padding, eg: <meter style="padding: 1%;" /> Test case attached. 273194 1 66318 koz 2010-09-01 20:46:18 -0700 Created attachment 66318 Stack trace 273197 2 koz 2010-09-01 21:22:24 -0700 The crash is caused by a null dereference of containingBlock() in RenderBoxModelObject::paddingTop(). RenderMeter queries its size when determining whether it needs to be layed out, but initially it has no containing block, hence the null dereference. I'll write a patch to make RenderMeter always request layout so this query never occurs. 273253 3 66338 koz 2010-09-02 01:22:10 -0700 Created attachment 66338 Proposed patch 273255 4 webkit.review.bot 2010-09-02 01:24:17 -0700 Attachment 66338 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 273259 5 66338 morrita 2010-09-02 01:47:35 -0700 Comment on attachment 66338 Proposed patch Hi, thank you for doing this! The change looks OK in general. Please fix what the bot claims. You can use WebKitTools/Scripts/check-webkit-style to correct coding convention errors before the bot bites us. For the test, are we OK even for other than padding? Having size-based properties like margin, width, height would be helpful. For ChangeLog, please mention what caused the crash briefly. 273260 6 66339 koz 2010-09-02 01:51:35 -0700 Created attachment 66339 Proposed patch 273261 7 66338 tkent 2010-09-02 01:52:03 -0700 Comment on attachment 66338 Proposed patch r- for the style error. 274501 8 tkent 2010-09-05 23:32:45 -0700 The second patch seems not to answer Morita-san's requests. > For the test, are we OK even for other than padding? > Having size-based properties like margin, width, height would be helpful. > > For ChangeLog, please mention what caused the crash briefly. 274506 9 66339 abarth 2010-09-05 23:43:39 -0700 Comment on attachment 66339 Proposed patch See comment above. 274844 10 66684 koz 2010-09-06 21:29:27 -0700 Created attachment 66684 Proposed patch 274871 11 morrita 2010-09-07 00:49:30 -0700 Looks fine for me. 274872 12 66684 tkent 2010-09-07 00:50:21 -0700 Comment on attachment 66684 Proposed patch OK. 274889 13 66684 commit-queue 2010-09-07 01:12:45 -0700 Comment on attachment 66684 Proposed patch Clearing flags on attachment: 66684 Committed r66864: <http://trac.webkit.org/changeset/66864> 274890 14 commit-queue 2010-09-07 01:12:49 -0700 All reviewed patches have been landed. Closing bug. 66312 2010-09-01 19:09:44 -0700 2010-09-01 19:09:44 -0700 Reproduction crash-meter.html text/html 31 koz PG1ldGVyIHN0eWxlPSJwYWRkaW5nOiA1JTsiIC8+Cg== 66318 2010-09-01 20:46:18 -0700 2010-09-01 20:46:18 -0700 Stack trace stack_trace.txt text/plain 1599 koz VGhyZWFkIDAgQ3Jhc2hlZDogIERpc3BhdGNoIHF1ZXVlOiBjb20uYXBwbGUubWFpbi10aHJlYWQK MCAgIGNvbS5hcHBsZS5XZWJDb3JlICAgICAgICAgICAgIAkweDAwMDAwMDAxMDE0ZGM5ODggV2Vi Q29yZTo6UmVuZGVyQm94TW9kZWxPYmplY3Q6OnBhZGRpbmdUb3AoYm9vbCkgY29uc3QgKyA4OAox ICAgY29tLmFwcGxlLldlYkNvcmUgICAgICAgICAgICAgCTB4MDAwMDAwMDEwMTUzNDA2MCBXZWJD b3JlOjpSZW5kZXJNZXRlcjo6YmFyUGFydFJlY3QoKSBjb25zdCArIDY0CjIgICBjb20uYXBwbGUu V2ViQ29yZSAgICAgICAgICAgICAJMHgwMDAwMDAwMTAxNTM0MTdkIFdlYkNvcmU6OlJlbmRlck1l dGVyOjppc0hvcml6b250YWwoKSBjb25zdCArIDEzCjMgICBjb20uYXBwbGUuV2ViQ29yZSAgICAg ICAgICAgICAJMHgwMDAwMDAwMTAxNTM0NDUxIFdlYkNvcmU6OlJlbmRlck1ldGVyOjpzaG91bGRI YXZlUGFydHMoKSBjb25zdCArIDQ5CjQgICBjb20uYXBwbGUuV2ViQ29yZSAgICAgICAgICAgICAJ MHgwMDAwMDAwMTAxNGZjNDc3IFdlYkNvcmU6OlJlbmRlckluZGljYXRvcjo6cmVxdWVzdExheW91 dEZvclBhcnRzKCkgKyAyMwo1ICAgY29tLmFwcGxlLldlYkNvcmUgICAgICAgICAgICAgCTB4MDAw MDAwMDEwMTUzZGJhZCBXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OnNldFN0eWxlKFdURjo6UGFzc1Jl ZlB0cjxXZWJDb3JlOjpSZW5kZXJTdHlsZT4pICsgMzQ5CjYgICBjb20uYXBwbGUuV2ViQ29yZSAg ICAgICAgICAgICAJMHgwMDAwMDAwMTAxNTNjODY2IFdlYkNvcmU6OlJlbmRlck9iamVjdDo6c2V0 QW5pbWF0YWJsZVN0eWxlKFdURjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpSZW5kZXJTdHlsZT4pICsg ODYKNyAgIGNvbS5hcHBsZS5XZWJDb3JlICAgICAgICAgICAgIAkweDAwMDAwMDAxMDE0NjAyNWIg V2ViQ29yZTo6Tm9kZTo6Y3JlYXRlUmVuZGVyZXJJZk5lZWRlZCgpICsgMjgzCjggICBjb20uYXBw bGUuV2ViQ29yZSAgICAgICAgICAgICAJMHgwMDAwMDAwMTAwZTlhMzYwIFdlYkNvcmU6OkVsZW1l bnQ6OmF0dGFjaCgpICsgMzIKOSAgIGNvbS5hcHBsZS5XZWJDb3JlICAgICAgICAgICAgIAkweDAw MDAwMDAxMDBmNzM4MWMgV2ViQ29yZTo6SFRNTEZvcm1Db250cm9sRWxlbWVudDo6YXR0YWNoKCkg KyAyOAoxMCAgY29tLmFwcGxlLldlYkNvcmUgICAgICAgICAgICAgCTB4MDAwMDAwMDEwMTdhYTM1 MiBXVEY6OlBhc3NSZWZQdHI8V2ViQ29yZTo6RWxlbWVudD4gV2ViQ29yZTo6SFRNTENvbnN0cnVj dGlvblNpdGU6OmF0dGFjaDxXZWJDb3JlOjpFbGVtZW50PihXZWJDb3JlOjpDb250YWluZXJOb2Rl KiwgV1RGOjpQYXNzUmVmUHRyPFdlYkNvcmU6OkVsZW1lbnQ+KSArIDE3OAoxMSAgY29tLmFwcGxl LldlYkNvcmUgICAgICAgICAgICAgCTB4MDAwMDAwMDEwMTdhOTUwYiBXZWJDb3JlOjpIVE1MQ29u c3RydWN0aW9uU2l0ZTo6YXR0YWNoVG9DdXJyZW50KFdURjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpF bGVtZW50PikgKyA0MwoxMiAgY29tLmFwcGxlLldlYkNvcmUgICAgICAgICAgICAgCTB4MDAwMDAw MDEwMTdhOTg5YiBXZWJDb3JlOjpIVE1MQ29uc3RydWN0aW9uU2l0ZTo6aW5zZXJ0SFRNTEVsZW1l bnQK 66338 2010-09-02 01:22:10 -0700 2010-09-02 01:52:03 -0700 Proposed patch MeterCrash.txt text/plain 3333 koz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjY0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMDIgIEphbWVzIEtvemlhbnNraSAgPGtvekBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q3Jhc2ggcmVuZGVyaW5nIDxtZXRlci8+IHdpdGggcGVyY2VudCBwYWRkaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTA4MQorCisJCQkJQ2hhbmdl ZCBSZW5kZXJNZXRlciB0byBhbHdheXMgcmVxdWVzdCBsYXlvdXQgZm9yIGl0cyBwYXJ0cy4KKwor ICAgICAgICBUZXN0OiBmYXN0L2RvbS9IVE1MTWV0ZXJFbGVtZW50L21ldGVyLXBhZGRpbmcuaHRt bAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckluZGljYXRvci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJJbmRpY2F0b3I6OnJlcXVlc3RMYXlvdXRGb3JQYXJ0cyk6CisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckluZGljYXRvci5oOgorCiAyMDEwLTA5LTAyICBJbHlhIFNoZXJt YW4gIDxpc2hlcm1hbkBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2Vp ZGVsLgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5kaWNhdG9yLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbmRpY2F0b3IuY3BwCShyZXZpc2lvbiA2 NjYzOSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckluZGljYXRvci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTYzLDE3ICs2Myw5IEBAIHZvaWQgUmVuZGVySW5kaWNhdG9yOjp1cGRhdGVGcm9t RWxlbWVudCgKICAgICByZXBhaW50KCk7CiB9CiAKLWJvb2wgUmVuZGVySW5kaWNhdG9yOjpoYXNQ YXJ0cygpIGNvbnN0Ci17Ci0gICAgaWYgKFJlbmRlck9iamVjdCogbGFzdCA9IGxhc3RDaGlsZCgp KQotICAgICAgICByZXR1cm4gbGFzdC0+aXNSZW5kZXJCbG9jaygpOwotICAgIHJldHVybiBmYWxz ZTsKLX0KLQogdm9pZCBSZW5kZXJJbmRpY2F0b3I6OnJlcXVlc3RMYXlvdXRGb3JQYXJ0cygpCiB7 Ci0gICAgaWYgKHNob3VsZEhhdmVQYXJ0cygpIHx8IGhhc1BhcnRzKCkpCi0gICAgICAgIHNldE5l ZWRzTGF5b3V0KHRydWUpOworICAgIHNldE5lZWRzTGF5b3V0KHRydWUpOwogfQogCiB9IC8vIG5h bWVzcGFjZSBXZWJDb3JlCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbmRpY2F0b3Iu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbmRpY2F0b3IuaAkocmV2 aXNpb24gNjY2MzkpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbmRpY2F0b3IuaAkod29y a2luZyBjb3B5KQpAQCAtNDIsNyArNDIsNiBAQCBwcm90ZWN0ZWQ6CiAKIHByaXZhdGU6CiAgICAg dm9pZCByZXF1ZXN0TGF5b3V0Rm9yUGFydHMoKTsKLSAgICBib29sIGhhc1BhcnRzKCkgY29uc3Q7 CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2NjY0NykK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEwLTA5LTAyICBKYW1lcyBLb3ppYW5za2kgIDxrb3pAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyYXNoIHJlbmRlcmlu ZyA8bWV0ZXIvPiB3aXRoIHBlcmNlbnQgcGFkZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUwODEKKworICAgICAgICAqIGZhc3QvZG9tL0hUTUxN ZXRlckVsZW1lbnQvbWV0ZXItcGFkZGluZy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGZhc3QvZG9tL0hUTUxNZXRlckVsZW1lbnQvbWV0ZXItcGFkZGluZy5odG1sOiBBZGRlZC4KKwog MjAxMC0wOC0zMSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJsc29uLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9k b20vSFRNTE1ldGVyRWxlbWVudC9tZXRlci1wYWRkaW5nLWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MTWV0ZXJFbGVtZW50L21ldGVyLXBhZGRpbmct ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTE1l dGVyRWxlbWVudC9tZXRlci1wYWRkaW5nLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSwzIEBACitUZXN0cyB0aGF0IHBlcmNlbnRhZ2UgcGFkZGluZyBvbiBhIG1ldGVyIGVsZW1l bnQgZG9lc24ndCBjcmFzaC4KKworUEFTUwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRN TE1ldGVyRWxlbWVudC9tZXRlci1wYWRkaW5nLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC9kb20vSFRNTE1ldGVyRWxlbWVudC9tZXRlci1wYWRkaW5nLmh0bWwJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MTWV0ZXJFbGVtZW50L21ldGVyLXBhZGRp bmcuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMCBAQAorPGh0bWw+CisgIDxib2R5Pgor ICAgIDxwPlRlc3RzIHRoYXQgcGVyY2VudGFnZSBwYWRkaW5nIG9uIGEgbWV0ZXIgZWxlbWVudCBk b2Vzbid0IGNyYXNoLjwvcD4KKyAgICA8bWV0ZXIgc3R5bGU9InBhZGRpbmc6IDElOyI+MzAlPC9t ZXRlcj5QQVNTCisgICAgPHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9s bGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgPC9z Y3JpcHQ+CisgIDwvYm9keT4KKzwvaHRtbD4K 66339 2010-09-02 01:51:35 -0700 2010-09-05 23:43:39 -0700 Proposed patch MeterCrash.txt text/plain 3337 koz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjY0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMDIgIEphbWVzIEtvemlhbnNraSAgPGtvekBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q3Jhc2ggcmVuZGVyaW5nIDxtZXRlci8+IHdpdGggcGVyY2VudCBwYWRkaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTA4MQorCisgICAgICAgIENo YW5nZWQgUmVuZGVyTWV0ZXIgdG8gYWx3YXlzIHJlcXVlc3QgbGF5b3V0IGZvciBpdHMgcGFydHMu CisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vSFRNTE1ldGVyRWxlbWVudC9tZXRlci1wYWRkaW5n Lmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJJbmRpY2F0b3IuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVySW5kaWNhdG9yOjpyZXF1ZXN0TGF5b3V0Rm9yUGFydHMpOgorICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJJbmRpY2F0b3IuaDoKKwogMjAxMC0wOS0wMiAgSWx5YSBT aGVybWFuICA8aXNoZXJtYW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmlj IFNlaWRlbC4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckluZGljYXRvci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5kaWNhdG9yLmNwcAkocmV2aXNp b24gNjY2MzkpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbmRpY2F0b3IuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC02MywxNyArNjMsOSBAQCB2b2lkIFJlbmRlckluZGljYXRvcjo6dXBkYXRl RnJvbUVsZW1lbnQoCiAgICAgcmVwYWludCgpOwogfQogCi1ib29sIFJlbmRlckluZGljYXRvcjo6 aGFzUGFydHMoKSBjb25zdAotewotICAgIGlmIChSZW5kZXJPYmplY3QqIGxhc3QgPSBsYXN0Q2hp bGQoKSkKLSAgICAgICAgcmV0dXJuIGxhc3QtPmlzUmVuZGVyQmxvY2soKTsKLSAgICByZXR1cm4g ZmFsc2U7Ci19Ci0KIHZvaWQgUmVuZGVySW5kaWNhdG9yOjpyZXF1ZXN0TGF5b3V0Rm9yUGFydHMo KQogewotICAgIGlmIChzaG91bGRIYXZlUGFydHMoKSB8fCBoYXNQYXJ0cygpKQotICAgICAgICBz ZXROZWVkc0xheW91dCh0cnVlKTsKKyAgICBzZXROZWVkc0xheW91dCh0cnVlKTsKIH0KIAogfSAv LyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5kaWNh dG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5kaWNhdG9yLmgJ KHJldmlzaW9uIDY2NjM5KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5kaWNhdG9yLmgJ KHdvcmtpbmcgY29weSkKQEAgLTQyLDcgKzQyLDYgQEAgcHJvdGVjdGVkOgogCiBwcml2YXRlOgog ICAgIHZvaWQgcmVxdWVzdExheW91dEZvclBhcnRzKCk7Ci0gICAgYm9vbCBoYXNQYXJ0cygpIGNv bnN0OwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNjY2 NDcpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MyBAQAorMjAxMC0wOS0wMiAgSmFtZXMgS296aWFuc2tpICA8a296QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDcmFzaCByZW5k ZXJpbmcgPG1ldGVyLz4gd2l0aCBwZXJjZW50IHBhZGRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1MDgxCisKKyAgICAgICAgKiBmYXN0L2RvbS9I VE1MTWV0ZXJFbGVtZW50L21ldGVyLXBhZGRpbmctZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2RvbS9IVE1MTWV0ZXJFbGVtZW50L21ldGVyLXBhZGRpbmcuaHRtbDogQWRkZWQu CisKIDIwMTAtMDgtMzEgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvZG9tL0hUTUxNZXRlckVsZW1lbnQvbWV0ZXItcGFkZGluZy1leHBlY3RlZC50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTE1ldGVyRWxlbWVudC9tZXRlci1wYWRk aW5nLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0hU TUxNZXRlckVsZW1lbnQvbWV0ZXItcGFkZGluZy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMyBAQAorVGVzdHMgdGhhdCBwZXJjZW50YWdlIHBhZGRpbmcgb24gYSBtZXRlciBl bGVtZW50IGRvZXNuJ3QgY3Jhc2guCisKK1BBU1MKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9t L0hUTUxNZXRlckVsZW1lbnQvbWV0ZXItcGFkZGluZy5odG1sCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvZG9tL0hUTUxNZXRlckVsZW1lbnQvbWV0ZXItcGFkZGluZy5odG1sCShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTE1ldGVyRWxlbWVudC9tZXRlci1w YWRkaW5nLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTAgQEAKKzxodG1sPgorICA8Ym9k eT4KKyAgICA8cD5UZXN0cyB0aGF0IHBlcmNlbnRhZ2UgcGFkZGluZyBvbiBhIG1ldGVyIGVsZW1l bnQgZG9lc24ndCBjcmFzaC48L3A+CisgICAgPG1ldGVyIHN0eWxlPSJwYWRkaW5nOiAxJTsiPjMw JTwvbWV0ZXI+UEFTUworICAgIDxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAg IDwvc2NyaXB0PgorICA8L2JvZHk+Cis8L2h0bWw+Cg== 66684 2010-09-06 21:29:27 -0700 2010-09-07 01:12:44 -0700 Proposed patch MeterCrash.txt text/plain 4180 koz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Njg1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMDktMDYgIEphbWVzIEtvemlhbnNraSAgPGtvekBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q3Jhc2ggcmVuZGVyaW5nIDxtZXRlci8+IHdpdGggcGVyY2VudCBwYWRkaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTA4MQorCisgICAgICAgIEF2 b2lkcyBhIGNyYXNoIGNhdXNlZCBieSBSZW5kZXJNZXRlciBjaGVja2luZyBpdHMgb3duIGRpbWVu c2lvbnMgdG8KKyAgICAgICAgZGV0ZXJtaW5lIHdoZXRoZXIgaXQgbmVlZHMgbGF5b3V0LiBUaGUg Y3Jhc2ggaXMgYXZvaWRlZCBieSByZW1vdmluZworICAgICAgICB0aGUgY2hlY2sgYW5kIGFsd2F5 cyBjYWxsaW5nIHNldE5lZWRzTGF5b3V0KHRydWUpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9t L0hUTUxNZXRlckVsZW1lbnQvbWV0ZXItcGVyY2VudC1zaXplLmh0bWwKKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJJbmRpY2F0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVySW5k aWNhdG9yOjp1cGRhdGVGcm9tRWxlbWVudCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlcklu ZGljYXRvci5oOgorCiAyMDEwLTA5LTA2ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+ CiAKICAgICAgICAgV2luZG93cyBidWlsZCBmaXgKSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckluZGljYXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklu ZGljYXRvci5oCShyZXZpc2lvbiA2Njg1OSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklu ZGljYXRvci5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNCwxNSArMzQsMTAgQEAKIHByb3RlY3RlZDoK ICAgICB2aXJ0dWFsIHZvaWQgbGF5b3V0KCk7CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUZyb21F bGVtZW50KCk7Ci0gICAgdmlydHVhbCB2b2lkIHN0eWxlRGlkQ2hhbmdlKFN0eWxlRGlmZmVyZW5j ZSwgY29uc3QgUmVuZGVyU3R5bGUqIG9sZFN0eWxlKTsKICAgICB2aXJ0dWFsIGJvb2wgcmVxdWly ZXNGb3JjZWRTdHlsZVJlY2FsY1Byb3BhZ2F0aW9uKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQog CiAgICAgdmlydHVhbCB2b2lkIGxheW91dFBhcnRzKCkgPSAwOwogICAgIHZpcnR1YWwgYm9vbCBz aG91bGRIYXZlUGFydHMoKSBjb25zdCA9IDA7Ci0KLXByaXZhdGU6Ci0gICAgdm9pZCByZXF1ZXN0 TGF5b3V0Rm9yUGFydHMoKTsKLSAgICBib29sIGhhc1BhcnRzKCkgY29uc3Q7CiB9OwogCiB9IC8v IG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbmRpY2F0 b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckluZGljYXRvci5j cHAJKHJldmlzaW9uIDY2ODU5KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5kaWNhdG9y LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTEsMzEgKzUxLDEyIEBACiAgICAgc2V0TmVlZHNMYXlv dXQoZmFsc2UpOwogfQogCi12b2lkIFJlbmRlckluZGljYXRvcjo6c3R5bGVEaWRDaGFuZ2UoU3R5 bGVEaWZmZXJlbmNlIGRpZmYsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdHlsZSkKLXsKLSAgICBS ZW5kZXJCbG9jazo6c3R5bGVEaWRDaGFuZ2UoZGlmZiwgb2xkU3R5bGUpOwotICAgIHJlcXVlc3RM YXlvdXRGb3JQYXJ0cygpOwotfQotCiB2b2lkIFJlbmRlckluZGljYXRvcjo6dXBkYXRlRnJvbUVs ZW1lbnQoKQogewotICAgIHJlcXVlc3RMYXlvdXRGb3JQYXJ0cygpOworICAgIHNldE5lZWRzTGF5 b3V0KHRydWUpOwogICAgIHJlcGFpbnQoKTsKIH0KIAotYm9vbCBSZW5kZXJJbmRpY2F0b3I6Omhh c1BhcnRzKCkgY29uc3QKLXsKLSAgICBpZiAoUmVuZGVyT2JqZWN0KiBsYXN0ID0gbGFzdENoaWxk KCkpCi0gICAgICAgIHJldHVybiBsYXN0LT5pc1JlbmRlckJsb2NrKCk7Ci0gICAgcmV0dXJuIGZh bHNlOwotfQotCi12b2lkIFJlbmRlckluZGljYXRvcjo6cmVxdWVzdExheW91dEZvclBhcnRzKCkK LXsKLSAgICBpZiAoc2hvdWxkSGF2ZVBhcnRzKCkgfHwgaGFzUGFydHMoKSkKLSAgICAgICAgc2V0 TmVlZHNMYXlvdXQodHJ1ZSk7Ci19Ci0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlm CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MTWV0ZXJFbGVtZW50L21ldGVyLXBlcmNl bnQtc2l6ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20v SFRNTE1ldGVyRWxlbWVudC9tZXRlci1wZXJjZW50LXNpemUtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTE1ldGVyRWxlbWVudC9tZXRlci1wZXJj ZW50LXNpemUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMgQEAKK1Rlc3Rz IHRoYXQgcGVyY2VudGFnZSBzaXplcyBvbiBhIG1ldGVyIGVsZW1lbnQgZG9lc24ndCBjcmFzaC4K KworICAgICAgIFBBU1MKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxNZXRlckVsZW1l bnQvbWV0ZXItcGVyY2VudC1zaXplLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFz dC9kb20vSFRNTE1ldGVyRWxlbWVudC9tZXRlci1wZXJjZW50LXNpemUuaHRtbAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxNZXRlckVsZW1lbnQvbWV0ZXItcGVyY2Vu dC1zaXplLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTQgQEAKKzxodG1sPgorICA8Ym9k eT4KKyAgICA8cD5UZXN0cyB0aGF0IHBlcmNlbnRhZ2Ugc2l6ZXMgb24gYSBtZXRlciBlbGVtZW50 IGRvZXNuJ3QgY3Jhc2guPC9wPgorICAgIDxtZXRlciBzdHlsZT0id2lkdGg6IDElOyI+MzAlPC9t ZXRlcj4KKyAgICA8bWV0ZXIgc3R5bGU9ImhlaWdodDogMSU7Ij4zMCU8L21ldGVyPgorICAgIDxt ZXRlciBzdHlsZT0ibWFyZ2luOiAxJTsiPjMwJTwvbWV0ZXI+CisgICAgPG1ldGVyIHN0eWxlPSJw YWRkaW5nOiAxJTsiPjMwJTwvbWV0ZXI+CisgICAgUEFTUworICAgIDxzY3JpcHQ+CisgICAgaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIuZHVtcEFzVGV4dCgpOworICAgIDwvc2NyaXB0PgorICA8L2JvZHk+Cis8L2h0bWw+CkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiA2Njg1OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEwLTA5LTA2ICBKYW1lcyBLb3ppYW5za2kgIDxrb3pA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZHMgdGVzdHMgZm9yIHBlcmNlbnQtYmFzZWQgYXR0cmlidXRlcyBvbiB0aGUgPG1l dGVyPiBlbGVtZW50LgorCisgICAgICAgICogZmFzdC9kb20vSFRNTE1ldGVyRWxlbWVudC9tZXRl ci1wZXJjZW50LXNpemUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9I VE1MTWV0ZXJFbGVtZW50L21ldGVyLXBlcmNlbnQtc2l6ZS5odG1sOiBBZGRlZC4KKwogMjAxMC0w OS0wNiAgSnVzdGluIFNjaHVoICA8anNjaHVoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkLiBCdWlsZCBmaXguCg==