45076 2010-09-01 17:44:51 -0700 Add Panner files 2010-09-03 12:05:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 crogers webkit-unassigned cmarrin dglazkov eric.carlson japhet jer.noble kbr simon.fraser oldest_to_newest 273133 0 crogers 2010-09-01 17:44:51 -0700 Add Panner files 273135 1 66306 crogers 2010-09-01 17:46:11 -0700 Created attachment 66306 Patch 273660 2 66306 kbr 2010-09-02 16:26:00 -0700 Comment on attachment 66306 Patch Basically looks fine; one nit. Feel free to fix before commit if committing with webkit-patch land, or upload a new patch. > Index: WebCore/platform/audio/Panner.h > =================================================================== > --- WebCore/platform/audio/Panner.h (revision 0) > +++ WebCore/platform/audio/Panner.h (revision 0) > @@ -0,0 +1,69 @@ > +/* > + * Copyright (C) 2009 Google Inc. All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * 1. Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * 2. Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in the > + * documentation and/or other materials provided with the distribution. > + * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of > + * its contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY > + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE > + * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY > + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES > + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; > + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND > + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF > + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ > + > +#ifndef Panner_h > +#define Panner_h > + > +#include <wtf/PassOwnPtr.h> > + > +namespace WebCore { > + > +class AudioBus; > + > +// Abstract base class for panning a mono or stereo source. > + > +class Panner { > +public: > + enum { > + PanningModelPassthrough = 0, > + PanningModelEqualPower = 1, > + PanningModelHRTF = 2, > + PanningModelSoundField = 3 > + }; > + > + typedef unsigned PanningModel; Just use "enum PanningModel" and get rid of the typedef. > + > + static PassOwnPtr<Panner> create(PanningModel model, double sampleRate); > + > + virtual ~Panner() { }; > + > + PanningModel panningModel() const { return m_panningModel; } > + > + virtual void pan(double azimuth, double elevation, AudioBus* inputBus, AudioBus* outputBus, size_t framesToProcess) = 0; > + > + virtual void reset() = 0; > + > +protected: > + Panner(PanningModel model) : m_panningModel(model) { } > + > + PanningModel m_panningModel; > +}; > + > +} // namespace WebCore > + > +#endif // Panner_h 273705 3 66306 commit-queue 2010-09-02 18:01:13 -0700 Comment on attachment 66306 Patch Rejecting patch 66306 from commit-queue. crogers@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 274097 4 66306 crogers 2010-09-03 12:05:04 -0700 Comment on attachment 66306 Patch Clearing flags on attachment: 66306 Committed r66753: <http://trac.webkit.org/changeset/66753> 274098 5 crogers 2010-09-03 12:05:09 -0700 All reviewed patches have been landed. Closing bug. 66306 2010-09-01 17:46:11 -0700 2010-09-03 12:05:04 -0700 Patch bug-45076-20100901174610.patch text/plain 6205 crogers SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjYyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDktMDEgIENocmlzIFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgUGFubmVyIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NTA3NgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSBhdWRpbyBBUEkgaXMg bm90IHlldCBpbXBsZW1lbnRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL1Bhbm5lci5j cHA6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6UGFubmVyOjpjcmVhdGUpOgorICAgICAgICAq IHBsYXRmb3JtL2F1ZGlvL1Bhbm5lci5oOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlBhbm5l cjo6flBhbm5lcik6CisgICAgICAgIChXZWJDb3JlOjpQYW5uZXI6OnBhbm5pbmdNb2RlbCk6Cisg ICAgICAgIChXZWJDb3JlOjpQYW5uZXI6OlBhbm5lcik6CisKIDIwMTAtMDktMDEgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBH bGF6a292LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9QYW5uZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vYXVkaW8vUGFubmVyLmNwcAkocmV2aXNpb24gMCkKKysr IFdlYkNvcmUvcGxhdGZvcm0vYXVkaW8vUGFubmVyLmNwcAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSw3MSBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAxMCBHb29nbGUgSW5jLiBBbGwgcmlnaHRz IHJlc2VydmVkLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBi aW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0 dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0Ogor ICoKKyAqIDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhl IGFib3ZlIGNvcHlyaWdodAorICogICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMg YW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqIDIuICBSZWRpc3RyaWJ1dGlvbnMgaW4g YmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgIG5v dGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1l ciBpbiB0aGUKKyAqICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJv dmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICogMy4gIE5laXRoZXIgdGhlIG5hbWUgb2Yg QXBwbGUgQ29tcHV0ZXIsIEluYy4gKCJBcHBsZSIpIG5vciB0aGUgbmFtZXMgb2YKKyAqICAgICBp dHMgY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0 cyBkZXJpdmVkCisgKiAgICAgZnJvbSB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJp b3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQg QlkgQVBQTEUgQU5EIElUUyBDT05UUklCVVRPUlMgIkFTIElTIiBBTkQgQU5ZCisgKiBFWFBSRVNT IE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRI RSBJTVBMSUVECisgKiBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBG T1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCisgKiBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBT SEFMTCBBUFBMRSBPUiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZCisgKiBESVJF Q1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVF TlRJQUwgREFNQUdFUworICogKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJF TUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOworICogTE9TUyBPRiBVU0UsIERB VEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQg QU5ECisgKiBPTiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwg U1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9U SEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GCisgKiBUSElTIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKworI2lmIEVOQUJMRShXRUJfQVVESU8pCisK KyNpbmNsdWRlICJQYW5uZXIuaCIKKworI2luY2x1ZGUgIkVxdWFsUG93ZXJQYW5uZXIuaCIKKyNp bmNsdWRlICJIUlRGUGFubmVyLmgiCisjaW5jbHVkZSAiUGFzc1Rocm91Z2hQYW5uZXIuaCIKKyNp bmNsdWRlIDx3dGYvT3duUHRyLmg+CisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworUGFzc093blB0 cjxQYW5uZXI+IFBhbm5lcjo6Y3JlYXRlKFBhbm5pbmdNb2RlbCBtb2RlbCwgZG91YmxlIHNhbXBs ZVJhdGUpCit7CisgICAgT3duUHRyPFBhbm5lcj4gcGFubmVyOworCisgICAgc3dpdGNoIChtb2Rl bCkgeworICAgIGNhc2UgUGFubmluZ01vZGVsRXF1YWxQb3dlcjoKKyAgICAgICAgcGFubmVyID0g YWRvcHRQdHIobmV3IEVxdWFsUG93ZXJQYW5uZXIoKSk7CisgICAgICAgIGJyZWFrOworCisgICAg Y2FzZSBQYW5uaW5nTW9kZWxIUlRGOgorICAgICAgICBwYW5uZXIgPSBhZG9wdFB0cihuZXcgSFJU RlBhbm5lcihzYW1wbGVSYXRlKSk7CisgICAgICAgIGJyZWFrOworCisgICAgY2FzZSBQYW5uaW5n TW9kZWxQYXNzdGhyb3VnaDoKKyAgICAgICAgcGFubmVyID0gYWRvcHRQdHIobmV3IFBhc3NUaHJv dWdoUGFubmVyKCkpOworICAgICAgICBicmVhazsKKworICAgIC8vIEZJWE1FOiBzb3VuZCBmaWVs ZCBwYW5uaW5nIGlzIG5vdCB5ZXQgaW1wbGVtZW50ZWQuLi4KKyAgICBjYXNlIFBhbm5pbmdNb2Rl bFNvdW5kRmllbGQ6CisgICAgZGVmYXVsdDoKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7 CisgICAgICAgIHJldHVybiAwOworICAgIH0KKworICAgIHJldHVybiBwYW5uZXIucmVsZWFzZSgp OworfQorCit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCisKKyNlbmRpZiAvLyBFTkFCTEUoV0VCX0FV RElPKQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9QYW5uZXIuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1Bhbm5lci5oCShyZXZpc2lvbiAwKQorKysgV2ViQ29y ZS9wbGF0Zm9ybS9hdWRpby9QYW5uZXIuaAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw2OSBAQAor LyoKKyAqIENvcHlyaWdodCAoQykgMjAwOSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICoKKyAqIDEu ICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNv cHlyaWdodAorICogICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBm b2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqIDIuICBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZv cm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgIG5vdGljZSwgdGhp cyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUK KyAqICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0 aCB0aGUgZGlzdHJpYnV0aW9uLgorICogMy4gIE5laXRoZXIgdGhlIG5hbWUgb2YgQXBwbGUgQ29t cHV0ZXIsIEluYy4gKCJBcHBsZSIpIG5vciB0aGUgbmFtZXMgb2YKKyAqICAgICBpdHMgY29udHJp YnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVk CisgKiAgICAgZnJvbSB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRl biBwZXJtaXNzaW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUg QU5EIElUUyBDT05UUklCVVRPUlMgIkFTIElTIiBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElNUExJ RUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRSBJTVBMSUVE CisgKiBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJU SUNVTEFSIFBVUlBPU0UgQVJFCisgKiBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBM RSBPUiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZCisgKiBESVJFQ1QsIElORElS RUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFN QUdFUworICogKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBT VUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOworICogTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBS T0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5ECisgKiBP TiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJ QUJJTElUWSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkg QVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GCisgKiBUSElTIFNPRlRXQVJFLCBF VkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisK KyNpZm5kZWYgUGFubmVyX2gKKyNkZWZpbmUgUGFubmVyX2gKKworI2luY2x1ZGUgPHd0Zi9QYXNz T3duUHRyLmg+CisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworY2xhc3MgQXVkaW9CdXM7CisKKy8v IEFic3RyYWN0IGJhc2UgY2xhc3MgZm9yIHBhbm5pbmcgYSBtb25vIG9yIHN0ZXJlbyBzb3VyY2Uu CisKK2NsYXNzIFBhbm5lciB7CitwdWJsaWM6CisgICAgZW51bSB7CisgICAgICAgIFBhbm5pbmdN b2RlbFBhc3N0aHJvdWdoID0gMCwKKyAgICAgICAgUGFubmluZ01vZGVsRXF1YWxQb3dlciA9IDEs CisgICAgICAgIFBhbm5pbmdNb2RlbEhSVEYgPSAyLAorICAgICAgICBQYW5uaW5nTW9kZWxTb3Vu ZEZpZWxkID0gMworICAgIH07CisgICAgCisgICAgdHlwZWRlZiB1bnNpZ25lZCBQYW5uaW5nTW9k ZWw7CisKKyAgICBzdGF0aWMgUGFzc093blB0cjxQYW5uZXI+IGNyZWF0ZShQYW5uaW5nTW9kZWwg bW9kZWwsIGRvdWJsZSBzYW1wbGVSYXRlKTsKKworICAgIHZpcnR1YWwgflBhbm5lcigpIHsgfTsK KworICAgIFBhbm5pbmdNb2RlbCBwYW5uaW5nTW9kZWwoKSBjb25zdCB7IHJldHVybiBtX3Bhbm5p bmdNb2RlbDsgfQorCisgICAgdmlydHVhbCB2b2lkIHBhbihkb3VibGUgYXppbXV0aCwgZG91Ymxl IGVsZXZhdGlvbiwgQXVkaW9CdXMqIGlucHV0QnVzLCBBdWRpb0J1cyogb3V0cHV0QnVzLCBzaXpl X3QgZnJhbWVzVG9Qcm9jZXNzKSA9IDA7CisKKyAgICB2aXJ0dWFsIHZvaWQgcmVzZXQoKSA9IDA7 CisKK3Byb3RlY3RlZDoKKyAgICBQYW5uZXIoUGFubmluZ01vZGVsIG1vZGVsKSA6IG1fcGFubmlu Z01vZGVsKG1vZGVsKSB7IH0KKworICAgIFBhbm5pbmdNb2RlbCBtX3Bhbm5pbmdNb2RlbDsKK307 CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUKKworI2VuZGlmIC8vIFBhbm5lcl9oCg==