45068 2010-09-01 15:53:45 -0700 REGRESSION(r66431): WebCore::Editor::selectionStartCSSPropertyValue crashes if no background color is specified 2010-09-01 16:19:03 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED P1 Critical --- 1 rniwa rniwa darin eric ojan tony oldest_to_newest 273075 0 rniwa 2010-09-01 15:53:45 -0700 When there is no background color specified in any ancestor, execCommand('backColor') crashes WebKit. This is a regression from r66431 and major blocking bug for Chromium dev release. It affects hotmail.com and should be fixed promptly. http://crbug.com/54155 273086 1 66297 rniwa 2010-09-01 16:06:35 -0700 Created attachment 66297 Patch 273088 2 rniwa 2010-09-01 16:07:28 -0700 Very embarrassing regression. The loop was missing a null check. 273090 3 66297 dglazkov 2010-09-01 16:10:00 -0700 Comment on attachment 66297 Patch ok. 273094 4 rniwa 2010-09-01 16:19:03 -0700 Committed r66624: <http://trac.webkit.org/changeset/66624> 66297 2010-09-01 16:06:35 -0700 2010-09-01 16:10:00 -0700 Patch bug-45068-20100901160633.patch text/plain 4200 rniwa SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjYyMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMDEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVH UkVTU0lPTihyNjY0MzEpOiBXZWJDb3JlOjpFZGl0b3I6OnNlbGVjdGlvblN0YXJ0Q1NTUHJvcGVy dHlWYWx1ZSBjcmFzaGVzIGlmIG5vIGJhY2tncm91bmQgY29sb3IgaXMgc3BlY2lmaWVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTA2OAorCisgICAg ICAgIFRoZSBjcmFzaCB3YXMgY2F1c2VkIGJ5IHRoZSBhc3N1bXB0aW9uIHRoYXQgZXZlcnkgbm9k ZSBoYXMgYW4gYW5jZXN0b3Igd2l0aCBzb21lIGJhY2tncm91bmQgY29sb3IsCisgICAgICAgIHdo aWNoIHdhcyBvYnZpb3VzbHkgZmFsc2UuIEZpeGVkIHRoaXMgYnkgYWRkaW5nIGEgbnVsbCBmb3Ig YW5jZXN0b3IuCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9leGVjQ29tbWFuZC9iYWNrY29sb3It Y3Jhc2guaHRtbAorCisgICAgICAgICogZWRpdGluZy9FZGl0b3IuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RWRpdG9yOjpzZWxlY3Rpb25TdGFydENTU1Byb3BlcnR5VmFsdWUpOgorCiAyMDEwLTA4 LTMxICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHJldmlzaW9uIDY2NjE1KQorKysg V2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk1NiwxMyArOTU2 LDEzIEBAIFN0cmluZyBFZGl0b3I6OnNlbGVjdGlvblN0YXJ0Q1NTUHJvcGVydHkKICAgICBpZiAo cHJvcGVydHlJRCA9PSBDU1NQcm9wZXJ0eUJhY2tncm91bmRDb2xvciAmJiAobV9mcmFtZS0+c2Vs ZWN0aW9uKCktPmlzUmFuZ2UoKSB8fCBoYXNUcmFuc3BhcmVudEJhY2tncm91bmRDb2xvcihzZWxl Y3Rpb25TdHlsZS5nZXQoKSkpKSB7CiAgICAgICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2UobV9mcmFt ZS0+c2VsZWN0aW9uKCktPnRvTm9ybWFsaXplZFJhbmdlKCkpOwogICAgICAgICBFeGNlcHRpb25D b2RlIGVjID0gMDsKLSAgICAgICAgTm9kZSogYW5jZXN0b3IgPSByYW5nZS0+Y29tbW9uQW5jZXN0 b3JDb250YWluZXIoZWMpOwotICAgICAgICBBU1NFUlQoYW5jZXN0b3IpOwotICAgICAgICBkbyB7 CisgICAgICAgIGZvciAoTm9kZSogYW5jZXN0b3IgPSByYW5nZS0+Y29tbW9uQW5jZXN0b3JDb250 YWluZXIoZWMpOyBhbmNlc3RvcjsgYW5jZXN0b3IgPSBhbmNlc3Rvci0+cGFyZW50Tm9kZSgpKSB7 CiAgICAgICAgICAgICBzZWxlY3Rpb25TdHlsZSA9IGNvbXB1dGVkU3R5bGUoYW5jZXN0b3IpOwot ICAgICAgICAgICAgYW5jZXN0b3IgPSBhbmNlc3Rvci0+cGFyZW50Tm9kZSgpOwotICAgICAgICB9 IHdoaWxlIChoYXNUcmFuc3BhcmVudEJhY2tncm91bmRDb2xvcihzZWxlY3Rpb25TdHlsZS5nZXQo KSkpOwotICAgICAgICB2YWx1ZSA9IHNlbGVjdGlvblN0eWxlLT5nZXRQcm9wZXJ0eVZhbHVlKENT U1Byb3BlcnR5QmFja2dyb3VuZENvbG9yKTsKKyAgICAgICAgICAgIGlmICghaGFzVHJhbnNwYXJl bnRCYWNrZ3JvdW5kQ29sb3Ioc2VsZWN0aW9uU3R5bGUuZ2V0KCkpKSB7CisgICAgICAgICAgICAg ICAgdmFsdWUgPSBzZWxlY3Rpb25TdHlsZS0+Z2V0UHJvcGVydHlWYWx1ZShDU1NQcm9wZXJ0eUJh Y2tncm91bmRDb2xvcik7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9Cisg ICAgICAgIH0KICAgICB9CiAKICAgICByZXR1cm4gdmFsdWU7CkluZGV4OiBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2 NjYyMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE2IEBACisyMDEwLTA5LTAxICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04o cjY2NDMxKTogV2ViQ29yZTo6RWRpdG9yOjpzZWxlY3Rpb25TdGFydENTU1Byb3BlcnR5VmFsdWUg Y3Jhc2hlcyBpZiBubyBiYWNrZ3JvdW5kIGNvbG9yIGlzIHNwZWNpZmllZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUwNjgKKworICAgICAgICBBZGRl ZCBhIHRlc3QgdG8gZW5zdXJlIFdlYktpdCBkb2Vzbid0IGNyYXNoIHdoZW4gYmFja0NvbG9yIGlz IHF1ZXJpZWQgb24gYSBub2RlIHdpdGhvdXQgYW55IGFuY2VzdG9ycworICAgICAgICB3aXRoIGEg YmFja2dyb3VuZCBjb2xvci4KKworICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvYmFja2Nv bG9yLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9leGVjQ29t bWFuZC9iYWNrY29sb3ItY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTAtMDgtMzEgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2JhY2tjb2xvci1jcmFz aC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29t bWFuZC9iYWNrY29sb3ItY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9iYWNrY29sb3ItY3Jhc2gtZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMgQEAKK1RoaXMgaXMgYSBjcmFzaCB0ZXN0IHdoZW4gZXhl Y3V0aW5nIGJhY2tDb2xvciBvbiBhIG5vZGUgd2hlcmUgYWxsIG9mIGl0cyBhbmNlc3RvcnMgaGF2 ZSB0cmFuc3BhcmVudCBiYWNrZ3JvdW5kIGNvbG9yLiBZb3Ugc2hvdWxkIHNlZSBQQVNTIGF0IHRo ZSBlbmQuCitiYWNrQ29sb3I6IHJnYmEoMCwgMCwgMCwgMCkKK1BBU1MKSW5kZXg6IExheW91dFRl c3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvYmFja2NvbG9yLWNyYXNoLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9iYWNrY29sb3ItY3Jhc2guaHRtbAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvYmFja2NvbG9y LWNyYXNoLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTYgQEAKKzxodG1sPgorPGJvZHk+ CitUaGlzIGlzIGEgY3Jhc2ggdGVzdCB3aGVuIGV4ZWN1dGluZyBiYWNrQ29sb3Igb24gYSBub2Rl IHdoZXJlIGFsbCBvZiBpdHMgYW5jZXN0b3JzIGhhdmUgdHJhbnNwYXJlbnQgYmFja2dyb3VuZCBj b2xvci4gIFlvdSBzaG91bGQgc2VlIFBBU1MgYXQgdGhlIGVuZC4KKzxkaXYgaWQ9InRlc3QiIGNv bnRlbnRlZGl0YWJsZT48L2Rpdj4KKzxzY3JpcHQ+CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpCisgICAgd2luZG93LmxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsK Kword2luZG93LmdldFNlbGVjdGlvbigpLnNldFBvc2l0aW9uKHRlc3QsIDApOwordmFyIGNvbG9y ID0gZG9jdW1lbnQucXVlcnlDb21tYW5kVmFsdWUoJ2JhY2tDb2xvcicsIGZhbHNlLCBudWxsKTsK KworZG9jdW1lbnQud3JpdGUoJ2JhY2tDb2xvcjogJyArIGNvbG9yICsgJzxicj4nKTsKK2RvY3Vt ZW50LndyaXRlKCdQQVNTJyk7Cis8L3NjcmlwdD4KKzwvaHRtbD4K