45067 2010-09-01 15:48:36 -0700 test failure: inspector/console-format.html 2010-09-01 16:27:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 lilmatt webkit-unassigned barraclough bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 273074 0 lilmatt 2010-09-01 15:48:36 -0700 The test 'inspector/console-format.html' is failing. This is fallout from svn revision 66616. 273077 1 66295 lilmatt 2010-09-01 15:57:52 -0700 Created attachment 66295 Fix failing test Fixes failing test caused by r66616 273078 2 joepeck 2010-09-01 16:00:33 -0700 The diff shows: "Error: Unknown error" => "Error: " Which is what r66616 did as expected. http://trac.webkit.org/changeset/66616/trunk/JavaScriptCore/runtime/ErrorPrototype.cpp Sounds to me like we just need to check in updated results. it also looks like v8 already has the empty error message. So you could check to see if we can remove the chromium platform specific results after reseting the results: LayoutTests/platform/chromium/inspector/console-format-expected.txt 273085 3 66295 joepeck 2010-09-01 16:06:09 -0700 Comment on attachment 66295 Fix failing test Looks good. Thanks! I'll see if this can get landed sooner than the commit queue. 273087 4 barraclough 2010-09-01 16:07:26 -0700 Ooops! apologies for the breakage, thank you for fixing. 273102 5 joepeck 2010-09-01 16:27:58 -0700 Committed r66625 M LayoutTests/inspector/console-format-expected.txt M LayoutTests/ChangeLog r66625 = 2f15e0a53e38f4e30aeaf5ab4bc394f5c9ebca51 http://trac.webkit.org/changeset/66625 66295 2010-09-01 15:57:52 -0700 2010-09-01 16:06:09 -0700 Fix failing test wk45067r0.patch text/plain 1857 lilmatt SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY2NjIxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDktMDEgIE1hdHRoZXcgV2lsbGlzICA8 bGlsbWF0dEBmbG9jay5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4IGZhaWxpbmcgdGVzdDogaW5zcGVjdG9yL2NvbnNvbGUtZm9ybWF0Lmh0 bWwgKHJlZ3Jlc3Npb24gZnJvbSByNjY2MTYpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00NTA2NworCisgICAgICAgICogaW5zcGVjdG9yL2NvbnNvbGUt Zm9ybWF0LWV4cGVjdGVkLnR4dDoKKwogMjAxMC0wOS0wMSAgVG9ueSBDaGFuZyAgPHRvbnlAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHVwZGF0aW5nIGEgY2hyb21pdW0gYmFz ZWxpbmUsIHRoZSBvbmx5IGRpZmZlcmVuY2UgaXMgaW4KSW5kZXg6IExheW91dFRlc3RzL2luc3Bl Y3Rvci9jb25zb2xlLWZvcm1hdC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvaW5zcGVjdG9yL2NvbnNvbGUtZm9ybWF0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNjY2MTYp CisrKyBMYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS1mb3JtYXQtZXhwZWN0ZWQudHh0CSh3 b3JraW5nIGNvcHkpCkBAIC0xMiw4ICsxMiw4IEBAIENPTlNPTEUgTUVTU0FHRTogbGluZSA2MDog dGVzdAogQ09OU09MRSBNRVNTQUdFOiBsaW5lIDYxOiB0ZXN0CiBDT05TT0xFIE1FU1NBR0U6IGxp bmUgNjA6IHRlc3QgbmFtZWQgInRlc3QiCiBDT05TT0xFIE1FU1NBR0U6IGxpbmUgNjE6IHRlc3Qg bmFtZWQgInRlc3QiCi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgNjA6IEVycm9yOiBVbmtub3duIGVy cm9yCi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgNjE6IEVycm9yOiBVbmtub3duIGVycm9yCitDT05T T0xFIE1FU1NBR0U6IGxpbmUgNjA6IEVycm9yOiAKK0NPTlNPTEUgTUVTU0FHRTogbGluZSA2MTog RXJyb3I6IAogQ09OU09MRSBNRVNTQUdFOiBsaW5lIDYwOiBbb2JqZWN0IEhUTUxCb2R5RWxlbWVu dF0KIENPTlNPTEUgTUVTU0FHRTogbGluZSA2MTogW29iamVjdCBIVE1MQm9keUVsZW1lbnRdCiBD T05TT0xFIE1FU1NBR0U6IGxpbmUgNjA6IGZ1bmN0aW9uICgpIHsgcmV0dXJuIDE7IH0KQEAgLTU4 LDkgKzU4LDkgQEAgY29uc29sZS1mb3JtYXQuaHRtbDo2MVsidGVzdCJdCiBjb25zb2xlLWZvcm1h dC5odG1sOjYwdGVzdCBuYW1lZCAidGVzdCIKIGNvbnNvbGUtZm9ybWF0Lmh0bWw6NjFbInRlc3Qg bmFtZWQgInRlc3QiIl0KICJ0ZXN0IG5hbWVkICJ0ZXN0IiIKLWNvbnNvbGUtZm9ybWF0Lmh0bWw6 NjBFcnJvcjogVW5rbm93biBlcnJvcgotY29uc29sZS1mb3JtYXQuaHRtbDo2MVtFcnJvcjogVW5r bm93biBlcnJvcl0KLUVycm9yOiBVbmtub3duIGVycm9yCitjb25zb2xlLWZvcm1hdC5odG1sOjYw RXJyb3I6IAorY29uc29sZS1mb3JtYXQuaHRtbDo2MVtFcnJvcjogXQorRXJyb3I6IAogY29uc29s ZS1mb3JtYXQuaHRtbDo2MDxib2R5IG9ubG9hZD0ib25sb2FkKCkiPuKApjwvYm9keT4KIGNvbnNv bGUtZm9ybWF0Lmh0bWw6NjFbPGJvZHkgb25sb2FkPSJvbmxvYWQoKSI+4oCmPC9ib2R5Pl0KIDxi b2R5IG9ubG9hZD0ib25sb2FkKCkiPuKApjwvYm9keT4K