45063 2010-09-01 14:56:27 -0700 [Chromium] Update test results server to make sure it does not have corrupted data 2010-09-08 15:16:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 victorw victorw ojan oldest_to_newest 273042 0 victorw 2010-09-01 14:56:27 -0700 The results.json file size could be >1M (data store entry limit), so we split it into multiple data store entries in this case. The current test results server may leave the data in corrupted state if data store error happens in the middle of saving multiple entries. To fix this, we should save keys to the new data entries separately and set the data_keys in DataStoreFile only when all data are saved successfully. This avoids the issue that only partial results are saved. 273051 1 66285 victorw 2010-09-01 15:09:15 -0700 Created attachment 66285 Proposed Patch 276077 2 66285 ojan 2010-09-08 14:32:54 -0700 Comment on attachment 66285 Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66285&action=prettypatch > WebKitTools/ChangeLog:11 > + be corrupted if data store error happens in teh middle typo: teh 276106 3 victorw 2010-09-08 15:16:48 -0700 Committed r67024: <http://trac.webkit.org/changeset/67024> 66285 2010-09-01 15:09:15 -0700 2010-09-08 14:32:54 -0700 Proposed Patch data_corrputed.patch text/plain 3426 victorw SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY2NjE5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDktMDEgIFZpY3RvciBXYW5nICA8dmlj dG9yd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0Nocm9taXVtXSBGaXggdGVzdCByZXN1bHRzIHNlcnZlciB0byBtYWtlIHN1 cmUKKyAgICAgICAgaXQgZG9lcyBub3QgaGF2ZSBjb3JydXB0ZWQgZGF0YS4KKworICAgICAgICBy ZXN1bHRzLmpzb24gZmlsZSBzaXplIGNvdWxiZSBiZSA+MU0gYW5kIHdlIHNwbGl0CisgICAgICAg IHRoZSBkYXRhIGludG8gbXVsdGlwbGUgZGF0YSBzdG9yZSBlbnRyaWVzIGluIHRoaXMKKyAgICAg ICAgY2FzZS4gVGhpcyBwYXRjaCBmaXhlcyB0aGUgaXNzdWUgdGhhdCB0aGUgZGF0YSBtYXkKKyAg ICAgICAgYmUgY29ycnVwdGVkIGlmIGRhdGEgc3RvcmUgZXJyb3IgaGFwcGVucyBpbiB0ZWggbWlk ZGxlCisgICAgICAgIG9mIHNhdmluZyBtdWx0aXBsZSBlbnRyaWVzLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTA2MworCisgICAgICAgICogVGVz dFJlc3VsdFNlcnZlci9tb2RlbC9kYXRhc3RvcmVmaWxlLnB5OgorCiAyMDEwLTA5LTAxICBHYWJv ciBSYXBjc2FueWkgIDxyZ2Fib3JAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFudG9uaW8gR29tZXMuCkluZGV4OiBXZWJLaXRUb29scy9UZXN0UmVzdWx0U2VydmVyL21v ZGVsL2RhdGFzdG9yZWZpbGUucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvVGVzdFJlc3Vs dFNlcnZlci9tb2RlbC9kYXRhc3RvcmVmaWxlLnB5CShyZXZpc2lvbiA2NTc1NCkKKysrIFdlYktp dFRvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvbW9kZWwvZGF0YXN0b3JlZmlsZS5weQkod29ya2luZyBj b3B5KQpAQCAtNTgsNiArNTgsOSBAQCBjbGFzcyBEYXRhU3RvcmVGaWxlKGRiLk1vZGVsKToKIAog ICAgIG5hbWUgPSBkYi5TdHJpbmdQcm9wZXJ0eSgpCiAgICAgZGF0YV9rZXlzID0gZGIuTGlzdFBy b3BlcnR5KGRiLktleSkKKyAgICAjIGtleXMgdG8gdGhlIGRhdGEgc3RvcmUgZW50cmllcyB0aGF0 IGNhbiBiZSByZXVzZWQgZm9yIG5ldyBkYXRhLgorICAgICMgSWYgaXQgaXMgZW10cHksIGNyZWF0 ZSBuZXcgRGF0YUVudHJ5LgorICAgIG5ld19kYXRhX2tleXMgPSBkYi5MaXN0UHJvcGVydHkoZGIu S2V5KQogICAgIGRhdGUgPSBkYi5EYXRlVGltZVByb3BlcnR5KGF1dG9fbm93X2FkZD1UcnVlKQog CiAgICAgZGF0YSA9IE5vbmUKQEAgLTgyLDExICs4NSwxOCBAQCBjbGFzcyBEYXRhU3RvcmVGaWxl KGRiLk1vZGVsKToKICAgICAgICAgICAgIHJldHVybiBGYWxzZQogCiAgICAgICAgIHN0YXJ0ID0g MAotICAgICAgICBrZXlzID0gc2VsZi5kYXRhX2tleXMKLSAgICAgICAgc2VsZi5kYXRhX2tleXMg PSBbXQorICAgICAgICAjIFVzZSB0aGUgbmV3X2RhdGFfa2V5cyB0byBzdG9yZSBuZXcgZGF0YS4g SWYgYWxsIG5ldyBkYXRhIGFyZSBzYXZlZAorICAgICAgICAjIHN1Y2Nlc3NmdWxseSwgc3dhcCBu ZXdfZGF0YV9rZXlzIGFuZCBkYXRhX2tleXMgc28gd2UgY2FuIHJldXNlIHRoZQorICAgICAgICAj IGRhdGFfa2V5cyBlbnRyaWVzIGluIG5leHQgcnVuLiBJZiB1bmFibGUgdG8gc2F2ZSBuZXcgZGF0 YSBmb3IgYW55CisgICAgICAgICMgcmVhc29uLCBvbmx5IHRoZSBkYXRhIHBvaW50ZWQgYnkgbmV3 X2RhdGFfa2V5cyBtYXkgYmUgY29ycnVwdGVkLAorICAgICAgICAjIHRoZSBleGlzdGluZyBkYXRh X2tleXMgZGF0YSByZW1haW5zIHVudG91Y2hlZC4gVGhlIGNvcnJ1cHRlZCBkYXRhCisgICAgICAg ICMgaW4gbmV3X2RhdGFfa2V5cyB3aWxsIGJlIG92ZXJ3cml0dGVuIGluIG5leHQgdXBkYXRlLgor ICAgICAgICBrZXlzID0gc2VsZi5uZXdfZGF0YV9rZXlzCisgICAgICAgIHNlbGYubmV3X2RhdGFf a2V5cyA9IFtdCisKICAgICAgICAgd2hpbGUgc3RhcnQgPCBsZW4oZGF0YSk6CiAgICAgICAgICAg ICBpZiBrZXlzOgotICAgICAgICAgICAgICAgIGtleSA9IGtleXMucG9wKDApCisgICAgICAgICAg ICAgICAga2V5ID0ga2V5c1swXQogICAgICAgICAgICAgICAgIGRhdGFfZW50cnkgPSBEYXRhRW50 cnkuZ2V0KGtleSkKICAgICAgICAgICAgICAgICBpZiBub3QgZGF0YV9lbnRyeToKICAgICAgICAg ICAgICAgICAgICAgbG9nZ2luZy53YXJuaW5nKCJGb3VuZCBrZXksIGJ1dCBubyBkYXRhIGVudHJ5 OiAlcyIsIGtleSkKQEAgLTk1LDE2ICsxMDUsMjcgQEAgY2xhc3MgRGF0YVN0b3JlRmlsZShkYi5N b2RlbCk6CiAgICAgICAgICAgICAgICAgZGF0YV9lbnRyeSA9IERhdGFFbnRyeSgpCiAKICAgICAg ICAgICAgIGRhdGFfZW50cnkuZGF0YSA9IGRiLkJsb2IoZGF0YVtzdGFydDogc3RhcnQgKyBNQVhf RU5UUllfTEVOXSkKLSAgICAgICAgICAgIGRhdGFfZW50cnkucHV0KCkKKyAgICAgICAgICAgIHRy eToKKyAgICAgICAgICAgICAgICBkYXRhX2VudHJ5LnB1dCgpCisgICAgICAgICAgICBleGNlcHQg RXhjZXB0aW9uLCBlcnI6CisgICAgICAgICAgICAgICAgbG9nZ2luZy5lcnJvcigiRmFpbGVkIHRv IHNhdmUgZGF0YSBzdG9yZSBlbnRyeTogJXMiLCBlcnIpCisgICAgICAgICAgICAgICAgaWYga2V5 czoKKyAgICAgICAgICAgICAgICAgICAgc2VsZi5kZWxldGVfZGF0YShrZXlzKQorICAgICAgICAg ICAgICAgIHJldHVybiBGYWxzZQogCiAgICAgICAgICAgICBsb2dnaW5nLmluZm8oIkRhdGEgc2F2 ZWQ6ICVzLiIsIGRhdGFfZW50cnkua2V5KCkpCi0gICAgICAgICAgICBzZWxmLmRhdGFfa2V5cy5h cHBlbmQoZGF0YV9lbnRyeS5rZXkoKSkKKyAgICAgICAgICAgIHNlbGYubmV3X2RhdGFfa2V5cy5h cHBlbmQoZGF0YV9lbnRyeS5rZXkoKSkKKyAgICAgICAgICAgIGlmIGtleXM6CisgICAgICAgICAg ICAgICAga2V5cy5wb3AoMCkKIAogICAgICAgICAgICAgc3RhcnQgPSBzdGFydCArIE1BWF9FTlRS WV9MRU4KIAogICAgICAgICBpZiBrZXlzOgogICAgICAgICAgICAgc2VsZi5kZWxldGVfZGF0YShr ZXlzKQogCisgICAgICAgIHRlbXBfa2V5cyA9IHNlbGYuZGF0YV9rZXlzCisgICAgICAgIHNlbGYu ZGF0YV9rZXlzID0gc2VsZi5uZXdfZGF0YV9rZXlzCisgICAgICAgIHNlbGYubmV3X2RhdGFfa2V5 cyA9IHRlbXBfa2V5cwogICAgICAgICBzZWxmLmRhdGEgPSBkYXRhCiAKICAgICAgICAgcmV0dXJu IFRydWUK