45037 2010-09-01 08:14:38 -0700 Web Inspector: webInspector.inspectedWindow.evaluate() should not fail if not passed callback 2010-09-01 12:37:41 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 caseq webkit-unassigned commit-queue loislo pfeldman yurys oldest_to_newest 272806 0 caseq 2010-09-01 08:14:38 -0700 webInspector.inspectedWindow.evaluate() currently throws exception if not passed callback. This was accidently regressed with r66601 272813 1 66214 caseq 2010-09-01 08:24:16 -0700 Created attachment 66214 Patch 272935 2 66214 commit-queue 2010-09-01 12:37:36 -0700 Comment on attachment 66214 Patch Clearing flags on attachment: 66214 Committed r66613: <http://trac.webkit.org/changeset/66613> 272936 3 commit-queue 2010-09-01 12:37:41 -0700 All reviewed patches have been landed. Closing bug. 66214 2010-09-01 08:24:16 -0700 2010-09-01 12:37:36 -0700 Patch bug-45037-20100901192413.patch text/plain 1543 caseq ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjlhM2U1ODI5ZDZlNzRmYmE3NjQzN2MyMjkzYjkyNGEwN2MyYTY2ZC4uY2M0MWNlYmJiZTM0NGQz MGQ5NTkwNWY0YmUyODUyZDcwMDY0MjYzYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNSBAQAogMjAxMC0wOS0wMSAgQW5k cmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHdlYkluc3BlY3Rvci5p bnNwZWN0ZWRXaW5kb3cuZXZhbHVhdGUoKSBzaG91bGQgbm90IGZhaWwgaWYgbm90IHBhc3NlZCBj YWxsYmFjay4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ1MDM3CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvbkFQSS5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5pbmplY3RlZEV4dGVuc2lvbkFQSS5JbnNwZWN0ZWRXaW5k b3cucHJvdG90eXBlLmV2YWx1YXRlKToKKworMjAxMC0wOS0wMSAgQW5kcmV5IEtvc3lha292ICA8 Y2FzZXFAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRz a3kuCiAKICAgICAgICAgV2ViIEluc3BlY3RvciwgRXh0ZW5zaW9uIEFQSTogUGFuZWwub25TZWxl Y3Rpb25DaGFuZ2VkIGV2ZW50IGlzIG5ldmVyIGZpcmVkCmRpZmYgLS1naXQgYS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uQVBJLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0V4dGVuc2lvbkFQSS5qcwppbmRleCBmZDFkZjZlMmI1NDY2YTgyMTY4YjMxOGI3MGUz MTM3NDIwMDU5YzI0Li42NGY1NDgyODZiNTJlMGQyMjUxZWNlZmUzMjkxYjk1NTk0MTZmOTUxIDEw MDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uQVBJLmpzCisr KyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25BUEkuanMKQEAgLTM3MSw3 ICszNzEsNyBAQCBJbnNwZWN0ZWRXaW5kb3cucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAg IHJlc3VsdC52YWx1ZSA9IHJlc3VsdC52YWx1ZSA9PT0gInVuZGVmaW5lZCIgPyB1bmRlZmluZWQg OiBKU09OLnBhcnNlKHJlc3VsdC52YWx1ZSk7CiAgICAgICAgICAgICBjYWxsYmFjayhyZXN1bHQp OwogICAgICAgICB9Ci0gICAgICAgIHJldHVybiBleHRlbnNpb25TZXJ2ZXIuc2VuZFJlcXVlc3Qo eyBjb21tYW5kOiAiZXZhbHVhdGVPbkluc3BlY3RlZFBhZ2UiLCBleHByZXNzaW9uOiBleHByZXNz aW9uIH0sIGNhbGxiYWNrV3JhcHBlcik7CisgICAgICAgIHJldHVybiBleHRlbnNpb25TZXJ2ZXIu c2VuZFJlcXVlc3QoeyBjb21tYW5kOiAiZXZhbHVhdGVPbkluc3BlY3RlZFBhZ2UiLCBleHByZXNz aW9uOiBleHByZXNzaW9uIH0sIGNhbGxiYWNrICYmIGNhbGxiYWNrV3JhcHBlcik7CiAgICAgfQog fQogCg==