45036 2010-09-01 07:48:12 -0700 [v8] bypass caches when query memory usage from post GC and in crash handler. 2010-09-10 08:33:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 antonm antonm abarth commit-queue thakis oldest_to_newest 272799 0 antonm 2010-09-01 07:48:12 -0700 [v8] bypass caches when query memory usage from post GC and in crash handler. 272803 1 66212 antonm 2010-09-01 08:03:22 -0700 Created attachment 66212 Patch 272913 2 66212 abarth 2010-09-01 11:35:04 -0700 Comment on attachment 66212 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66212&action=prettypatch > WebCore/bindings/v8/V8GCController.cpp:400 > -int getMemoryUsageInMB() > +int getMemoryUsageInMB(bool noCache) Instead of using a bool, please use an enum so we can understand what passing "true" means at the callsites. 273396 3 antonm 2010-09-02 08:24:58 -0700 (In reply to comment #2) > (From update of attachment 66212 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=66212&action=prettypatch > > > WebCore/bindings/v8/V8GCController.cpp:400 > > -int getMemoryUsageInMB() > > +int getMemoryUsageInMB(bool noCache) > Instead of using a bool, please use an enum so we can understand what passing "true" means at the callsites. Adam, Chromium's counterpart to this change has been backed out, so, please, let put on hold this review. I'll address your comment and request for another round when I am done with Chromium side. Sorry for troubles. 274107 4 66531 antonm 2010-09-03 12:15:05 -0700 Created attachment 66531 Patch 274109 5 antonm 2010-09-03 12:16:02 -0700 Adam, may you have a look? Now I should really start with extending Chromium's API. 274504 6 66531 abarth 2010-09-05 23:37:56 -0700 Comment on attachment 66531 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66531&action=prettypatch > WebCore/platform/chromium/ChromiumBridge.h:194 > + // Same as above, but always returns actual value, without any caches. > + static int actualMemoryUsageMB(); Much nicer. 274517 7 66531 antonm 2010-09-06 01:06:37 -0700 Comment on attachment 66531 Patch Thanks a lot for review, Adam. 274520 8 66531 commit-queue 2010-09-06 01:31:57 -0700 Comment on attachment 66531 Patch Clearing flags on attachment: 66531 Committed r66818: <http://trac.webkit.org/changeset/66818> 274521 9 commit-queue 2010-09-06 01:32:01 -0700 All reviewed patches have been landed. Closing bug. 275886 10 66906 antonm 2010-09-08 09:35:09 -0700 Created attachment 66906 Patch 275887 11 antonm 2010-09-08 09:36:48 -0700 Reopend as that was two sided patch: 1) introduce API in the bridge; 2) commit implementation of API into Chromium proper; 3) actually use the API. The latest patch corresponds to phase 3. 276562 12 antonm 2010-09-09 10:35:36 -0700 Adam, may you have a look, please? 276721 13 66906 commit-queue 2010-09-09 13:50:13 -0700 Comment on attachment 66906 Patch Clearing flags on attachment: 66906 Committed r67111: <http://trac.webkit.org/changeset/67111> 276722 14 commit-queue 2010-09-09 13:50:17 -0700 All reviewed patches have been landed. Closing bug. 277207 15 antonm 2010-09-10 08:33:53 -0700 Thanks a lot for review, Adam 66212 2010-09-01 08:03:22 -0700 2010-09-03 12:15:00 -0700 Patch bug-45036-20100901190320.patch text/plain 6436 antonm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTQyZjlkYTc4ZWRhZjljM2MyYjFkYzRmMGFhYjFiOWRlNWM0YWRmYi4uMzlhNzQ2OTUzYjU1ZTA4 ODJiZjliZWI4MDk3ZTJkY2FhN2YwNjBjNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wOS0wMSAgQW50 b24gTXVoaW4gIDxhbnRvbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFt2OF0gYnlwYXNzIGNhY2hlcyB3aGVuIHF1ZXJ5IG1l bW9yeSB1c2FnZSBmcm9tIHBvc3QgR0MgYW5kIGluIGNyYXNoIGhhbmRsZXIuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTAzNgorCisgICAgICAgIFRv IGhhdmUgYSBwcmVjaXNlIGVzdGltYXRlIG9mIHdvcmtpbmcgc2V0LCB3ZSBuZWVkIHRoZSBtb3N0 IGZyZXNoIHZhbHVlCisgICAgICAgIChvdGhlcndpc2UgbWVtb3J5IHJlbGVhc2VkIGJ5IEdDIHdv dWxkbid0IGJlIGFjY291bnRlZCBmb3IuKQorICAgICAgICBTaW1pbGFybHksIHdoZW4gcmVwb3J0 aW5nIE9PTSwgd2UgbmVlZCBnaXZlIGFuIGV4YWN0IG1lbW9yeSB1c2FnZS4KKworICAgICAgICAq IGJpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cmVw b3J0RmF0YWxFcnJvckluVjgpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4R0NDb250cm9sbGVyOjpnY0VwaWxvZ3VlKToKKyAg ICAgICAgKFdlYkNvcmU6OlY4R0NDb250cm9sbGVyOjpjaGVja01lbW9yeVVzYWdlKToKKyAgICAg ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9DaHJvbWl1bUJyaWRnZS5oOgorCiAyMDEwLTA5LTAxICBO aWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERpcmsgU2NodWx6ZS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhE T01XaW5kb3dTaGVsbC5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwu Y3BwCmluZGV4IGQ3NDdjNzU1ZWI0MmM2MGJjZTM3ZWY5MzRkMjJjNDc0ZjI1MWMwMmQuLmQ2ZDEy ZjFhMzU3MGQyNzg1MmFkZTljMzE4NTk0NGUxNDcwOTgzNjIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOERPTVdpbmRvd1NoZWxsLmNwcApAQCAtODUsNyArODUsNyBAQCBzdGF0aWMgdm9pZCByZXBv cnRGYXRhbEVycm9ySW5WOChjb25zdCBjaGFyKiBsb2NhdGlvbiwgY29uc3QgY2hhciogbWVzc2Fn ZSkKICAgICAvLyBGSVhNRTogY2xlYW4gdXAgVjhQcm94eSBhbmQgZGlzYWJsZSBKYXZhU2NyaXB0 LgogICAgIGludCBtZW1vcnlVc2FnZU1CID0gLTE7CiAjaWYgUExBVEZPUk0oQ0hST01JVU0pCi0g ICAgbWVtb3J5VXNhZ2VNQiA9IENocm9taXVtQnJpZGdlOjptZW1vcnlVc2FnZU1CKCk7CisgICAg bWVtb3J5VXNhZ2VNQiA9IENocm9taXVtQnJpZGdlOjptZW1vcnlVc2FnZU1CKHRydWUpOwogI2Vu ZGlmCiAgICAgcHJpbnRmKCJWOCBlcnJvcjogJXMgKCVzKS4gIEN1cnJlbnQgbWVtb3J5IHVzYWdl OiAlZCBNQlxuIiwgbWVzc2FnZSwgbG9jYXRpb24sIG1lbW9yeVVzYWdlTUIpOwogICAgIGhhbmRs ZUZhdGFsRXJyb3JJblY4KCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0ND b250cm9sbGVyLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCmlu ZGV4IGMyN2UxZDU4MjFiYzRlNWRmNWFiNmI1MGY0MDJlZDQ3NTBlMmRmODAuLjUwNjllOWE1OGY5 NmQ3MDFmNWNhZWIyMDMwYWVjYzU2YWQwYzZkYjUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0Nv bnRyb2xsZXIuY3BwCkBAIC0zOTcsMTAgKzM5NywxMCBAQCBpbnQgVjhHQ0NvbnRyb2xsZXI6Ondv cmtpbmdTZXRFc3RpbWF0ZU1CID0gMDsKIAogbmFtZXNwYWNlIHsKIAotaW50IGdldE1lbW9yeVVz YWdlSW5NQigpCitpbnQgZ2V0TWVtb3J5VXNhZ2VJbk1CKGJvb2wgbm9DYWNoZSkKIHsKICNpZiBQ TEFURk9STShDSFJPTUlVTSkKLSAgICByZXR1cm4gQ2hyb21pdW1CcmlkZ2U6Om1lbW9yeVVzYWdl TUIoKTsKKyAgICByZXR1cm4gQ2hyb21pdW1CcmlkZ2U6Om1lbW9yeVVzYWdlTUIobm9DYWNoZSk7 CiAjZWxzZQogICAgIHJldHVybiAwOwogI2VuZGlmCkBAIC00MTcsNyArNDE3LDcgQEAgdm9pZCBW OEdDQ29udHJvbGxlcjo6Z2NFcGlsb2d1ZSgpCiAgICAgR0NFcGlsb2d1ZVZpc2l0b3IgZXBpbG9n dWVWaXNpdG9yOwogICAgIHZpc2l0QWN0aXZlRE9NT2JqZWN0c0luQ3VycmVudFRocmVhZCgmZXBp bG9ndWVWaXNpdG9yKTsKIAotICAgIHdvcmtpbmdTZXRFc3RpbWF0ZU1CID0gZ2V0TWVtb3J5VXNh Z2VJbk1CKCk7CisgICAgd29ya2luZ1NldEVzdGltYXRlTUIgPSBnZXRNZW1vcnlVc2FnZUluTUIo dHJ1ZSk7CiAKICNpZm5kZWYgTkRFQlVHCiAgICAgLy8gQ2hlY2sgYWxsIHN1cnZpdmFscyBhcmUg d2Vhay4KQEAgLTQ0MCw3ICs0NDAsNyBAQCB2b2lkIFY4R0NDb250cm9sbGVyOjpjaGVja01lbW9y eVVzYWdlKCkKICAgICBjb25zdCBpbnQgaGlnaFVzYWdlTUIgPSAxMDI0OyAgLy8gSWYgbWVtb3J5 IHVzYWdlIGlzIGFib3ZlIHRoaXMgdGhyZXNob2xkLCBmb3JjZSBHQyBtb3JlIGFnZ3Jlc2l2ZWx5 LgogICAgIGNvbnN0IGludCBoaWdoVXNhZ2VEZWx0YU1CID0gMTI4OyAgLy8gRGVsdGEgb2YgbWVt b3J5IHVzYWdlIGdyb3d0aCAodnMuIGxhc3Qgd29ya2luZ1NldEVzdGltYXRlTUIpIHRvIGZvcmNl IEdDIHdoZW4gbWVtb3J5IHVzYWdlIGlzIGhpZ2guCiAKLSAgICBpbnQgbWVtb3J5VXNhZ2VNQiA9 IGdldE1lbW9yeVVzYWdlSW5NQigpOworICAgIGludCBtZW1vcnlVc2FnZU1CID0gZ2V0TWVtb3J5 VXNhZ2VJbk1CKGZhbHNlKTsKICAgICBpZiAoKG1lbW9yeVVzYWdlTUIgPiBsb3dVc2FnZU1CICYm IG1lbW9yeVVzYWdlTUIgPiAyICogd29ya2luZ1NldEVzdGltYXRlTUIpIHx8IChtZW1vcnlVc2Fn ZU1CID4gaGlnaFVzYWdlTUIgJiYgbWVtb3J5VXNhZ2VNQiA+IHdvcmtpbmdTZXRFc3RpbWF0ZU1C ICsgaGlnaFVzYWdlRGVsdGFNQikpCiAgICAgICAgIHY4OjpWODo6TG93TWVtb3J5Tm90aWZpY2F0 aW9uKCk7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hy b21pdW1CcmlkZ2UuaCBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1CcmlkZ2Uu aAppbmRleCBiYzg2ZGUyYmI5OGEwM2RhM2RhMzk2NTg3NDM1NGE5NWEyYmJhYTBmLi40MGRkZGZj NTdmMjMzYzQzNTI5OGQ1MTVhYjMzYzMzZTRkMTk3NmI3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bs YXRmb3JtL2Nocm9taXVtL0Nocm9taXVtQnJpZGdlLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9j aHJvbWl1bS9DaHJvbWl1bUJyaWRnZS5oCkBAIC0xODgsNyArMTg4LDcgQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogICAgICAgICAvLyBNZW1vcnkgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogICAgICAgICAvLyBSZXR1cm5zIHRoZSBj dXJyZW50IHNwYWNlIGFsbG9jYXRlZCBmb3IgdGhlIHBhZ2VmaWxlLCBpbiBNQi4KICAgICAgICAg Ly8gVGhhdCBpcyBjb21taXR0ZWQgc2l6ZSBmb3IgV2luZG93cyBhbmQgdmlydHVhbCBtZW1vcnkg c2l6ZSBmb3IgUE9TSVgKLSAgICAgICAgc3RhdGljIGludCBtZW1vcnlVc2FnZU1CKCk7CisgICAg ICAgIHN0YXRpYyBpbnQgbWVtb3J5VXNhZ2VNQihib29sIG5vQ2FjaGUpOwogCiAgICAgICAgIC8v IE1pbWVUeXBlIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tCiAgICAgICAgIHN0YXRpYyBib29sIGlzU3VwcG9ydGVkSW1hZ2VNSU1FVHlw ZShjb25zdCBTdHJpbmcmIG1pbWVUeXBlKTsKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDQ4M2QxODE3MDk0ZGIx MTdiZTI3OWFmMzk0MzA1NzYzYTMyNmRiNGIuLjg3ODJhOThiMTdjNjFiMzlhMzQ4MzBlMTQxOGE3 MDYwMjFhZWUyN2EgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIv V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTA5LTAxICBB bnRvbiBNdWhpbiAgPGFudG9ubUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW3Y4XSBieXBhc3MgY2FjaGVzIHdoZW4gcXVlcnkg bWVtb3J5IHVzYWdlIGZyb20gcG9zdCBHQyBhbmQgaW4gY3Jhc2ggaGFuZGxlci4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1MDM2CisKKyAgICAgICAg VG8gaGF2ZSBhIHByZWNpc2UgZXN0aW1hdGUgb2Ygd29ya2luZyBzZXQsIHdlIG5lZWQgdGhlIG1v c3QgZnJlc2ggdmFsdWUKKyAgICAgICAgKG90aGVyd2lzZSBtZW1vcnkgcmVsZWFzZWQgYnkgR0Mg d291bGRuJ3QgYmUgYWNjb3VudGVkIGZvci4pCisgICAgICAgIFNpbWlsYXJseSwgd2hlbiByZXBv cnRpbmcgT09NLCB3ZSBuZWVkIGdpdmUgYW4gZXhhY3QgbWVtb3J5IHVzYWdlLgorCisgICAgICAg ICogcHVibGljL1dlYktpdENsaWVudC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJLaXRDbGllbnQ6 Om1lbW9yeVVzYWdlTUIpOgorICAgICAgICAqIHNyYy9DaHJvbWl1bUJyaWRnZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDaHJvbWl1bUJyaWRnZTo6bWVtb3J5VXNhZ2VNQik6CisKIDIwMTAtMDgt MzEgIERhdmUgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg U2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0Q2xp ZW50LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdENsaWVudC5oCmluZGV4IGUzOWZi MmEyOWNmZTMyNTU0NDRmOGJkYzM1NjdhYzFjODhmZDJlZDUuLjU4MDg2ZjA0NzAwNWVhYWZhMTE0 MzdjYjA3YWFlMzI0MGFjNWM2NDQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViS2l0Q2xpZW50LmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXRDbGllbnQu aApAQCAtMTYxLDcgKzE2MSw3IEBAIHB1YmxpYzoKIAogICAgIC8vIFJldHVybnMgdGhlIGN1cnJl bnQgc3BhY2UgYWxsb2NhdGVkIGZvciB0aGUgcGFnZWZpbGUsIGluIE1CLgogICAgIC8vIFRoYXQg aXMgY29tbWl0dGVkIHNpemUgZm9yIFdpbmRvd3MgYW5kIHZpcnR1YWwgbWVtb3J5IHNpemUgZm9y IFBPU0lYCi0gICAgdmlydHVhbCBzaXplX3QgbWVtb3J5VXNhZ2VNQigpIHsgcmV0dXJuIDA7IH0K KyAgICB2aXJ0dWFsIHNpemVfdCBtZW1vcnlVc2FnZU1CKGJvb2wgbm9DYWNoZSkgeyByZXR1cm4g MDsgfQogCiAKICAgICAvLyBNZXNzYWdlIFBvcnRzIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1 bS9zcmMvQ2hyb21pdW1CcmlkZ2UuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWl1bUJy aWRnZS5jcHAKaW5kZXggOTExZGNmMzlmZDk4OGNmYzBkNjk4Zjg0YjU4ZTE1MmE2ZWUyMjcxYi4u M2Y3MWVhM2UwYWIyMzZmMThmYTZkZmY4ZmZhZWUwOGJlYjgzYjY4OSAxMDA2NDQKLS0tIGEvV2Vi S2l0L2Nocm9taXVtL3NyYy9DaHJvbWl1bUJyaWRnZS5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVt L3NyYy9DaHJvbWl1bUJyaWRnZS5jcHAKQEAgLTgxOCw5ICs4MTgsOSBAQCB2b2lkIENocm9taXVt QnJpZGdlOjpub3RpZnlKU091dE9mTWVtb3J5KEZyYW1lKiBmcmFtZSkKICAgICB3ZWJGcmFtZS0+ Y2xpZW50KCktPmRpZEV4aGF1c3RNZW1vcnlBdmFpbGFibGVGb3JTY3JpcHQod2ViRnJhbWUpOwog fQogCi1pbnQgQ2hyb21pdW1CcmlkZ2U6Om1lbW9yeVVzYWdlTUIoKQoraW50IENocm9taXVtQnJp ZGdlOjptZW1vcnlVc2FnZU1CKGJvb2wgbm9DYWNoZSkKIHsKLSAgICByZXR1cm4gc3RhdGljX2Nh c3Q8aW50Pih3ZWJLaXRDbGllbnQoKS0+bWVtb3J5VXNhZ2VNQigpKTsKKyAgICByZXR1cm4gc3Rh dGljX2Nhc3Q8aW50Pih3ZWJLaXRDbGllbnQoKS0+bWVtb3J5VXNhZ2VNQihub0NhY2hlKSk7CiB9 CiAKIGludCBDaHJvbWl1bUJyaWRnZTo6c2NyZWVuRGVwdGgoV2lkZ2V0KiB3aWRnZXQpCg== 66531 2010-09-03 12:15:05 -0700 2010-09-08 09:35:03 -0700 Patch bug-45036-20100903231503.patch text/plain 3639 antonm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjRhMTlkMGYxNDhhMzgxMTJmY2QzM2YzOGQyOGM0YTQ2NDI1ZTk2Mi4uZjZmNDdmYTMwOTQ1YTUz NDIzMDg0ZDBlZTVjMDA5MGUxNTFhOTFkOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOS0wMyAgQW50 b24gTXVoaW4gIDxhbnRvbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFt2OF0gYnlwYXNzIGNhY2hlcyB3aGVuIHF1ZXJ5IG1l bW9yeSB1c2FnZSBmcm9tIHBvc3QgR0MgYW5kIGluIGNyYXNoIGhhbmRsZXIuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTAzNgorCisgICAgICAgIEFk ZCBDaHJvbWl1bS1zcGVjaWZpYyBBUEkgdG8gcXVlcnkgYWN0dWFsIG1lbW9yeSB1c2FnZSB3aGlj aCBieXBhc3NlcyBhbnkgY2FjaGVzLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vQ2hy b21pdW1CcmlkZ2UuaDoKKwogMjAxMC0wOS0wMyAgQ2hyaXMgUm9nZXJzICA8Y3JvZ2Vyc0Bnb29n bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUnVzc2VsbC4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1CcmlkZ2UuaCBiL1dlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1CcmlkZ2UuaAppbmRleCBiYzg2ZGUyYmI5OGEwM2Rh M2RhMzk2NTg3NDM1NGE5NWEyYmJhYTBmLi44OTQ3OTljYTdhMTQ0MmNkNmMwMjQxZTM1NDE1OWQ5 ZTk5NGY4Mjc0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVt QnJpZGdlLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DaHJvbWl1bUJyaWRnZS5o CkBAIC0xOTAsNiArMTkwLDkgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAvLyBUaGF0 IGlzIGNvbW1pdHRlZCBzaXplIGZvciBXaW5kb3dzIGFuZCB2aXJ0dWFsIG1lbW9yeSBzaXplIGZv ciBQT1NJWAogICAgICAgICBzdGF0aWMgaW50IG1lbW9yeVVzYWdlTUIoKTsKIAorICAgICAgICAv LyBTYW1lIGFzIGFib3ZlLCBidXQgYWx3YXlzIHJldHVybnMgYWN0dWFsIHZhbHVlLCB3aXRob3V0 IGFueSBjYWNoZXMuCisgICAgICAgIHN0YXRpYyBpbnQgYWN0dWFsTWVtb3J5VXNhZ2VNQigpOwor CiAgICAgICAgIC8vIE1pbWVUeXBlIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAgICAgICAgIHN0YXRpYyBib29sIGlzU3VwcG9ydGVk SW1hZ2VNSU1FVHlwZShjb25zdCBTdHJpbmcmIG1pbWVUeXBlKTsKICAgICAgICAgc3RhdGljIGJv b2wgaXNTdXBwb3J0ZWRKYXZhU2NyaXB0TUlNRVR5cGUoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSk7 CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvV2ViS2l0L2Nocm9taXVt L0NoYW5nZUxvZwppbmRleCBjYTE3ZWI5MTQ4MDlmMWMwZWY5OTBlYzE0NGU3MWQ0NTRkMGZiOTI3 Li5kYmNhM2RhYWZkMWU3ZWRlYTI5NTkwZDU2ODg5MTFlZDVjYzE5MmI0IDEwMDY0NAotLS0gYS9X ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOS0wMyAgQW50b24gTXVoaW4gIDxhbnRvbm1AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFt2OF0gYnlwYXNzIGNhY2hlcyB3aGVuIHF1ZXJ5IG1lbW9yeSB1c2FnZSBmcm9tIHBvc3QgR0Mg YW5kIGluIGNyYXNoIGhhbmRsZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NTAzNgorCisgICAgICAgIEFkZCBDaHJvbWl1bS1zcGVjaWZpYyBBUEkg dG8gcXVlcnkgYWN0dWFsIG1lbW9yeSB1c2FnZSB3aGljaCBieXBhc3NlcyBhbnkgY2FjaGVzLgor CisgICAgICAgICogcHVibGljL1dlYktpdENsaWVudC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJL aXRDbGllbnQ6OmFjdHVhbE1lbW9yeVVzYWdlTUIpOgorICAgICAgICAqIHNyYy9DaHJvbWl1bUJy aWRnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWl1bUJyaWRnZTo6YWN0dWFsTWVtb3J5 VXNhZ2VNQik6CisKIDIwMTAtMDktMDMgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCByZW1vdmUgc3ZuOmV4ZWN1dGFibGUgZmxhZyBmcm9tIGlt YWdlcyBhbmQgY3NzIGZpbGVzLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJLaXRDbGllbnQuaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0Q2xpZW50LmgKaW5k ZXggOWMwYjRjMmE1NzlmNGIyNzNiNmMwMTVlZmY5NzYyZTFlZjFiMjRjNy4uMGYyODJlMGEwNGRj NjRlMTk2YmZjNWRlOTg4NGVkMzNiOTE5YTViOSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJLaXRDbGllbnQuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktp dENsaWVudC5oCkBAIC0xNjMsNiArMTYzLDkgQEAgcHVibGljOgogICAgIC8vIFRoYXQgaXMgY29t bWl0dGVkIHNpemUgZm9yIFdpbmRvd3MgYW5kIHZpcnR1YWwgbWVtb3J5IHNpemUgZm9yIFBPU0lY CiAgICAgdmlydHVhbCBzaXplX3QgbWVtb3J5VXNhZ2VNQigpIHsgcmV0dXJuIDA7IH0KIAorICAg IC8vIFNhbWUgYXMgYWJvdmUsIGJ1dCBhbHdheXMgcmV0dXJucyBhY3R1YWwgdmFsdWUsIHdpdGhv dXQgYW55IGNhY2hlcy4KKyAgICB2aXJ0dWFsIHNpemVfdCBhY3R1YWxNZW1vcnlVc2FnZU1CKCkg eyByZXR1cm4gMDsgfQorCiAKICAgICAvLyBNZXNzYWdlIFBvcnRzIC0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIApkaWZmIC0tZ2l0IGEvV2Vi S2l0L2Nocm9taXVtL3NyYy9DaHJvbWl1bUJyaWRnZS5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3Jj L0Nocm9taXVtQnJpZGdlLmNwcAppbmRleCA5MTFkY2YzOWZkOTg4Y2ZjMGQ2OThmODRiNThlMTUy YTZlZTIyNzFiLi4zY2VkN2I4YzkwOWZmMGE0N2Y5NzQ1MjczYjVhNmJhMzk0MTNjNGUyIDEwMDY0 NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9taXVtQnJpZGdlLmNwcAorKysgYi9XZWJL aXQvY2hyb21pdW0vc3JjL0Nocm9taXVtQnJpZGdlLmNwcApAQCAtODIzLDYgKzgyMywxMSBAQCBp bnQgQ2hyb21pdW1CcmlkZ2U6Om1lbW9yeVVzYWdlTUIoKQogICAgIHJldHVybiBzdGF0aWNfY2Fz dDxpbnQ+KHdlYktpdENsaWVudCgpLT5tZW1vcnlVc2FnZU1CKCkpOwogfQogCitpbnQgQ2hyb21p dW1CcmlkZ2U6OmFjdHVhbE1lbW9yeVVzYWdlTUIoKQoreworICAgIHJldHVybiBzdGF0aWNfY2Fz dDxpbnQ+KHdlYktpdENsaWVudCgpLT5hY3R1YWxNZW1vcnlVc2FnZU1CKCkpOworfQorCiBpbnQg Q2hyb21pdW1CcmlkZ2U6OnNjcmVlbkRlcHRoKFdpZGdldCogd2lkZ2V0KQogewogICAgIFdlYldp ZGdldENsaWVudCogY2xpZW50ID0gdG9XZWJXaWRnZXRDbGllbnQod2lkZ2V0KTsK 66906 2010-09-08 09:35:09 -0700 2010-09-09 13:50:12 -0700 Patch bug-45036-20100908203507.patch text/plain 2468 antonm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2QwMGEzNWQ0MWFkNGJhYzI5YjRlYTcwMjBmN2NiMDMyN2Q2YjExNC4uNGU3YjM5ZDYyMjAxMDRh OGY2NjRiNjVmYWEzNWY1OTEyM2I2YWFhYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOS0wOCAgQW50 b24gTXVoaW4gIDxhbnRvbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFt2OF0gYnlwYXNzIGNhY2hlcyB3aGVuIHF1ZXJ5IG1l bW9yeSB1c2FnZSBmcm9tIHBvc3QgR0MgYW5kIGluIGNyYXNoIGhhbmRsZXIuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTAzNgorCisgICAgICAgIFNl Y29uZCBwYXJ0IG9mIHRoZSB3aG9sZSBjaGFuZ2U6IG5vdyB1c2UgQVBJIGludHJvZHVjZWQgaW4K KyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNjY4MTggYW5kIG5vdyBi YWNrZWQgYnkgQ2hyb21pdW0uCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdpbmRvd1No ZWxsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJlcG9ydEZhdGFsRXJyb3JJblY4KToKKyAgICAg ICAgKiBiaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpW OEdDQ29udHJvbGxlcjo6Z2NFcGlsb2d1ZSk6CisKIDIwMTAtMDktMDggIFBoaWxpcHBlIE5vcm1h bmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2Fy bHNvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5j cHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwCmluZGV4IDA3NDhj YjYzMjVkOTkzNjUzYjdjYTM1MzM4ZTdlZmVjODc0N2ZhMzcuLmIwN2Y2ZmNkMDVhMGJjMzY5OWI2 YzE0OWRmNWQzOWQzZmFiNjU1NzkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhE T01XaW5kb3dTaGVsbC5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1No ZWxsLmNwcApAQCAtODUsNyArODUsNyBAQCBzdGF0aWMgdm9pZCByZXBvcnRGYXRhbEVycm9ySW5W OChjb25zdCBjaGFyKiBsb2NhdGlvbiwgY29uc3QgY2hhciogbWVzc2FnZSkKICAgICAvLyBGSVhN RTogY2xlYW4gdXAgVjhQcm94eSBhbmQgZGlzYWJsZSBKYXZhU2NyaXB0LgogICAgIGludCBtZW1v cnlVc2FnZU1CID0gLTE7CiAjaWYgUExBVEZPUk0oQ0hST01JVU0pCi0gICAgbWVtb3J5VXNhZ2VN QiA9IENocm9taXVtQnJpZGdlOjptZW1vcnlVc2FnZU1CKCk7CisgICAgbWVtb3J5VXNhZ2VNQiA9 IENocm9taXVtQnJpZGdlOjphY3R1YWxNZW1vcnlVc2FnZU1CKCk7CiAjZW5kaWYKICAgICBwcmlu dGYoIlY4IGVycm9yOiAlcyAoJXMpLiAgQ3VycmVudCBtZW1vcnkgdXNhZ2U6ICVkIE1CXG4iLCBt ZXNzYWdlLCBsb2NhdGlvbiwgbWVtb3J5VXNhZ2VNQik7CiAgICAgaGFuZGxlRmF0YWxFcnJvcklu VjgoKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3Bw IGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKaW5kZXggYzI3ZTFkNTgy MWJjNGU1ZGY1YWI2YjUwZjQwMmVkNDc1MGUyZGY4MC4uMzZiZWVjZWUyNzBiOTAxNTliZjlhODMx YTVlOWI3MjcyMjFjNzdmMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29u dHJvbGxlci5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAK QEAgLTQwNiw2ICs0MDYsMTUgQEAgaW50IGdldE1lbW9yeVVzYWdlSW5NQigpCiAjZW5kaWYKIH0K IAoraW50IGdldEFjdHVhbE1lbW9yeVVzYWdlSW5NQigpCit7CisjaWYgUExBVEZPUk0oQ0hST01J VU0pCisgICAgcmV0dXJuIENocm9taXVtQnJpZGdlOjphY3R1YWxNZW1vcnlVc2FnZU1CKCk7Cisj ZWxzZQorICAgIHJldHVybiAwOworI2VuZGlmCit9CisKIH0gIC8vIGFub255bW91cyBuYW1lc3Bh Y2UKIAogdm9pZCBWOEdDQ29udHJvbGxlcjo6Z2NFcGlsb2d1ZSgpCkBAIC00MTcsNyArNDI2LDcg QEAgdm9pZCBWOEdDQ29udHJvbGxlcjo6Z2NFcGlsb2d1ZSgpCiAgICAgR0NFcGlsb2d1ZVZpc2l0 b3IgZXBpbG9ndWVWaXNpdG9yOwogICAgIHZpc2l0QWN0aXZlRE9NT2JqZWN0c0luQ3VycmVudFRo cmVhZCgmZXBpbG9ndWVWaXNpdG9yKTsKIAotICAgIHdvcmtpbmdTZXRFc3RpbWF0ZU1CID0gZ2V0 TWVtb3J5VXNhZ2VJbk1CKCk7CisgICAgd29ya2luZ1NldEVzdGltYXRlTUIgPSBnZXRBY3R1YWxN ZW1vcnlVc2FnZUluTUIoKTsKIAogI2lmbmRlZiBOREVCVUcKICAgICAvLyBDaGVjayBhbGwgc3Vy dml2YWxzIGFyZSB3ZWFrLgo=