45014 2010-08-31 18:43:09 -0700 [Qt] Number Pad Enter Key Returns Char Code 0 Instead of 13 2010-09-14 12:03:15 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Normal --- 0 jarred webkit-qt-unassigned ap ariya.hidayat kling laszlo.gombos tonikitoo webkit.review.bot oldest_to_newest 272562 0 jarred 2010-08-31 18:43:09 -0700 There is a missing case statement in the PlatformKeyboardEventQt.cpp file to handle the Enter button on the number pad. Because it is not handled, the char code returned in a javascript event is 0 rather than 13. Attached is an svn diff patch I'd like to submit. Thanks, Jarred 272564 1 66158 jarred 2010-08-31 18:44:35 -0700 Created attachment 66158 Patch that corrects the bug 272931 2 ap 2010-09-01 12:24:56 -0700 Does this affect any test results? If not, can you add a test covering this? 272933 3 jarred 2010-09-01 12:28:24 -0700 (In reply to comment #2) > Does this affect any test results? If not, can you add a test covering this? No test are affected. I will add a test to cover it. I am also adding an appropriate ChangeLog as that was omitted previously. Thanks! 272938 4 66245 jarred 2010-09-01 12:40:13 -0700 Created attachment 66245 Patch + ChangeLog 272941 5 webkit.review.bot 2010-09-01 12:41:21 -0700 Attachment 66245 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 272948 6 66247 jarred 2010-09-01 12:52:26 -0700 Created attachment 66247 Patch + ChangeLog 272966 7 66252 jarred 2010-09-01 13:16:21 -0700 Created attachment 66252 Manual Test (WebCore/manual-tests/qt/numpad-enter-key.html) This is a manual test, not committed as a new file, but that could be placed in WebCore/manual-tests/qt/. It tests the resulting keycode of keypress event and pops an alert when 13 is discovered. Prior to the patch, hitting Enter key on Number Pad did not result in an alert. After the patch it does. Thanks. 272969 8 webkit.review.bot 2010-09-01 13:18:00 -0700 Attachment 66252 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 273108 9 kling 2010-09-01 16:56:18 -0700 First off, I cannot reproduce the problem (WebKit trunk, Qt 4.7, Linux) using the manual test. Is this a platform specific problem? Second, the manual test needs to include instructions on how to use it. Just a textual description in the page body is fine. (What should I press? Should NumLock be on/off? etc.) Also, please avoid the alert() if possible. Third, please squash the patches into one (and make sure the test is included in the ChangeLog entry.) 273173 10 66252 ariya.hidayat 2010-09-01 19:38:19 -0700 Comment on attachment 66252 Manual Test (WebCore/manual-tests/qt/numpad-enter-key.html) Clear the review flag, this needs to be in the same patch as the fix. 273495 11 jarred 2010-09-02 12:16:27 -0700 Thanks Andreas for the info. I checked WebKit trunk, and there is no fix/case statement for the enter key under the "isKeypad" if branch. See http://gitorious.org/webkit/webkit/blobs/master/WebCore/platform/qt/PlatformKeyboardEventQt.cpp If there is no case statement for the return/enter keys, such as is included in my patch, then it is *not* fixed or working...that I can assure you. I have suffered from this issue since 4.6.0, and finally got around to correcting it myself. I didn't find a bug report for this on bugs.webkit.org, so I created it (my first one). However just this morning I did find a bug report on Nokia's site from some time ago: http://bugreports.qt.nokia.com/browse/QTWEBKIT-221 The submitted patch is nearly identical to my patch, only it is missing the Qt::Key_Return case statement. I too am running WebKit trunk, Qt 4.7, and Linux. Num Lock is on, and before I compiled my change in, the normalized keycode that is returned is 0. Afterwards, it is properly 13. Thanks, Jarred 273526 12 tonikitoo 2010-09-02 13:25:22 -0700 LGTM too. Jarred, as said, please make your manual test and the patch in the same patch file, and re-upload. 279058 13 67581 kling 2010-09-14 11:51:38 -0700 Created attachment 67581 Cleaned up patch Same patch including cleaned-up manual test. 279064 14 67581 kling 2010-09-14 12:03:04 -0700 Comment on attachment 67581 Cleaned up patch Clearing flags on attachment: 67581 Committed r67483: <http://trac.webkit.org/changeset/67483> 279065 15 kling 2010-09-14 12:03:15 -0700 All reviewed patches have been landed. Closing bug. 66158 2010-08-31 18:44:35 -0700 2010-09-01 12:39:35 -0700 Patch that corrects the bug QtWebKit_NumberPadEnter.patch text/plain 574 jarred SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50UXQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50UXQu Y3BwCShyZXZpc2lvbiA2NjUwMykKKysrIFdlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXli b2FyZEV2ZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODgsNiArMTg4LDkgQEAKICAgICAg ICAgICAgIHJldHVybiBWS19SSUdIVDsgLy8gKDI3KSBSSUdIVCBBUlJPVyBrZXkKICAgICAgICAg Y2FzZSBRdDo6S2V5X0Rvd246CiAgICAgICAgICAgICByZXR1cm4gVktfRE9XTjsgLy8gKDI4KSBE T1dOIEFSUk9XIGtleQorICAgICAgICBjYXNlIFF0OjpLZXlfRW50ZXI6CisgICAgICAgIGNhc2Ug UXQ6OktleV9SZXR1cm46CisgICAgICAgICAgICByZXR1cm4gVktfUkVUVVJOOyAvLyAoMEQpIFJl dHVybiBrZXkKICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgIHJldHVybiAwOwogICAgICAg ICB9Cg== 66245 2010-09-01 12:40:13 -0700 2010-09-01 12:52:06 -0700 Patch + ChangeLog QtWebKit_NumberPadEnter.patch text/plain 1397 jarred SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjYxMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMDEgIEphcnJlZCBOaWNob2xscyAgPGphcnJlZC5uaWNo b2xsc0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KwlbUXRdIE51bWJlciBQYWQgRW50ZXIgS2V5IFJldHVybnMgQ2hhciBDb2RlIDAgSW5zdGVhZCBv ZiAxMworCWh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTAxNAorCisJ VGhlcmUgaXMgYSBtaXNzaW5nIGNhc2Ugc3RhdGVtZW50IGluIHRoZSBQbGF0Zm9ybUtleWJvYXJk RXZlbnRRdC5jcHAgCisJZmlsZSB0byBoYW5kbGUgdGhlIEVudGVyIGJ1dHRvbiBvbiB0aGUgbnVt YmVyIHBhZC4gIEJlY2F1c2UgaXQgaXMgbm90IAorCWhhbmRsZWQsIHRoZSBjaGFyIGNvZGUgcmV0 dXJuZWQgaW4gYSBqYXZhc2NyaXB0IGV2ZW50IGlzIDAgcmF0aGVyIHRoYW4gCisJMTMuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9xdC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRRdC5jcHA6CisgICAgICAg IChXZWJDb3JlOjp3aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KToKKwogMjAxMC0wOS0wMSAgRGF2 ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVy bnN0ZWluIGFuZCBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRm b3JtS2V5Ym9hcmRFdmVudFF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3F0 L1BsYXRmb3JtS2V5Ym9hcmRFdmVudFF0LmNwcAkocmV2aXNpb24gNjY1MDMpCisrKyBXZWJDb3Jl L3BsYXRmb3JtL3F0L1BsYXRmb3JtS2V5Ym9hcmRFdmVudFF0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTg4LDYgKzE4OCw5IEBACiAgICAgICAgICAgICByZXR1cm4gVktfUklHSFQ7IC8vICgyNykg UklHSFQgQVJST1cga2V5CiAgICAgICAgIGNhc2UgUXQ6OktleV9Eb3duOgogICAgICAgICAgICAg cmV0dXJuIFZLX0RPV047IC8vICgyOCkgRE9XTiBBUlJPVyBrZXkKKyAgICAgICAgY2FzZSBRdDo6 S2V5X0VudGVyOgorICAgICAgICBjYXNlIFF0OjpLZXlfUmV0dXJuOgorICAgICAgICAgICAgcmV0 dXJuIFZLX1JFVFVSTjsgLy8gKDBEKSBSZXR1cm4ga2V5CiAgICAgICAgIGRlZmF1bHQ6CiAgICAg ICAgICAgICByZXR1cm4gMDsKICAgICAgICAgfQo= 66247 2010-09-01 12:52:26 -0700 2010-09-14 11:51:38 -0700 Patch + ChangeLog QtWebKit_NumberPadEnter.patch text/plain 1439 jarred SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjYxMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMDEgIEphcnJlZCBOaWNob2xscyAgPGphcnJlZC5uaWNo b2xsc0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1F0XSBOdW1iZXIgUGFkIEVudGVyIEtleSBSZXR1cm5zIENoYXIgQ29kZSAwIElu c3RlYWQgb2YgMTMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ1MDE0CisKKyAgICAgICAgVGhlcmUgaXMgYSBtaXNzaW5nIGNhc2Ugc3RhdGVtZW50IGlu IHRoZSBQbGF0Zm9ybUtleWJvYXJkRXZlbnRRdC5jcHAgCisgICAgICAgIGZpbGUgdG8gaGFuZGxl IHRoZSBFbnRlciBidXR0b24gb24gdGhlIG51bWJlciBwYWQuICBCZWNhdXNlIGl0IGlzIG5vdCAK KyAgICAgICAgaGFuZGxlZCwgdGhlIGNoYXIgY29kZSByZXR1cm5lZCBpbiBhIGphdmFzY3JpcHQg ZXZlbnQgaXMgMCByYXRoZXIgdGhhbiAKKyAgICAgICAgMTMuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9xdC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjp3aW5k b3dzS2V5Q29kZUZvcktleUV2ZW50KToKKwogMjAxMC0wOS0wMSAgRGF2ZSBIeWF0dCAgPGh5YXR0 QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluIGFuZCBTaW1v biBGcmFzZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtS2V5Ym9hcmRFdmVu dFF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtS2V5Ym9h cmRFdmVudFF0LmNwcAkocmV2aXNpb24gNjY1MDMpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3F0L1Bs YXRmb3JtS2V5Ym9hcmRFdmVudFF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg4LDYgKzE4OCw5 IEBACiAgICAgICAgICAgICByZXR1cm4gVktfUklHSFQ7IC8vICgyNykgUklHSFQgQVJST1cga2V5 CiAgICAgICAgIGNhc2UgUXQ6OktleV9Eb3duOgogICAgICAgICAgICAgcmV0dXJuIFZLX0RPV047 IC8vICgyOCkgRE9XTiBBUlJPVyBrZXkKKyAgICAgICAgY2FzZSBRdDo6S2V5X0VudGVyOgorICAg ICAgICBjYXNlIFF0OjpLZXlfUmV0dXJuOgorICAgICAgICAgICAgcmV0dXJuIFZLX1JFVFVSTjsg Ly8gKDBEKSBSZXR1cm4ga2V5CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICByZXR1cm4g MDsKICAgICAgICAgfQo= 66252 2010-09-01 13:16:21 -0700 2010-09-14 11:51:38 -0700 Manual Test (WebCore/manual-tests/qt/numpad-enter-key.html) numpad-enter-key.html text/html 389 jarred PGh0bWw+CjxoZWFkPgogICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgogICAgICAg IHdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpIHsKICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ3Rlc3QnKS5hZGRFdmVudExpc3RlbmVyKCdrZXlwcmVzcycsIGZ1bmN0aW9uKGUp IHsKICAgICAgICAgICAgICAgIGlmIChlLmtleUNvZGUgPT0gMTMpIHsKICAgICAgICAgICAgICAg ICAgICBhbGVydCgnVGVzdCBwYXNzZWQhJyk7CiAgICAgICAgICAgICAgICB9CiAgICAgICAgICAg IH0sIGZhbHNlKTsKICAgICAgICB9OwogICAgPC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHk+CiAgICA8 aW5wdXQgdHlwZT0idGV4dCIgaWQ9InRlc3QiIC8+CjwvYm9keT4KPC9odG1sPgo= 67581 2010-09-14 11:51:38 -0700 2010-09-14 12:03:04 -0700 Cleaned up patch bug-45014-v2.diff text/plain 2649 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDUwMzYxNy4uNDY2ZjUzMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wOS0xNCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTnVtcGFkIEVudGVyIGtleSByZXR1cm5zIGtleUNv ZGUgMCBpbnN0ZWFkIG9mIDEzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00NTAxNAorCisgICAgICAgIE9yaWdpbmFsIHBhdGNoIGJ5IEphcnJlZCBOaWNo b2xscyA8amFycmVkLm5pY2hvbGxzQGdtYWlsLmNvbT4KKworICAgICAgICBUaGVyZSBpcyBhIG1p c3NpbmcgY2FzZSBzdGF0ZW1lbnQgaW4gdGhlIFBsYXRmb3JtS2V5Ym9hcmRFdmVudFF0LmNwcAor ICAgICAgICBmaWxlIHRvIGhhbmRsZSB0aGUgRW50ZXIgYnV0dG9uIG9uIHRoZSBudW1iZXIgcGFk LiAgQmVjYXVzZSBpdCBpcyBub3QKKyAgICAgICAgaGFuZGxlZCwgdGhlIGtleUNvZGUgcmV0dXJu ZWQgaW4gYSBKYXZhU2NyaXB0IGV2ZW50IGlzIDAgcmF0aGVyIHRoYW4gMTMuCisKKyAgICAgICAg VGVzdDogbWFudWFsLXRlc3RzL3F0L251bXBhZC1lbnRlci1rZXkuaHRtbAorCisgICAgICAgICog bWFudWFsLXRlc3RzL3F0L251bXBhZC1lbnRlci1rZXkuaHRtbDogQWRkZWQuCisgICAgICAgICog cGxhdGZvcm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6d2luZG93c0tleUNvZGVGb3JLZXlFdmVudCk6CisKIDIwMTAtMDktMTQgIEV2YW4gTWFydGlu ICA8ZXZhbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVy LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9tYW51YWwtdGVzdHMvcXQvbnVtcGFkLWVudGVyLWtleS5o dG1sIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMvcXQvbnVtcGFkLWVudGVyLWtleS5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmVhOWI4MDAKLS0tIC9kZXYvbnVsbAorKysg Yi9XZWJDb3JlL21hbnVhbC10ZXN0cy9xdC9udW1wYWQtZW50ZXIta2V5Lmh0bWwKQEAgLTAsMCAr MSwyMiBAQAorPGh0bWw+Cis8aGVhZD4KKyAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlw dCI+CisgICAgICAgIHdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCd0ZXN0JykuYWRkRXZlbnRMaXN0ZW5lcigna2V5cHJlc3Mn LCBmdW5jdGlvbihlKSB7CisgICAgICAgICAgICAgICAgb3V0ID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ291dCcpOworICAgICAgICAgICAgICAgIG91dC5pbm5lckhUTUwgPSAna2V5Q29kZTog JyArIGUua2V5Q29kZSArICcgKHNob3VsZCBiZSAxMyknOworICAgICAgICAgICAgICAgIGlmIChl LmtleUNvZGUgPT0gMTMpCisgICAgICAgICAgICAgICAgICAgIG91dC5zdHlsZS5iYWNrZ3JvdW5k ID0gJyM2ZjYnOworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgb3V0 LnN0eWxlLmJhY2tncm91bmQgPSAnI2Y2Nic7CisgICAgICAgICAgICB9LCBmYWxzZSk7CisgICAg ICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdCcpLmZvY3VzKCkKKyAgICAgICAg fTsKKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorICAgIDxwPlByZXNzIHRoZSBudW1w YWQgRW50ZXIga2V5IHdoaWxlIHRoZSBpbnB1dCBib3ggYmVsb3cgaXMgZm9jdXNlZDo8L3A+Cisg ICAgPHA+PGlucHV0IHR5cGU9InRleHQiIGlkPSJ0ZXN0IiAvPjwvcD4KKyAgICA8cCBpZD0ib3V0 Ij48L3A+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3F0 L1BsYXRmb3JtS2V5Ym9hcmRFdmVudFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZv cm1LZXlib2FyZEV2ZW50UXQuY3BwCmluZGV4IGQwZWRiMTYuLjMzZTk1NTIgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50UXQuY3BwCisrKyBiL1dl YkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50UXQuY3BwCkBAIC0xODgsNiAr MTg4LDkgQEAgaW50IHdpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQodW5zaWduZWQgaW50IGtleWNv ZGUsIGJvb2wgaXNLZXlwYWQpCiAgICAgICAgICAgICByZXR1cm4gVktfUklHSFQ7IC8vICgyNykg UklHSFQgQVJST1cga2V5CiAgICAgICAgIGNhc2UgUXQ6OktleV9Eb3duOgogICAgICAgICAgICAg cmV0dXJuIFZLX0RPV047IC8vICgyOCkgRE9XTiBBUlJPVyBrZXkKKyAgICAgICAgY2FzZSBRdDo6 S2V5X0VudGVyOgorICAgICAgICBjYXNlIFF0OjpLZXlfUmV0dXJuOgorICAgICAgICAgICAgcmV0 dXJuIFZLX1JFVFVSTjsgLy8gKDBEKSBSZXR1cm4ga2V5CiAgICAgICAgIGNhc2UgUXQ6OktleV9J bnNlcnQ6CiAgICAgICAgICAgICByZXR1cm4gVktfSU5TRVJUOyAvLyAoMkQpIElOUyBrZXkKICAg ICAgICAgY2FzZSBRdDo6S2V5X0RlbGV0ZToK