45002 2010-08-31 16:23:52 -0700 [reviewtool] Make it easy to scroll through review comments 2010-08-31 16:31:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth eric oldest_to_newest 272472 0 abarth 2010-08-31 16:23:52 -0700 [reviewtool] Make it easy to scroll through review comments 272475 1 66134 abarth 2010-08-31 16:25:52 -0700 Created attachment 66134 Patch 272483 2 66134 eric 2010-08-31 16:29:58 -0700 Comment on attachment 66134 Patch We *need* testing. :( 272486 3 abarth 2010-08-31 16:31:15 -0700 Committed r66553: <http://trac.webkit.org/changeset/66553> 66134 2010-08-31 16:25:52 -0700 2010-08-31 16:29:58 -0700 Patch bug-45002-20100831162551.patch text/plain 7505 abarth SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY2NTUyKQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMzEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb cmV2aWV3dG9vbF0gTWFrZSBpdCBlYXN5IHRvIHNjcm9sbCB0aHJvdWdoIHJldmlldyBjb21tZW50 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUwMDIK KworICAgICAgICBUaGlzIHBhdGNoIGxldHMgeW91IHNjcm9sbCB0aHJvdWdoIHJldmlldyBjb21t ZW50cyB1c2luZyAibiIgKGZvciBuZXh0KQorICAgICAgICBhbmQgInAiIChmb3IgcHJldmlvdXMp LiAgSXQgYWxzbyBhdHRyaWJ1dGVzIGNvbW1lbnRzIHRvIHRoZWlyIGF1dGhvcnMuCisKKyAgICAg ICAgKiBQcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYjoKKyAgICAgICAgKiBjb2RlLXJldmlldy5q czoKKwogMjAxMC0wOC0zMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogQnVnc1NpdGUvY29kZS1yZXZpZXcu anMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gQnVnc1NpdGUvY29kZS1yZXZpZXcuanMJKHJldmlzaW9uIDY2NTM1 KQorKysgQnVnc1NpdGUvY29kZS1yZXZpZXcuanMJKHdvcmtpbmcgY29weSkKQEAgLTE0LDcgKzE0 LDYgQEAKICAgaWYgKCFhdHRhY2htZW50X2lkKQogICAgIHJldHVybjsKIAotICB2YXIgY3VycmVu dF9jb21tZW50ID0ge30KICAgdmFyIG5leHRfbGluZV9pZCA9IDA7CiAKICAgZnVuY3Rpb24gaWRG b3JMaW5lKG51bWJlcikgewpAQCAtODIsMTUgKzgxLDE2IEBACiAKICAgdmFyIGZpbGVzID0ge30K IAotICBmdW5jdGlvbiBhZGRQcmV2aW91c0NvbW1lbnQobGluZSwgY29tbWVudF90ZXh0KSB7Cisg IGZ1bmN0aW9uIGFkZFByZXZpb3VzQ29tbWVudChsaW5lLCBhdXRob3IsIGNvbW1lbnRfdGV4dCkg ewogICAgIHZhciBjb21tZW50X2Jsb2NrID0gJCgnPGRpdiBkYXRhLWNvbW1lbnQtZm9yPSInICsg bGluZS5hdHRyKCdpZCcpICsgJyIgY2xhc3M9InByZXZpb3VzX2NvbW1lbnQiPjwvZGl2PicpOwot ICAgIGNvbW1lbnRfYmxvY2sudGV4dChjb21tZW50X3RleHQpLnByZXBlbmQoJzxkaXYgY2xhc3M9 InJlcGx5Ij5DbGljayB0byByZXBseTwvZGl2PicpOwotICAgIGNvbW1lbnRfYmxvY2suZWFjaCho b3ZlcmlmeSkuY2xpY2soYWRkQ29tbWVudEZpZWxkKTsKKyAgICB2YXIgYXV0aG9yX2Jsb2NrID0g JCgnPGRpdiBjbGFzcz0iYXV0aG9yIj48L2Rpdj4nKS50ZXh0KGF1dGhvciArICc6Jyk7CisgICAg Y29tbWVudF9ibG9jay50ZXh0KGNvbW1lbnRfdGV4dCkucHJlcGVuZChhdXRob3JfYmxvY2spLmVh Y2goaG92ZXJpZnkpLmNsaWNrKGFkZENvbW1lbnRGaWVsZCk7CiAgICAgaW5zZXJ0Q29tbWVudEZv cihsaW5lLCBjb21tZW50X2Jsb2NrKTsKICAgfQogCiAgIGZ1bmN0aW9uIGRpc3BsYXlQcmV2aW91 c0NvbW1lbnRzKGNvbW1lbnRzKSB7CiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBjb21tZW50cy5s ZW5ndGg7ICsraSkgeworICAgICAgdmFyIGF1dGhvciA9IGNvbW1lbnRzW2ldLmF1dGhvcjsKICAg ICAgIHZhciBmaWxlX25hbWUgPSBjb21tZW50c1tpXS5maWxlX25hbWU7CiAgICAgICB2YXIgbGlu ZV9udW1iZXIgPSBjb21tZW50c1tpXS5saW5lX251bWJlcjsKICAgICAgIHZhciBjb21tZW50X3Rl eHQgPSBjb21tZW50c1tpXS5jb21tZW50X3RleHQ7CkBAIC0xMTAsMTIgKzExMCwxOCBAQAogICAg ICAgICBpZiAoJCh0aGlzKS50ZXh0KCkgIT0gbGluZV9udW1iZXIpCiAgICAgICAgICAgcmV0dXJu OwogICAgICAgICB2YXIgbGluZSA9ICQodGhpcykucGFyZW50KCk7Ci0gICAgICAgIGFkZFByZXZp b3VzQ29tbWVudChsaW5lLCBjb21tZW50X3RleHQpOworICAgICAgICBhZGRQcmV2aW91c0NvbW1l bnQobGluZSwgYXV0aG9yLCBjb21tZW50X3RleHQpOwogICAgICAgfSk7CiAgICAgfQorICAgIGlm IChjb21tZW50cy5sZW5ndGggPT0gMCkKKyAgICAgIHJldHVybjsKKyAgICBkZXNjcmlwdG9yID0g Y29tbWVudHMubGVuZ3RoICsgJyBjb21tZW50JzsKKyAgICBpZiAoY29tbWVudHMubGVuZ3RoID4g MSkKKyAgICAgIGRlc2NyaXB0b3IgKz0gJ3MnOworICAgICQoJyN0b29sYmFyIC5jb21tZW50U3Rh dHVzJykudGV4dCgnVGhpcyBwYXRjaCBoYXMgJyArIGRlc2NyaXB0b3IgKyAnLiAgU2Nyb2xsIHRo cm91Z2ggdGhlbSB3aXRoIHRoZSAibiIgYW5kICJwIiBrZXlzLicpOwogICB9CiAKLSAgZnVuY3Rp b24gc2NhbkZvckNvbW1lbnRzKHRleHQpIHsKKyAgZnVuY3Rpb24gc2NhbkZvckNvbW1lbnRzKGF1 dGhvciwgdGV4dCkgewogICAgIHZhciBjb21tZW50cyA9IFtdCiAgICAgdmFyIGxpbmVzID0gdGV4 dC5zcGxpdCgnXG4nKTsKICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGxpbmVzLmxlbmd0aDsgKytp KSB7CkBAIC0xMzQsOCArMTQwLDEwIEBACiAgICAgICAgIGNvbW1lbnRfbGluZXMucHVzaChsaW5l c1tpXSk7CiAgICAgICAgICsraTsKICAgICAgIH0KKyAgICAgIC0taTsgLy8gRGVjcmVtZW50IGkg YmVjYXVzZSB0aGUgZm9yIGxvb3Agd2lsbCBpbmNyZW1lbnQgaXQgYWdhaW4gaW4gYSBzZWNvbmQu CiAgICAgICB2YXIgY29tbWVudF90ZXh0ID0gY29tbWVudF9saW5lcy5qb2luKCdcbicpOwogICAg ICAgY29tbWVudHMucHVzaCh7CisgICAgICAgICdhdXRob3InOiBhdXRob3IsCiAgICAgICAgICdm aWxlX25hbWUnOiBmaWxlX25hbWUsCiAgICAgICAgICdsaW5lX251bWJlcic6IGxpbmVfbnVtYmVy LAogICAgICAgICAnY29tbWVudF90ZXh0JzogY29tbWVudF90ZXh0CkBAIC0xNTQsNyArMTYyLDcg QEAKICAgICAgICAgICB2YXIgdGV4dCA9ICQodGhpcykuZmluZCgnLmJ6X2NvbW1lbnRfdGV4dCcp LnRleHQoKTsKICAgICAgICAgICB2YXIgY29tbWVudF9tYXJrZXIgPSAnKEZyb20gdXBkYXRlIG9m IGF0dGFjaG1lbnQgJyArIGF0dGFjaG1lbnRfaWQgKyAnIC5kZXRhaWxzLiknOwogICAgICAgICAg IGlmICh0ZXh0Lm1hdGNoKGNvbW1lbnRfbWFya2VyKSkKLSAgICAgICAgICAgICQubWVyZ2UoY29t bWVudHMsIHNjYW5Gb3JDb21tZW50cyh0ZXh0KSk7CisgICAgICAgICAgICAkLm1lcmdlKGNvbW1l bnRzLCBzY2FuRm9yQ29tbWVudHMoYXV0aG9yLCB0ZXh0KSk7CiAgICAgICAgIH0pOwogICAgICAg ICBkaXNwbGF5UHJldmlvdXNDb21tZW50cyhjb21tZW50cyk7CiAgICAgICB9KTsKQEAgLTE3Miwy NCArMTgwLDYyIEBACiAgICQoZG9jdW1lbnQpLnJlYWR5KGZ1bmN0aW9uKCkgewogICAgIGNyYXds RGlmZigpOwogICAgIGZldGNoSGlzdG9yeSgpOwotICAgICQoZG9jdW1lbnQuYm9keSkucHJlcGVu ZCgnPGRpdiBpZD0idG9vbGJhciI+PGRpdiBjbGFzcz0iYWN0aW9ucyI+PGJ1dHRvbiBpZD0icG9z dF9jb21tZW50cyI+UHJlcGFyZSBjb21tZW50czwvYnV0dG9uPjwvZGl2PjxkaXYgY2xhc3M9Imhl bHAiPkRvdWJsZS1jbGljayBhIGxpbmUgdG8gYWRkIGEgY29tbWVudC48L2Rpdj48L2Rpdj4nKTsK KyAgICAkKGRvY3VtZW50LmJvZHkpLnByZXBlbmQoJzxkaXYgaWQ9InRvb2xiYXIiPjxkaXYgY2xh c3M9ImFjdGlvbnMiPjxidXR0b24gaWQ9InBvc3RfY29tbWVudHMiPlByZXBhcmUgY29tbWVudHM8 L2J1dHRvbj48L2Rpdj48c3BhbiBjbGFzcz0iY29tbWVudFN0YXR1cyI+PC9zcGFuPiA8c3BhbiBj bGFzcz0iaGVscCI+RG91YmxlLWNsaWNrIGEgbGluZSB0byBhZGQgYSBjb21tZW50Ljwvc3Bhbj48 L2Rpdj4nKTsKICAgICAkKGRvY3VtZW50LmJvZHkpLnByZXBlbmQoJzxkaXYgaWQ9ImNvbW1lbnRf Zm9ybSIgY2xhc3M9ImluYWN0aXZlIj48ZGl2IGNsYXNzPSJ3aW50ZXIiPjwvZGl2PjxkaXYgY2xh c3M9ImxpZ2h0Ym94Ij48aWZyYW1lIHNyYz0iYXR0YWNobWVudC5jZ2k/aWQ9JyArIGF0dGFjaG1l bnRfaWQgKyAnJmFjdGlvbj1yZXZpZXdmb3JtIj48L2lmcmFtZT48L2Rpdj48L2Rpdj4nKTsKICAg fSk7CiAKLSAgJCgnLmNvbW1lbnQgdGV4dGFyZWEnKS5saXZlKCdrZXlkb3duJywgZnVuY3Rpb24o KSB7Ci0gICAgdmFyIGxpbmVfaWQgPSAkKHRoaXMpLmF0dHIoJ2RhdGEtY29tbWVudC1mb3InKTsK LSAgICBjdXJyZW50X2NvbW1lbnRbbGluZV9pZF0gPSAkKHRoaXMpLnZhbCgpOwotICB9KTsKLQog ICAkKCcuY29tbWVudCAuZGVsZXRlJykubGl2ZSgnY2xpY2snLCBmdW5jdGlvbigpIHsKICAgICB2 YXIgbGluZV9pZCA9ICQodGhpcykucGFyZW50c1VudGlsKCcuY29tbWVudCcpLnBhcmVudCgpLmZp bmQoJ3RleHRhcmVhJykuYXR0cignZGF0YS1jb21tZW50LWZvcicpOwotICAgIGRlbGV0ZSBjdXJy ZW50X2NvbW1lbnRbbGluZV9pZF07CiAgICAgdmFyIGxpbmUgPSAkKCcjJyArIGxpbmVfaWQpCiAg ICAgZmluZENvbW1lbnRCbG9ja0ZvcihsaW5lKS5yZW1vdmUoKTsKICAgICBsaW5lLnJlbW92ZUF0 dHIoJ2RhdGEtaGFzLWNvbW1lbnQnKTsKICAgICB0cmltQ29tbWVudENvbnRleHRUb0JlZm9yZShs aW5lKTsKICAgfSk7CiAKKyAgZnVuY3Rpb24gZm9jdXNPbihjb21tZW50KSB7CisgICAgJCgnLmZv Y3VzZWQnKS5yZW1vdmVDbGFzcygnZm9jdXNlZCcpOworICAgIGlmIChjb21tZW50Lmxlbmd0aCA9 PSAwKQorICAgICAgcmV0dXJuOworICAgICQoZG9jdW1lbnQpLnNjcm9sbFRvcChjb21tZW50LmFk ZENsYXNzKCdmb2N1c2VkJykucG9zaXRpb24oKS50b3AgLSB3aW5kb3cuaW5uZXJIZWlnaHQvMik7 CisgIH0KKworICBmdW5jdGlvbiBmb2N1c05leHRDb21tZW50KCkgeworICAgIHZhciBjb21tZW50 cyA9ICQoJy5wcmV2aW91c19jb21tZW50Jyk7CisgICAgaWYgKGNvbW1lbnRzLmxlbmd0aCA9PSAw KQorICAgICAgcmV0dXJuOworICAgIHZhciBpbmRleCA9IGNvbW1lbnRzLmluZGV4KCQoJy5mb2N1 c2VkJykpOworICAgIC8vIE5vdGljZSB0aGF0IC0xIGdldHMgbWFwcGVkIHRvIDAuCisgICAgZm9j dXNPbigkKGNvbW1lbnRzLmdldChpbmRleCArIDEpKSk7CisgIH0KKworICBmdW5jdGlvbiBmb2N1 c1ByZXZpb3VzQ29tbWVudCgpIHsKKyAgICB2YXIgY29tbWVudHMgPSAkKCcucHJldmlvdXNfY29t bWVudCcpOworICAgIGlmIChjb21tZW50cy5sZW5ndGggPT0gMCkKKyAgICAgIHJldHVybjsKKyAg ICB2YXIgaW5kZXggPSBjb21tZW50cy5pbmRleCgkKCcuZm9jdXNlZCcpKTsKKyAgICBpZiAoaW5k ZXggPT0gLTEpCisgICAgICBpbmRleCA9IGNvbW1lbnRzLmxlbmd0aDsKKyAgICBpZiAoaW5kZXgg PT0gMCkgeworICAgICAgZm9jdXNPbihbXSk7CisgICAgICByZXR1cm47CisgICAgfQorICAgIGZv Y3VzT24oJChjb21tZW50cy5nZXQoaW5kZXggLSAxKSkpOworICB9CisKKyAgdmFyIGtDaGFyQ29k ZUZvck4gPSAnbicuY2hhckNvZGVBdCgwKTsKKyAgdmFyIGtDaGFyQ29kZUZvclAgPSAncCcuY2hh ckNvZGVBdCgwKTsKKworICAkKCdib2R5JykubGl2ZSgna2V5cHJlc3MnLCBmdW5jdGlvbigpIHsK KyAgICAvLyBGSVhNRTogVGhlcmUncyBnb3QgdG8gYmUgYSBiZXR0ZXIgd2F5IHRvIGF2b2lkIHNl ZWluZyB0aGVzZSBrZXlwcmVzcworICAgIC8vIGV2ZW50cy4KKyAgICBpZiAoZXZlbnQudGFyZ2V0 Lm5vZGVOYW1lID09ICdURVhUQVJFQScpCisgICAgICByZXR1cm47CisgICAgaWYgKGV2ZW50LmNo YXJDb2RlID09IGtDaGFyQ29kZUZvck4pCisgICAgICBmb2N1c05leHRDb21tZW50KCk7CisgICAg ZWxzZSBpZiAoZXZlbnQuY2hhckNvZGUgPT0ga0NoYXJDb2RlRm9yUCkKKyAgICAgIGZvY3VzUHJl dmlvdXNDb21tZW50KCk7CisgIH0pOworCiAgIGZ1bmN0aW9uIGNvbnRleHRMaW5lc0ZvcihsaW5l KSB7CiAgICAgdmFyIGNvbnRleHQgPSBbXTsKICAgICB3aGlsZSAobGluZS5oYXNDbGFzcygnY29t bWVudENvbnRleHQnKSkgewpAQCAtMjg5LDYgKzMzNSw4IEBACiAgICAgfSk7CiAgICAgJCgnI2Nv bW1lbnRfZm9ybScpLnJlbW92ZUNsYXNzKCdpbmFjdGl2ZScpOwogICAgIHZhciBjb21tZW50ID0g Y29tbWVudHNfaW5fY29udGV4dC5qb2luKCdcblxuJyk7CisgICAgaWYgKGNvbW1lbnQgIT0gJycp CisgICAgICBjb21tZW50ID0gJ1ZpZXcgaW4gY29udGV4dDogJyArIHdpbmRvdy5sb2NhdGlvbiAr ICdcblxuJyArIGNvbW1lbnQ7CiAgICAgJCgnI2NvbW1lbnRfZm9ybScpLmZpbmQoJ2lmcmFtZScp LmNvbnRlbnRzKCkuZmluZCgnI2NvbW1lbnQnKS52YWwoY29tbWVudCk7CiAgIH0pOwogfSkoKTsK SW5kZXg6IEJ1Z3NTaXRlL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IEJ1Z3NTaXRlL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCShyZXZpc2lvbiA2NjUzNSkKKysr IEJ1Z3NTaXRlL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCSh3b3JraW5nIGNvcHkpCkBAIC0x OTQsNiArMTk0LDE0IEBAIGgxIDpob3ZlciB7CiAgIGJhY2tncm91bmQtY29sb3I6ICNmZmQ7CiB9 CiAKKy5hdXRob3IgeworICBmb250LXN0eWxlOiBpdGFsaWM7Cit9CisKKy5mb2N1c2VkIHsKKyAg Ym9yZGVyOiAxcHggc29saWQgYmx1ZTsKK30KKwogLmNvbW1lbnQgewogICBwb3NpdGlvbjogcmVs YXRpdmU7CiB9CkBAIC0yMDMsMTcgKzIxMSw2IEBAIGgxIDpob3ZlciB7CiAgIGhlaWdodDogNmVt OwogfQogCi0ucmVwbHkgewotICBmb250LWZhbWlseTogc2Fucy1zZXJpZjsKLSAgZmxvYXQ6IHJp Z2h0OwotICBjb2xvcjogIzk5OTsKLSAgZGlzcGxheTogbm9uZTsKLX0KLQotLmhvdCAucmVwbHkg ewotICBkaXNwbGF5OiBibG9jazsKLX0KLQogYm9keSB7CiAgIG1hcmdpbi1ib3R0b206IDQwcHg7 CiB9CkBAIC0yMzIsNiArMjI5LDEwIEBAIGJvZHkgewogICBmbG9hdDogcmlnaHQ7CiB9CiAKKyN0 b29sYmFyIC5jb21tZW50U3RhdHVzIHsKKyAgZm9udC1zdHlsZTppdGFsaWMKK30KKwogLndpbnRl ciB7CiAgIHBvc2l0aW9uOiBmaXhlZDsKICAgei1pbmRleDogNTsKQEAgLTI3Nyw3ICsyNzgsNyBA QCBib2R5IHsKIH0KIDwvc3R5bGU+CiA8c2NyaXB0IHNyYz0iaHR0cHM6Ly9hamF4Lmdvb2dsZWFw aXMuY29tL2FqYXgvbGlicy9qcXVlcnkvMS40LjIvanF1ZXJ5Lm1pbi5qcyI+PC9zY3JpcHQ+IAot PHNjcmlwdCBzcmM9ImNvZGUtcmV2aWV3LmpzP3ZlcnNpb249NCI+PC9zY3JpcHQ+IAorPHNjcmlw dCBzcmM9ImNvZGUtcmV2aWV3LmpzP3ZlcnNpb249NSI+PC9zY3JpcHQ+IAogRU9GCiAKICAgICBk ZWYgc2VsZi5yZXZpc2lvbk9yRGVzY3JpcHRpb24oc3RyaW5nKQo=