44998 2010-08-31 15:14:34 -0700 [GTK] warning: unused variable "queryResult" 2010-09-01 23:50:00 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned commit-queue pnormand oldest_to_newest 272427 0 mrobinson 2010-08-31 15:14:34 -0700 I see this warning on the build bots whenever WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp is built. 272514 1 66143 mrobinson 2010-08-31 17:00:41 -0700 Created attachment 66143 Patch for this issue 272619 2 66143 commit-queue 2010-08-31 21:28:01 -0700 Comment on attachment 66143 Patch for this issue Clearing flags on attachment: 66143 Committed r66573: <http://trac.webkit.org/changeset/66573> 272620 3 commit-queue 2010-08-31 21:28:05 -0700 All reviewed patches have been landed. Closing bug. 272949 4 66248 pnormand 2010-09-01 12:52:51 -0700 Created attachment 66248 second fix proposal 272951 5 pnormand 2010-09-01 12:54:49 -0700 Reopening, with the patch commited the newsegment propagation is likely to fail if WebKitGTK has been built with gstreamer < 0.10.30 272953 6 66248 mrobinson 2010-09-01 12:56:46 -0700 Comment on attachment 66248 second fix proposal LGTM. Thanks for fixing this. 273237 7 pnormand 2010-09-01 23:49:42 -0700 http://trac.webkit.org/changeset/66645 66143 2010-08-31 17:00:41 -0700 2010-08-31 21:28:01 -0700 Patch for this issue bug-44998-20100831170039.patch text/plain 1687 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTIzMjAxOGZmYjM4N2ZhYzUyYTI0OWNkYTFkYjJmMzYxNTA3OTBhOC4uZWIzMzUzYTU1NWZiNTM0 NjZhMmU2NDMyY2UyYzkyMzZiNWI4ODdlMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxMC0wOC0zMSAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gd2FybmluZzogdW51c2VkIHZhcmlh YmxlICJxdWVyeVJlc3VsdCIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQ0OTk4CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIGZ1bmN0aW9uYWxpdHkg aGFzIG5vdCBjaGFuZ2VkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L0dTdHJlYW1lckdXb3JsZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHU3RyZWFtZXJHV29ybGQ6 OmVudGVyRnVsbHNjcmVlbik6IE1vdmUgcXVlcnlSZXN1bHQgd2l0aGluIHRoZSBnc3RyZWFtZXIK KyAgICAgICAgdmVyc2lvbiBndWFyZHMsIHdoZXJlIGl0IGlzIHVzZWQuCisKKzIwMTAtMDgtMzEg IE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCiAgICAgICAgIFJldmll d2VkIGJ5IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4KIAogICAgICAgICBbR1RLXSBTY3JvbGxiYXJU aGVtZUd0ayBzaG91bGQgcmVzcG9uZCB0byB0aGVtZSBjaGFuZ2VzCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJHV29ybGQuY3BwIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyR1dvcmxkLmNwcAppbmRl eCA5NmE2MzliMmIxMjcxOGEwYTgxMGMxYWE3MDk4NGJkODkyYmRjN2FhLi5mMjIyY2RlNmY0M2Yx NWM4ZTM0ZTI1MDM4YzUzN2NmNjM2ZGQ4NTFmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJHV29ybGQuY3BwCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckdXb3JsZC5jcHAKQEAgLTExMywxMCAr MTEzLDEwIEBAIGJvb2wgR1N0cmVhbWVyR1dvcmxkOjplbnRlckZ1bGxzY3JlZW4oKQogICAgIC8v IHRoZSBuZXcgdGVlIGJyYW5jaCBkb3duc3RyZWFtLgogCiAgICAgR3N0UXVlcnkqIHF1ZXJ5ID0g Z3N0X3F1ZXJ5X25ld19zZWdtZW50KEdTVF9GT1JNQVRfVElNRSk7Ci0gICAgZ2Jvb2xlYW4gcXVl cnlSZXN1bHQgPSBnc3RfZWxlbWVudF9xdWVyeShtX3BpcGVsaW5lLCBxdWVyeSk7CiAKICAgICAv LyBTZWUgaHR0cHM6Ly9idWd6aWxsYS5nbm9tZS5vcmcvc2hvd19idWcuY2dpP2lkPTYyMDQ5MC4K ICNpZiBHU1RfQ0hFQ0tfVkVSU0lPTigwLCAxMCwgMzApCisgICAgZ2Jvb2xlYW4gcXVlcnlSZXN1 bHQgPSBnc3RfZWxlbWVudF9xdWVyeShtX3BpcGVsaW5lLCBxdWVyeSk7CiAgICAgaWYgKCFxdWVy eVJlc3VsdCkgewogICAgICAgICBnc3RfcXVlcnlfdW5yZWYocXVlcnkpOwogICAgICAgICBnc3Rf b2JqZWN0X3VucmVmKEdTVF9PQkpFQ1Qoc3JjUGFkKSk7Cg== 66248 2010-09-01 12:52:51 -0700 2010-09-01 23:50:00 -0700 second fix proposal second-fix-proposal.patch text/plain 2117 pnormand RnJvbSA2NGM5NWY2ZWJlYmY0NTAyYTEzYzczOGYxMzJmMjRlYTcxMGFkMjI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDEgU2VwIDIwMTAgMjE6NTA6NDkgKzAyMDAKU3ViamVjdDogW1BBVENIXSBz ZWNvbmQgZml4IHByb3Bvc2FsCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3N0 cmVhbWVyL0dTdHJlYW1lckdXb3JsZC5jcHAgICAgICAgICB8ICAgIDcgKysrKystLQogMiBmaWxl cyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGY1MjI2NC4uM2M2 ZmRlMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOS0wMSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3Jt YW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTm9ib2R5IChPT1BTISkuCisK KyAgICAgICAgW0dUS10gd2FybmluZzogdW51c2VkIHZhcmlhYmxlICJxdWVyeVJlc3VsdCIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0OTk4CisKKyAg ICAgICAgRml4IHRoZSBtaXNiZWhhdmlvciBpbnRyb2R1Y2VkIGluIHI2NjU3My4gVGhlIGdzdF9l bGVtZW50X3F1ZXJ5KCkKKyAgICAgICAgY2FsbCBuZWVkcyB0byBiZSBkb25lIHdoYXRldmVyIHRo ZSBHU3RyZWFtZXIgdmVyc2lvbiB1c2VkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL0dTdHJlYW1lckdXb3JsZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHU3RyZWFt ZXJHV29ybGQ6OmVudGVyRnVsbHNjcmVlbik6CisKIDIwMTAtMDktMDEgIEFuZHJleSBLb3N5YWtv diAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlr aGF0c2t5LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv R1N0cmVhbWVyR1dvcmxkLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L0dTdHJlYW1lckdXb3JsZC5jcHAKaW5kZXggZjIyMmNkZS4uMDE3MTFlNiAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyR1dvcmxkLmNwcAor KysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJHV29ybGQu Y3BwCkBAIC0xMTMsMTUgKzExMywxOCBAQCBib29sIEdTdHJlYW1lckdXb3JsZDo6ZW50ZXJGdWxs c2NyZWVuKCkKICAgICAvLyB0aGUgbmV3IHRlZSBicmFuY2ggZG93bnN0cmVhbS4KIAogICAgIEdz dFF1ZXJ5KiBxdWVyeSA9IGdzdF9xdWVyeV9uZXdfc2VnbWVudChHU1RfRk9STUFUX1RJTUUpOwor ICAgIGdib29sZWFuIHF1ZXJ5UmVzdWx0ID0gZ3N0X2VsZW1lbnRfcXVlcnkobV9waXBlbGluZSwg cXVlcnkpOwogCi0gICAgLy8gU2VlIGh0dHBzOi8vYnVnemlsbGEuZ25vbWUub3JnL3Nob3dfYnVn LmNnaT9pZD02MjA0OTAuCiAjaWYgR1NUX0NIRUNLX1ZFUlNJT04oMCwgMTAsIDMwKQotICAgIGdi b29sZWFuIHF1ZXJ5UmVzdWx0ID0gZ3N0X2VsZW1lbnRfcXVlcnkobV9waXBlbGluZSwgcXVlcnkp OwogICAgIGlmICghcXVlcnlSZXN1bHQpIHsKICAgICAgICAgZ3N0X3F1ZXJ5X3VucmVmKHF1ZXJ5 KTsKICAgICAgICAgZ3N0X29iamVjdF91bnJlZihHU1RfT0JKRUNUKHNyY1BhZCkpOwogICAgICAg ICByZXR1cm4gdHJ1ZTsKICAgICB9CisjZWxzZQorICAgIC8vIEdTdHJlYW1lciA8IDAuMTAuMzAg ZG9lc24ndCBzZXQgdGhlIHF1ZXJ5IHJlc3VsdCBjb3JyZWN0bHkuCisgICAgLy8gU2VlIGh0dHBz Oi8vYnVnemlsbGEuZ25vbWUub3JnL3Nob3dfYnVnLmNnaT9pZD02MjA0OTAuCisgICAgVU5VU0VE X1BBUkFNKHF1ZXJ5UmVzdWx0KTsKICNlbmRpZgogCiAgICAgR3N0Rm9ybWF0IGZvcm1hdDsKLS0g CjEuNi4zLjM=