44987 2010-08-31 14:20:58 -0700 Regression (r63528): HTTP headers not being set correctly for FrameLoadTypeReloadFromOrigin 2010-08-31 16:08:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 japhet japhet fishd oldest_to_newest 272366 0 japhet 2010-08-31 14:20:58 -0700 Currently, the cache policy is being set correctly for subresources when the FrameLoader's load type is FrameLoadTypeReloadFromOrigin, but the additional headers (Cache-Control, Pragma) are not being correctly set. 272367 1 66105 japhet 2010-08-31 14:23:07 -0700 Created attachment 66105 patch 272413 2 66105 darin 2010-08-31 14:58:06 -0700 Comment on attachment 66105 patch Can we add a regression test for this? 272414 3 japhet 2010-08-31 14:59:33 -0700 (In reply to comment #2) > (From update of attachment 66105 [details]) > Can we add a regression test for this? I'm happy to add a test, I just wasn't sure what kind was preferred, since DRT doesn't seem to be able to test this case. Manual test perhaps? 272423 4 66105 fishd 2010-08-31 15:05:58 -0700 Comment on attachment 66105 patch We could probably extend layoutTestController to add a queueReloadFromOrigin method. I think it is fair to create a separate patch for that since it involves new DRT functionality. 272451 5 japhet 2010-08-31 15:52:02 -0700 (In reply to comment #4) > (From update of attachment 66105 [details]) > We could probably extend layoutTestController to add a queueReloadFromOrigin method. > I think it is fair to create a separate patch for that since it involves new DRT > functionality. Filed and assigned to me: https://bugs.webkit.org/show_bug.cgi?id=44999 272460 6 japhet 2010-08-31 16:08:22 -0700 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 66105 [details] [details]) > > We could probably extend layoutTestController to add a queueReloadFromOrigin method. > > I think it is fair to create a separate patch for that since it involves new DRT > > functionality. > > Filed and assigned to me: https://bugs.webkit.org/show_bug.cgi?id=44999 http://trac.webkit.org/changeset/66549 66105 2010-08-31 14:23:07 -0700 2010-08-31 15:05:58 -0700 patch fl.txt text/plain 2522 japhet SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjUzMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDgtMzEgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZWdyZXNzaW9uIGluIHI2MzUyODogQ3VzdG9tIGh0dHAgaGVhZGVycyBmb3IgbG9hZHMgb2YgdHlw ZQorICAgICAgICBGcmFtZUxvYWRUeXBlUmVsb2FkRnJvbU9yaWdpbiBhcmUgbm90IGJlaW5nIGNv cnJlY3RseQorICAgICAgICBwcm9wYWdhdGVkIHRvIHN1YnJlc291cmNlIGxvYWRzLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDk4NworCisgICAg ICAgIE5vIHRlc3RzLCBzaW5jZSBEUlQgZG9lc24ndCBzZWVtIHRvIGhhdmUgYSB3YXkgdG8gdHJp Z2dlciBhCisgICAgICAgIEZyYW1lTG9hZFR5cGVSZWxvYWRGcm9tT3JpZ2luIGxvYWQuCisKKyAg ICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVM b2FkZXI6OmFkZEV4dHJhRmllbGRzVG9SZXF1ZXN0KToKKwogMjAxMC0wOC0zMSAgVG9ueSBDaGFu ZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCBjaHJvbWl1 bSBjb21waWxlLgpJbmRleDogV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24gNjY1MTgpCisr KyBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2NDUs MTcgKzI2NDUsMTkgQEAKICAgICAgICAgICAgIHJlcXVlc3Quc2V0Q2FjaGVQb2xpY3koZG9jdW1l bnRMb2FkZXIoKS0+b3JpZ2luYWxSZXF1ZXN0KCkuY2FjaGVQb2xpY3koKSk7CiAgICAgICAgIGVs c2UKICAgICAgICAgICAgIHJlcXVlc3Quc2V0Q2FjaGVQb2xpY3koVXNlUHJvdG9jb2xDYWNoZVBv bGljeSk7Ci0gICAgfSBlbHNlIGlmIChsb2FkVHlwZSA9PSBGcmFtZUxvYWRUeXBlUmVsb2FkKSB7 CisgICAgfSBlbHNlIGlmIChsb2FkVHlwZSA9PSBGcmFtZUxvYWRUeXBlUmVsb2FkIHx8IGxvYWRU eXBlID09IEZyYW1lTG9hZFR5cGVSZWxvYWRGcm9tT3JpZ2luIHx8IHJlcXVlc3QuaXNDb25kaXRp b25hbCgpKQogICAgICAgICByZXF1ZXN0LnNldENhY2hlUG9saWN5KFJlbG9hZElnbm9yaW5nQ2Fj aGVEYXRhKTsKLSAgICAgICAgcmVxdWVzdC5zZXRIVFRQSGVhZGVyRmllbGQoIkNhY2hlLUNvbnRy b2wiLCAibWF4LWFnZT0wIik7Ci0gICAgfSBlbHNlIGlmIChsb2FkVHlwZSA9PSBGcmFtZUxvYWRU eXBlUmVsb2FkRnJvbU9yaWdpbikgewotICAgICAgICByZXF1ZXN0LnNldENhY2hlUG9saWN5KFJl bG9hZElnbm9yaW5nQ2FjaGVEYXRhKTsKLSAgICAgICAgcmVxdWVzdC5zZXRIVFRQSGVhZGVyRmll bGQoIkNhY2hlLUNvbnRyb2wiLCAibm8tY2FjaGUiKTsKLSAgICAgICAgcmVxdWVzdC5zZXRIVFRQ SGVhZGVyRmllbGQoIlByYWdtYSIsICJuby1jYWNoZSIpOwotICAgIH0gZWxzZSBpZiAocmVxdWVz dC5pc0NvbmRpdGlvbmFsKCkpCi0gICAgICAgIHJlcXVlc3Quc2V0Q2FjaGVQb2xpY3koUmVsb2Fk SWdub3JpbmdDYWNoZURhdGEpOwogICAgIGVsc2UgaWYgKGlzQmFja0ZvcndhcmRMb2FkVHlwZShs b2FkVHlwZSkgJiYgbV9zdGF0ZU1hY2hpbmUuY29tbWl0dGVkRmlyc3RSZWFsRG9jdW1lbnRMb2Fk KCkgJiYgIXJlcXVlc3QudXJsKCkucHJvdG9jb2xJcygiaHR0cHMiKSkKICAgICAgICAgcmVxdWVz dC5zZXRDYWNoZVBvbGljeShSZXR1cm5DYWNoZURhdGFFbHNlTG9hZCk7CisgICAgICAgIAorICAg IGlmIChyZXF1ZXN0LmNhY2hlUG9saWN5KCkgPT0gUmVsb2FkSWdub3JpbmdDYWNoZURhdGEpIHsK KyAgICAgICAgaWYgKGxvYWRUeXBlID09IEZyYW1lTG9hZFR5cGVSZWxvYWQpCisgICAgICAgICAg ICByZXF1ZXN0LnNldEhUVFBIZWFkZXJGaWVsZCgiQ2FjaGUtQ29udHJvbCIsICJtYXgtYWdlPTAi KTsKKyAgICAgICAgZWxzZSBpZiAobG9hZFR5cGUgPT0gRnJhbWVMb2FkVHlwZVJlbG9hZEZyb21P cmlnaW4pIHsKKyAgICAgICAgICAgIHJlcXVlc3Quc2V0SFRUUEhlYWRlckZpZWxkKCJDYWNoZS1D b250cm9sIiwgIm5vLWNhY2hlIik7CisgICAgICAgICAgICByZXF1ZXN0LnNldEhUVFBIZWFkZXJG aWVsZCgiUHJhZ21hIiwgIm5vLWNhY2hlIik7CisgICAgICAgIH0KKyAgICB9CiAgICAgCiAgICAg aWYgKG1haW5SZXNvdXJjZSkKICAgICAgICAgcmVxdWVzdC5zZXRIVFRQQWNjZXB0KGRlZmF1bHRB Y2NlcHRIZWFkZXIpOwo=