44982 2010-08-31 13:57:58 -0700 ews: Add support for EFL-EWS 2010-09-01 04:59:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 leandro leandro abarth commit-queue eric webkit.review.bot oldest_to_newest 272344 0 leandro 2010-08-31 13:57:58 -0700 ews: Add support for EFL-EWS 272353 1 66100 leandro 2010-08-31 14:03:40 -0700 Created attachment 66100 Patch 272490 2 66100 abarth 2010-08-31 16:40:11 -0700 Comment on attachment 66100 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66100&action=prettypatch > WebKitTools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:114 > +class EflEWS(AbstractEarlyWarningSystem): > + name = "efl-ews" > + port_name = "efl" Does the EFL port run on more than one platform? If so, you might want to consider a name like efl-win-ews. Once you pick a name, you're stuck with it. :) 272551 3 66100 commit-queue 2010-08-31 18:16:51 -0700 Comment on attachment 66100 Patch Clearing flags on attachment: 66100 Committed r66564: <http://trac.webkit.org/changeset/66564> 272552 4 commit-queue 2010-08-31 18:16:55 -0700 All reviewed patches have been landed. Closing bug. 272568 5 webkit.review.bot 2010-08-31 18:55:45 -0700 http://trac.webkit.org/changeset/66564 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/66561 http://trac.webkit.org/changeset/66562 http://trac.webkit.org/changeset/66563 http://trac.webkit.org/changeset/66564 272749 6 leandro 2010-09-01 04:58:02 -0700 (In reply to comment #5) > http://trac.webkit.org/changeset/66564 might have broken GTK Linux 64-bit Debug > The following changes are on the blame list: > http://trac.webkit.org/changeset/66561 > http://trac.webkit.org/changeset/66562 > http://trac.webkit.org/changeset/66563 > http://trac.webkit.org/changeset/66564 Looks like a false alarm. 272751 7 leandro 2010-09-01 04:59:18 -0700 (In reply to comment #2) > Does the EFL port run on more than one platform? If so, you might want to consider a name like > efl-win-ews. Once you pick a name, you're stuck with it. :) Currently, only Linux is supported. EFL itself is portable, but I don't know if there are short-term plans to support other platforms. 66100 2010-08-31 14:03:40 -0700 2010-08-31 18:16:51 -0700 Patch bug-44982-20100831180905.patch text/plain 3678 leandro SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY2NTI4KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDgtMzEgIExlYW5kcm8gUGVyZWlyYSAg PGxlYW5kcm9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgZXdzOiBBZGQgc3VwcG9ydCBmb3IgRUZMLUVXUworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ5ODIKKworICAgICAgICAq IFF1ZXVlU3RhdHVzU2VydmVyL21vZGVsL3F1ZXVlcy5weTogQWRkICJlZmwtZXdzIiB0byBxdWV1 ZXMgbGlzdC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHMu cHk6IERlZmluZSBhIEVmbFBvcnQgY2xhc3MKKyAgICAgICAgYW5kIGFkZCBpdCB0byB0aGUgcG9y dHMgZGljdC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3 YXJuaW5nc3lzdGVtLnB5OiBEZWZpbmUgYQorICAgICAgICBFZmxFV1MgY2xhc3MuCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0 dGVzdC5weTogQWRkCisgICAgICAgIGEgdGVzdCBjYXNlIGZvciB0aGUgRUZMIEVXUy4KKwogMjAx MC0wOC0zMSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFdlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL21v ZGVsL3F1ZXVlcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9RdWV1ZVN0YXR1c1NlcnZl ci9tb2RlbC9xdWV1ZXMucHkJKHJldmlzaW9uIDY2NTI2KQorKysgV2ViS2l0VG9vbHMvUXVldWVT dGF0dXNTZXJ2ZXIvbW9kZWwvcXVldWVzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zNyw2ICszNyw3 IEBAIHF1ZXVlcyA9IFsKICAgICAiZ3RrLWV3cyIsCiAgICAgIm1hYy1ld3MiLAogICAgICJ3aW4t ZXdzIiwKKyAgICAiZWZsLWV3cyIsCiBdCiAKIApJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9jb21tb24vY29uZmlnL3BvcnRzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5weQkocmV2aXNpb24gNjY1MjYp CisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHMucHkJ KHdvcmtpbmcgY29weSkKQEAgLTQ5LDYgKzQ5LDcgQEAgY2xhc3MgV2ViS2l0UG9ydChvYmplY3Qp OgogICAgICAgICAgICAgIm1hYyI6IE1hY1BvcnQsCiAgICAgICAgICAgICAid2luIjogV2luUG9y dCwKICAgICAgICAgICAgICJxdCI6IFF0UG9ydCwKKyAgICAgICAgICAgICJlZmwiOiBFZmxQb3J0 LAogICAgICAgICB9CiAgICAgICAgIGRlZmF1bHRfcG9ydCA9IHsKICAgICAgICAgICAgICJXaW5k b3dzIjogV2luUG9ydCwKQEAgLTE3Niw2ICsxNzcsMjQgQEAgY2xhc3MgUXRQb3J0KFdlYktpdFBv cnQpOgogICAgICAgICBjb21tYW5kLmFwcGVuZChXZWJLaXRQb3J0Lm1ha2VBcmdzKCkpCiAgICAg ICAgIHJldHVybiBjb21tYW5kCiAKKworY2xhc3MgRWZsUG9ydChXZWJLaXRQb3J0KToKKworICAg IEBjbGFzc21ldGhvZAorICAgIGRlZiBuYW1lKGNscyk6CisgICAgICAgIHJldHVybiAiRWZsIgor CisgICAgQGNsYXNzbWV0aG9kCisgICAgZGVmIGZsYWcoY2xzKToKKyAgICAgICAgcmV0dXJuICIt LXBvcnQ9ZWZsIgorCisgICAgQGNsYXNzbWV0aG9kCisgICAgZGVmIGJ1aWxkX3dlYmtpdF9jb21t YW5kKGNscywgYnVpbGRfc3R5bGU9Tm9uZSk6CisgICAgICAgIGNvbW1hbmQgPSBXZWJLaXRQb3J0 LmJ1aWxkX3dlYmtpdF9jb21tYW5kKGJ1aWxkX3N0eWxlPWJ1aWxkX3N0eWxlKQorICAgICAgICBj b21tYW5kLmFwcGVuZCgiLS1lZmwiKQorICAgICAgICBjb21tYW5kLmFwcGVuZChXZWJLaXRQb3J0 Lm1ha2VBcmdzKCkpCisgICAgICAgIHJldHVybiBjb21tYW5kCisKIAogY2xhc3MgQ2hyb21pdW1Q b3J0KFdlYktpdFBvcnQpOgogCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkJ KHJldmlzaW9uIDY2NTI2KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Nv bW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQkod29ya2luZyBjb3B5KQpAQCAtMTA5LDYgKzEw OSwxNiBAQCBjbGFzcyBHdGtFV1MoQWJzdHJhY3RFYXJseVdhcm5pbmdTeXN0ZW0pCiAgICAgXQog CiAKK2NsYXNzIEVmbEVXUyhBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbSk6CisgICAgbmFtZSA9 ICJlZmwtZXdzIgorICAgIHBvcnRfbmFtZSA9ICJlZmwiCisgICAgd2F0Y2hlcnMgPSBBYnN0cmFj dEVhcmx5V2FybmluZ1N5c3RlbS53YXRjaGVycyArIFsKKyAgICAgICAgImxlYW5kcm9AcHJvZnVz aW9uLm1vYmkiLAorICAgICAgICAiYW50b2dub2xsaUBwcm9mdXNpb24ubW9iaSIsCisgICAgICAg ICJsdWNhcy5kZW1hcmNoaUBwcm9mdXNpb24ubW9iaSIsCisgICAgXQorCisKIGNsYXNzIFF0RVdT KEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVtKToKICAgICBuYW1lID0gInF0LWV3cyIKICAgICBw b3J0X25hbWUgPSAicXQiCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv Y29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0 ZW1fdW5pdHRlc3QucHkJKHJldmlzaW9uIDY2NTI2KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weQkod29y a2luZyBjb3B5KQpAQCAtNzUsNiArNzUsOSBAQCBjbGFzcyBFYXJseVdhcm5pbmdTeXRlbVRlc3Qo UXVldWVzVGVzdCk6CiAgICAgZGVmIHRlc3RfZ3RrX2V3cyhzZWxmKToKICAgICAgICAgc2VsZi5f dGVzdF9ld3MoR3RrRVdTKCkpCiAKKyAgICBkZWYgdGVzdF9lZmxfZXdzKHNlbGYpOgorICAgICAg ICBzZWxmLl90ZXN0X2V3cyhFZmxFV1MoKSkKKwogICAgIGRlZiB0ZXN0X21hY19ld3Moc2VsZik6 CiAgICAgICAgIGV3cyA9IE1hY0VXUygpCiAgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9IHNlbGYu X2RlZmF1bHRfZXhwZWN0ZWRfc3RkZXJyKGV3cykK