44972 2010-08-31 12:39:55 -0700 Expose WorkerContext.createBlobURL and WorkerContext.revokeBlobURL 2010-08-31 14:35:23 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jianli jianli dimich fishd kinuko levin webkit.review.bot oldest_to_newest 272280 0 jianli 2010-08-31 12:39:55 -0700 Expose WorkerContext.createBlobURL and WorkerContext.revokeBlobURL 272283 1 66087 jianli 2010-08-31 12:43:26 -0700 Created attachment 66087 Proposed Patch 272286 2 webkit.review.bot 2010-08-31 12:45:16 -0700 Attachment 66087 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/workers/WorkerContext.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. 272324 3 66087 levin 2010-08-31 13:33:31 -0700 Comment on attachment 66087 Proposed Patch > diff --git a/WebCore/page/SecurityOrigin.cpp b/WebCore/page/SecurityOrigin.cpp > +#if ENABLE(BLOB) > + // For blob scheme, we want to ignore this check. > + if (!url.protocolIs("blob")) > + if (targetOrigin->isUnique()) > + return false; > +#else > if (targetOrigin->isUnique()) > return false; > +#endif Please consider: bool doUniqueOriginCheck = true; #if ENABLE(BLOB) // For blob scheme, we want to ignore this check. doUniqueOriginCheck = !url.protocolIs("blob")); #endif if (doUniqueOriginCheck && targetOrigin->isUnique()) return false; 272380 4 jianli 2010-08-31 14:35:23 -0700 Committed as http://trac.webkit.org/changeset/66537. 66087 2010-08-31 12:43:26 -0700 2010-08-31 13:33:31 -0700 Proposed Patch 44972 text/plain 7305 jianli ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1MTQ4NGNlLi4zOTk1YWU3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDgt MzEgIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cG9zZSBXb3JrZXJDb250ZXh0LmNyZWF0ZUJs b2JVUkwgYW5kIFdvcmtlckNvbnRleHQucmV2b2tlQmxvYlVSTC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0OTcyCisKKyAgICAgICAgKiBmYXN0L2Zp bGVzL3dvcmtlcnMvcmVzb3VyY2VzL3dvcmtlci1hcHBseS1ibG9iLXVybC10by14aHIuanM6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvZmlsZXMvd29ya2Vycy93b3JrZXItYXBwbHktYmxvYi11cmwt dG8teGhyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9maWxlcy93b3JrZXJz L3dvcmtlci1hcHBseS1ibG9iLXVybC10by14aHIuaHRtbDogQWRkZWQuCisKIDIwMTAtMDgtMzAg IElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEpvc2VwaCBQZWNvcmFyby4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZmls ZXMvd29ya2Vycy9yZXNvdXJjZXMvd29ya2VyLWFwcGx5LWJsb2ItdXJsLXRvLXhoci5qcyBiL0xh eW91dFRlc3RzL2Zhc3QvZmlsZXMvd29ya2Vycy9yZXNvdXJjZXMvd29ya2VyLWFwcGx5LWJsb2It dXJsLXRvLXhoci5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi42MGUzMDJk Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy93b3JrZXJzL3Jlc291 cmNlcy93b3JrZXItYXBwbHktYmxvYi11cmwtdG8teGhyLmpzCkBAIC0wLDAgKzEsMjggQEAKK2Z1 bmN0aW9uIGxvZyhtZXNzYWdlKQoreworICAgIHBvc3RNZXNzYWdlKG1lc3NhZ2UpOworfQorCitv bm1lc3NhZ2UgPSBmdW5jdGlvbihldmVudCkKK3sKKyAgICB2YXIgZmlsZSA9IGV2ZW50LmRhdGE7 CisgICAgdmFyIGZpbGVVUkwgPSBjcmVhdGVCbG9iVVJMKGZpbGUpOworCisgICAgbG9nKCJUZXN0 IHRoYXQgWE1MSHR0cFJlcXVlc3QgR0VUIHN1Y2NlZWRzLiIpOworICAgIHZhciB4aHIgPSBuZXcg WE1MSHR0cFJlcXVlc3QoKTsKKyAgICB4aHIub3BlbigiR0VUIiwgZmlsZVVSTCwgZmFsc2UpOwor ICAgIHhoci5zZW5kKCk7CisgICAgbG9nKHhoci5yZXNwb25zZVRleHQpOworCisgICAgbG9nKCJU ZXN0IHRoYXQgWE1MSHR0cFJlcXVlc3QgUE9TVCBmYWlscy4iKTsKKyAgICB4aHIgPSBuZXcgWE1M SHR0cFJlcXVlc3QoKTsKKyAgICB4aHIub3BlbigiUE9TVCIsIGZpbGVVUkwsIGZhbHNlKTsKKyAg ICB0cnkgeworICAgICAgICB4aHIuc2VuZCgpOworICAgIH0gY2F0Y2ggKGVycm9yKSB7CisgICAg ICAgIGxvZygiUmVjZWl2ZWQgZXhjZXB0aW9uICIgKyBlcnJvci5jb2RlICsgIjogIiArIGVycm9y Lm5hbWUpOworICAgIH0KKyAgICBsb2coeGhyLnJlc3BvbnNlVGV4dCk7CisKKyAgICBsb2coIkRP TkUiKTsKK30KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZmlsZXMvd29ya2Vycy93b3Jr ZXItYXBwbHktYmxvYi11cmwtdG8teGhyLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qv ZmlsZXMvd29ya2Vycy93b3JrZXItYXBwbHktYmxvYi11cmwtdG8teGhyLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5hMjRjNzE5Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy93b3JrZXJzL3dvcmtlci1hcHBseS1ibG9iLXVy bC10by14aHItZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsOCBAQAorCitUZXN0IHRoYXQgWE1MSHR0 cFJlcXVlc3QgR0VUIHN1Y2NlZWRzLgorSGVsbG8KK1Rlc3QgdGhhdCBYTUxIdHRwUmVxdWVzdCBQ T1NUIGZhaWxzLgorUmVjZWl2ZWQgZXhjZXB0aW9uIDEwMTogTkVUV09SS19FUlIKKworRE9ORQor CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL3dvcmtlcnMvd29ya2VyLWFwcGx5 LWJsb2ItdXJsLXRvLXhoci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy93b3JrZXJzL3dv cmtlci1hcHBseS1ibG9iLXVybC10by14aHIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwLi5jYTAzMzhhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9m aWxlcy93b3JrZXJzL3dvcmtlci1hcHBseS1ibG9iLXVybC10by14aHIuaHRtbApAQCAtMCwwICsx LDQ4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8aW5wdXQgdHlwZT0iZmls ZSIgbmFtZT0iZmlsZSIgaWQ9ImZpbGUiIG9uY2hhbmdlPSJvbklucHV0RmlsZUNoYW5nZSgpIj4K KzxwcmUgaWQ9J2NvbnNvbGUnPjwvcHJlPgorCis8c2NyaXB0PgorZnVuY3Rpb24gbG9nKG1lc3Nh Z2UpCit7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnNvbGUnKS5hcHBlbmRDaGls ZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShtZXNzYWdlICsgIlxuIikpOworfQorCitmdW5jdGlv biBvbklucHV0RmlsZUNoYW5nZSgpCit7CisgICAgdmFyIGZpbGUgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgiZmlsZSIpLmZpbGVzWzBdOworICAgIHZhciB3b3JrZXIgPSBuZXcgV29ya2VyKCJy ZXNvdXJjZXMvd29ya2VyLWFwcGx5LWJsb2ItdXJsLXRvLXhoci5qcyIpOworICAgIHdvcmtlci5v bm1lc3NhZ2UgPSBmdW5jdGlvbihldmVudCkKKyAgICB7CisgICAgICAgIGxvZyhldmVudC5kYXRh KTsKKyAgICAgICAgaWYgKGV2ZW50LmRhdGEgPT0gIkRPTkUiKSB7CisgICAgICAgICAgICBpZiAo d2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICAgICAgfQorICAgIH0KKyAgICB3b3JrZXIub25l cnJvciA9IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgbG9nKCJSZWNlaXZlZCBlcnJv ciBmcm9tIHdvcmtlcjogIiArIGV2ZW50Lm1lc3NhZ2UpOworICAgICAgICBpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90 aWZ5RG9uZSgpOworICAgIH0KKyAgICB3b3JrZXIucG9zdE1lc3NhZ2UoZmlsZSk7Cit9CisKK2Z1 bmN0aW9uIHJ1blRlc3RzKCkKK3sKKyAgICBldmVudFNlbmRlci5iZWdpbkRyYWdXaXRoRmlsZXMo WycuLi9yZXNvdXJjZXMvVVRGOC50eHQnXSk7CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8o MTAsIDEwKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7Cit9CisKK2lmICh3aW5kb3cuZXZl bnRTZW5kZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgIHdpbmRvdy5vbmxvYWQg PSBydW5UZXN0czsKK30KKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYmQ0OWRiLi5lMWU4 ZTYxIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDEwLTA4LTMxICBKaWFuIExpICA8amlhbmxpQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF eHBvc2UgV29ya2VyQ29udGV4dC5jcmVhdGVCbG9iVVJMIGFuZCBXb3JrZXJDb250ZXh0LnJldm9r ZUJsb2JVUkwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00NDk3MgorCisgICAgICAgIFRlc3Q6IGZhc3QvZmlsZXMvd29ya2Vycy93b3JrZXItYXBwbHkt YmxvYi11cmwtdG8teGhyLmh0bWwKKworICAgICAgICAqIHBhZ2UvU2VjdXJpdHlPcmlnaW4uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6U2VjdXJpdHlPcmlnaW46OmNhblJlcXVlc3QpOgorICAgICAg ICAqIHdvcmtlcnMvV29ya2VyQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJD b250ZXh0OjpjcmVhdGVCbG9iVVJMKToKKyAgICAgICAgKFdlYkNvcmU6OldvcmtlckNvbnRleHQ6 OnJldm9rZUJsb2JVUkwpOgorICAgICAgICAqIHdvcmtlcnMvV29ya2VyQ29udGV4dC5oOgorICAg ICAgICAqIHdvcmtlcnMvV29ya2VyQ29udGV4dC5pZGw6CisKIDIwMTAtMDgtMzAgIElseWEgVGlr aG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpv c2VwaCBQZWNvcmFyby4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdpbi5j cHAgYi9XZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uY3BwCmluZGV4IDViNTE1MDEuLjExMDY0 MjUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdpbi5jcHAKKysrIGIvV2Vi Q29yZS9wYWdlL1NlY3VyaXR5T3JpZ2luLmNwcApAQCAtMjM2LDggKzIzNiwxNSBAQCBib29sIFNl Y3VyaXR5T3JpZ2luOjpjYW5SZXF1ZXN0KGNvbnN0IEtVUkwmIHVybCkgY29uc3QKICAgICAgICAg cmV0dXJuIGZhbHNlOwogCiAgICAgUmVmUHRyPFNlY3VyaXR5T3JpZ2luPiB0YXJnZXRPcmlnaW4g PSBTZWN1cml0eU9yaWdpbjo6Y3JlYXRlKHVybCk7CisjaWYgRU5BQkxFKEJMT0IpCisgICAgLy8g Rm9yIGJsb2Igc2NoZW1lLCB3ZSB3YW50IHRvIGlnbm9yZSB0aGlzIGNoZWNrLgorICAgIGlmICgh dXJsLnByb3RvY29sSXMoImJsb2IiKSkKKyAgICAgICAgaWYgKHRhcmdldE9yaWdpbi0+aXNVbmlx dWUoKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyNlbHNlCiAgICAgaWYgKHRhcmdldE9y aWdpbi0+aXNVbmlxdWUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCiAKICAgICAv LyBXZSBjYWxsIGlzU2FtZVNjaGVtZUhvc3RQb3J0IGhlcmUgaW5zdGVhZCBvZiBjYW5BY2Nlc3Mg YmVjYXVzZSB3ZSB3YW50CiAgICAgLy8gdG8gaWdub3JlIGRvY3VtZW50LmRvbWFpbiBlZmZlY3Rz LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuY3BwIGIvV2ViQ29y ZS93b3JrZXJzL1dvcmtlckNvbnRleHQuY3BwCmluZGV4IDM2YTlmOTQ2Li5iNTJiMjg1IDEwMDY0 NAotLS0gYS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5jcHAKKysrIGIvV2ViQ29yZS93 b3JrZXJzL1dvcmtlckNvbnRleHQuY3BwCkBAIC00Myw2ICs0Myw3IEBACiAjaW5jbHVkZSAiRXZl bnQuaCIKICNpbmNsdWRlICJFdmVudEV4Y2VwdGlvbi5oIgogI2luY2x1ZGUgIkluc3BlY3RvckNv bnRyb2xsZXIuaCIKKyNpbmNsdWRlICJLVVJMLmgiCiAjaW5jbHVkZSAiTWVzc2FnZVBvcnQuaCIK ICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgogI2luY2x1ZGUgIlNjcmlwdFNvdXJjZUNvZGUu aCIKQEAgLTMyMiw2ICszMjMsMTggQEAgRXZlbnRUYXJnZXREYXRhKiBXb3JrZXJDb250ZXh0Ojpl bnN1cmVFdmVudFRhcmdldERhdGEoKQogICAgIHJldHVybiAmbV9ldmVudFRhcmdldERhdGE7CiB9 CiAKKyNpZiBFTkFCTEUoQkxPQikKK1N0cmluZyBXb3JrZXJDb250ZXh0OjpjcmVhdGVCbG9iVVJM KEJsb2IqIGJsb2IpCit7CisgICAgcmV0dXJuIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKS0+Y3Jl YXRlUHVibGljQmxvYlVSTChibG9iKS5zdHJpbmcoKTsKK30KKwordm9pZCBXb3JrZXJDb250ZXh0 OjpyZXZva2VCbG9iVVJMKGNvbnN0IFN0cmluZyYgYmxvYlVSTFN0cmluZykKK3sKKyAgICBzY3Jp cHRFeGVjdXRpb25Db250ZXh0KCktPnJldm9rZVB1YmxpY0Jsb2JVUkwoS1VSTChQYXJzZWRVUkxT dHJpbmcsIGJsb2JVUkxTdHJpbmcpKTsKK30KKyNlbmRpZgorCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCiAKICNlbmRpZiAvLyBFTkFCTEUoV09SS0VSUykKZGlmZiAtLWdpdCBhL1dlYkNvcmUvd29y a2Vycy9Xb3JrZXJDb250ZXh0LmggYi9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5oCmlu ZGV4IDllOWU1NGYuLjdmYjhiNDYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJD b250ZXh0LmgKKysrIGIvV2ViQ29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuaApAQCAtNDMsNiAr NDMsNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKKyAgICBjbGFzcyBCbG9iOwogICAgIGNs YXNzIERhdGFiYXNlOwogICAgIGNsYXNzIERhdGFiYXNlQ2FsbGJhY2s7CiAgICAgY2xhc3MgRGF0 YWJhc2VTeW5jOwpAQCAtMTE1LDYgKzExNiwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAg ICAgIHZpcnR1YWwgYm9vbCBpc0NvbnRleHRUaHJlYWQoKSBjb25zdDsKICAgICAgICAgdmlydHVh bCBib29sIGlzSlNFeGVjdXRpb25UZXJtaW5hdGVkKCkgY29uc3Q7CiAKKyNpZiBFTkFCTEUoQkxP QikKKyAgICAgICAgU3RyaW5nIGNyZWF0ZUJsb2JVUkwoQmxvYiopOworICAgICAgICB2b2lkIHJl dm9rZUJsb2JVUkwoY29uc3QgU3RyaW5nJik7CisjZW5kaWYKIAogICAgICAgICAvLyBUaGVzZSBt ZXRob2RzIGFyZSB1c2VkIGZvciBHQyBtYXJraW5nLiBTZWUgSlNXb3JrZXJDb250ZXh0OjptYXJr Q2hpbGRyZW4oTWFya1N0YWNrJikgaW4KICAgICAgICAgLy8gSlNXb3JrZXJDb250ZXh0Q3VzdG9t LmNwcC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250ZXh0LmlkbCBiL1dl YkNvcmUvd29ya2Vycy9Xb3JrZXJDb250ZXh0LmlkbAppbmRleCA4MWE2ODFhLi4wMmFhNGFkIDEw MDY0NAotLS0gYS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5pZGwKKysrIGIvV2ViQ29y ZS93b3JrZXJzL1dvcmtlckNvbnRleHQuaWRsCkBAIC0xMDEsNiArMTAxLDggQEAgbW9kdWxlIHRo cmVhZHMgewogICAgICAgICBhdHRyaWJ1dGUgQmxvYkJ1aWxkZXJDb25zdHJ1Y3RvciBCbG9iQnVp bGRlcjsKICAgICAgICAgYXR0cmlidXRlIEZpbGVSZWFkZXJDb25zdHJ1Y3RvciBGaWxlUmVhZGVy OwogICAgICAgICBhdHRyaWJ1dGUgRmlsZVJlYWRlclN5bmNDb25zdHJ1Y3RvciBGaWxlUmVhZGVy U3luYzsKKyAgICAgICAgRE9NU3RyaW5nIGNyZWF0ZUJsb2JVUkwoaW4gQmxvYiBibG9iKTsKKyAg ICAgICAgdm9pZCByZXZva2VCbG9iVVJMKGluIERPTVN0cmluZyBibG9iVVJMKTsKICNlbmRpZgog ICAgIH07CiAK