44970 2010-08-31 12:01:43 -0700 Add cross product and arithmetic operations to FloatPoint3D 2010-09-01 10:10:58 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 44729 44991 1 kbr kbr cmarrin jamesr senorblanco simon.fraser oldest_to_newest 272258 0 kbr 2010-08-31 12:01:43 -0700 Currently FloatPoint contains arithmetic operations like addition and subtraction that FloatPoint3D lacks. Additionally, FloatPoint3D is missing useful operations like cross products that are needed for various geometric algorithms. 272277 1 66086 kbr 2010-08-31 12:35:42 -0700 Created attachment 66086 Patch From the ChangeLog: Added set, move, and scale operations similar to FloatPoint's, addition and subtraction operators, length, lengthSquared and cross product. These changes have been tested with new code to be added later. 272375 2 kbr 2010-08-31 14:27:50 -0700 Committed r66533: <http://trac.webkit.org/changeset/66533> 66086 2010-08-31 12:35:42 -0700 2010-08-31 13:43:41 -0700 Patch float-point-3d.patch text/plain 4826 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjUyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzEgQEAKKzIwMTAtMDgtMzEgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZCBjcm9zcyBwcm9kdWN0IGFuZCBhcml0aG1ldGljIG9wZXJhdGlvbnMgdG8gRmxvYXRQb2ludDNE CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDk3MAor CisgICAgICAgIEFkZGVkIHNldCwgbW92ZSwgYW5kIHNjYWxlIG9wZXJhdGlvbnMgc2ltaWxhciB0 byBGbG9hdFBvaW50J3MsCisgICAgICAgIGFkZGl0aW9uIGFuZCBzdWJ0cmFjdGlvbiBvcGVyYXRv cnMsIGxlbmd0aCwgbGVuZ3RoU3F1YXJlZCBhbmQKKyAgICAgICAgY3Jvc3MgcHJvZHVjdC4gVGhl c2UgY2hhbmdlcyBoYXZlIGJlZW4gdGVzdGVkIHdpdGggbmV3IGNvZGUgdG8gYmUKKyAgICAgICAg YWRkZWQgbGF0ZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFBvaW50M0Qu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRQb2ludDNEOjpub3JtYWxpemUpOgorICAgICAg ICAoV2ViQ29yZTo6RmxvYXRQb2ludDNEOjpsZW5ndGgpOgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL0Zsb2F0UG9pbnQzRC5oOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRQb2ludDNEOjpz ZXQpOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRQb2ludDNEOjptb3ZlKToKKyAgICAgICAgKFdl YkNvcmU6OkZsb2F0UG9pbnQzRDo6c2NhbGUpOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRQb2lu dDNEOjpkb3QpOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRQb2ludDNEOjpjcm9zcyk6CisgICAg ICAgIChXZWJDb3JlOjpGbG9hdFBvaW50M0Q6Omxlbmd0aFNxdWFyZWQpOgorICAgICAgICAoV2Vi Q29yZTo6b3BlcmF0b3IgKz0pOgorICAgICAgICAoV2ViQ29yZTo6b3BlcmF0b3IgLT0pOgorICAg ICAgICAoV2ViQ29yZTo6b3BlcmF0b3IrKToKKyAgICAgICAgKFdlYkNvcmU6Om9wZXJhdG9yLSk6 CisgICAgICAgIChXZWJDb3JlOjpvcGVyYXRvciopOgorCiAyMDEwLTA4LTMwICBJbHlhIFRpa2hv bm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKb3Nl cGggUGVjb3Jhcm8uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQz RC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFBvaW50 M0QuY3BwCShyZXZpc2lvbiA2NjUwOCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxv YXRQb2ludDNELmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjEsMjEgKzIxLDI3IEBACiAKICNpbmNs dWRlICJjb25maWcuaCIKIAotI2luY2x1ZGUgPG1hdGguaD4KICNpbmNsdWRlICJGbG9hdFBvaW50 M0QuaCIKIAorI2luY2x1ZGUgPG1hdGguaD4KKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiB2b2lk IEZsb2F0UG9pbnQzRDo6bm9ybWFsaXplKCkKIHsKLSAgICBmbG9hdCBsZW5ndGggPSBzcXJ0Ziht X3ggKiBtX3ggKyBtX3kgKiBtX3kgKyBtX3ogKiBtX3opOworICAgIGZsb2F0IHRlbXBMZW5ndGgg PSBsZW5ndGgoKTsKIAotICAgIGlmIChsZW5ndGggIT0gMCkgewotICAgICAgICBtX3ggLz0gbGVu Z3RoOwotICAgICAgICBtX3kgLz0gbGVuZ3RoOwotICAgICAgICBtX3ogLz0gbGVuZ3RoOworICAg IGlmICh0ZW1wTGVuZ3RoKSB7CisgICAgICAgIG1feCAvPSB0ZW1wTGVuZ3RoOworICAgICAgICBt X3kgLz0gdGVtcExlbmd0aDsKKyAgICAgICAgbV96IC89IHRlbXBMZW5ndGg7CiAgICAgfQogfQog CitmbG9hdCBGbG9hdFBvaW50M0Q6Omxlbmd0aCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIHNxcnRm KGxlbmd0aFNxdWFyZWQoKSk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIApJbmRleDog V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFBvaW50M0QuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQzRC5oCShyZXZpc2lvbiA2NjUwOCkK KysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQb2ludDNELmgJKHdvcmtpbmcgY29w eSkKQEAgLTY1LDE1ICs2NSw4NSBAQCBwdWJsaWM6CiAKICAgICBmbG9hdCB6KCkgY29uc3QgeyBy ZXR1cm4gbV96OyB9CiAgICAgdm9pZCBzZXRaKGZsb2F0IHopIHsgbV96ID0gejsgfQorICAgIHZv aWQgc2V0KGZsb2F0IHgsIGZsb2F0IHksIGZsb2F0IHopCisgICAgeworICAgICAgICBtX3ggPSB4 OworICAgICAgICBtX3kgPSB5OworICAgICAgICBtX3ogPSB6OworICAgIH0KKyAgICB2b2lkIG1v dmUoZmxvYXQgZHgsIGZsb2F0IGR5LCBmbG9hdCBkeikKKyAgICB7CisgICAgICAgIG1feCArPSBk eDsKKyAgICAgICAgbV95ICs9IGR5OworICAgICAgICBtX3ogKz0gZHo7CisgICAgfQorICAgIHZv aWQgc2NhbGUoZmxvYXQgc3gsIGZsb2F0IHN5LCBmbG9hdCBzeikKKyAgICB7CisgICAgICAgIG1f eCAqPSBzeDsKKyAgICAgICAgbV95ICo9IHN5OworICAgICAgICBtX3ogKj0gc3o7CisgICAgfQog CiAgICAgdm9pZCBub3JtYWxpemUoKTsKIAorICAgIGZsb2F0IGRvdChjb25zdCBGbG9hdFBvaW50 M0QmIGEpIGNvbnN0CisgICAgeworICAgICAgICByZXR1cm4gbV94ICogYS54KCkgKyBtX3kgKiBh LnkoKSArIG1feiAqIGEueigpOworICAgIH0KKworICAgIC8vIFNldHMgdGhpcyBGbG9hdFBvaW50 M0QgdG8gdGhlIGNyb3NzIHByb2R1Y3Qgb2YgdGhlIHBhc3NlZCB0d28uCisgICAgLy8gSXQgaXMg c2FmZSBmb3IgInRoaXMiIHRvIGJlIHRoZSBzYW1lIGFzIGVpdGhlciBvciBib3RoIG9mIHRoZQor ICAgIC8vIGFyZ3VtZW50cy4KKyAgICB2b2lkIGNyb3NzKGNvbnN0IEZsb2F0UG9pbnQzRCYgYSwg Y29uc3QgRmxvYXRQb2ludDNEJiBiKQorICAgIHsKKyAgICAgICAgZmxvYXQgeCA9IGEueSgpICog Yi56KCkgLSBhLnooKSAqIGIueSgpOworICAgICAgICBmbG9hdCB5ID0gYS56KCkgKiBiLngoKSAt IGEueCgpICogYi56KCk7CisgICAgICAgIGZsb2F0IHogPSBhLngoKSAqIGIueSgpIC0gYS55KCkg KiBiLngoKTsKKyAgICAgICAgbV94ID0geDsKKyAgICAgICAgbV95ID0geTsKKyAgICAgICAgbV96 ID0gejsKKyAgICB9CisKKyAgICAvLyBDb252ZW5pZW5jZSBmdW5jdGlvbiByZXR1cm5pbmcgInRo aXMgY3Jvc3MgcG9pbnQiIGFzIGEKKyAgICAvLyBzdGFjay1hbGxvY2F0ZWQgcmVzdWx0LgorICAg IEZsb2F0UG9pbnQzRCBjcm9zcyhjb25zdCBGbG9hdFBvaW50M0QmIHBvaW50KSBjb25zdAorICAg IHsKKyAgICAgICAgRmxvYXRQb2ludDNEIHJlc3VsdDsKKyAgICAgICAgcmVzdWx0LmNyb3NzKCp0 aGlzLCBwb2ludCk7CisgICAgICAgIHJldHVybiByZXN1bHQ7CisgICAgfQorCisgICAgZmxvYXQg bGVuZ3RoKCkgY29uc3Q7CisgICAgZmxvYXQgbGVuZ3RoU3F1YXJlZCgpIGNvbnN0IHsgcmV0dXJu IHRoaXMtPmRvdCgqdGhpcyk7IH0KKwogcHJpdmF0ZToKICAgICBmbG9hdCBtX3g7CiAgICAgZmxv YXQgbV95OwogICAgIGZsb2F0IG1fejsKIH07CiAKK2lubGluZSBGbG9hdFBvaW50M0QmIG9wZXJh dG9yICs9KEZsb2F0UG9pbnQzRCYgYSwgY29uc3QgRmxvYXRQb2ludDNEJiBiKQoreworICAgIGEu bW92ZShiLngoKSwgYi55KCksIGIueigpKTsKKyAgICByZXR1cm4gYTsKK30KKworaW5saW5lIEZs b2F0UG9pbnQzRCYgb3BlcmF0b3IgLT0oRmxvYXRQb2ludDNEJiBhLCBjb25zdCBGbG9hdFBvaW50 M0QmIGIpCit7CisgICAgYS5tb3ZlKC1iLngoKSwgLWIueSgpLCAtYi56KCkpOworICAgIHJldHVy biBhOworfQorCitpbmxpbmUgRmxvYXRQb2ludDNEIG9wZXJhdG9yKyhjb25zdCBGbG9hdFBvaW50 M0QmIGEsIGNvbnN0IEZsb2F0UG9pbnQzRCYgYikKK3sKKyAgICByZXR1cm4gRmxvYXRQb2ludDNE KGEueCgpICsgYi54KCksIGEueSgpICsgYi55KCksIGEueigpICsgYi56KCkpOworfQorCitpbmxp bmUgRmxvYXRQb2ludDNEIG9wZXJhdG9yLShjb25zdCBGbG9hdFBvaW50M0QmIGEsIGNvbnN0IEZs b2F0UG9pbnQzRCYgYikKK3sKKyAgICByZXR1cm4gRmxvYXRQb2ludDNEKGEueCgpIC0gYi54KCks IGEueSgpIC0gYi55KCksIGEueigpIC0gYi56KCkpOworfQorCiBpbmxpbmUgYm9vbCBvcGVyYXRv cj09KGNvbnN0IEZsb2F0UG9pbnQzRCYgYSwgY29uc3QgRmxvYXRQb2ludDNEJiBiKQogewogICAg IHJldHVybiBhLngoKSA9PSBiLngoKSAmJiBhLnkoKSA9PSBiLnkoKSAmJiBhLnooKSA9PSBiLnoo KTsKQEAgLTg3LDcgKzE1Nyw3IEBAIGlubGluZSBib29sIG9wZXJhdG9yIT0oY29uc3QgRmxvYXRQ b2ludDMKIGlubGluZSBmbG9hdCBvcGVyYXRvciooY29uc3QgRmxvYXRQb2ludDNEJiBhLCBjb25z dCBGbG9hdFBvaW50M0QmIGIpCiB7CiAgICAgLy8gZG90IHByb2R1Y3QKLSAgICByZXR1cm4gYS54 KCkgKiBiLngoKSArIGEueSgpICogYi55KCkgKyBhLnooKSAqIGIueigpOworICAgIHJldHVybiBh LmRvdChiKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=