44959 2010-08-31 09:12:44 -0700 [GTK] Leak in the GraphicsContextCairo drawPathShadow 2010-09-13 11:46:44 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned gustavo webkit.review.bot oldest_to_newest 272126 0 alex 2010-08-31 09:12:44 -0700 We are copying the cairo_path but we are not destroying it: cairo_path_t* path = cairo_copy_path(cr); 272128 1 66062 alex 2010-08-31 09:15:20 -0700 Created attachment 66062 Proposed patch 272240 2 66062 gustavo 2010-08-31 11:44:10 -0700 Comment on attachment 66062 Proposed patch Can't we use a PlatformRefPtr/CairoRefPtr for this? 272318 3 alex 2010-08-31 13:28:49 -0700 (In reply to comment #2) > (From update of attachment 66062 [details]) > Can't we use a PlatformRefPtr/CairoRefPtr for this? I've checked path is not already included, but I can do it in this same patch and use it, thanks for the comment. 272741 4 66198 alex 2010-09-01 04:33:50 -0700 Created attachment 66198 Proposed patch Added the GOwnPtrCairo code so we can use it in these situations. 272742 5 webkit.review.bot 2010-09-01 04:40:46 -0700 Attachment 66198 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/graphics/cairo/GOwnPtrCairo.h:31: cairo_path_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 272747 6 alex 2010-09-01 04:54:13 -0700 (In reply to comment #5) > Attachment 66198 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 > WebCore/platform/graphics/cairo/GOwnPtrCairo.h:31: cairo_path_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] > Total errors found: 1 in 4 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Yep, it is a false positive. Opened bug 45032. 273226 7 66198 mrobinson 2010-09-01 22:33:34 -0700 Comment on attachment 66198 Proposed patch Looks reasonable. 278352 8 alex 2010-09-13 11:46:44 -0700 lande r67398 66062 2010-08-31 09:15:20 -0700 2010-09-01 04:34:20 -0700 Proposed patch cairo_path_leak.patch text/plain 1705 alex ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWMwYmI2MS4uYjFkNWRiMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOC0zMSAgQWxlamFuZHJvIEcu IENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbR1RLXSBMZWFrIGluIHRoZSBHcmFwaGljc0NvbnRleHRDYWly byBkcmF3UGF0aFNoYWRvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDQ5NTkKKyAgICAgICAgCisgICAgICAgIEZpeCBhIGxlYWsgb2YgdGhlIGNhaXJv X3BhdGguCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRl eHRDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpkcmF3UGF0aFNoYWRvdyk6CisKIDIwMTAt MDgtMzEgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCmluZGV4IDY4M2MxNDQuLjQ5ZjMxNWQg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250 ZXh0Q2Fpcm8uY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhp Y3NDb250ZXh0Q2Fpcm8uY3BwCkBAIC0yMDAsNyArMjAwLDYgQEAgc3RhdGljIGlubGluZSB2b2lk IGRyYXdQYXRoU2hhZG93KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgR3JhcGhpY3NDb250ZXh0 UHJpdmEKICAgICAKICAgICAvLyBDYWxjdWxhdGUgZmlsdGVyIHZhbHVlcyB0byBjcmVhdGUgYXBw cm9wcmlhdGUgc2hhZG93LgogICAgIGNhaXJvX3QqIGNyID0gY29udGV4dC0+cGxhdGZvcm1Db250 ZXh0KCk7Ci0gICAgY2Fpcm9fcGF0aF90KiBwYXRoID0gY2Fpcm9fY29weV9wYXRoKGNyKTsKICAg ICBkb3VibGUgeDAsIHgxLCB5MCwgeTE7CiAgICAgaWYgKHN0cm9rZVNoYWRvdykKICAgICAgICAg Y2Fpcm9fc3Ryb2tlX2V4dGVudHMoY3IsICZ4MCwgJnkwLCAmeDEsICZ5MSk7CkBAIC0yMjEsNyAr MjIwLDkgQEAgc3RhdGljIGlubGluZSB2b2lkIGRyYXdQYXRoU2hhZG93KEdyYXBoaWNzQ29udGV4 dCogY29udGV4dCwgR3JhcGhpY3NDb250ZXh0UHJpdmEKICAgICBjb3B5Q29udGV4dFByb3BlcnRp ZXMoY3IsIHNoYWRvd0NvbnRleHQpOwogICAgIGNhaXJvX3RyYW5zbGF0ZShzaGFkb3dDb250ZXh0 LCAtcmVjdC54KCkgKyByYWRpdXMsIC1yZWN0LnkoKSArIHJhZGl1cyk7CiAgICAgY2Fpcm9fbmV3 X3BhdGgoc2hhZG93Q29udGV4dCk7CisgICAgY2Fpcm9fcGF0aF90KiBwYXRoID0gY2Fpcm9fY29w eV9wYXRoKGNyKTsKICAgICBjYWlyb19hcHBlbmRfcGF0aChzaGFkb3dDb250ZXh0LCBwYXRoKTsK KyAgICBjYWlyb19wYXRoX2Rlc3Ryb3kocGF0aCk7CiAKICAgICBpZiAoZmlsbFNoYWRvdykKICAg ICAgICAgc2V0UGxhdGZvcm1GaWxsKGNvbnRleHQsIHNoYWRvd0NvbnRleHQsIGdjcCk7Cg== 66198 2010-09-01 04:33:50 -0700 2010-09-01 22:33:34 -0700 Proposed patch cairo_path_leak.patch text/plain 3100 alex ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Mjc4MTZlMS4uZjlmZjQzNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0wMSAgQWxlamFuZHJvIEcu IENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZv IE5vcm9uaGEgU2lsdmEuCisKKyAgICAgICAgW0dUS10gTGVhayBpbiB0aGUgR3JhcGhpY3NDb250 ZXh0Q2Fpcm8gZHJhd1BhdGhTaGFkb3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ0OTU5CisKKyAgICAgICAgRml4IGEgbGVhayBvZiB0aGUgY2Fpcm9f cGF0aC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4 dENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRyYXdQYXRoU2hhZG93KToKKwogMjAxMC0w OS0wMSAgS2ludWtvIFlhc3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5y ZXZpZXdlZDsgYW5vdGhlciBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NhaXJvL0dPd25QdHJDYWlyby5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NhaXJvL0dPd25QdHJDYWlyby5jcHAKaW5kZXggMTJkZjNjZi4uYmRkYzk1YiAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HT3duUHRyQ2Fpcm8uY3BwCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR093blB0ckNhaXJvLmNwcApAQCAt NDcsNCArNDcsMTAgQEAgdGVtcGxhdGUgPD4gdm9pZCBmcmVlT3duZWRHUHRyPEZjRm9udFNldD4o RmNGb250U2V0KiBwdHIpCiB9CiAjZW5kaWYKIAordGVtcGxhdGUgPD4gdm9pZCBmcmVlT3duZWRH UHRyPGNhaXJvX3BhdGhfdD4oY2Fpcm9fcGF0aF90KiBwdHIpCit7CisgICAgaWYgKHB0cikKKyAg ICAgICAgY2Fpcm9fcGF0aF9kZXN0cm95KHB0cik7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdURgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HT3duUHRyQ2Fpcm8u aCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR093blB0ckNhaXJvLmgKaW5kZXgg YjA5OTcwNy4uMWM1OTc2YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9HT3duUHRyQ2Fpcm8uaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJv L0dPd25QdHJDYWlyby5oCkBAIC0yOCw2ICsyOCw4IEBAIHR5cGVkZWYgc3RydWN0IF9GY09iamVj dFNldCBGY09iamVjdFNldDsKIHR5cGVkZWYgc3RydWN0IF9GY0ZvbnRTZXQgRmNGb250U2V0Owog I2VuZGlmCiAKK3R5cGVkZWYgc3RydWN0IGNhaXJvX3BhdGggY2Fpcm9fcGF0aF90OworCiBuYW1l c3BhY2UgV1RGIHsKIAogI2lmIGRlZmluZWQoVVNFX0ZSRUVUWVBFKQpAQCAtMzYsNiArMzgsOCBA QCB0ZW1wbGF0ZSA8PiB2b2lkIGZyZWVPd25lZEdQdHI8RmNPYmplY3RTZXQ+KEZjT2JqZWN0U2V0 Kik7CiB0ZW1wbGF0ZSA8PiB2b2lkIGZyZWVPd25lZEdQdHI8RmNGb250U2V0PihGY0ZvbnRTZXQq KTsKICNlbmRpZgogCit0ZW1wbGF0ZSA8PiB2b2lkIGZyZWVPd25lZEdQdHI8Y2Fpcm9fcGF0aF90 PihjYWlyb19wYXRoX3QqKTsKKwogfSAvLyBuYW1lc3BhY2UgV1RGCiAKICNlbmRpZgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWly by5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENh aXJvLmNwcAppbmRleCA2ODNjMTQ0Li4zMGI3MmQxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAorKysgYi9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcApAQCAtMzgs NiArMzgsNyBAQAogI2luY2x1ZGUgIkZFR2F1c3NpYW5CbHVyLmgiCiAjaW5jbHVkZSAiRmxvYXRS ZWN0LmgiCiAjaW5jbHVkZSAiRm9udC5oIgorI2luY2x1ZGUgIkdPd25QdHJDYWlyby5oIgogI2lu Y2x1ZGUgIkltYWdlQnVmZmVyLmgiCiAjaW5jbHVkZSAiSW1hZ2VCdWZmZXJGaWx0ZXIuaCIKICNp bmNsdWRlICJJbnRSZWN0LmgiCkBAIC0yMDAsNyArMjAxLDYgQEAgc3RhdGljIGlubGluZSB2b2lk IGRyYXdQYXRoU2hhZG93KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgR3JhcGhpY3NDb250ZXh0 UHJpdmEKICAgICAKICAgICAvLyBDYWxjdWxhdGUgZmlsdGVyIHZhbHVlcyB0byBjcmVhdGUgYXBw cm9wcmlhdGUgc2hhZG93LgogICAgIGNhaXJvX3QqIGNyID0gY29udGV4dC0+cGxhdGZvcm1Db250 ZXh0KCk7Ci0gICAgY2Fpcm9fcGF0aF90KiBwYXRoID0gY2Fpcm9fY29weV9wYXRoKGNyKTsKICAg ICBkb3VibGUgeDAsIHgxLCB5MCwgeTE7CiAgICAgaWYgKHN0cm9rZVNoYWRvdykKICAgICAgICAg Y2Fpcm9fc3Ryb2tlX2V4dGVudHMoY3IsICZ4MCwgJnkwLCAmeDEsICZ5MSk7CkBAIC0yMjEsNyAr MjIxLDggQEAgc3RhdGljIGlubGluZSB2b2lkIGRyYXdQYXRoU2hhZG93KEdyYXBoaWNzQ29udGV4 dCogY29udGV4dCwgR3JhcGhpY3NDb250ZXh0UHJpdmEKICAgICBjb3B5Q29udGV4dFByb3BlcnRp ZXMoY3IsIHNoYWRvd0NvbnRleHQpOwogICAgIGNhaXJvX3RyYW5zbGF0ZShzaGFkb3dDb250ZXh0 LCAtcmVjdC54KCkgKyByYWRpdXMsIC1yZWN0LnkoKSArIHJhZGl1cyk7CiAgICAgY2Fpcm9fbmV3 X3BhdGgoc2hhZG93Q29udGV4dCk7Ci0gICAgY2Fpcm9fYXBwZW5kX3BhdGgoc2hhZG93Q29udGV4 dCwgcGF0aCk7CisgICAgR093blB0cjxjYWlyb19wYXRoX3Q+IHBhdGgoY2Fpcm9fY29weV9wYXRo KGNyKSk7CisgICAgY2Fpcm9fYXBwZW5kX3BhdGgoc2hhZG93Q29udGV4dCwgcGF0aC5nZXQoKSk7 CiAKICAgICBpZiAoZmlsbFNoYWRvdykKICAgICAgICAgc2V0UGxhdGZvcm1GaWxsKGNvbnRleHQs IHNoYWRvd0NvbnRleHQsIGdjcCk7Cg==