44954 2010-08-31 08:00:52 -0700 [WML] Remove create() function in WMLTaskElement because of build breaks. 2010-09-08 06:46:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim webkit-unassigned abarth commit-queue eric krit oldest_to_newest 272099 0 gyuyoung.kim 2010-08-31 08:00:52 -0700 There is a build break when WML is enabled. It seems to me that executeTask() is needed to implement because the create function is added. /home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLTaskElement.cpp: In static member function ‘static WTF::PassRefPtr<WebCore::WMLTaskElement> WebCore::WMLTaskElement::create(const WebCore::QualifiedName&, WebCore::Document*)’: /home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLTaskElement.cpp:44: error: cannot allocate an object of abstract type ‘WebCore::WMLTaskElement’ /home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLTaskElement.h:34: note: because the following virtual functions are pure within ‘WebCore::WMLTaskElement’: /home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLTaskElement.h:45: note: virtual void WebCore::WMLTaskElement::executeTask() make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/wml/WMLTaskElement.cpp.o] Error 1 272102 1 66054 gyuyoung.kim 2010-08-31 08:04:04 -0700 Created attachment 66054 Patch 274863 2 krit 2010-09-07 00:19:50 -0700 Do we ever create a WMLTaskElement? It looks like it is just the base class for: WMLGoElement.h:class WMLGoElement : public WMLTaskElement { WMLPrevElement.h:class WMLPrevElement : public WMLTaskElement { WMLRefreshElement.h:class WMLRefreshElement : public WMLTaskElement { So maybe it's better to remove the 'create' here and move the CTor to protected, the same for the DTor: protected: WMLTaskElement(const QualifiedName& tagName, Document*); virtual ~WMLTaskElement(); Can you test this please? I'm also confused, that we don't have 'create' for the elements mentioned above (Go, Prev, Refresh). 275062 3 66054 krit 2010-09-07 08:53:10 -0700 Comment on attachment 66054 Patch r- because of the comment before. 275583 4 66837 gyuyoung.kim 2010-09-07 20:26:36 -0700 Created attachment 66837 Patch When I modify this patch with your guidance, there are no build break. As you know, the build break came from the create(). So, if we remove the create() in WMLTaskElement.cpp, I think we should find which class uses the create() function. But, I can't find classes which invokes the create() from WMLTaskElement.cpp. >> I'm also confused, that we don't have 'create' for the elements mentioned above (Go, Prev, Refresh). The three elements you mentioned have create() functions as below. The create() of WMLTaskCreate is not invoked by other classes. If we need to make the create() function for WMLTaskElement, I think we can make it again. For now, this patch is needed to fix build break. How do you think about it ? ================================================================================================ 53 PassRefPtr<WMLGoElement> WMLGoElement::create(const QualifiedName& tagName, Document* document) 54 { 39 PassRefPtr<WMLPrevElement> WMLPrevElement::create(const QualifiedName& tagName, Document* document) 40 { 40 PassRefPtr<WMLRefreshElement> WMLRefreshElement::create(const QualifiedName& tagName, Document* document) 41 { ================================================================================================ 275638 5 66837 krit 2010-09-07 23:35:05 -0700 Comment on attachment 66837 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66837&action=prettypatch Great patch! r=me. 275801 6 66837 commit-queue 2010-09-08 06:46:41 -0700 Comment on attachment 66837 Patch Clearing flags on attachment: 66837 Committed r66978: <http://trac.webkit.org/changeset/66978> 275802 7 commit-queue 2010-09-08 06:46:46 -0700 All reviewed patches have been landed. Closing bug. 66054 2010-08-31 08:04:04 -0700 2010-09-07 20:26:36 -0700 Patch patch-wml-task.txt text/plain 1574 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTFhYjk5Zi4uNzE2MTU0NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOC0zMSAgR3l1eW91bmcgS2lt ICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtXTUxdIE5lZWQgdG8gaW1wbGVtZW50IGV4ZWN1dGVUYXNr KCkgaW4gV01MVGFza0VsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ0OTU0CisKKyAgICAgICAgSW1wbGVtZW50IGV4ZWN1dGVUYXNrKCkgYmVj YXVzZSBvZiBidWlsZCBicmVhay4KKworICAgICAgICAqIHdtbC9XTUxUYXNrRWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpXTUxUYXNrRWxlbWVudDo6ZXhlY3V0ZVRhc2spOgorICAgICAg ICAqIHdtbC9XTUxUYXNrRWxlbWVudC5oOgorCiAyMDEwLTA4LTMwICBBbmRyZXkgS29zeWFrb3Yg IDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hh dHNreS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvd21sL1dNTFRhc2tFbGVtZW50LmNwcCBiL1dlYkNv cmUvd21sL1dNTFRhc2tFbGVtZW50LmNwcAppbmRleCBkYzJiMTljLi42ZDZiYmExIDEwMDY0NAot LS0gYS9XZWJDb3JlL3dtbC9XTUxUYXNrRWxlbWVudC5jcHAKKysrIGIvV2ViQ29yZS93bWwvV01M VGFza0VsZW1lbnQuY3BwCkBAIC03OSw2ICs3OSwxMCBAQCB2b2lkIFdNTFRhc2tFbGVtZW50Ojpy ZW1vdmVkRnJvbURvY3VtZW50KCkKICAgICBXTUxFbGVtZW50OjpyZW1vdmVkRnJvbURvY3VtZW50 KCk7CiB9CiAKK3ZvaWQgV01MVGFza0VsZW1lbnQ6OmV4ZWN1dGVUYXNrKCkKK3sKK30KKwogdm9p ZCBXTUxUYXNrRWxlbWVudDo6cmVnaXN0ZXJWYXJpYWJsZVNldHRlcihXTUxTZXR2YXJFbGVtZW50 KiBlbGVtZW50KQogewogICAgIEFTU0VSVChtX3ZhcmlhYmxlU2V0dGVyRWxlbWVudHMuZmluZChl bGVtZW50KSA9PSBXVEY6Om5vdEZvdW5kKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvd21sL1dNTFRh c2tFbGVtZW50LmggYi9XZWJDb3JlL3dtbC9XTUxUYXNrRWxlbWVudC5oCmluZGV4IGI3YzUzNzYu LmRlZWFjZGIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvd21sL1dNTFRhc2tFbGVtZW50LmgKKysrIGIv V2ViQ29yZS93bWwvV01MVGFza0VsZW1lbnQuaApAQCAtNDIsNyArNDIsNyBAQCBwdWJsaWM6CiAK ICAgICB2aXJ0dWFsIHZvaWQgaW5zZXJ0ZWRJbnRvRG9jdW1lbnQoKTsKICAgICB2aXJ0dWFsIHZv aWQgcmVtb3ZlZEZyb21Eb2N1bWVudCgpOwotICAgIHZpcnR1YWwgdm9pZCBleGVjdXRlVGFzaygp ID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgZXhlY3V0ZVRhc2soKTsKIAogICAgIHZvaWQgcmVnaXN0 ZXJWYXJpYWJsZVNldHRlcihXTUxTZXR2YXJFbGVtZW50Kik7CiAgICAgdm9pZCBkZXJlZ2lzdGVy VmFyaWFibGVTZXR0ZXIoV01MU2V0dmFyRWxlbWVudCopOwo= 66837 2010-09-07 20:26:36 -0700 2010-09-08 06:46:40 -0700 Patch patch-wml-task.txt text/plain 1928 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWQ2ZDgwYS4uMWQwMDQwOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0wNyAgR3l1eW91bmcgS2lt ICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtXTUxdIFJlbW92ZSBjcmVhdGUoKSBmdW5jdGlvbiBpbiBX TUxUYXNrRWxlbWVudCBiZWNhdXNlIG9mIGJ1aWxkIGJyZWFrLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ5NTQKKworICAgICAgICBSZW1vdmUgY3Jl YXRlKCkgZnVuY3Rpb24gaW4gV01MVGFza0VsZW1lbnQuY3BwIGJlY2F1c2Ugb2YgYnVpbGQgYnJl YWtzLgorCisgICAgICAgICogd21sL1dNTFRhc2tFbGVtZW50LmNwcDoKKyAgICAgICAgKiB3bWwv V01MVGFza0VsZW1lbnQuaDoKKwogMjAxMC0wOS0wNiAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcu a2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpcmsgU2NodWx6ZS4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvd21sL1dNTFRhc2tFbGVtZW50LmNwcCBiL1dlYkNvcmUvd21sL1dN TFRhc2tFbGVtZW50LmNwcAppbmRleCA0ZWYzNDk2Li5kNDlhMDNlIDEwMDY0NAotLS0gYS9XZWJD b3JlL3dtbC9XTUxUYXNrRWxlbWVudC5jcHAKKysrIGIvV2ViQ29yZS93bWwvV01MVGFza0VsZW1l bnQuY3BwCkBAIC0zOSwxMSArMzksNiBAQCBXTUxUYXNrRWxlbWVudDo6V01MVGFza0VsZW1lbnQo Y29uc3QgUXVhbGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1lbnQqIGRvYykKIHsKIH0KIAotUGFz c1JlZlB0cjxXTUxUYXNrRWxlbWVudD4gV01MVGFza0VsZW1lbnQ6OmNyZWF0ZShjb25zdCBRdWFs aWZpZWROYW1lJiB0YWdOYW1lLCBEb2N1bWVudCogZG9jdW1lbnQpCi17Ci0gICAgcmV0dXJuIGFk b3B0UmVmKG5ldyBXTUxUYXNrRWxlbWVudCh0YWdOYW1lLCBkb2N1bWVudCkpOwotfQotCiBXTUxU YXNrRWxlbWVudDo6fldNTFRhc2tFbGVtZW50KCkKIHsKIH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUv d21sL1dNTFRhc2tFbGVtZW50LmggYi9XZWJDb3JlL3dtbC9XTUxUYXNrRWxlbWVudC5oCmluZGV4 IGI3YzUzNzYuLjkxZTJhMzIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvd21sL1dNTFRhc2tFbGVtZW50 LmgKKysrIGIvV2ViQ29yZS93bWwvV01MVGFza0VsZW1lbnQuaApAQCAtMzMsMTEgKzMzLDYgQEAg Y2xhc3MgV01MU2V0dmFyRWxlbWVudDsKIAogY2xhc3MgV01MVGFza0VsZW1lbnQgOiBwdWJsaWMg V01MRWxlbWVudCB7CiBwdWJsaWM6Ci0gICAgc3RhdGljIFBhc3NSZWZQdHI8V01MVGFza0VsZW1l bnQ+IGNyZWF0ZShjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lLCBEb2N1bWVudCopOwotCi0g ICAgV01MVGFza0VsZW1lbnQoY29uc3QgUXVhbGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1lbnQq KTsKLSAgICB2aXJ0dWFsIH5XTUxUYXNrRWxlbWVudCgpOwotCiAgICAgdmlydHVhbCBib29sIGlz V01MVGFza0VsZW1lbnQoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAKICAgICB2aXJ0dWFsIHZv aWQgaW5zZXJ0ZWRJbnRvRG9jdW1lbnQoKTsKQEAgLTQ4LDYgKzQzLDkgQEAgcHVibGljOgogICAg IHZvaWQgZGVyZWdpc3RlclZhcmlhYmxlU2V0dGVyKFdNTFNldHZhckVsZW1lbnQqKTsKIAogcHJv dGVjdGVkOgorICAgIFdNTFRhc2tFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUs IERvY3VtZW50Kik7CisgICAgdmlydHVhbCB+V01MVGFza0VsZW1lbnQoKTsKKwogICAgIHZvaWQg c3RvcmVWYXJpYWJsZVN0YXRlKFdNTFBhZ2VTdGF0ZSopOwogCiBwcml2YXRlOgo=