44952 2010-08-31 07:54:31 -0700 [WML] Use RenderImageResource in WMLImageElement.cpp 2010-09-06 06:20:37 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned commit-queue oldest_to_newest 272094 0 gyuyoung.kim 2010-08-31 07:54:31 -0700 The hasImage() and setCachedImage() were moved to RenderImageResource class. So, WML also should use the functions from RenderImageResource. 272095 1 66052 gyuyoung.kim 2010-08-31 07:56:57 -0700 Created attachment 66052 Patch 274347 2 gyuyoung.kim 2010-09-03 22:49:28 -0700 Hello Eric Seidel, Could you please review this patch ? It seems nobody uses WML feature in webkit. I'd like to maintain WML continually. 274570 3 66052 krit 2010-09-06 05:46:09 -0700 Comment on attachment 66052 Patch r=me 274582 4 66052 commit-queue 2010-09-06 06:20:32 -0700 Comment on attachment 66052 Patch Clearing flags on attachment: 66052 Committed r66822: <http://trac.webkit.org/changeset/66822> 274583 5 commit-queue 2010-09-06 06:20:37 -0700 All reviewed patches have been landed. Closing bug. 66052 2010-08-31 07:56:57 -0700 2010-09-06 06:20:32 -0700 Patch patch-wml-render.txt text/plain 1544 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTFhYjk5Zi4uZjMzNTEyNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOC0zMSAgR3l1eW91bmcgS2lt ICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtXTUxdIFVzZSBSZW5kZXJJbWFnZVJlc291cmNlIGluIFdN TEltYWdlRWxlbWVudC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQ0OTUyCisKKyAgICAgICAgVGhlIGhhc0ltYWdlKCkgYW5kIHNldENhY2hlZElt YWdlKCkgd2VyZSBtb3ZlZCB0byBSZW5kZXJJbWFnZVJlc291cmNlIGNsYXNzLiAKKyAgICAgICAg U28sIFdNTCBhbHNvIHNob3VsZCB1c2UgdGhlIGZ1bmN0aW9ucyBmcm9tIFJlbmRlckltYWdlUmVz b3VyY2UuCisKKyAgICAgICAgKiB3bWwvV01MSW1hZ2VFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OldNTEltYWdlRWxlbWVudDo6YXR0YWNoKToKKwogMjAxMC0wOC0zMCAgQW5kcmV5IEtv c3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkg U2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3dtbC9XTUxJbWFnZUVsZW1lbnQuY3Bw IGIvV2ViQ29yZS93bWwvV01MSW1hZ2VFbGVtZW50LmNwcAppbmRleCA0YWEzYzY4Li5iZWZhOGQ3 IDEwMDY0NAotLS0gYS9XZWJDb3JlL3dtbC9XTUxJbWFnZUVsZW1lbnQuY3BwCisrKyBiL1dlYkNv cmUvd21sL1dNTEltYWdlRWxlbWVudC5jcHAKQEAgLTEwMSw5ICsxMDEsMTAgQEAgdm9pZCBXTUxJ bWFnZUVsZW1lbnQ6OmF0dGFjaCgpCiAKICAgICBpZiAocmVuZGVyZXIoKSAmJiByZW5kZXJlcigp LT5pc0ltYWdlKCkgJiYgbV9pbWFnZUxvYWRlci5oYXZlRmlyZWRCZWZvcmVMb2FkRXZlbnQoKSkg ewogICAgICAgICBSZW5kZXJJbWFnZSogaW1hZ2VPYmogPSB0b1JlbmRlckltYWdlKHJlbmRlcmVy KCkpOwotICAgICAgICBpZiAoaW1hZ2VPYmotPmhhc0ltYWdlKCkpCisgICAgICAgIFJlbmRlcklt YWdlUmVzb3VyY2UqIHJlbmRlckltYWdlUmVzb3VyY2UgPSBpbWFnZU9iai0+aW1hZ2VSZXNvdXJj ZSgpOworICAgICAgICBpZiAocmVuZGVySW1hZ2VSZXNvdXJjZS0+aGFzSW1hZ2UoKSkKICAgICAg ICAgICAgIHJldHVybjsKLSAgICAgICAgaW1hZ2VPYmotPnNldENhY2hlZEltYWdlKG1faW1hZ2VM b2FkZXIuaW1hZ2UoKSk7CisgICAgICAgIHJlbmRlckltYWdlUmVzb3VyY2UtPnNldENhY2hlZElt YWdlKG1faW1hZ2VMb2FkZXIuaW1hZ2UoKSk7CiAgICAgICAgIAogICAgICAgICAvLyBJZiB3ZSBo YXZlIG5vIGltYWdlIGF0IGFsbCBiZWNhdXNlIHdlIGhhdmUgbm8gc3JjIGF0dHJpYnV0ZSwgc2V0 CiAgICAgICAgIC8vIGltYWdlIGhlaWdodCBhbmQgd2lkdGggZm9yIHRoZSBhbHQgdGV4dCBpbnN0 ZWFkLgo=