44951 2010-08-31 07:50:29 -0700 [GStreamer] can't play m4v videos 2010-09-02 01:23:17 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://www.robwinters.co.uk/lab/html5/video/basic.htm P2 Normal --- 1 pnormand webkit-unassigned abarth eric.carlson eric webkit.review.bot oldest_to_newest 272093 0 pnormand 2010-08-31 07:50:29 -0700 The typefind factory for m4v is not advertised as video/x-m4v but as video/mpeg. In this case I see no other option but check the file extensions registered by the factory and if we find the m4v extension, add "video/x-m4v" to our hash table of supported media types. 272107 1 66056 pnormand 2010-08-31 08:16:53 -0700 Created attachment 66056 proposed patch 272433 2 66056 eric.carlson 2010-08-31 15:22:21 -0700 Comment on attachment 66056 proposed patch > + * media/media-can-play-mpeg-video-expected.txt: Added. > + * media/media-can-play-mpeg-video.html: Added. The test name should probably change because it is testing for MPEG-4 support and "mpeg" can mean MPEG-1. > + <p>Test HTMLMediaElement <em>canPlayType()</em> method with > + multiple video mpeg MIME types.</p> > + This is incorrect because you you only test for "video/x-m4v", but you might as well add a test for the standard type as well. r=me with these minor changes. 272666 3 pnormand 2010-09-01 00:08:03 -0700 (In reply to comment #2) > (From update of attachment 66056 [details]) > > > + * media/media-can-play-mpeg-video-expected.txt: Added. > > + * media/media-can-play-mpeg-video.html: Added. > The test name should probably change because it is testing for MPEG-4 support and "mpeg" can mean MPEG-1. > > > > + <p>Test HTMLMediaElement <em>canPlayType()</em> method with > > + multiple video mpeg MIME types.</p> > > + > This is incorrect because you you only test for "video/x-m4v", but you might as well add a test for the standard type as well. > > r=me with these minor changes. What if I add tests for video/mp4 and video/mpeg? Wouldn't hurt either ;) 273001 4 pnormand 2010-09-01 14:06:41 -0700 Sorry I thought you were CC'ed already. Can you reply to comment 3 please? Thanks :) 273022 5 eric.carlson 2010-09-01 14:31:23 -0700 > What if I add tests for video/mp4 and video/mpeg? Wouldn't hurt either ;) I think adding a test for "video/mp4" is a good idea, but a test for "video/mpeg" isn't a good idea because not all ports that support MPEG-4 video support MPEG-1 video (eg. Chrome). 273240 6 pnormand 2010-09-02 00:08:51 -0700 Landed in http://trac.webkit.org/changeset/66646 I renamed the test to mention mpeg4 and added a test for video/mp4 Thanks! 273250 7 webkit.review.bot 2010-09-02 01:18:29 -0700 http://trac.webkit.org/changeset/66646 might have broken Qt Linux Release 273254 8 pnormand 2010-09-02 01:23:17 -0700 (In reply to comment #7) > http://trac.webkit.org/changeset/66646 might have broken Qt Linux Release See bug 45093 66056 2010-08-31 08:16:53 -0700 2010-08-31 15:22:21 -0700 proposed patch proposed-patch.patch text/plain 4901 pnormand RnJvbSBkNzRjMjY0MTFjMmFjNWI4M2QyZmU1NzMwMmQ1MzQ1MDk4ODQ1MjQ4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDMxIEF1ZyAyMDEwIDE3OjA5OjQ5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKwogLi4uL21lZGlhL21lZGlhLWNhbi1wbGF5 LW1wZWctdmlkZW8tZXhwZWN0ZWQudHh0ICAgfCAgICA1ICsrKwogTGF5b3V0VGVzdHMvbWVkaWEv bWVkaWEtY2FuLXBsYXktbXBlZy12aWRlby5odG1sICAgfCAgIDI3ICsrKysrKysrKysrKysrKysr KysrCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTUgKysrKysrKysrKysKIC4uLi9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyLmNwcCAgICAgIHwgICAxMSArKysrKysrKwogNSBmaWxlcyBjaGFuZ2VkLCA3MSBpbnNlcnRp b25zKCspLCAwIGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL21l ZGlhL21lZGlhLWNhbi1wbGF5LW1wZWctdmlkZW8tZXhwZWN0ZWQudHh0CiBjcmVhdGUgbW9kZSAx MDA2NDQgTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtY2FuLXBsYXktbXBlZy12aWRlby5odG1sCgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IDVlMTk2ZDMuLjRhODZkN2YgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOC0z MSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dTdHJlYW1lcl0gY2FuJ3QgcGxh eSBtNHYgdmlkZW9zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NDk1MQorCisgICAgICAgIFRlc3Qgc2ltaWxhciB0byBtZWRpYS1jYW4tcGxheS1tcGVn LWF1ZGlvLmh0bWwgYnV0IGZvciB2aWRlb3MuIEZvcgorICAgICAgICBub3cgb25seSBtNHYgdHlw ZSBpcyB0ZXN0ZWQuCisKKyAgICAgICAgKiBtZWRpYS9tZWRpYS1jYW4tcGxheS1tcGVnLXZpZGVv LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbWVkaWEvbWVkaWEtY2FuLXBsYXktbXBl Zy12aWRlby5odG1sOiBBZGRlZC4KKwogMjAxMC0wOC0zMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtY2FuLXBsYXktbXBlZy12aWRlby1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1jYW4tcGxheS1tcGVnLXZpZGVvLWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5lMzRmNjRhCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtY2FuLXBsYXktbXBlZy12aWRlby1l eHBlY3RlZC50eHQKQEAgLTAsMCArMSw1IEBACitUZXN0IEhUTUxNZWRpYUVsZW1lbnQgY2FuUGxh eVR5cGUoKSBtZXRob2Qgd2l0aCBtdWx0aXBsZSB2aWRlbyBtcGVnIE1JTUUgdHlwZXMuCisKK0VY UEVDVEVEICh2aWRlby5jYW5QbGF5VHlwZSgndmlkZW8veC1tNHYnKSA9PSAnbWF5YmUnKSBPSwor RU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtY2FuLXBs YXktbXBlZy12aWRlby5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtY2FuLXBsYXktbXBl Zy12aWRlby5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmU3NGI1YzUK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1jYW4tcGxheS1tcGVn LXZpZGVvLmh0bWwKQEAgLTAsMCArMSwyNyBAQAorPGh0bWw+CisgICAgPGhlYWQ+CisgICAgICAg IDxzdHlsZT4KKyAgICAgICAgICAgIHZpZGVvIHsgYmFja2dyb3VuZC1jb2xvcjogeWVsbG93OyB3 aWR0aDogMzIwcHg7IGhlaWdodDogMjQwcHg7fQorICAgICAgICA8L3N0eWxlPgorICAgICAgICA8 c2NyaXB0IHNyYz12aWRlby10ZXN0LmpzPjwvc2NyaXB0PgorICAgICAgICA8c2NyaXB0PgorICAg ICAgICAgICAgZnVuY3Rpb24gc3RhcnQoKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAg IHZpZGVvID0gbWVkaWFFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3Zp ZGVvJylbMF07CisKKyAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInZpZGVvLmNhblBsYXlU eXBlKCd2aWRlby94LW00dicpIiwgIm1heWJlIik7CisKKyAgICAgICAgICAgICAgICBlbmRUZXN0 KCk7CisgICAgICAgICAgICB9CisgICAgICAgIDwvc2NyaXB0PgorCisgICAgPC9oZWFkPgorICAg IDxib2R5IG9ubG9hZD0ic3RhcnQoKSI+CisKKyAgICAgICAgPHZpZGVvIGNvbnRyb2xzID48L3Zp ZGVvPgorCisgICAgICAgIDxwPlRlc3QgSFRNTE1lZGlhRWxlbWVudCA8ZW0+Y2FuUGxheVR5cGUo KTwvZW0+IG1ldGhvZCB3aXRoCisgICAgICAgIG11bHRpcGxlIHZpZGVvIG1wZWcgTUlNRSB0eXBl cy48L3A+CisKKyAgICA8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDc2MWI2ZmYuLjEzYjI1N2QgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTggQEAKKzIwMTAtMDgtMzEgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHU3Ry ZWFtZXJdIGNhbid0IHBsYXkgbTR2IHZpZGVvcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ5NTEKKworICAgICAgICBGaXhlZCByZWdpc3RyYXRpb24g b2YgdGhlIG00diBtZWRpYSB0eXBlIGluIHRoZSBoYXNodGFibGUgdXNlZCBieQorICAgICAgICB0 aGUgcGxheWVyIHRvIHJlcG9ydCBpZiBpdCBzdXBwb3J0cyBhIGdpdmVuIG1lZGlhIHR5cGUuCisK KyAgICAgICAgVGVzdDogbWVkaWEvbWVkaWEtY2FuLXBsYXktbXBlZy12aWRlby5odG1sCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om1pbWVUeXBlQ2FjaGUpOgorCiAyMDEwLTA4 LTMxICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUBwYXJvZ2EuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggZDlkMmQ5Ny4uNTYyOGViMyAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuY3BwCkBAIC0xMjM5LDYgKzEyMzksNyBAQCBzdGF0aWMgSGFz aFNldDxTdHJpbmc+IG1pbWVUeXBlQ2FjaGUoKQogICAgICAgICBmb3IgKEdMaXN0KiBpdGVyYXRv ciA9IGZhY3RvcmllczsgaXRlcmF0b3I7IGl0ZXJhdG9yID0gaXRlcmF0b3ItPm5leHQpIHsKICAg ICAgICAgICAgIEdzdFR5cGVGaW5kRmFjdG9yeSogZmFjdG9yeSA9IEdTVF9UWVBFX0ZJTkRfRkFD VE9SWShpdGVyYXRvci0+ZGF0YSk7CiAgICAgICAgICAgICBHc3RDYXBzKiBjYXBzID0gZ3N0X3R5 cGVfZmluZF9mYWN0b3J5X2dldF9jYXBzKGZhY3RvcnkpOworICAgICAgICAgICAgZ2NoYXIqKiBl eHRlbnNpb25zOwogCiAgICAgICAgICAgICBpZiAoIWNhcHMpCiAgICAgICAgICAgICAgICAgY29u dGludWU7CkBAIC0xMzE2LDYgKzEzMTcsMTYgQEAgc3RhdGljIEhhc2hTZXQ8U3RyaW5nPiBtaW1l VHlwZUNhY2hlKCkKIAogICAgICAgICAgICAgICAgICAgICBnX3N0cmZyZWV2KG1pbWV0eXBlKTsK ICAgICAgICAgICAgICAgICB9CisKKyAgICAgICAgICAgICAgICAvLyBBcyBhIGxhc3QgcmVzb3J0 IHRyeSBzb21lIHNwZWNpYWwgY2FzZXMgZGVwZW5kaW5nCisgICAgICAgICAgICAgICAgLy8gb24g dGhlIGZpbGUgZXh0ZW5zaW9ucyByZWdpc3RlcmVkIHdpdGggdGhlIHR5cGVmaW5kCisgICAgICAg ICAgICAgICAgLy8gZmFjdG9yeS4KKyAgICAgICAgICAgICAgICBpZiAoIWNhY2hlZCAmJiAoZXh0 ZW5zaW9ucyA9IGdzdF90eXBlX2ZpbmRfZmFjdG9yeV9nZXRfZXh0ZW5zaW9ucyhmYWN0b3J5KSkp IHsKKyAgICAgICAgICAgICAgICAgICAgZm9yIChpbnQgaW5kZXggPSAwOyBleHRlbnNpb25zW2lu ZGV4XTsgaW5kZXgrKykgeworICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGdfc3RyX2VxdWFs KGV4dGVuc2lvbnNbaW5kZXhdLCAibTR2IikpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y2FjaGUuYWRkKFN0cmluZygidmlkZW8veC1tNHYiKSk7CisgICAgICAgICAgICAgICAgICAgIH0K KyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAotLSAKMS43LjE=