44936 2010-08-31 02:35:05 -0700 [reviewtool] Allow reviewer to select lines of context by dragging over the line numbers 2010-08-31 12:07:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth eric zimmermann oldest_to_newest 271991 0 abarth 2010-08-31 02:35:05 -0700 [reviewtool] Allow reviewer to select lines of context by dragging over the line numbers 271994 1 66024 abarth 2010-08-31 02:37:33 -0700 Created attachment 66024 Patch 271995 2 66024 eric 2010-08-31 02:38:52 -0700 Comment on attachment 66024 Patch LGTM! So exciting. 271996 3 abarth 2010-08-31 02:40:19 -0700 Committed r66471: <http://trac.webkit.org/changeset/66471> 272005 4 zimmermann 2010-08-31 03:06:27 -0700 Great work Adam, that's the stuff I was missing most! Now we should just move it over to "Review patch" :-) 272264 5 abarth 2010-08-31 12:07:25 -0700 (In reply to comment #4) > Great work Adam, that's the stuff I was missing most! Thanks! :) > Now we should just move it over to "Review patch" :-) Let me polish a few things first. The delete button is way too inviting currently. I delete my comments way too often. Also, I need to get Darin on board before removing the existing "review patch." 66024 2010-08-31 02:37:33 -0700 2010-08-31 02:38:52 -0700 Patch bug-44936-20100831023731.patch text/plain 4575 abarth SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY2NDcwKQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDgtMzEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb cmV2aWV3dG9vbF0gQWxsb3cgcmV2aWV3ZXIgdG8gc2VsZWN0IGxpbmVzIG9mIGNvbnRleHQgYnkg ZHJhZ2dpbmcgb3ZlciB0aGUgbGluZSBudW1iZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDkzNgorCisgICAgICAgICogUHJldHR5UGF0Y2gvUHJl dHR5UGF0Y2gucmI6CisgICAgICAgICAgICAtIEFkZCBhIHZlcnNpb24gbnVtYmVyIHRvIGJ1c3Qg dGhyb3VnaCBidWdzLndlYmtpdC5vcmcncyBhZ2dyZXNzaXZlCisgICAgICAgICAgICAgIGNhY2hl aW5nLgorICAgICAgICAqIGNvZGUtcmV2aWV3LmpzOgorCiAyMDEwLTA4LTMwICBBZGFtIEJhcnRo ICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwu CkluZGV4OiBCdWdzU2l0ZS9jb2RlLXJldmlldy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9j b2RlLXJldmlldy5qcwkocmV2aXNpb24gNjY0NjIpCisrKyBCdWdzU2l0ZS9jb2RlLXJldmlldy5q cwkod29ya2luZyBjb3B5KQpAQCAtNjMsMjIgKzYzLDI0IEBACiAgICAgZmluZENvbW1lbnRQb3Np dGlvbkZvcihsaW5lKS5hZnRlcihibG9jayk7CiAgIH0KIAotICBmdW5jdGlvbiBhZGRDb21tZW50 RmllbGQoKSB7Ci0gICAgdmFyIGlkID0gJCh0aGlzKS5hdHRyKCdkYXRhLWNvbW1lbnQtZm9yJyk7 Ci0gICAgaWYgKCFpZCkgewotICAgICAgaWQgPSB0aGlzLmlkOwotICAgICAgJCh0aGlzKS5hZGRD bGFzcygnY29tbWVudENvbnRleHQnKTsKLSAgICB9Ci0gICAgdmFyIGxpbmUgPSAkKCcjJyArIGlk KTsKKyAgZnVuY3Rpb24gYWRkQ29tbWVudEZvcihsaW5lKSB7CiAgICAgaWYgKGxpbmUuYXR0cign ZGF0YS1oYXMtY29tbWVudCcpKQogICAgICAgcmV0dXJuOwogICAgIGxpbmUuYXR0cignZGF0YS1o YXMtY29tbWVudCcsICd0cnVlJyk7CisgICAgbGluZS5hZGRDbGFzcygnY29tbWVudENvbnRleHQn KTsKIAotICAgIHZhciBjb21tZW50X2Jsb2NrID0gJCgnPGRpdiBjbGFzcz0iY29tbWVudCI+PHRl eHRhcmVhIGRhdGEtY29tbWVudC1mb3I9IicgKyBpZCArICciPjwvdGV4dGFyZWE+PGRpdiBjbGFz cz0iYWN0aW9ucyI+PGJ1dHRvbiBjbGFzcz0iZGVsZXRlIj5EZWxldGU8L2J1dHRvbj48L2Rpdj48 L2Rpdj4nKTsKKyAgICB2YXIgY29tbWVudF9ibG9jayA9ICQoJzxkaXYgY2xhc3M9ImNvbW1lbnQi Pjx0ZXh0YXJlYSBkYXRhLWNvbW1lbnQtZm9yPSInICsgbGluZS5hdHRyKCdpZCcpICsgJyI+PC90 ZXh0YXJlYT48ZGl2IGNsYXNzPSJhY3Rpb25zIj48YnV0dG9uIGNsYXNzPSJkZWxldGUiPkRlbGV0 ZTwvYnV0dG9uPjwvZGl2PjwvZGl2PicpOwogICAgIGluc2VydENvbW1lbnRGb3IobGluZSwgY29t bWVudF9ibG9jayk7CiAgICAgY29tbWVudF9ibG9jay5jaGlsZHJlbigndGV4dGFyZWEnKS5mb2N1 cygpOwogICB9CiAKKyAgZnVuY3Rpb24gYWRkQ29tbWVudEZpZWxkKCkgeworICAgIHZhciBpZCA9 ICQodGhpcykuYXR0cignZGF0YS1jb21tZW50LWZvcicpOworICAgIGlmICghaWQpCisgICAgICBp ZCA9IHRoaXMuaWQ7CisgICAgYWRkQ29tbWVudEZvcigkKCcjJyArIGlkKSk7CisgIH0KKwogICBm dW5jdGlvbiBkaXNwbGF5UHJldmlvdXNDb21tZW50cygpIHsKICAgICBjb21tZW50X2NvbGxlY3Rp b24gPSB0aGlzOwogICAgIGZvckVhY2hMaW5lKGZ1bmN0aW9uKGxpbmUpIHsKQEAgLTEzMCwyNiAr MTMyLDQ4IEBACiAgICAgfQogICB9CiAKLSAgZnVuY3Rpb24gdHJ5VG9FeHBhbmRDb21tZW50Q29u dGV4dFRvKGxpbmUpIHsKLSAgICB2YXIgY29udGV4dF9saW5lID0gbGluZTsKLSAgICB3aGlsZSAo Y29udGV4dF9saW5lLmxlbmd0aCAhPSAwKSB7Ci0gICAgICBjb250ZXh0X2xpbmUgPSBjb250ZXh0 X2xpbmUubmV4dCgpOwotICAgICAgaWYgKGNvbnRleHRfbGluZS5oYXNDbGFzcygnY29tbWVudENv bnRleHQnKSkKLSAgICAgICAgYnJlYWs7Ci0gICAgfQotICAgIGlmIChjb250ZXh0X2xpbmUubGVu Z3RoID09IDApCi0gICAgICByZXR1cm47IC8vIE5vIGNvbW1lbnQgY29udGV4dCB0byBleHBhbmQu Ci0gICAgbGluZS5hZGRDbGFzcygnY29tbWVudENvbnRleHQnKS5uZXh0VW50aWwoJy5jb21tZW50 Q29udGV4dCcpLmFkZENsYXNzKCdjb21tZW50Q29udGV4dCcpOworICB2YXIgaW5fZHJhZ19zZWxl Y3QgPSBmYWxzZTsKKworICBmdW5jdGlvbiBzdG9wRHJhZ1NlbGVjdCgpIHsKKyAgICAkKCcuc2Vs ZWN0ZWQnKS5yZW1vdmVDbGFzcygnc2VsZWN0ZWQnKTsKKyAgICBpbl9kcmFnX3NlbGVjdCA9IGZh bHNlOwogICB9CiAKICAgJCgnLmxpbmVOdW1iZXInKS5saXZlKCdjbGljaycsIGZ1bmN0aW9uKCkg ewogICAgIHZhciBsaW5lID0gJCh0aGlzKS5wYXJlbnQoKTsKICAgICBpZiAobGluZS5oYXNDbGFz cygnY29tbWVudENvbnRleHQnKSkKICAgICAgIHRyaW1Db21tZW50Q29udGV4dFRvQmVmb3JlKGxp bmUucHJldigpKTsKLSAgICBlbHNlCi0gICAgICB0cnlUb0V4cGFuZENvbW1lbnRDb250ZXh0VG8o bGluZSk7CisgIH0pLmxpdmUoJ21vdXNlZG93bicsIGZ1bmN0aW9uKCkgeworICAgIGluX2RyYWdf c2VsZWN0ID0gdHJ1ZTsKKyAgICAkKHRoaXMpLnBhcmVudCgpLmFkZENsYXNzKCdzZWxlY3RlZCcp OworICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CisgIH0pOworICAKKyAgJCgnLkxpbmUnKS5s aXZlKCdtb3VzZWVudGVyJywgZnVuY3Rpb24oKSB7CisgICAgaWYgKCFpbl9kcmFnX3NlbGVjdCkK KyAgICAgIHJldHVybjsKKworICAgIHZhciBiZWZvcmUgPSAkKHRoaXMpLnByZXZVbnRpbCgnLnNl bGVjdGVkJykKKyAgICBpZiAoYmVmb3JlLnByZXYoKS5oYXNDbGFzcygnc2VsZWN0ZWQnKSkKKyAg ICAgIGJlZm9yZS5hZGRDbGFzcygnc2VsZWN0ZWQnKTsKKworICAgIHZhciBhZnRlciA9ICQodGhp cykubmV4dFVudGlsKCcuc2VsZWN0ZWQnKQorICAgIGlmIChhZnRlci5uZXh0KCkuaGFzQ2xhc3Mo J3NlbGVjdGVkJykpCisgICAgICBhZnRlci5hZGRDbGFzcygnc2VsZWN0ZWQnKTsKKworICAgICQo dGhpcykuYWRkQ2xhc3MoJ3NlbGVjdGVkJyk7CisgIH0pLmxpdmUoJ21vdXNldXAnLCBmdW5jdGlv bigpIHsKKyAgICBpZiAoIWluX2RyYWdfc2VsZWN0KQorICAgICAgcmV0dXJuOworICAgIHZhciBz ZWxlY3RlZCA9ICQoJy5zZWxlY3RlZCcpOworICAgIHZhciBzaG91bGRfYWRkX2NvbW1lbnQgPSAh c2VsZWN0ZWQubGFzdCgpLm5leHQoKS5oYXNDbGFzcygnY29tbWVudENvbnRleHQnKTsKKyAgICBz ZWxlY3RlZC5hZGRDbGFzcygnY29tbWVudENvbnRleHQnKTsKKyAgICBpZiAoc2hvdWxkX2FkZF9j b21tZW50KQorICAgICAgYWRkQ29tbWVudEZvcihzZWxlY3RlZC5sYXN0KCkpOwogICB9KTsKIAor ICAkKCcuRGlmZlNlY3Rpb24nKS5saXZlKCdtb3VzZWxlYXZlJywgc3RvcERyYWdTZWxlY3QpLmxp dmUoJ21vdXNldXAnLCBzdG9wRHJhZ1NlbGVjdCk7CisKICAgZnVuY3Rpb24gY29udGV4dFNuaXBw ZXRGb3IobGluZSkgewogICAgIHZhciBzbmlwcGV0cyA9IFtdCiAgICAgY29udGV4dExpbmVzRm9y KGxpbmUpLmVhY2goZnVuY3Rpb24oKSB7CkluZGV4OiBCdWdzU2l0ZS9QcmV0dHlQYXRjaC9QcmV0 dHlQYXRjaC5yYgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9QcmV0dHlQYXRjaC9QcmV0dHlQYXRj aC5yYgkocmV2aXNpb24gNjY0NjIpCisrKyBCdWdzU2l0ZS9QcmV0dHlQYXRjaC9QcmV0dHlQYXRj aC5yYgkod29ya2luZyBjb3B5KQpAQCAtMjY5LDkgKzI2OSwxNSBAQCBib2R5IHsKIC5jb21tZW50 Q29udGV4dCAubGluZU51bWJlciB7CiAgIGJhY2tncm91bmQtY29sb3I6IHllbGxvdzsKIH0KKwor LnNlbGVjdGVkIC5saW5lTnVtYmVyIHsKKyAgYmFja2dyb3VuZC1jb2xvcjogIzY5RjsKKyAgYm9y ZGVyLWJvdHRvbS1jb2xvcjogIzY5RjsKKyAgYm9yZGVyLXJpZ2h0LWNvbG9yOiAjNjlGOworfQog PC9zdHlsZT4KIDxzY3JpcHQgc3JjPSJodHRwczovL2FqYXguZ29vZ2xlYXBpcy5jb20vYWpheC9s aWJzL2pxdWVyeS8xLjQuMi9qcXVlcnkubWluLmpzIj48L3NjcmlwdD4gCi08c2NyaXB0IHNyYz0i Y29kZS1yZXZpZXcuanMiPjwvc2NyaXB0PiAKKzxzY3JpcHQgc3JjPSJjb2RlLXJldmlldy5qcz92 ZXJzaW9uPTMiPjwvc2NyaXB0PiAKIEVPRgogCiAgICAgZGVmIHNlbGYucmV2aXNpb25PckRlc2Ny aXB0aW9uKHN0cmluZykK