44931 2010-08-30 23:36:41 -0700 [EFL] Add setting API for enabling page cache. 2010-09-13 15:05:48 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned antognolli+webkit commit-queue kenneth lucas.de.marchi tonikitoo oldest_to_newest 271951 0 gyuyoung.kim 2010-08-30 23:36:41 -0700 Add APIs to enable / disable page cache. 271954 1 66017 gyuyoung.kim 2010-08-30 23:42:39 -0700 Created attachment 66017 Patch 271998 2 66017 kenneth 2010-08-31 02:51:46 -0700 Comment on attachment 66017 Patch > +Eina_Bool ewk_view_setting_page_cache_get(Evas_Object* o) why not page_cache_enabled? it returns a bool not a page cache! 272015 3 gyuyoung.kim 2010-08-31 03:29:12 -0700 (In reply to comment #2) > (From update of attachment 66017 [details]) > > > +Eina_Bool ewk_view_setting_page_cache_get(Evas_Object* o) > > why not page_cache_enabled? it returns a bool not a page cache! The ewk_view_setting_page_cache_get() just returns if page cache feature is enabled or not. This method doesn't return page cache. In ewk_view.cpp, settings features like local_storage also have similar method. Eina_Bool ewk_view_setting_spatial_navigation_get(Evas_Object* o) { EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE); EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE); return priv->settings.spatial_navigation; } Eina_Bool ewk_view_setting_local_storage_get(Evas_Object* o) { EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE); EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE); return priv->settings.local_storage; } ... I add a doxyzen for the method. However, if the naming can make confusion, I change the name. 278010 4 kenneth 2010-09-13 00:01:09 -0700 What do you EFL guys think? 278380 5 antognolli+webkit 2010-09-13 12:14:36 -0700 (In reply to comment #4) > What do you EFL guys think? The naming is really not the best one, but as Gyuyoung told, it's following other ewk_view_setting functions. Maybe we should make a big change on all of them? Anyway, the patch looks good to me. 278445 6 66017 kenneth 2010-09-13 13:44:49 -0700 Comment on attachment 66017 Patch We can change the method names as a separate patch 278498 7 66017 commit-queue 2010-09-13 15:05:43 -0700 Comment on attachment 66017 Patch Clearing flags on attachment: 66017 Committed r67413: <http://trac.webkit.org/changeset/67413> 278499 8 commit-queue 2010-09-13 15:05:48 -0700 All reviewed patches have been landed. Closing bug. 66017 2010-08-30 23:42:39 -0700 2010-09-13 15:05:43 -0700 Patch patch-pagecache.txt text/plain 4067 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggODM5OWNlOS4uZDc3M2M5ZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOC0zMCAg R3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEFkZCBzZXR0aW5nIEFQSSBm b3IgZW5hYmxpbmcgcGFnZSBjYWNoZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDQ5MzEKKworICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAg ICAgIChfZXdrX3ZpZXdfcHJpdl9uZXcpOgorICAgICAgICAoZXdrX3ZpZXdfc2V0dGluZ19wYWdl X2NhY2hlX2dldCk6IEFkZGVkLgorICAgICAgICAoZXdrX3ZpZXdfc2V0dGluZ19wYWdlX2NhY2hl X3NldCk6IEFkZGVkLgorICAgICAgICAqIGV3ay9ld2tfdmlldy5oOgorCiAyMDEwLTA4LTMwICBL YW1pbCBCbGFuayAgPGsuYmxhbmtAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1dl YktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCA3MDkyZDhjLi41MjBjOWEyIDEwMDY0NAot LS0gYS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvV2ViS2l0L2VmbC9ld2svZXdr X3ZpZXcuY3BwCkBAIC0xMTIsNiArMTEyLDcgQEAgc3RydWN0IF9Fd2tfVmlld19Qcml2YXRlX0Rh dGEgewogICAgICAgICBFaW5hX0Jvb2wgc3BhdGlhbF9uYXZpZ2F0aW9uOjE7CiAgICAgICAgIEVp bmFfQm9vbCBsb2NhbF9zdG9yYWdlOjE7CiAgICAgICAgIEVpbmFfQm9vbCBvZmZsaW5lX2FwcF9j YWNoZTogMTsKKyAgICAgICAgRWluYV9Cb29sIHBhZ2VfY2FjaGU6IDE7CiAgICAgICAgIHN0cnVj dCB7CiAgICAgICAgICAgICBmbG9hdCB3OwogICAgICAgICAgICAgZmxvYXQgaDsKQEAgLTU2NSw2 ICs1NjYsNyBAQCBzdGF0aWMgRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhKiBfZXdrX3ZpZXdfcHJpdl9u ZXcoRXdrX1ZpZXdfU21hcnRfRGF0YSogc2QpCiAgICAgcHJpdi0+cGFnZV9zZXR0aW5ncy0+c2V0 UGx1Z2luc0VuYWJsZWQodHJ1ZSk7CiAgICAgcHJpdi0+cGFnZV9zZXR0aW5ncy0+c2V0TG9jYWxT dG9yYWdlRW5hYmxlZCh0cnVlKTsKICAgICBwcml2LT5wYWdlX3NldHRpbmdzLT5zZXRPZmZsaW5l V2ViQXBwbGljYXRpb25DYWNoZUVuYWJsZWQodHJ1ZSk7CisgICAgcHJpdi0+cGFnZV9zZXR0aW5n cy0+c2V0VXNlc1BhZ2VDYWNoZSh0cnVlKTsKIAogICAgIHVybCA9IHByaXYtPnBhZ2Vfc2V0dGlu Z3MtPnVzZXJTdHlsZVNoZWV0TG9jYXRpb24oKTsKICAgICBwcml2LT5zZXR0aW5ncy51c2VyX3N0 eWxlc2hlZXQgPSBlaW5hX3N0cmluZ3NoYXJlX2FkZCh1cmwucHJldHR5VVJMKCkudXRmOCgpLmRh dGEoKSk7CkBAIC02MDUsNiArNjA3LDcgQEAgc3RhdGljIEV3a19WaWV3X1ByaXZhdGVfRGF0YSog X2V3a192aWV3X3ByaXZfbmV3KEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNkKQogICAgIHByaXYtPnNl dHRpbmdzLmNhcmV0X2Jyb3dzaW5nID0gcHJpdi0+cGFnZV9zZXR0aW5ncy0+Y2FyZXRCcm93c2lu Z0VuYWJsZWQoKTsKICAgICBwcml2LT5zZXR0aW5ncy5sb2NhbF9zdG9yYWdlID0gcHJpdi0+cGFn ZV9zZXR0aW5ncy0+bG9jYWxTdG9yYWdlRW5hYmxlZCgpOwogICAgIHByaXYtPnNldHRpbmdzLm9m ZmxpbmVfYXBwX2NhY2hlID0gdHJ1ZTsgLy8gWFhYIG5vIGZ1bmN0aW9uIHRvIHJlYWQgc2V0dGlu ZzsgdGhpcyBrZWVwcyB0aGUgb3JpZ2luYWwgc2V0dGluZworICAgIHByaXYtPnNldHRpbmdzLnBh Z2VfY2FjaGUgPSBwcml2LT5wYWdlX3NldHRpbmdzLT51c2VzUGFnZUNhY2hlKCk7CiAKICAgICAv LyBTaW5jZSB0aGVyZSdzIG5vIHNjYWxlIHNlcGFyYXRlZCBmcm9tIHpvb21pbmcgaW4gd2Via2l0 LWVmbCwgdGhpcyBmdW5jdGlvbmFsaXR5IG9mCiAgICAgLy8gdmlld3BvcnQgbWV0YSB0YWcgaXMg aW1wbGVtZW50ZWQgdXNpbmcgem9vbS4gV2hlbiBzY2FsZSB6b29tIGlzIHN1cHBvcnRlZCBieSB3 ZWJraXQtZWZsLApAQCAtMjc0Niw2ICsyNzQ5LDM3IEBAIEVpbmFfQm9vbCBld2tfdmlld19zZXR0 aW5nX2xvY2FsX3N0b3JhZ2Vfc2V0KEV2YXNfT2JqZWN0KiBvLCBFaW5hX0Jvb2wgZW5hYmxlKQog fQogCiAvKioKKyAqIEdldHMgaWYgdGhlIHBhZ2UgY2FjaGUgaXMgZW5hYmxlZC4KKyAqCisgKiBA cGFyYW0gbyB2aWV3IG9iamVjdCB0byBzZXQgaWYgcGFnZSBjYWNoZSBpcyBlbmFibGVkLgorICog QHJldHVybiBAYyBFSU5BX1RSVUUgaWYgcGFnZSBjYWNoZSBpcyBlbmFibGVkLCBAYyBFSU5BX0ZB TFNFIGlmIG5vdC4KKyAqLworRWluYV9Cb29sIGV3a192aWV3X3NldHRpbmdfcGFnZV9jYWNoZV9n ZXQoRXZhc19PYmplY3QqIG8pCit7CisgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihvLCBz ZCwgRUlOQV9GQUxTRSk7CisgICAgRVdLX1ZJRVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNkLCBwcml2 LCBFSU5BX0ZBTFNFKTsKKyAgICByZXR1cm4gcHJpdi0+c2V0dGluZ3MucGFnZV9jYWNoZTsKK30K KworLyoqCisgKiBTZXRzIHRoZSBwYWdlIGNhY2hlLgorICoKKyAqIEBwYXJhbSBvIHZpZXcgb2Jq ZWN0IHRvIHNldCBpZiBwYWdlIGNhY2hlIGlzIGVuYWJsZWQuCisgKiBAcmV0dXJuIEBjIEVJTkFf VFJVRSBvbiBzdWNjZXNzIGFuZCBAYyBFSU5BX0ZBTFNFIG9uIGZhaWx1cmUKKyAqLworRWluYV9C b29sIGV3a192aWV3X3NldHRpbmdfcGFnZV9jYWNoZV9zZXQoRXZhc19PYmplY3QqIG8sIEVpbmFf Qm9vbCBlbmFibGUpCit7CisgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihvLCBzZCwgRUlO QV9GQUxTRSk7CisgICAgRVdLX1ZJRVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNkLCBwcml2LCBFSU5B X0ZBTFNFKTsKKyAgICBlbmFibGUgPSAhIWVuYWJsZTsKKyAgICBpZiAocHJpdi0+c2V0dGluZ3Mu cGFnZV9jYWNoZSAhPSBlbmFibGUpIHsKKyAgICAgICAgcHJpdi0+cGFnZV9zZXR0aW5ncy0+c2V0 VXNlc1BhZ2VDYWNoZShlbmFibGUpOworICAgICAgICBwcml2LT5zZXR0aW5ncy5wYWdlX2NhY2hl ID0gZW5hYmxlOworICAgIH0KKyAgICByZXR1cm4gRUlOQV9UUlVFOworfQorCisvKioKICAqIFNp bWlsYXIgdG8gZXZhc19vYmplY3Rfc21hcnRfZGF0YV9nZXQoKSwgYnV0IGRvZXMgdHlwZSBjaGVj a2luZy4KICAqCiAgKiBAcGFyYW0gbyB2aWV3IG9iamVjdCB0byBxdWVyeSBpbnRlcm5hbCBkYXRh LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaCBiL1dlYktpdC9lZmwvZXdr L2V3a192aWV3LmgKaW5kZXggYzVkMmQ0NS4uYmUyN2Y2OCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Vm bC9ld2svZXdrX3ZpZXcuaAorKysgYi9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCkBAIC00NTAs NiArNDUwLDkgQEAgRUFQSSBFaW5hX0Jvb2wgICAgZXdrX3ZpZXdfc2V0dGluZ19zcGF0aWFsX25h dmlnYXRpb25fc2V0KEV2YXNfT2JqZWN0KiBvLCBFaW5hX0IKIEVBUEkgRWluYV9Cb29sICAgIGV3 a192aWV3X3NldHRpbmdfbG9jYWxfc3RvcmFnZV9nZXQoRXZhc19PYmplY3QqIG8pOwogRUFQSSBF aW5hX0Jvb2wgICAgZXdrX3ZpZXdfc2V0dGluZ19sb2NhbF9zdG9yYWdlX3NldChFdmFzX09iamVj dCogbywgRWluYV9Cb29sIGVuYWJsZSk7CiAKK0VBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X3Nl dHRpbmdfcGFnZV9jYWNoZV9nZXQoRXZhc19PYmplY3QqIG8pOworRUFQSSBFaW5hX0Jvb2wgICAg ZXdrX3ZpZXdfc2V0dGluZ19wYWdlX2NhY2hlX3NldChFdmFzX09iamVjdCogbywgRWluYV9Cb29s IGVuYWJsZSk7CisKIC8qIHRvIGJlIHVzZWQgYnkgc3ViY2xhc3MgaW1wbGVtZW50YXRpb25zICov CiBFQVBJIEV3a19WaWV3X1NtYXJ0X0RhdGEgKmV3a192aWV3X3NtYXJ0X2RhdGFfZ2V0KGNvbnN0 IEV2YXNfT2JqZWN0ICpvKTsKIAo=