4493 2005-08-17 08:59:26 -0700 add qualifiedName checking for empty string 2019-02-06 09:02:52 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 4565 1 darin darin adele andersca cdumez curt.arnold mjs oldest_to_newest 16861 0 darin 2005-08-17 08:59:26 -0700 16863 1 3438 darin 2005-08-17 09:00:48 -0700 Created attachment 3438 adds code that knows that an empty qualified name is not valid 16876 2 3438 darin 2005-08-17 11:42:03 -0700 Comment on attachment 3438 adds code that knows that an empty qualified name is not valid Adele and Maciej are looking into this. The DOM specification clearly doesn't call for INVALID_CHARACTER_ERR in the case of an empty string, so we're trying to learn more about the conference call where someone decided this was correct behavior. 18541 3 darin 2005-09-03 12:53:23 -0700 This bug affects these tests: dom/html/level2/core/createDocument08.html dom/html/level2/core/createDocumentType04.html 18775 4 darin 2005-09-05 15:23:48 -0700 Looks like this is definitely correct for DOM Level 3 and arguably OK for Level 2, so we're going to make the change. 18787 5 mjs 2005-09-05 22:27:58 -0700 This behavior not even arguably ok for level 2, barring a possible future change to the level 2 spec. It likely doesn't matter for any real-world cases, but it seems silly to make a change for a test that isn't testing what it says it is. 18810 6 darin 2005-09-06 09:25:30 -0700 OK. Maciej, you're welcome to change this back, or resolve the problem in whatever other way you see fit. Since I didn't get any comment from you on this for a couple of weeks, I mistakenly thought you agreed with Curt that this should just be changed in our code. 1502859 7 lforschler 2019-02-06 09:02:52 -0800 Mass moving XML DOM bugs to the "DOM" Component. 3438 2005-08-17 09:00:48 -0700 2005-09-05 11:40:41 -0700 adds code that knows that an empty qualified name is not valid QualifiedNameEmptyPatch.txt text/plain 4610 darin SW5kZXg6IGtodG1sL3htbC9kb21fZG9jaW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2 cy9yb290L1dlYkNvcmUva2h0bWwveG1sL2RvbV9kb2NpbXBsLmNwcCx2CnJldHJpZXZpbmcgcmV2 aXNpb24gMS4yNDQKZGlmZiAtcCAtdSAtcjEuMjQ0IGtodG1sL3htbC9kb21fZG9jaW1wbC5jcHAK LS0tIGtodG1sL3htbC9kb21fZG9jaW1wbC5jcHAJOSBBdWcgMjAwNSAyMTo1NDoxMyAtMDAwMAkx LjI0NAorKysga2h0bWwveG1sL2RvbV9kb2NpbXBsLmNwcAkxNyBBdWcgMjAwNSAxNTo1NzowOSAt MDAwMApAQCAtMTA0LDYgKzEwNCwyMyBAQCBjb25zdCBpbnQgY0xheW91dFNjaGVkdWxlVGhyZXNo b2xkID0gMjUwCiAKIERPTUltcGxlbWVudGF0aW9uSW1wbCAqRE9NSW1wbGVtZW50YXRpb25JbXBs OjptX2luc3RhbmNlID0gMDsKIAorc3RhdGljIGJvb2wgcXVhbGlmaWVkTmFtZUlzVmFsaWQoY29u c3QgRE9NU3RyaW5nICZxdWFsaWZpZWROYW1lKQoreworICAgIC8vIE5vdCBtZW50aW9uZWQgaW4g c3BlYzogZW1wdHkgcXVhbGlmaWVkIG5hbWVzIGFyZSBub3QgdmFsaWQuCisgICAgaWYgKHF1YWxp ZmllZE5hbWUuaXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgLy8gRklYTUU6 IENoZWNrIGZvciBpbGxlZ2FsIGNoYXJhY3RlcnMuCisgICAgLy8gRklYTUU6IE1lcmdlL3JlY29u Y2lsZSB3aXRoIERvY3VtZW50SW1wbDo6aXNWYWxpZE5hbWUuCisgICAgcmV0dXJuIHRydWU7Cit9 CisKK3N0YXRpYyBib29sIHF1YWxpZmllZE5hbWVJc01hbGZvcm1lZChjb25zdCBET01TdHJpbmcg JnF1YWxpZmllZE5hbWUpCit7CisgICAgYXNzZXJ0KHF1YWxpZmllZE5hbWVJc1ZhbGlkKHF1YWxp ZmllZE5hbWUpKTsKKyAgICAvLyBGSVhNRTogSW1wbGVtZW50IHRoaXMgY2hlY2suCisgICAgcmV0 dXJuIGZhbHNlOworfQorCiBET01JbXBsZW1lbnRhdGlvbkltcGw6OkRPTUltcGxlbWVudGF0aW9u SW1wbCgpCiB7CiB9CkBAIC0xNDEsMjEgKzE1OCwxNyBAQCBEb2N1bWVudFR5cGVJbXBsICpET01J bXBsZW1lbnRhdGlvbkltcGw6CiAgICAgICAgIHJldHVybiAwOwogICAgIH0KIAotI2lmIDAKLSAg ICAvLyBGSVhNRTogQWRkIHRoZXNlIGNoZWNrcyAoYnV0IG5vdCBpbiBhIHdheSB0aGF0IGRlcGVu ZHMgb24gdGhlIEMrKyBET00hKQotCiAgICAgLy8gSU5WQUxJRF9DSEFSQUNURVJfRVJSOiBSYWlz ZWQgaWYgdGhlIHNwZWNpZmllZCBxdWFsaWZpZWQgbmFtZSBjb250YWlucyBhbiBpbGxlZ2FsIGNo YXJhY3Rlci4KLSAgICBpZiAoIUVsZW1lbnQ6OmtodG1sVmFsaWRRdWFsaWZpZWROYW1lKHF1YWxp ZmllZE5hbWUpKSB7CisgICAgaWYgKCFxdWFsaWZpZWROYW1lSXNWYWxpZChxdWFsaWZpZWROYW1l KSkgewogICAgICAgICBleGNlcHRpb25jb2RlID0gRE9NRXhjZXB0aW9uOjpJTlZBTElEX0NIQVJB Q1RFUl9FUlI7CiAgICAgICAgIHJldHVybiAwOwogICAgIH0KIAogICAgIC8vIE5BTUVTUEFDRV9F UlI6IFJhaXNlZCBpZiB0aGUgcXVhbGlmaWVkTmFtZSBpcyBtYWxmb3JtZWQuCi0gICAgaWYgKEVs ZW1lbnQ6OmtodG1sTWFsZm9ybWVkUXVhbGlmaWVkTmFtZShxdWFsaWZpZWROYW1lKSkgeworICAg IGlmIChxdWFsaWZpZWROYW1lSXNNYWxmb3JtZWQocXVhbGlmaWVkTmFtZSkpIHsKICAgICAgICAg ZXhjZXB0aW9uY29kZSA9IERPTUV4Y2VwdGlvbjo6TkFNRVNQQUNFX0VSUjsKICAgICAgICAgcmV0 dXJuIDA7CiAgICAgfQotI2VuZGlmCiAKICAgICByZXR1cm4gbmV3IERvY3VtZW50VHlwZUltcGwo dGhpcyxEb2N1bWVudFB0cjo6bnVsbERvY3VtZW50UHRyKCkscXVhbGlmaWVkTmFtZSxwdWJsaWNJ ZCxzeXN0ZW1JZCk7CiB9CkBAIC0xNzcsMTQgKzE5MCwxMSBAQCBEb2N1bWVudEltcGwgKkRPTUlt cGxlbWVudGF0aW9uSW1wbDo6Y3JlCiAgICAgICAgIHJldHVybiAwOwogICAgIH0KIAotI2lmIDAK LSAgICAvLyBGSVhNRTogQWRkIHRoaXMgY2hlY2sgKGJ1dCBub3QgaW4gYSB3YXkgdGhhdCBkZXBl bmRzIG9uIHRoZSBDKysgRE9NISkKICAgICAvLyBJTlZBTElEX0NIQVJBQ1RFUl9FUlI6IFJhaXNl ZCBpZiB0aGUgc3BlY2lmaWVkIHF1YWxpZmllZCBuYW1lIGNvbnRhaW5zIGFuIGlsbGVnYWwgY2hh cmFjdGVyLgotICAgIGlmICghRWxlbWVudDo6a2h0bWxWYWxpZFF1YWxpZmllZE5hbWUocXVhbGlm aWVkTmFtZSkpIHsKKyAgICBpZiAoIXF1YWxpZmllZE5hbWVJc1ZhbGlkKHF1YWxpZmllZE5hbWUp KSB7CiAgICAgICAgIGV4Y2VwdGlvbmNvZGUgPSBET01FeGNlcHRpb246OklOVkFMSURfQ0hBUkFD VEVSX0VSUjsKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQotI2VuZGlmCiAKICAgICAvLyBOQU1F U1BBQ0VfRVJSOgogICAgIC8vIC0gUmFpc2VkIGlmIHRoZSBxdWFsaWZpZWROYW1lIGlzIG1hbGZv cm1lZCwKQEAgLTE5OSwxMSArMjA5LDcgQEAgRG9jdW1lbnRJbXBsICpET01JbXBsZW1lbnRhdGlv bkltcGw6OmNyZQogICAgICAgICAgICAgY29sb25wb3MgPSBpOwogICAgIH0KIAotICAgIGlmICgK LSNpZiAwCi0gICAgICAgIC8vIEZJWE1FOiBBZGQgdGhpcyBjaGVjayAoYnV0IG5vdCBpbiBhIHdh eSB0aGF0IGRlcGVuZHMgb24gdGhlIEMrKyBET00hKQotICAgICAgICBFbGVtZW50OjpraHRtbE1h bGZvcm1lZFF1YWxpZmllZE5hbWUocXVhbGlmaWVkTmFtZSkgfHwKLSNlbmRpZgorICAgIGlmIChx dWFsaWZpZWROYW1lSXNNYWxmb3JtZWQocXVhbGlmaWVkTmFtZSkgfHwKICAgICAgICAgKGNvbG9u cG9zID49IDAgJiYgbmFtZXNwYWNlVVJJLmlzTnVsbCgpKSB8fAogICAgICAgICAoY29sb25wb3Mg PT0gMyAmJiBxdWFsaWZpZWROYW1lWzBdID09ICd4JyAmJiBxdWFsaWZpZWROYW1lWzFdID09ICdt JyAmJiBxdWFsaWZpZWROYW1lWzJdID09ICdsJyAmJgogICAgICAgICAgbmFtZXNwYWNlVVJJICE9 ICJodHRwOi8vd3d3LnczLm9yZy9YTUwvMTk5OC9uYW1lc3BhY2UiKSkgewpJbmRleDogbGF5b3V0 LXRlc3RzL2RvbS9odG1sL2xldmVsMi9jb3JlL2NyZWF0ZURvY3VtZW50MDgtZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2xheW91dC10ZXN0cy9kb20v aHRtbC9sZXZlbDIvY29yZS9jcmVhdGVEb2N1bWVudDA4LWV4cGVjdGVkLnR4dCx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4xCmRpZmYgLXAgLXUgLXIxLjEgbGF5b3V0LXRlc3RzL2RvbS9odG1sL2xl dmVsMi9jb3JlL2NyZWF0ZURvY3VtZW50MDgtZXhwZWN0ZWQudHh0Ci0tLSBsYXlvdXQtdGVzdHMv ZG9tL2h0bWwvbGV2ZWwyL2NvcmUvY3JlYXRlRG9jdW1lbnQwOC1leHBlY3RlZC50eHQJMjYgSnVs IDIwMDUgMDg6MzU6MDYgLTAwMDAJMS4xCisrKyBsYXlvdXQtdGVzdHMvZG9tL2h0bWwvbGV2ZWwy L2NvcmUvY3JlYXRlRG9jdW1lbnQwOC1leHBlY3RlZC50eHQJMTcgQXVnIDIwMDUgMTU6NTc6MTEg LTAwMDAKQEAgLTEsMyArMSwyIEBACi1UZXN0OglodHRwOi8vd3d3LnczLm9yZy8yMDAxL0RPTS1U ZXN0LVN1aXRlL2xldmVsMi9jb3JlL2NyZWF0ZURvY3VtZW50MDgJCi1TdGF0dXM6CWZhaWx1cmUK LURldGFpbDoJdGhyb3dfSU5WQUxJRF9DSEFSQUNURVJfRVJSOiBhc3NlcnRUcnVlIGZhaWxlZAor VGVzdDoJaHR0cDovL3d3dy53My5vcmcvMjAwMS9ET00tVGVzdC1TdWl0ZS9sZXZlbDIvY29yZS9j cmVhdGVEb2N1bWVudDA4CitTdGF0dXM6CVN1Y2Nlc3MKSW5kZXg6IGxheW91dC10ZXN0cy9kb20v aHRtbC9sZXZlbDIvY29yZS9jcmVhdGVEb2N1bWVudFR5cGUwNC1leHBlY3RlZC50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUvbGF5b3V0LXRlc3RzL2RvbS9odG1sL2xl dmVsMi9jb3JlL2NyZWF0ZURvY3VtZW50VHlwZTA0LWV4cGVjdGVkLnR4dCx2CnJldHJpZXZpbmcg cmV2aXNpb24gMS4xCmRpZmYgLXAgLXUgLXIxLjEgbGF5b3V0LXRlc3RzL2RvbS9odG1sL2xldmVs Mi9jb3JlL2NyZWF0ZURvY3VtZW50VHlwZTA0LWV4cGVjdGVkLnR4dAotLS0gbGF5b3V0LXRlc3Rz L2RvbS9odG1sL2xldmVsMi9jb3JlL2NyZWF0ZURvY3VtZW50VHlwZTA0LWV4cGVjdGVkLnR4dAky NiBKdWwgMjAwNSAwODozNTowNiAtMDAwMAkxLjEKKysrIGxheW91dC10ZXN0cy9kb20vaHRtbC9s ZXZlbDIvY29yZS9jcmVhdGVEb2N1bWVudFR5cGUwNC1leHBlY3RlZC50eHQJMTcgQXVnIDIwMDUg MTU6NTc6MTEgLTAwMDAKQEAgLTEsMyArMSwyIEBACi1UZXN0OglodHRwOi8vd3d3LnczLm9yZy8y MDAxL0RPTS1UZXN0LVN1aXRlL2xldmVsMi9jb3JlL2NyZWF0ZURvY3VtZW50VHlwZTA0CQotU3Rh dHVzOglmYWlsdXJlCi1EZXRhaWw6CXRocm93X0lOVkFMSURfQ0hBUkFDVEVSX0VSUjogYXNzZXJ0 VHJ1ZSBmYWlsZWQKK1Rlc3Q6CWh0dHA6Ly93d3cudzMub3JnLzIwMDEvRE9NLVRlc3QtU3VpdGUv bGV2ZWwyL2NvcmUvY3JlYXRlRG9jdW1lbnRUeXBlMDQKK1N0YXR1czoJU3VjY2Vzcwo=