44922 2010-08-30 18:59:13 -0700 [Chromium] bindTexture(TEXTURE_CUBE_MAP) shouldn't generate errors with valid cubemap texture 2010-09-01 00:03:22 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zmo zmo abarth eric kbr webkit.review.bot oldest_to_newest 271859 0 zmo 2010-08-30 18:59:13 -0700 It's due to the code to set TEXTURE_WRAP_R to CLAMP_TO_EDGE. Remove it for now. 271865 1 66000 zmo 2010-08-30 19:08:18 -0700 Created attachment 66000 patch 272187 2 66000 kbr 2010-08-31 10:28:50 -0700 Comment on attachment 66000 patch Looks good to me. r=me 272217 3 zmo 2010-08-31 11:01:59 -0700 Committed r66509: <http://trac.webkit.org/changeset/66509> 272664 4 webkit.review.bot 2010-09-01 00:03:22 -0700 http://trac.webkit.org/changeset/66509 might have broken Leopard Intel Debug (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/66505 http://trac.webkit.org/changeset/66506 http://trac.webkit.org/changeset/66507 http://trac.webkit.org/changeset/66508 http://trac.webkit.org/changeset/66509 66000 2010-08-30 19:08:18 -0700 2010-08-31 10:28:50 -0700 patch cubemap.patch text/plain 4019 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjQ0NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMzAgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21p dW1dIGJpbmRUZXh0dXJlKFRFWFRVUkVfQ1VCRV9NQVApIHNob3VsZG4ndCBnZW5lcmF0ZSBlcnJv cnMgd2l0aCB2YWxpZCBjdWJlbWFwIHRleHR1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0OTIyCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJH TFJlbmRlcmluZ0NvbnRleHQuY3BwOiBSZW1vdmUgVEVYVFVSRV9XUkFQX1IgY29kZS4KKyAgICAg ICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6YmluZFRleHR1cmUpOgorICAgICAg ICAqIGh0bWwvY2FudmFzL1dlYkdMVGV4dHVyZS5jcHA6IFJlbW92ZSB0aGUgY29kZSBmb3IgdHJh Y2tpbmcgVEVYVFVSRV9XUkFQX1IuCisgICAgICAgIChXZWJDb3JlOjpXZWJHTFRleHR1cmU6Oldl YkdMVGV4dHVyZSk6CisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xUZXh0dXJlLmg6IERpdHRv LgorCiAyMDEwLTA4LTMwICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL2h0bWwvY2FudmFzL1dl YkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCShyZXZpc2lvbiA2NjE2OCkKKysrIFdlYkNvcmUv aHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAt MzA5LDIzICszMDksMTQgQEAgdm9pZCBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmJpbmRUZXh0dXJl KAogICAgIGlmICh0ZXh0dXJlKQogICAgICAgICB0ZXh0dXJlLT5zZXRUYXJnZXQodGFyZ2V0LCBt YXhMZXZlbCk7CiAKLSAgICAvLyBGSVhNRTogZG8gd2Ugd2FudCB0byBkbyB0aGlzIG9uIGFsbCBw bGF0Zm9ybXM/Ci0jaWYgUExBVEZPUk0oQ0hST01JVU0pCi0gICAgLy8gRklYTUU6IEdMX1RFWFRV UkVfV1JBUF9SIGlzbid0IGV4cG9zZWQgaW4gdGhlIE9wZW5HTCBFUyAyLjAKLSAgICAvLyBBUEku IE9uIGRlc2t0b3AgT3BlbkdMIGltcGxlbWVudGF0aW9ucyBpdCBzZWVtcyBuZWNlc3NhcnkgdG8K LSAgICAvLyBzZXQgdGhpcyB3cmFwIG1vZGUgdG8gR0xfQ0xBTVBfVE9fRURHRSB0byBnZXQgY29y cmVjdCBiZWhhdmlvcgotICAgIC8vIG9mIGN1YmUgbWFwcy4KLSAgICBpZiAodGV4dHVyZSkgewot ICAgICAgICBpZiAodGFyZ2V0ID09IEdyYXBoaWNzQ29udGV4dDNEOjpURVhUVVJFX0NVQkVfTUFQ KSB7Ci0gICAgICAgICAgICBpZiAoIXRleHR1cmUtPmlzQ3ViZU1hcFJXcmFwTW9kZUluaXRpYWxp emVkKCkpIHsKLSAgICAgICAgICAgICAgICBzdGF0aWMgY29uc3QgaW50IHRleHR1cmVXcmFwUiA9 IDB4ODA3MjsKLSAgICAgICAgICAgICAgICB0ZXhQYXJhbWV0ZXJpKEdyYXBoaWNzQ29udGV4dDNE OjpURVhUVVJFX0NVQkVfTUFQLCB0ZXh0dXJlV3JhcFIsIEdyYXBoaWNzQ29udGV4dDNEOjpDTEFN UF9UT19FREdFKTsKLSAgICAgICAgICAgICAgICB0ZXh0dXJlLT5zZXRDdWJlTWFwUldyYXBNb2Rl SW5pdGlhbGl6ZWQodHJ1ZSk7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0gZWxzZQotICAgICAg ICAgICAgdGV4dHVyZS0+c2V0Q3ViZU1hcFJXcmFwTW9kZUluaXRpYWxpemVkKGZhbHNlKTsKLSAg ICB9Ci0jZW5kaWYKKyAgICAvLyBOb3RlOiBwcmV2aW91c2x5IHdlIHVzZWQgdG8gYXV0b21hdGlj YWxseSBzZXQgdGhlIFRFWFRVUkVfV1JBUF9SCisgICAgLy8gcmVwZWF0IG1vZGUgdG8gQ0xBTVBf VE9fRURHRSBmb3IgY3ViZSBtYXAgdGV4dHVyZXMsIGJlY2F1c2UgT3BlbkdMCisgICAgLy8gRVMg Mi4wIGRvZXNuJ3QgZXhwb3NlIHRoaXMgZmxhZyAoYSBidWcgaW4gdGhlIHNwZWNpZmljYXRpb24p IGFuZAorICAgIC8vIG90aGVyd2lzZSB0aGUgYXBwbGljYXRpb24gaGFzIG5vIGNvbnRyb2wgb3Zl ciB0aGUgc2VhbXMgaW4gdGhpcworICAgIC8vIGRpbWVuc2lvbi4gSG93ZXZlciwgaXQgYXBwZWFy cyB0aGF0IHN1cHBvcnRpbmcgdGhpcyBwcm9wZXJseSBvbiBhbGwKKyAgICAvLyBwbGF0Zm9ybXMg aXMgZmFpcmx5IGludm9sdmVkICh3aWxsIHJlcXVpcmUgYSBIYXNoTWFwIGZyb20gdGV4dHVyZSBJ RAorICAgIC8vIGluIGFsbCBwb3J0cyksIGFuZCB3ZSBoYXZlIG5vdCBoYWQgYW55IGNvbXBsYWlu dHMsIHNvIHRoZSBsb2dpYyBoYXMKKyAgICAvLyBiZWVuIHJlbW92ZWQuCiAKICAgICBjbGVhbnVw QWZ0ZXJHcmFwaGljc0NhbGwoZmFsc2UpOwogfQpJbmRleDogV2ViQ29yZS9odG1sL2NhbnZhcy9X ZWJHTFRleHR1cmUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xU ZXh0dXJlLmNwcAkocmV2aXNpb24gNjYxNjgpCisrKyBXZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdM VGV4dHVyZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQwLDcgKzQwLDYgQEAgUGFzc1JlZlB0cjxX ZWJHTFRleHR1cmU+IFdlYkdMVGV4dHVyZTo6YwogCiBXZWJHTFRleHR1cmU6OldlYkdMVGV4dHVy ZShXZWJHTFJlbmRlcmluZ0NvbnRleHQqIGN0eCkKICAgICA6IFdlYkdMT2JqZWN0KGN0eCkKLSAg ICAsIGN1YmVNYXBSV3JhcE1vZGVJbml0aWFsaXplZChmYWxzZSkKICAgICAsIG1fdGFyZ2V0KDAp CiAgICAgLCBtX21pbkZpbHRlcihHcmFwaGljc0NvbnRleHQzRDo6TkVBUkVTVF9NSVBNQVBfTElO RUFSKQogICAgICwgbV9tYWdGaWx0ZXIoR3JhcGhpY3NDb250ZXh0M0Q6OkxJTkVBUikKSW5kZXg6 IFdlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xUZXh0dXJlLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9odG1sL2NhbnZhcy9XZWJHTFRleHR1cmUuaAkocmV2aXNpb24gNjYxNjgpCisrKyBXZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMVGV4dHVyZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00MCwxNiArNDAs NiBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxXZWJHTFRleHR1cmU+IGNyZWF0 ZShXZWJHTFJlbmRlcmluZ0NvbnRleHQqKTsKIAotICAgIGJvb2wgaXNDdWJlTWFwUldyYXBNb2Rl SW5pdGlhbGl6ZWQoKQotICAgIHsKLSAgICAgICAgcmV0dXJuIGN1YmVNYXBSV3JhcE1vZGVJbml0 aWFsaXplZDsKLSAgICB9Ci0KLSAgICB2b2lkIHNldEN1YmVNYXBSV3JhcE1vZGVJbml0aWFsaXpl ZChib29sIGluaXRpYWxpemVkKQotICAgIHsKLSAgICAgICAgY3ViZU1hcFJXcmFwTW9kZUluaXRp YWxpemVkID0gaW5pdGlhbGl6ZWQ7Ci0gICAgfQotCiAgICAgdm9pZCBzZXRUYXJnZXQodW5zaWdu ZWQgbG9uZyB0YXJnZXQsIGludCBtYXhMZXZlbCk7CiAgICAgdm9pZCBzZXRQYXJhbWV0ZXJpKHVu c2lnbmVkIGxvbmcgcG5hbWUsIGludCBwYXJhbSk7CiAgICAgdm9pZCBzZXRQYXJhbWV0ZXJmKHVu c2lnbmVkIGxvbmcgcG5hbWUsIGZsb2F0IHBhcmFtKTsKQEAgLTgzLDggKzczLDYgQEAgcHJpdmF0 ZToKIAogICAgIGludCBtYXBUYXJnZXRUb0luZGV4KHVuc2lnbmVkIGxvbmcpOwogCi0gICAgYm9v bCBjdWJlTWFwUldyYXBNb2RlSW5pdGlhbGl6ZWQ7Ci0KICAgICB1bnNpZ25lZCBsb25nIG1fdGFy Z2V0OwogCiAgICAgaW50IG1fbWluRmlsdGVyOwo=