44918 2010-08-30 18:19:03 -0700 Cannot make lists quoted on gmail 2017-07-18 08:29:33 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All NEW GoogleBug P2 Normal --- 19795 1 rniwa webkit-unassigned darin enrica jparent justin.garcia mjs tony oldest_to_newest 271835 0 rniwa 2010-08-30 18:19:03 -0700 Reproductions steps: 1. Goto gmail, and compose. 2. Type in nested lists 3. Quote the entire nested lists by clicking "(quote) Expected results: Lists are quoted Actual results: Spacing between lists are modified weirdly but lists are not quoted properly. 275646 1 jparent 2010-09-07 23:57:29 -0700 This is a bug in Gmail's text editor (TrogEdit), not WebKit. If you look at the generated HTML, the blockquotes are there, they just do not have the classname on them for the special quoted style. My guess is that it is an issue in the TrogEdit code that is trying to work around https://bugs.webkit.org/show_bug.cgi?id=19795. Can you file a bug against TrogEdit instead? http://code.google.com/p/closure-library/issues/ 275650 2 66852 rniwa 2010-09-08 00:05:47 -0700 Created attachment 66852 demo 275652 3 rniwa 2010-09-08 00:09:13 -0700 (In reply to comment #1) > If you look at the generated HTML, the blockquotes are there, they just do not have the classname on them for the special quoted style. Sure, blockquotes are there but they aren't at the places I'd expect it to be. For example, if I called formatBlock on: <ul><li>hello</li><li>world</li></ul> I'd expect to get: <blockquote><ul><li>hello</li><li>world</li></ul></blockquote> but instead, I get: <ul><li><blockquote>hello</blockquote></li><li><blockquote>world</blockquote></li></ul> > My guess is that it is an issue in the TrogEdit code that is trying to work around https://bugs.webkit.org/show_bug.cgi?id=19795. > > Can you file a bug against TrogEdit instead? http://code.google.com/p/closure-library/issues/ It's possible that TrogEdit's doing something wrong as well but I think we should fix this bug in WebKit first. It's quite unreasonable for me to ask TrogEdit and other editing tools to work-around this problem. I'm surprised that this has never been a problem in Mail. 275654 4 jparent 2010-09-08 00:11:00 -0700 (In reply to comment #3) > (In reply to comment #1) > > If you look at the generated HTML, the blockquotes are there, they just do not have the classname on them for the special quoted style. > > Sure, blockquotes are there but they aren't at the places I'd expect it to be. For example, if I called formatBlock on: > <ul><li>hello</li><li>world</li></ul> > > I'd expect to get: > <blockquote><ul><li>hello</li><li>world</li></ul></blockquote> > > but instead, I get: > <ul><li><blockquote>hello</blockquote></li><li><blockquote>world</blockquote></li></ul> Right. That behavior is the other bug I referenced, https://bugs.webkit.org/show_bug.cgi?id=19795. > > > My guess is that it is an issue in the TrogEdit code that is trying to work around https://bugs.webkit.org/show_bug.cgi?id=19795. > > > > Can you file a bug against TrogEdit instead? http://code.google.com/p/closure-library/issues/ > > It's possible that TrogEdit's doing something wrong as well but I think we should fix this bug in WebKit first. It's quite unreasonable for me to ask TrogEdit and other editing tools to work-around this problem. I'm surprised that this has never been a problem in Mail. 318296 5 rniwa 2010-12-07 10:28:10 -0800 This almost works now. The problem we have now is that we split lists when formatting by a block. For example, if we had: <ol> <li>hello</li> <li>world</li> </ol> and formatted the entire list, then we'll end up with <blockquote> <ol> <li>hello</li> </ol> <ol> <li>world</li> </ol> </blockquote> Merging lists don't work because if we had: <ol> <li>hello<ol><li>abc</li><li>def</li></ol></li> <li>world</li> </ol> then we also need to merge li. But we can't always merge li's either. It turns out that once we split nodes, it becomes ambiguous whether or not we should merge nodes. So what we should do instead is NOT to split. Instead of moving each paragraph separately, we need to move all them at once when the entire block is selected. 66852 2010-09-08 00:05:47 -0700 2010-09-08 00:05:47 -0700 demo blockformat-test.html text/html 298 rniwa PGh0bWw+CjxkaXYgaWQ9InRlc3QiIGNvbnRlbnRlZGl0YWJsZT48dWw+PGxpPmhlbGxvPC9saT48 bGk+d29ybGQ8L2xpPjwvdWw+PC9kaXY+CjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4K CndpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZWxlY3RBbGxDaGlsZHJlbih0ZXN0KTsKZG9jdW1lbnQu ZXhlY0NvbW1hbmQoJ2Zvcm1hdEJsb2NrJywgZmFsc2UsICdibG9ja3F1b3RlJyk7CmRvY3VtZW50 LmJvZHkuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUodGVzdC5pbm5lckhUTUwp KTsKCjwvc2NyaXB0Pg==