44915 2010-08-30 17:50:11 -0700 Need to handle CSSValueAuto in CSSPrimitiveValue::operator ETextAlign() 2010-08-31 23:14:26 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 justin.garcia justin.garcia darin mitz simon.fraser oldest_to_newest 271815 0 justin.garcia 2010-08-30 17:50:11 -0700 When we map a CSSPrimitiveValue to an ETextAlign value, we need to handle CSSValueAuto, since we map TAAUTO to CSSValueAuto when going in the opposite direction in CSSPrimitiveValue::CSSPrimitiveValue(ETextAlign e). 271837 1 mitz 2010-08-30 18:21:39 -0700 'auto' is not a vaild text-align value. We use TAAUTO internally for the “nameless value that acts as 'left' if 'direction' is 'ltr', 'right' if 'direction' is 'rtl'” from CSS2.1. I’m just not sure where you’re going with this :) 271845 2 65994 justin.garcia 2010-08-30 18:33:38 -0700 Created attachment 65994 patch 271935 3 65994 darin 2010-08-30 22:32:30 -0700 Comment on attachment 65994 patch > + No new tests because we don't appear to cast a CSSPrimitiveValue to an ETextAlign anywhere currently. We convert a CSSPrimitiveValue to an ETextAlign in CSSStyleSelector::applyProperty's case for CSSPropertyTextAlign. You should be able to create a test case based on using text-align: auto. > Index: WebCore.xcodeproj/project.pbxproj > =================================================================== > --- WebCore.xcodeproj/project.pbxproj (revision 66441) > +++ WebCore.xcodeproj/project.pbxproj (working copy) > @@ -20491,6 +20491,7 @@ > isa = PBXProject; > buildConfigurationList = 149C284308902B11008A9EFC /* Build configuration list for PBXProject "WebCore" */; > compatibilityVersion = "Xcode 2.4"; > + developmentRegion = English; > hasScannedForEncodings = 1; > knownRegions = ( > English, Please do not check this project change in. review- for lack of test case 271939 4 mitz 2010-08-30 22:41:53 -0700 (In reply to comment #3) > (From update of attachment 65994 [details]) > > + No new tests because we don't appear to cast a CSSPrimitiveValue to an ETextAlign anywhere currently. > > We convert a CSSPrimitiveValue to an ETextAlign in CSSStyleSelector::applyProperty's case for CSSPropertyTextAlign. You should be able to create a test case based on using text-align: auto. text-algin: auto is invalid and the parser rejects it. CSSPrimitiveValue::operator ETextAlign() currently maps -webkit-auto to TAAUTO. It would be wrong to map auto to the same value. I think the bug is in CSSPrimitiveValue::CSSPrimitiveValue(ETextAlign). I don’t understand why it maps TAAUTO back to the invalid value auto. 271940 5 darin 2010-08-30 22:44:38 -0700 (In reply to comment #4) > I think the bug is in CSSPrimitiveValue::CSSPrimitiveValue(ETextAlign). I don’t understand why it maps TAAUTO back to the invalid value auto. I think you are right! Should be easy to test with getComputedStyle. 272587 6 66160 justin.garcia 2010-08-31 19:47:40 -0700 Created attachment 66160 patch Map TAAuto to -webkit-auto instead of auto. 272593 7 66160 mitz 2010-08-31 19:53:09 -0700 Comment on attachment 66160 patch OK. I just checked what Firefox does, and apparently it returns the modern value 'start', but for now WebKit can do this. 272655 8 justin.garcia 2010-08-31 23:14:26 -0700 http://trac.webkit.org/changeset/66581 65994 2010-08-30 18:33:38 -0700 2010-08-31 19:47:40 -0700 patch 44915.txt text/plain 1826 justin.garcia SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDY2NDQx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgt MzAgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lhQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ5MTUKKyAgICAgICAgTmVlZCB0byBoYW5kbGUgQ1NTVmFs dWVBdXRvIGluIENTU1ByaW1pdGl2ZVZhbHVlOjpvcGVyYXRvciBFVGV4dEFsaWduKCkKKworICAg ICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB3ZSBkb24ndCBhcHBlYXIgdG8gY2FzdCBhIENTU1By aW1pdGl2ZVZhbHVlIHRvIGFuIEVUZXh0QWxpZ24gYW55d2hlcmUgY3VycmVudGx5LgorCisgICAg ICAgICogV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorICAgICAgICAqIGNzcy9D U1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmg6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRp dmVWYWx1ZTo6b3BlcmF0b3IgRVRleHRBbGlnbik6IE1hcCBDU1NWYWx1ZUF1dG8gdG8gVEFBdXRv LgorCiAyMDEwLTA4LTMwICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0 LnBieHByb2oKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9q CShyZXZpc2lvbiA2NjQ0MSkKKysrIFdlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagko d29ya2luZyBjb3B5KQpAQCAtMjA0OTEsNiArMjA0OTEsNyBAQAogCQkJaXNhID0gUEJYUHJvamVj dDsKIAkJCWJ1aWxkQ29uZmlndXJhdGlvbkxpc3QgPSAxNDlDMjg0MzA4OTAyQjExMDA4QTlFRkMg LyogQnVpbGQgY29uZmlndXJhdGlvbiBsaXN0IGZvciBQQlhQcm9qZWN0ICJXZWJDb3JlIiAqLzsK IAkJCWNvbXBhdGliaWxpdHlWZXJzaW9uID0gIlhjb2RlIDIuNCI7CisJCQlkZXZlbG9wbWVudFJl Z2lvbiA9IEVuZ2xpc2g7CiAJCQloYXNTY2FubmVkRm9yRW5jb2RpbmdzID0gMTsKIAkJCWtub3du UmVnaW9ucyA9ICgKIAkJCQlFbmdsaXNoLApJbmRleDogY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFw cGluZ3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBjc3MvQ1NTUHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5oCShy ZXZpc2lvbiA2NjQ0MSkKKysrIGNzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmgJKHdvcmtp bmcgY29weSkKQEAgLTE2NDQsNiArMTY0NCw4IEBACiAgICAgICAgIGNhc2UgQ1NTVmFsdWVFbmQ6 CiAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsgLy8gRGVwZW5kcyBvbiBkaXJlY3Rp b24sIHRodXMgc2hvdWxkIGJlIGhhbmRsZWQgYnkgdGhlIGNhbGxlci4KICAgICAgICAgICAgIHJl dHVybiBMRUZUOworICAgICAgICBjYXNlIENTU1ZhbHVlQXV0bzoKKyAgICAgICAgICAgIHJldHVy biBUQUFVVE87CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICByZXR1cm4gc3RhdGljX2Nh c3Q8RVRleHRBbGlnbj4obV92YWx1ZS5pZGVudCAtIENTU1ZhbHVlV2Via2l0QXV0byk7CiAgICAg fQo= 66160 2010-08-31 19:47:40 -0700 2010-08-31 19:53:09 -0700 patch 44915.txt text/plain 3043 justin.garcia SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjU2NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDgtMzEgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lh QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg ICAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDkx NQorICAgICAgICBOZWVkIHRvIGhhbmRsZSBDU1NWYWx1ZUF1dG8gaW4gQ1NTUHJpbWl0aXZlVmFs dWU6Om9wZXJhdG9yIEVUZXh0QWxpZ24oKQorICAgICAgICAKKyAgICAgICAgKiBjc3MvQ1NTUHJp bWl0aXZlVmFsdWVNYXBwaW5ncy5oOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUHJpbWl0aXZlVmFs dWU6OkNTU1ByaW1pdGl2ZVZhbHVlKTogTWFwIFRBQVVUTyB0byAtd2Via2l0LWF1dG8uICAiYXV0 byIgaXMKKyAgICAgICAgbm90IGEgdmFsaWQgdGV4dC1hbGlnbiB2YWx1ZS4gIFdlIHVzZSBUQUFV VE8gaW50ZXJuYWxseSBmb3IgdGhlIG5hbWVsZXNzIHZhbHVlIHRoYXQgYWN0cworICAgICAgICBh cyBsZWZ0IGlmIGRpcmVjdGlvbjpsdHIgYW5kIHJpZ2h0IGZvciBkaXJlY3Rpb246cnRsLgorCiAy MDEwLTA4LTMxICBEYW5pZWwgQ2hlbmcgIDxkY2hlbmdAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCkluZGV4OiBXZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVW YWx1ZU1hcHBpbmdzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFs dWVNYXBwaW5ncy5oCShyZXZpc2lvbiA2NjQ2NCkKKysrIFdlYkNvcmUvY3NzL0NTU1ByaW1pdGl2 ZVZhbHVlTWFwcGluZ3MuaAkod29ya2luZyBjb3B5KQpAQCAtMTYxMSw3ICsxNjExLDcgQEAKIHsK ICAgICBzd2l0Y2ggKGUpIHsKICAgICAgICAgY2FzZSBUQUFVVE86Ci0gICAgICAgICAgICBtX3Zh bHVlLmlkZW50ID0gQ1NTVmFsdWVBdXRvOworICAgICAgICAgICAgbV92YWx1ZS5pZGVudCA9IENT U1ZhbHVlV2Via2l0QXV0bzsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIExFRlQ6 CiAgICAgICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVMZWZ0OwpJbmRleDogTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2 aXNpb24gNjY1NjcpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxMyBAQAorMjAxMC0wOC0zMSAgSnVzdGluIEdhcmNpYSAgPGp1c3Rpbi5nYXJjaWFA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDkxNQorICAgICAg ICBOZWVkIHRvIGhhbmRsZSBDU1NWYWx1ZUF1dG8gaW4gQ1NTUHJpbWl0aXZlVmFsdWU6Om9wZXJh dG9yIEVUZXh0QWxpZ24oKQorCisgICAgICAgICogZmFzdC9jc3MvdGV4dC1hbGlnbi13ZWJraXQt YXV0by1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL3RleHQtYWxpZ24t d2Via2l0LWF1dG8uaHRtbDogQWRkZWQuCisKIDIwMTAtMDgtMzEgIERhcmluIEFkbGVyICA8ZGFy aW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBndGsgYm90LgpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9jc3MvdGV4dC1hbGlnbi13ZWJraXQtYXV0by1leHBlY3RlZC50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MvdGV4dC1hbGlnbi13ZWJraXQtYXV0by1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy90ZXh0LWFsaWduLXdlYmtp dC1hdXRvLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorU1VDQ0VTUwpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9jc3MvdGV4dC1hbGlnbi13ZWJraXQtYXV0by5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3NzL3RleHQtYWxpZ24td2Via2l0LWF1dG8u aHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY3NzL3RleHQtYWxpZ24td2Vi a2l0LWF1dG8uaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNyBAQAorPGhlYWQ+Cis8c2Ny aXB0PgorZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyKQorICAgICAgICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgp OworICAgICAgICAKKyAgICB2YXIgdGV4dEFsaWduID0gd2luZG93LmdldENvbXB1dGVkU3R5bGUo ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRpdiIpKS50ZXh0QWxpZ247CisgICAgaWYgKHRleHRB bGlnbiA9PSAiLXdlYmtpdC1hdXRvIikKKyAgICAgICAgZG9jdW1lbnQuYm9keS5pbm5lclRleHQg PSAiU1VDQ0VTUyI7CisgICAgZWxzZQorICAgICAgICBkb2N1bWVudC5ib2R5LmlubmVyVGV4dCA9 ICJGQUlMVVJFLiAgdGV4dC1hbGlnbiB3YXMgIiArIHRleHRBbGlnbiArICIsIGl0IHNob3VsZCBo YXZlIGJlZW4gLXdlYmtpdC1hdXRvIjsgICAKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkg b25Mb2FkPSJydW5UZXN0KCk7Ij4KKzxkaXYgaWQ9ImRpdiIgc3R5bGU9ImRpcmVjdGlvbjpydGw7 Ij50ZXN0PC9kaXY+Cis8L2JvZHk+Cg==