44911 2010-08-30 17:21:14 -0700 check-webkit-style should understand WTF #include guards 2010-12-17 05:15:56 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 44892 1 kbr webkit-unassigned abarth commit-queue crogers eric hamaji levin oldest_to_newest 271791 0 kbr 2010-08-30 17:21:14 -0700 Many of the files in JavaScriptCore/wtf use a different #include guard than those used in WebCore; e.g., "#ifndef WTF_Vector_h" rather than "#ifndef Vector_h". This does seem to be a good idea to avoid clashes between potentially similarly-named headers in WTF and WebCore, since the #include style is different ('#include <wtf/Vector.h>' rather than '#include "Vector.h"'). check-webkit-style complains about the addition of new WTF_ prefixed #include guards; I think it should be taught about them. See https://bugs.webkit.org/show_bug.cgi?id=44892 for one instance where it complained. 323523 1 76830 levin 2010-12-16 16:59:06 -0800 Created attachment 76830 Patch 323697 2 76830 eric 2010-12-17 03:56:43 -0800 Comment on attachment 76830 Patch LGTM. Thanks. 323722 3 76830 commit-queue 2010-12-17 05:15:50 -0800 Comment on attachment 76830 Patch Clearing flags on attachment: 76830 Committed r74255: <http://trac.webkit.org/changeset/74255> 323723 4 commit-queue 2010-12-17 05:15:56 -0800 All reviewed patches have been landed. Closing bug. 76830 2010-12-16 16:59:06 -0800 2010-12-17 05:15:50 -0800 Patch bug-44911-20101216165904.patch text/plain 4914 levin ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkYjM2NGQzODZiYTI0MjExZGQ5ZDkyNTFmZTg5MzNlNmNjYTI0MjJiLi42M2Q2NWI0 MDY2NDY0Y2Y2NTNjZTQzODM4ZDNmZTYxNWYzZDFlYzRkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAK IDIwMTAtMTItMTYgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHls ZSBzaG91bGQgdW5kZXJzdGFuZCBXVEYgI2luY2x1ZGUgZ3VhcmRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDkxMQorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChnZXRfaGVhZGVyX2d1 YXJkX2NwcF92YXJpYWJsZSk6IG1vZGlmeSB0byBzdWdnZXN0IHRoZSBXVEYgc3R5bGUKKyAgICAg ICAgb2YgaGVhZGVyIGd1YXJkIHdoZW4gYXBwcm9wcmlhdGUuCisgICAgICAgIChjaGVja19mb3Jf aGVhZGVyX2d1YXJkKTogaGFuZGxlIG11bHRpcGxlIHJldHVybiB2YWx1ZXMgZnJvbQorICAgICAg ICBnZXRfaGVhZGVyX2d1YXJkX2NwcF92YXJpYWJsZQorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoQ3BwU3R5bGVUZXN0 LnRlc3RfYnVpbGRfaGVhZGVyX2d1YXJkKTogQWRkZWQgdGVzdHMgZm9yIHRoZSBXVEYKKyAgICAg ICAgaGVhZGVyIHN0eWxlLgorCisyMDEwLTEyLTE2ICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9t aXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBTaGluaWNoaXJvIEhhbWFqaS4KIAogICAg ICAgICBjaGVjay13ZWJraXQtc3R5bGUgdW5pdCB0ZXN0cyBoYXMgc29tZSBkdXBsaWNhdGUgYm9p bGVycGxhdGUgY29kZS4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2Vycy9jcHAucHkKaW5kZXggNDI5MThkOTgyZWI5ZTc0NjU0NWRlODJkNDM1OGE2MjJh Njk2OWNmOC4uZTg0MTAyOTI1YWI3MzNjYWRlNDQ2OGRjZmU3ZDgwYzliYmFmYjc3YiAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkK KysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkK QEAgLTY5NSw3ICs2OTUsMTQgQEAgZGVmIGdldF9oZWFkZXJfZ3VhcmRfY3BwX3ZhcmlhYmxlKGZp bGVuYW1lKToKICAgICAjIGZseW1ha2UuCiAgICAgZmlsZW5hbWUgPSByZS5zdWIocidfZmx5bWFr ZVwuaCQnLCAnLmgnLCBmaWxlbmFtZSkKIAotICAgIHJldHVybiBzdWIocidbLS5cc10nLCAnXycs IG9zLnBhdGguYmFzZW5hbWUoZmlsZW5hbWUpKQorICAgIHN0YW5kYXJkX25hbWUgPSBzdWIocidb LS5cc10nLCAnXycsIG9zLnBhdGguYmFzZW5hbWUoZmlsZW5hbWUpKQorCisgICAgIyBGaWxlcyB1 bmRlciBXVEYgdHlwaWNhbGx5IGhhdmUgaGVhZGVyIGd1YXJkcyB0aGF0IHN0YXJ0IHdpdGggV1RG Xy4KKyAgICBpZiBmaWxlbmFtZS5maW5kKCcvd3RmLycpOgorICAgICAgICBzcGVjaWFsX25hbWUg PSAiV1RGXyIgKyBzdGFuZGFyZF9uYW1lCisgICAgZWxzZToKKyAgICAgICAgc3BlY2lhbF9uYW1l ID0gc3RhbmRhcmRfbmFtZQorICAgIHJldHVybiAoc3BlY2lhbF9uYW1lLCBzdGFuZGFyZF9uYW1l KQogCiAKIGRlZiBjaGVja19mb3JfaGVhZGVyX2d1YXJkKGZpbGVuYW1lLCBsaW5lcywgZXJyb3Ip OgpAQCAtNzMxLDEzICs3MzgsMTMgQEAgZGVmIGNoZWNrX2Zvcl9oZWFkZXJfZ3VhcmQoZmlsZW5h bWUsIGxpbmVzLCBlcnJvcik6CiAgICAgaWYgbm90IGlmbmRlZiBvciBub3QgZGVmaW5lIG9yIGlm bmRlZiAhPSBkZWZpbmU6CiAgICAgICAgIGVycm9yKDAsICdidWlsZC9oZWFkZXJfZ3VhcmQnLCA1 LAogICAgICAgICAgICAgICAnTm8gI2lmbmRlZiBoZWFkZXIgZ3VhcmQgZm91bmQsIHN1Z2dlc3Rl ZCBDUFAgdmFyaWFibGUgaXM6ICVzJyAlCi0gICAgICAgICAgICAgIGNwcHZhcikKKyAgICAgICAg ICAgICAgY3BwdmFyWzBdKQogICAgICAgICByZXR1cm4KIAogICAgICMgVGhlIGd1YXJkIHNob3Vs ZCBiZSBGaWxlX2guCi0gICAgaWYgaWZuZGVmICE9IGNwcHZhcjoKKyAgICBpZiBpZm5kZWYgbm90 IGluIGNwcHZhcjoKICAgICAgICAgZXJyb3IoaWZuZGVmX2xpbmVfbnVtYmVyLCAnYnVpbGQvaGVh ZGVyX2d1YXJkJywgNSwKLSAgICAgICAgICAgICAgJyNpZm5kZWYgaGVhZGVyIGd1YXJkIGhhcyB3 cm9uZyBzdHlsZSwgcGxlYXNlIHVzZTogJXMnICUgY3BwdmFyKQorICAgICAgICAgICAgICAnI2lm bmRlZiBoZWFkZXIgZ3VhcmQgaGFzIHdyb25nIHN0eWxlLCBwbGVhc2UgdXNlOiAlcycgJSBjcHB2 YXJbMF0pCiAKIAogZGVmIGNoZWNrX2Zvcl91bmljb2RlX3JlcGxhY2VtZW50X2NoYXJhY3RlcnMo bGluZXMsIGVycm9yKToKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggZTc4OWY1Nzg1OWZjZmFi MmY3NzM0MDU3ODYzZGMyNzk0NTQ3MGFlNi4uY2RiYzY3Mjg2NDRlZGFiN2M1ODA4NjZiNTEwYjA3 NTdmNWI5NTM0OSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTE3NDEsNiArMTc0MSwzNSBA QCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAgICAg JyAgW2J1aWxkL2hlYWRlcl9ndWFyZF0gWzVdJyAlIGV4cGVjdGVkX2d1YXJkKSwKICAgICAgICAg ICAgIGVycm9yX2NvbGxlY3Rvci5yZXN1bHRfbGlzdCgpKQogCisgICAgICAgICMgQWxsb3cgdGhl IFdURl8gcHJlZml4IGZvciBmaWxlcyBpbiB0aGF0IGRpcmVjdG9yeS4KKyAgICAgICAgaGVhZGVy X2d1YXJkX2ZpbHRlciA9IEZpbHRlckNvbmZpZ3VyYXRpb24oKCctJywgJytidWlsZC9oZWFkZXJf Z3VhcmQnKSkKKyAgICAgICAgZXJyb3JfY29sbGVjdG9yID0gRXJyb3JDb2xsZWN0b3Ioc2VsZi5h c3NlcnRfLCBoZWFkZXJfZ3VhcmRfZmlsdGVyKQorICAgICAgICBzZWxmLnByb2Nlc3NfZmlsZV9k YXRhKCdKYXZhU2NyaXB0Q29yZS93dGYvVGVzdE5hbWUuaCcsICdoJywKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBbJyNpZm5kZWYgV1RGX1Rlc3ROYW1lX2gnLCAnI2RlZmluZSBXVEZf VGVzdE5hbWVfaCddLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVycm9yX2NvbGxl Y3RvcikKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoMCwgbGVuKGVycm9yX2NvbGxlY3Rvci5y ZXN1bHRfbGlzdCgpKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgZXJyb3JfY29sbGVjdG9y LnJlc3VsdF9saXN0KCkpCisKKyAgICAgICAgIyBBbHNvIGFsbG93IHRoZSBub24gV1RGXyBwcmVm aXggZm9yIGZpbGVzIGluIHRoYXQgZGlyZWN0b3J5LgorICAgICAgICBlcnJvcl9jb2xsZWN0b3Ig PSBFcnJvckNvbGxlY3RvcihzZWxmLmFzc2VydF8sIGhlYWRlcl9ndWFyZF9maWx0ZXIpCisgICAg ICAgIHNlbGYucHJvY2Vzc19maWxlX2RhdGEoJ0phdmFTY3JpcHRDb3JlL3d0Zi9UZXN0TmFtZS5o JywgJ2gnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFsnI2lmbmRlZiBUZXN0TmFt ZV9oJywgJyNkZWZpbmUgVGVzdE5hbWVfaCddLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGVycm9yX2NvbGxlY3RvcikKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoMCwgbGVuKGVy cm9yX2NvbGxlY3Rvci5yZXN1bHRfbGlzdCgpKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ZXJyb3JfY29sbGVjdG9yLnJlc3VsdF9saXN0KCkpCisKKyAgICAgICAgIyBWZXJpZnkgdGhhdCB3 ZSBzdWdnZXN0IHRoZSBXVEYgcHJlZml4IHZlcnNpb24uCisgICAgICAgIGVycm9yX2NvbGxlY3Rv ciA9IEVycm9yQ29sbGVjdG9yKHNlbGYuYXNzZXJ0XywgaGVhZGVyX2d1YXJkX2ZpbHRlcikKKyAg ICAgICAgc2VsZi5wcm9jZXNzX2ZpbGVfZGF0YSgnSmF2YVNjcmlwdENvcmUvd3RmL1Rlc3ROYW1l LmgnLCAnaCcsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgWycjaWZuZGVmIEJBRF9U ZXN0TmFtZV9oJywgJyNkZWZpbmUgQkFEX1Rlc3ROYW1lX2gnXSwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBlcnJvcl9jb2xsZWN0b3IpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxz KAorICAgICAgICAgICAgMSwKKyAgICAgICAgICAgIGVycm9yX2NvbGxlY3Rvci5yZXN1bHRfbGlz dCgpLmNvdW50KAorICAgICAgICAgICAgICAgICcjaWZuZGVmIGhlYWRlciBndWFyZCBoYXMgd3Jv bmcgc3R5bGUsIHBsZWFzZSB1c2U6IFdURl9UZXN0TmFtZV9oJworICAgICAgICAgICAgICAgICcg IFtidWlsZC9oZWFkZXJfZ3VhcmRdIFs1XScpLAorICAgICAgICAgICAgZXJyb3JfY29sbGVjdG9y LnJlc3VsdF9saXN0KCkpCisKICAgICBkZWYgdGVzdF9idWlsZF9wcmludGZfZm9ybWF0KHNlbGYp OgogICAgICAgICBzZWxmLmFzc2VydF9saW50KAogICAgICAgICAgICAgcidwcmludGYoIlwlJWQi LCB2YWx1ZSk7JywK