44895 2010-08-30 14:28:42 -0700 Remove unused canReferToParentFrameEncoding() function from FrameLoader.cpp 2010-08-31 10:20:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jschuh jschuh commit-queue japhet oldest_to_newest 271632 0 jschuh 2010-08-30 14:28:42 -0700 Remove unused canReferToParentFrameEncoding() function from FrameLoader.cpp 271638 1 65958 jschuh 2010-08-30 14:34:33 -0700 Created attachment 65958 Patch 271640 2 65958 japhet 2010-08-30 14:36:58 -0700 Comment on attachment 65958 Patch Yay cleanup! 272051 3 65958 commit-queue 2010-08-31 05:26:57 -0700 Comment on attachment 65958 Patch Clearing flags on attachment: 65958 Committed r66476: <http://trac.webkit.org/changeset/66476> 272052 4 commit-queue 2010-08-31 05:27:02 -0700 All reviewed patches have been landed. Closing bug. 272154 5 ap 2010-08-31 09:53:53 -0700 This function is now defined and used in DocumentWriter.cpp, someone just forgot to remove it from its old location. 272177 6 jschuh 2010-08-31 10:20:37 -0700 Sorry for the lack of context. I was looking at DocumentWriter and noticed this method was duplicated here. I checked with Nate and verified this was dead code left behind from when DocumentWriter was factored out of FrameLoader in: http://trac.webkit.org/changeset/57927 65958 2010-08-30 14:34:33 -0700 2010-08-31 05:26:57 -0700 Patch bug-44895-20100830143432.patch text/plain 1382 jschuh SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjQwOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDgtMzAgIEp1c3RpbiBTY2h1aCAgPGpzY2h1aEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVtb3ZlIHVudXNlZCBjYW5SZWZlclRvUGFyZW50RnJhbWVFbmNvZGluZygpIGZ1bmN0aW9uIGZy b20gRnJhbWVMb2FkZXIuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00NDg5NQorCisgICAgICAgIE5vIG5ldyB0ZXN0czsgbm8gYmVoYXZpb3IgY2hh bmdlZC4KKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisKIDIwMTAtMDgtMzAg IFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24gNjY0 MDUpCisrKyBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE1OSwxMSArMTU5LDYgQEAgc3RhdGljIGludCBudW1SZXF1ZXN0cyhEb2N1bWVudCogZG9jdW1l bgogICAgIHJldHVybiBkb2N1bWVudC0+ZG9jTG9hZGVyKCktPnJlcXVlc3RDb3VudCgpOwogfQog Ci1zdGF0aWMgaW5saW5lIGJvb2wgY2FuUmVmZXJUb1BhcmVudEZyYW1lRW5jb2RpbmcoY29uc3Qg RnJhbWUqIGZyYW1lLCBjb25zdCBGcmFtZSogcGFyZW50RnJhbWUpIAotewotICAgIHJldHVybiBw YXJlbnRGcmFtZSAmJiBwYXJlbnRGcmFtZS0+ZG9jdW1lbnQoKS0+c2VjdXJpdHlPcmlnaW4oKS0+ Y2FuQWNjZXNzKGZyYW1lLT5kb2N1bWVudCgpLT5zZWN1cml0eU9yaWdpbigpKTsKLX0KLQogLy8g VGhpcyBpcyBub3QgaW4gdGhlIEZyYW1lTG9hZGVyIGNsYXNzIHRvIGVtcGhhc2l6ZSB0aGF0IGl0 IGRvZXMgbm90IGRlcGVuZCBvbgogLy8gcHJpdmF0ZSBGcmFtZUxvYWRlciBkYXRhLCBhbmQgdG8g YXZvaWQgaW5jcmVhc2luZyB0aGUgbnVtYmVyIG9mIHB1YmxpYyBmdW5jdGlvbnMKIC8vIHdpdGgg YWNjZXNzIHRvIHByaXZhdGUgZGF0YS4gIFNpbmNlIG9ubHkgdGhpcyAuY3BwIGZpbGUgbmVlZHMg aXQsIG1ha2luZyBpdAo=