44892 2010-08-30 14:21:12 -0700 Fix namespace for wtf/Complex.h and wtf/Vector3.h 2010-08-31 10:15:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 44911 0 crogers webkit-unassigned kbr webkit.review.bot oldest_to_newest 271626 0 crogers 2010-08-30 14:21:12 -0700 Fix namespace for wtf/Complex.h and wtf/Vector3.h 271627 1 65954 crogers 2010-08-30 14:23:20 -0700 Created attachment 65954 Patch 271729 2 65954 kbr 2010-08-30 16:20:19 -0700 Comment on attachment 65954 Patch The #if guards are incorrect for these files as well. 271759 3 65978 crogers 2010-08-30 16:48:58 -0700 Created attachment 65978 Patch 271764 4 webkit.review.bot 2010-08-30 16:52:25 -0700 Attachment 65978 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/Vector3.h:29: #ifndef header guard has wrong style, please use: Vector3_h [build/header_guard] [5] JavaScriptCore/wtf/Complex.h:29: #ifndef header guard has wrong style, please use: Complex_h [build/header_guard] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 271786 5 65978 kbr 2010-08-30 17:15:45 -0700 Comment on attachment 65978 Patch I think the updates to the #include guards are the right thing to do regardless of what check-webkit-style says. r=me. Will file a bug against check-webkit-style. 271862 6 65978 crogers 2010-08-30 19:05:02 -0700 Comment on attachment 65978 Patch Clearing flags on attachment: 65978 Committed r66446: <http://trac.webkit.org/changeset/66446> 271863 7 crogers 2010-08-30 19:05:06 -0700 All reviewed patches have been landed. Closing bug. 272170 8 ap 2010-08-31 10:15:40 -0700 Please note that WTF symbols expected to be used in other projects need to have using declarations. We don't want to pollute WebCore with those (or with WTF:: prefixes), so we put them right into WTF headers. See e.g. Vector.h: } // namespace WTF using WTF::Vector; #endif // WTF_Vector_h 65954 2010-08-30 14:23:20 -0700 2010-08-30 16:48:55 -0700 Patch bug-44892-20100830142319.patch text/plain 1550 crogers SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY2NDA4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDgtMzAgIENocmlzIFJv Z2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXggbmFtZXNwYWNlIGZvciB3dGYvQ29tcGxleC5oIGFuZCB3 dGYvVmVjdG9yMy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NDg5MgorCisgICAgICAgICogd3RmL0NvbXBsZXguaDoKKyAgICAgICAgKiB3dGYvVmVj dG9yMy5oOgorCiAyMDEwLTA4LTMwICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93 dGYvQ29tcGxleC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9Db21wbGV4LmgJ KHJldmlzaW9uIDY2NDA3KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL0NvbXBsZXguaAkod29ya2lu ZyBjb3B5KQpAQCAtMzIsNyArMzIsNyBAQAogI2luY2x1ZGUgPGNvbXBsZXg+CiAjaW5jbHVkZSA8 d3RmL01hdGhFeHRyYXMuaD4KIAotbmFtZXNwYWNlIFdlYkNvcmUgeworbmFtZXNwYWNlIFdURiB7 CiAKIHR5cGVkZWYgc3RkOjpjb21wbGV4PGRvdWJsZT4gQ29tcGxleDsKIApAQCAtNDEsNiArNDEs NiBAQCBpbmxpbmUgQ29tcGxleCBjb21wbGV4RnJvbU1hZ25pdHVkZVBoYXNlCiAgICAgcmV0dXJu IENvbXBsZXgobWFnbml0dWRlICogY29zKHBoYXNlKSwgbWFnbml0dWRlICogc2luKHBoYXNlKSk7 CiB9CiAKLX0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKK30gLy8gbmFtZXNwYWNlIFdURgogCiAjZW5k aWYgLy8gQ29tcGxleF9oCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvVmVjdG9yMy5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IzLmgJKHJldmlzaW9uIDY2NDA3KQor KysgSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3RvcjMuaAkod29ya2luZyBjb3B5KQpAQCAtMzEsNyAr MzEsNyBAQAogCiAjaW5jbHVkZSA8bWF0aC5oPgogCi1uYW1lc3BhY2UgV2ViQ29yZSB7CituYW1l c3BhY2UgV1RGIHsKIAogY2xhc3MgVmVjdG9yMyB7CiBwdWJsaWM6CkBAIC0xMzMsNiArMTMzLDYg QEAgaW5saW5lIGRvdWJsZSBkaXN0YW5jZShjb25zdCBWZWN0b3IzJiB2MQogICAgIHJldHVybiAo djEgLSB2MikuYWJzKCk7CiB9CiAKLX0gLy8gV2ViQ29yZQorfSAvLyBXVEYKIAogI2VuZGlmIC8v IFZlY3RvcjNfaAo= 65978 2010-08-30 16:48:58 -0700 2010-08-30 19:05:01 -0700 Patch bug-44892-20100830164857.patch text/plain 1928 crogers SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY2NDI1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDgtMzAgIENocmlzIFJv Z2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXggbmFtZXNwYWNlIGZvciB3dGYvQ29tcGxleC5oIGFuZCB3 dGYvVmVjdG9yMy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NDg5MgorCisgICAgICAgICogd3RmL0NvbXBsZXguaDoKKyAgICAgICAgKiB3dGYvVmVj dG9yMy5oOgorCiAyMDEwLTA4LTMwICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93 dGYvQ29tcGxleC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9Db21wbGV4LmgJ KHJldmlzaW9uIDY2NDE4KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL0NvbXBsZXguaAkod29ya2lu ZyBjb3B5KQpAQCAtMjYsMTMgKzI2LDEzIEBACiAgKiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFE VklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKLSNpZm5kZWYg Q29tcGxleF9oCi0jZGVmaW5lIENvbXBsZXhfaAorI2lmbmRlZiBXVEZfQ29tcGxleF9oCisjZGVm aW5lIFdURl9Db21wbGV4X2gKIAogI2luY2x1ZGUgPGNvbXBsZXg+CiAjaW5jbHVkZSA8d3RmL01h dGhFeHRyYXMuaD4KIAotbmFtZXNwYWNlIFdlYkNvcmUgeworbmFtZXNwYWNlIFdURiB7CiAKIHR5 cGVkZWYgc3RkOjpjb21wbGV4PGRvdWJsZT4gQ29tcGxleDsKIApAQCAtNDEsNiArNDEsNiBAQCBp bmxpbmUgQ29tcGxleCBjb21wbGV4RnJvbU1hZ25pdHVkZVBoYXNlCiAgICAgcmV0dXJuIENvbXBs ZXgobWFnbml0dWRlICogY29zKHBoYXNlKSwgbWFnbml0dWRlICogc2luKHBoYXNlKSk7CiB9CiAK LX0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKK30gLy8gbmFtZXNwYWNlIFdURgogCi0jZW5kaWYgLy8g Q29tcGxleF9oCisjZW5kaWYgLy8gV1RGX0NvbXBsZXhfaApJbmRleDogSmF2YVNjcmlwdENvcmUv d3RmL1ZlY3RvcjMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvVmVjdG9yMy5o CShyZXZpc2lvbiA2NjQxOCkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IzLmgJKHdvcmtp bmcgY29weSkKQEAgLTI2LDEyICsyNiwxMiBAQAogICogVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBB RFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCi0jaWZuZGVm IFZlY3RvcjNfaAotI2RlZmluZSBWZWN0b3IzX2gKKyNpZm5kZWYgV1RGX1ZlY3RvcjNfaAorI2Rl ZmluZSBXVEZfVmVjdG9yM19oCiAKICNpbmNsdWRlIDxtYXRoLmg+CiAKLW5hbWVzcGFjZSBXZWJD b3JlIHsKK25hbWVzcGFjZSBXVEYgewogCiBjbGFzcyBWZWN0b3IzIHsKIHB1YmxpYzoKQEAgLTEz Myw2ICsxMzMsNiBAQCBpbmxpbmUgZG91YmxlIGRpc3RhbmNlKGNvbnN0IFZlY3RvcjMmIHYxCiAg ICAgcmV0dXJuICh2MSAtIHYyKS5hYnMoKTsKIH0KIAotfSAvLyBXZWJDb3JlCit9IC8vIFdURgog Ci0jZW5kaWYgLy8gVmVjdG9yM19oCisjZW5kaWYgLy8gV1RGX1ZlY3RvcjNfaAo=