44887 2010-08-30 12:31:37 -0700 On <select>, setting reflected attribute size to negative number should throw exception 2022-08-06 12:02:06 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC Linux RESOLVED INVALID P2 Minor --- 1 ayg webkit-unassigned ahmad.saleem792 ap bfulgham rniwa tabatkins tkent oldest_to_newest 271569 0 ayg 2010-08-30 12:31:37 -0700 Spec: """ If a reflecting IDL attribute is an unsigned integer type (unsigned long) that is limited to only non-negative numbers greater than zero, . . . On setting, if the value is zero, the user agent must fire an INDEX_SIZE_ERR exception. """ http://www.whatwg.org/specs/web-apps/current-work/multipage/urls.html#reflecting-content-attributes-in-idl-attributes "The size IDL attribute is limited to only non-negative numbers greater than zero . . ." http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#dom-select-size Test case: <!doctype html> <script> var el = document.createElement("select"); try { el.size = 0; alert(el.size); } catch (e) { alert(e); } </script> Chrome dev on Ubuntu and Safari 5 on XP alert "1". Recentish Firefox nightly throws an exception per spec, Opera 10.60 and IE8 alert "0". 366234 1 85512 kling 2011-03-11 12:29:49 -0800 Created attachment 85512 Proposed patch 369040 2 tkent 2011-03-17 07:47:53 -0700 Andres, please see the discussion on Bug 43887. 369041 3 tkent 2011-03-17 07:50:45 -0700 (In reply to comment #2) > Andres, please see the discussion on Bug 43887. Ah, this bug is not so related to Bug 43887. I'm sorry for the noise. Anyway, I think this change can make site compatibility issues, and we had better change the specification. 369134 4 ayg 2011-03-17 10:38:51 -0700 Yeah, it turns out that the spec as written is not web-compatible: http://www.w3.org/Bugs/Public/show_bug.cgi?id=12288 The preexisting behavior in IE is to throw an exception on negative numbers but not on 0, and the preexisting behavior in all other browsers is to accept any value. The spec requires throwing an exception on negative numbers and on 0, which is not only probably not web-compatible, but also insane -- as Mounir points out, it means var select = document.createElement('select'); select.size = select.size; throws an exception. Mounir suggests that the spec be changed to match IE's behavior. If you think it should be changed to other browsers' behavior, it would be a good idea to comment on that bug. 392993 5 85512 tkent 2011-04-26 16:24:39 -0700 Comment on attachment 85512 Proposed patch r- for comment #3 and #4. 401032 6 tkent 2011-05-09 21:22:06 -0700 http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#dom-select-size The specification has been updated. 402350 7 ayg 2011-05-11 15:33:54 -0700 Specifically, the spec now matches IE's behavior, so it still requires throwing on negative numbers -- just not 0. Firefox 4.0 now does this, in addition to IE, so it should be safe. 1889376 8 ahmad.saleem792 2022-08-06 07:31:45 -0700 From mentioned test cases in Comment 0, I changed into JSFiddle: Link - https://jsfiddle.net/japm72hv/show All browsers (Chrome Canary 106, Firefox Nightly 105 and Safari 15.6) throw "0" which was aligned with IE behavior mentioned in Comment 0. I think we can mark this as "RESOLVED CONFIGURATION CHANGED", if it is not aligned with spec still (to allow negative), appreciate if someone and can mark this bug accordingly. Link to Webkit Github source for HTMLSelectElement for setMultiple: https://github.com/WebKit/WebKit/blob/dd956d5e74249681ddf904e0bbe401f308b65e0f/Source/WebCore/html/HTMLSelectElement.cpp#L443 1889398 9 gsnedders 2022-08-06 12:02:06 -0700 And this is well-tested in wpt /html/dom/reflection-forms.html (where we pass everything) 85512 2011-03-11 12:29:49 -0800 2011-04-26 16:24:39 -0700 Proposed patch bug-44887.diff text/plain 5871 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2MGNkNDk0Li5iNzUxMWQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDMt MTEgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIDxzZWxlY3Q+LCBzZXR0aW5nIHJlZmxl Y3RlZCBhdHRyaWJ1dGUgc2l6ZSB0byBuZWdhdGl2ZSBudW1iZXIgc2hvdWxkIHRocm93IGV4Y2Vw dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ4 ODcKKworICAgICAgICAqIGZhc3QvZG9tL0hUTUxTZWxlY3RFbGVtZW50L3NjcmlwdC10ZXN0cy9z aXplLWF0dHJpYnV0ZS1leGNlcHRpb24uanM6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL0hU TUxTZWxlY3RFbGVtZW50L3NpemUtYXR0cmlidXRlLWV4Y2VwdGlvbi1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvZG9tL0hUTUxTZWxlY3RFbGVtZW50L3NpemUtYXR0cmlidXRl LWV4Y2VwdGlvbi5odG1sOiBBZGRlZC4KKwogMjAxMS0wMy0xMCAgTGV2aSBXZWludHJhdWIgIDxs ZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvc2NyaXB0 LXRlc3RzL3NpemUtYXR0cmlidXRlLWV4Y2VwdGlvbi5qcyBiL0xheW91dFRlc3RzL2Zhc3QvZG9t L0hUTUxTZWxlY3RFbGVtZW50L3NjcmlwdC10ZXN0cy9zaXplLWF0dHJpYnV0ZS1leGNlcHRpb24u anMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uODMxNDAyNAotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxTZWxlY3RFbGVtZW50L3NjcmlwdC10 ZXN0cy9zaXplLWF0dHJpYnV0ZS1leGNlcHRpb24uanMKQEAgLTAsMCArMSwxMyBAQAorZGVzY3Jp cHRpb24oIlRoaXMgdGVzdHMgdGhhdCBIVE1MU2VsZWN0RWxlbWVudCdzIHNpemUgYXR0cmlidXRl IHRocm93cyBJTkRFWF9TSVpFX0VSUiB3aGVuIHNldCB0byBhIHZhbHVlIGJlbG93IDEuIik7CisK K3ZhciBzZWxlY3QgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzZWxlY3QiKTsKKworLy8gTm90 ZSB0aGF0IHRoZSBzaXplIGF0dHJpYnV0ZSBpcyBvcmlnaW5hbGx5IDAsIGluIGFjY29yZGFuY2Ug d2l0aCBIVE1MNS4KK3Nob3VsZEJlKCJzZWxlY3Quc2l6ZSIsICIwIik7CitzaG91bGRCZSgic2Vs ZWN0LnNpemUgPSAzOyBzZWxlY3Quc2l6ZSIsICIzIik7CitzaG91bGRUaHJvdygic2VsZWN0LnNp emUgPSAwIiwgIidFcnJvcjogSU5ERVhfU0laRV9FUlI6IERPTSBFeGNlcHRpb24gMSciKTsKK3No b3VsZEJlKCJzZWxlY3Quc2l6ZSIsICIzIik7CitzaG91bGRUaHJvdygic2VsZWN0LnNpemUgPSAt MSIsICInRXJyb3I6IElOREVYX1NJWkVfRVJSOiBET00gRXhjZXB0aW9uIDEnIik7CitzaG91bGRC ZSgic2VsZWN0LnNpemUiLCAiMyIpOworCitzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvc2l6ZS1hdHRy aWJ1dGUtZXhjZXB0aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxT ZWxlY3RFbGVtZW50L3NpemUtYXR0cmlidXRlLWV4Y2VwdGlvbi1leHBlY3RlZC50eHQKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZWZkOGU0NAotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxTZWxlY3RFbGVtZW50L3NpemUtYXR0cmlidXRlLWV4 Y2VwdGlvbi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxNSBAQAorVGhpcyB0ZXN0cyB0aGF0IEhU TUxTZWxlY3RFbGVtZW50J3Mgc2l6ZSBhdHRyaWJ1dGUgdGhyb3dzIElOREVYX1NJWkVfRVJSIHdo ZW4gc2V0IHRvIGEgdmFsdWUgYmVsb3cgMS4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEg c2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgor CisKK1BBU1Mgc2VsZWN0LnNpemUgaXMgMAorUEFTUyBzZWxlY3Quc2l6ZSA9IDM7IHNlbGVjdC5z aXplIGlzIDMKK1BBU1Mgc2VsZWN0LnNpemUgPSAwIHRocmV3IGV4Y2VwdGlvbiBFcnJvcjogSU5E RVhfU0laRV9FUlI6IERPTSBFeGNlcHRpb24gMS4KK1BBU1Mgc2VsZWN0LnNpemUgaXMgMworUEFT UyBzZWxlY3Quc2l6ZSA9IC0xIHRocmV3IGV4Y2VwdGlvbiBFcnJvcjogSU5ERVhfU0laRV9FUlI6 IERPTSBFeGNlcHRpb24gMS4KK1BBU1Mgc2VsZWN0LnNpemUgaXMgMworUEFTUyBzdWNjZXNzZnVs bHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvZG9tL0hUTUxTZWxlY3RFbGVtZW50L3NpemUtYXR0cmlidXRlLWV4Y2VwdGlvbi5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvc2l6ZS1hdHRyaWJ1 dGUtZXhjZXB0aW9uLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNTE3 YzU3ZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxTZWxlY3RF bGVtZW50L3NpemUtYXR0cmlidXRlLWV4Y2VwdGlvbi5odG1sCkBAIC0wLDAgKzEsMTMgQEAKKzwh RE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhl YWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10 ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qt cHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48 L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMv c2l6ZS1hdHRyaWJ1dGUtZXhjZXB0aW9uLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8u Li9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRt bD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCAwMTRhZTZmLi4wNmNhYTk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTcgQEAKKzIwMTEtMDMtMTEgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIDxzZWxlY3Q+ LCBzZXR0aW5nIHJlZmxlY3RlZCBhdHRyaWJ1dGUgc2l6ZSB0byBuZWdhdGl2ZSBudW1iZXIgc2hv dWxkIHRocm93IGV4Y2VwdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDQ4ODcKKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9IVE1MU2VsZWN0RWxl bWVudC9zaXplLWF0dHJpYnV0ZS1leGNlcHRpb24uaHRtbAorCisgICAgICAgICogaHRtbC9IVE1M U2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6 c2V0U2l6ZSk6IFRocm93IElOREVYX1NJWkVfRVJSIHdoZW4gc2V0dGluZyBzaXplIHRvIGEgdmFs dWUgYmVsb3cgMS4KKyAgICAgICAgKiBodG1sL0hUTUxTZWxlY3RFbGVtZW50Lmg6CisgICAgICAg ICogaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5pZGw6CisKIDIwMTEtMDMtMTAgIExldmkgV2VpbnRy YXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2Ug Tml3YS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAKaW5kZXggZDIz ZTU2YS4uOTdlMWQzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0 RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5j cHAKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlICJBWE9iamVjdENhY2hlLmgiCiAjaW5jbHVk ZSAiQXR0cmlidXRlLmgiCiAjaW5jbHVkZSAiRXZlbnROYW1lcy5oIgorI2luY2x1ZGUgIkV4Y2Vw dGlvbkNvZGUuaCIKICNpbmNsdWRlICJIVE1MTmFtZXMuaCIKICNpbmNsdWRlICJIVE1MT3B0aW9u RWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxPcHRpb25zQ29sbGVjdGlvbi5oIgpAQCAtNDM3LDgg KzQzOCwxMiBAQCB2b2lkIEhUTUxTZWxlY3RFbGVtZW50OjpzZXRNdWx0aXBsZShib29sIG11bHRp cGxlKQogICAgIHNldEF0dHJpYnV0ZShtdWx0aXBsZUF0dHIsIG11bHRpcGxlID8gIiIgOiAwKTsK IH0KIAotdm9pZCBIVE1MU2VsZWN0RWxlbWVudDo6c2V0U2l6ZShpbnQgc2l6ZSkKK3ZvaWQgSFRN TFNlbGVjdEVsZW1lbnQ6OnNldFNpemUoaW50IHNpemUsIEV4Y2VwdGlvbkNvZGUmIGVjKQogewor ICAgIGlmIChzaXplIDwgMSkgeworICAgICAgICBlYyA9IElOREVYX1NJWkVfRVJSOworICAgICAg ICByZXR1cm47CisgICAgfQogICAgIHNldEF0dHJpYnV0ZShzaXplQXR0ciwgU3RyaW5nOjpudW1i ZXIoc2l6ZSkpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxl Y3RFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmgKaW5k ZXggODM3Njc1Yy4uMGFmMTExOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M U2VsZWN0RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1l bnQuaApAQCAtNzIsNyArNzIsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHNldE11bHRpcGxlKGJv b2wpOwogCi0gICAgdm9pZCBzZXRTaXplKGludCk7CisgICAgdm9pZCBzZXRTaXplKGludCwgRXhj ZXB0aW9uQ29kZSYpOwogCiAgICAgdm9pZCBzZXRPcHRpb24odW5zaWduZWQgaW5kZXgsIEhUTUxP cHRpb25FbGVtZW50KiwgRXhjZXB0aW9uQ29kZSYpOwogICAgIHZvaWQgc2V0TGVuZ3RoKHVuc2ln bmVkLCBFeGNlcHRpb25Db2RlJik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxTZWxlY3RFbGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1l bnQuaWRsCmluZGV4IGY1YWM2OWIuLjUyZDg1MjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TFNlbGVjdEVsZW1lbnQuaWRsCkBAIC01MCw3ICs1MCw3IEBAIG1vZHVsZSBodG1sIHsKICAgICAg ICAgYXR0cmlidXRlIGJvb2xlYW4gbXVsdGlwbGU7CiAgICAgICAgIGF0dHJpYnV0ZSBbQ29udmVy dE51bGxUb051bGxTdHJpbmddIERPTVN0cmluZyBuYW1lOwogICAgICAgICBhdHRyaWJ1dGUgW1Jl ZmxlY3RdIGJvb2xlYW4gcmVxdWlyZWQ7Ci0gICAgICAgIGF0dHJpYnV0ZSBsb25nIHNpemU7Cisg ICAgICAgIGF0dHJpYnV0ZSBsb25nIHNpemUgc2V0dGVyIHJhaXNlcyAoRE9NRXhjZXB0aW9uKTsK ICAgICAgICAgCiAgICAgICAgIFtPbGRTdHlsZU9iakNdIHZvaWQgYWRkKGluIEhUTUxFbGVtZW50 IGVsZW1lbnQsIGluIEhUTUxFbGVtZW50IGJlZm9yZSkgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAK