44865 2010-08-30 04:09:45 -0700 REGRESSION (r66156): Sites using AppleConnect for authentication fail to log in. 2010-08-30 18:02:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes oldest_to_newest 271381 0 aestes 2010-08-30 04:09:45 -0700 REGRESSION (r66156): Sites using AppleConnect for authentication fail to log in. 271383 1 65904 aestes 2010-08-30 04:17:42 -0700 Created attachment 65904 Patch 271384 2 aestes 2010-08-30 04:18:59 -0700 <rdar://problem/8366089> 271500 3 65904 darin 2010-08-30 10:31:24 -0700 Comment on attachment 65904 Patch > + bool forceFallback = frame->settings()->needsSiteSpecificQuirks() && document()->url().host() == "wdg2.apple.com"; If you put this into an inline function rather than a boolean local variable then you would not be evaluating it if beforeLoadAllowedLoad is true. In the current code you always evaluate this, even if you don't use its result. I think this needs a "why" comment in the code. It can be a brief one. Is there a guarantee that frame->settings() can't be 0? What if we are in a frame after it is no longer connected to a page? Then frame->settings() will be 0. Are we guaranteed safe from that? Seems OK, r=me 271768 4 65980 aestes 2010-08-30 17:01:09 -0700 Created attachment 65980 Patch 271771 5 aestes 2010-08-30 17:02:25 -0700 Darin, based on our conversation this morning, here is an updated patch that keys off the plug-in MIME type rather than the URL and works by lower-casing the plug-in parameters rather than falling back to the embed. 271804 6 65980 darin 2010-08-30 17:40:02 -0700 Comment on attachment 65980 Patch > + if (frame && frame->settings()->needsSiteSpecificQuirks() && mimeType == "application/x-snkp") { Since MIME types are not case sensitive it would be better to use equalIgnoringCase. You’ll also need to update StringsNotToBeLocalized.txt to add this new non-localized string. 271823 7 aestes 2010-08-30 18:02:30 -0700 Committed http://trac.webkit.org/changeset/66437. 65904 2010-08-30 04:17:42 -0700 2010-08-30 17:01:05 -0700 Patch bug-44865-20100830041741.patch text/plain 1988 aestes SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjM4MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDgtMzAgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JF U1NJT04gKHI2NjE1Nik6IFNpdGVzIHVzaW5nIEFwcGxlQ29ubmVjdCBmb3IgYXV0aGVudGljYXRp b24gZmFpbCB0byBsb2cgaW4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00NDg2NQorCisgICAgICAgIEFmdGVyIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcv Y2hhbmdlc2V0LzY2MTU2LCBzaXRlcyB1c2luZyB0aGUgQXBwbGVDb25uZWN0IHBsdWctaW4KKyAg ICAgICAgZm9yIGF1dGhlbnRpY2F0aW9uIGZhaWwgdG8gbG9nIGluLiBUaGlzIGlzIGR1ZSB0byBh IGJ1ZyBpbiBBcHBsZUNvbm5lY3QgdGhhdCByNjYxNTYKKyAgICAgICAgZXhwb3NlZCwgYnV0IHNp bmNlIHRoaXMgd2lsbCBoYXZlIGEgc2lnbmlmaWNhbnQgaW1wYWN0IG9uIHVzZXJzIG9mIFdlYktp dCBuaWdodGx5CisgICAgICAgIGJ1aWxkcywgYSBzaXRlLXNwZWNpZmljIGhhY2sgc2hvdWxkIGJl IGFkZGVkIHdoaWxlIHRoZSB1bmRlcmx5aW5nIGlzc3VlIGlzIGJlaW5nCisgICAgICAgIGFkZHJl c3NlZC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJFbWJlZGRlZE9iamVjdC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJFbWJlZGRlZE9iamVjdDo6dXBkYXRlV2lkZ2V0KToKKwog MjAxMC0wOC0zMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyRW1iZWRkZWRPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckVtYmVkZGVkT2JqZWN0LmNwcAkocmV2aXNpb24gNjYzNjkpCisrKyBXZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJFbWJlZGRlZE9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3NSw3ICsy NzUsOSBAQCB2b2lkIFJlbmRlckVtYmVkZGVkT2JqZWN0Ojp1cGRhdGVXaWRnZXQoCiAgICAgICAg IGlmICghbm9kZSgpKQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAKLSAgICAgICAgYm9v bCBzdWNjZXNzID0gYmVmb3JlTG9hZEFsbG93ZWRMb2FkICYmIGZyYW1lLT5sb2FkZXIoKS0+c3Vi ZnJhbWVMb2FkZXIoKS0+cmVxdWVzdE9iamVjdCh0aGlzLCB1cmwsIG9iamVjdEVsZW1lbnQtPmdl dEF0dHJpYnV0ZShuYW1lQXR0ciksIHNlcnZpY2VUeXBlLCBwYXJhbU5hbWVzLCBwYXJhbVZhbHVl cyk7CisgICAgICAgIGJvb2wgZm9yY2VGYWxsYmFjayA9IGZyYW1lLT5zZXR0aW5ncygpLT5uZWVk c1NpdGVTcGVjaWZpY1F1aXJrcygpICYmIGRvY3VtZW50KCktPnVybCgpLmhvc3QoKSA9PSAid2Rn Mi5hcHBsZS5jb20iOworICAgICAgICAKKyAgICAgICAgYm9vbCBzdWNjZXNzID0gYmVmb3JlTG9h ZEFsbG93ZWRMb2FkICYmICFmb3JjZUZhbGxiYWNrICYmIGZyYW1lLT5sb2FkZXIoKS0+c3ViZnJh bWVMb2FkZXIoKS0+cmVxdWVzdE9iamVjdCh0aGlzLCB1cmwsIG9iamVjdEVsZW1lbnQtPmdldEF0 dHJpYnV0ZShuYW1lQXR0ciksIHNlcnZpY2VUeXBlLCBwYXJhbU5hbWVzLCBwYXJhbVZhbHVlcyk7 CiAgICAgCiAgICAgICAgIGlmICghc3VjY2VzcyAmJiBtX2hhc0ZhbGxiYWNrQ29udGVudCkKICAg ICAgICAgICAgIG9iamVjdEVsZW1lbnQtPnJlbmRlckZhbGxiYWNrQ29udGVudCgpOwo= 65980 2010-08-30 17:01:09 -0700 2010-08-30 17:40:02 -0700 Patch bug-44865-20100830170107.patch text/plain 3788 aestes SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA2NjQyNSkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDgtMzAgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJFR1JFU1NJT04gKHI2NjE1Nik6IFNpdGVzIHVzaW5nIEFwcGxlQ29ubmVjdCBmb3IgYXV0 aGVudGljYXRpb24gZmFpbCB0byBsb2cgaW4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00NDg2NQorCisgICAgICAgIEFmdGVyIGh0dHA6Ly90cmFjLndl YmtpdC5vcmcvY2hhbmdlc2V0LzY2MTU2LCBzaXRlcyB1c2luZyB0aGUgQXBwbGVDb25uZWN0IHBs dWctaW4KKyAgICAgICAgZm9yIGF1dGhlbnRpY2F0aW9uIGZhaWwgdG8gbG9nIGluLiBUaGlzIGlz IGR1ZSB0byBhIGJ1ZyBpbiBBcHBsZUNvbm5lY3QgdGhhdCByNjYxNTYKKyAgICAgICAgZXhwb3Nl ZCwgYnV0IHNpbmNlIHRoaXMgd2lsbCBoYXZlIGEgc2lnbmlmaWNhbnQgaW1wYWN0IG9uIHVzZXJz IG9mIFdlYktpdCBuaWdodGx5CisgICAgICAgIGJ1aWxkcywgYSBwbHVnaW4tc3BlY2lmaWMgaGFj ayBzaG91bGQgYmUgYWRkZWQgd2hpbGUgdGhlIHVuZGVybHlpbmcgaXNzdWUgaXMgYmVpbmcKKyAg ICAgICAgYWRkcmVzc2VkLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2Fk ZXJDbGllbnQubW06CisgICAgICAgIChXZWJGcmFtZUxvYWRlckNsaWVudDo6Y3JlYXRlUGx1Z2lu KTogQ29udmVydCBwbHVnLWluIHBhcmFtZXRlciBuYW1lcyB0byBsb3dlcmNhc2UKKyAgICAgICAg aWYgdGhlIHBsdWdpbiBpcyBvZiB0eXBlICdhcHBsaWNhdGlvbi94LXNua3AnLgorCiAyMDEwLTA4 LTI3ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEVyaWMgQ2FybHNvbi4KSW5kZXg6IFdlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViRnJh bWVMb2FkZXJDbGllbnQubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9y dC9XZWJGcmFtZUxvYWRlckNsaWVudC5tbQkocmV2aXNpb24gNjY0MDEpCisrKyBXZWJLaXQvbWFj L1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50Lm1tCSh3b3JraW5nIGNvcHkpCkBA IC0xNTc2LDggKzE1NzYsMjAgQEAgUGFzc1JlZlB0cjxXaWRnZXQ+IFdlYkZyYW1lTG9hZGVyQ2xp ZW50OgogICAgIE5TVVJMICpiYXNlVVJMID0gZG9jdW1lbnQtPmJhc2VVUkwoKTsKICAgICBOU1VS TCAqcGx1Z2luVVJMID0gdXJsOwogICAgIAorICAgIC8vIDxyZGFyOi8vcHJvYmxlbS84MzY2MDg5 PjogQXBwbGVDb25uZWN0IGhhcyBhIGJ1ZyB3aGVyZSBpdCBkb2VzIG5vdAorICAgIC8vIHVuZGVy c3RhbmQgdGhlIHBhcmFtZXRlciBuYW1lcyBzcGVjaWZpZWQgaW4gdGhlIDxvYmplY3Q+IGVsZW1l bnQgdGhhdAorICAgIC8vIGVtYmVkcyBpdHMgcGx1Zy1pbi4gVGhpcyBzaXRlLXNwZWNpZmljIGhh Y2sgd29ya3MgYXJvdW5kIHRoZSBpc3N1ZSBieQorICAgIC8vIGNvbnZlcnRpbmcgdGhlIHBhcmFt ZXRlciBuYW1lcyB0byBsb3dlcmNhc2UgYmVmb3JlIHBhc3NpbmcgdGhlbSB0byB0aGUKKyAgICAv LyBwbHVnLWluLgorICAgIEZyYW1lKiBmcmFtZSA9IGNvcmUobV93ZWJGcmFtZS5nZXQoKSk7Cisg ICAgTlNNdXRhYmxlQXJyYXkgKmF0dHJpYnV0ZUtleXMgPSBraXQocGFyYW1OYW1lcyk7CisgICAg aWYgKGZyYW1lICYmIGZyYW1lLT5zZXR0aW5ncygpLT5uZWVkc1NpdGVTcGVjaWZpY1F1aXJrcygp ICYmIG1pbWVUeXBlID09ICJhcHBsaWNhdGlvbi94LXNua3AiKSB7CisgICAgICAgIGZvciAoTlNV SW50ZWdlciBpID0gMDsgaSA8IFthdHRyaWJ1dGVLZXlzIGNvdW50XTsgKytpKQorICAgICAgICAg ICAgW2F0dHJpYnV0ZUtleXMgcmVwbGFjZU9iamVjdEF0SW5kZXg6aSB3aXRoT2JqZWN0OltbYXR0 cmlidXRlS2V5cyBvYmplY3RBdEluZGV4OmldIGxvd2VyY2FzZVN0cmluZ11dOworICAgIH0KKyAg ICAKICAgICBpZiAoW1t3ZWJWaWV3IFVJRGVsZWdhdGVdIHJlc3BvbmRzVG9TZWxlY3RvcjpzZWxl Y3Rvcl0pIHsKLSAgICAgICAgTlNNdXRhYmxlRGljdGlvbmFyeSAqYXR0cmlidXRlcyA9IFtbTlNN dXRhYmxlRGljdGlvbmFyeSBhbGxvY10gaW5pdFdpdGhPYmplY3RzOmtpdChwYXJhbVZhbHVlcykg Zm9yS2V5czpraXQocGFyYW1OYW1lcyldOworICAgICAgICBOU011dGFibGVEaWN0aW9uYXJ5ICph dHRyaWJ1dGVzID0gW1tOU011dGFibGVEaWN0aW9uYXJ5IGFsbG9jXSBpbml0V2l0aE9iamVjdHM6 a2l0KHBhcmFtVmFsdWVzKSBmb3JLZXlzOmF0dHJpYnV0ZUtleXNdOwogICAgICAgICBOU0RpY3Rp b25hcnkgKmFyZ3VtZW50cyA9IFtbTlNEaWN0aW9uYXJ5IGFsbG9jXSBpbml0V2l0aE9iamVjdHNB bmRLZXlzOgogICAgICAgICAgICAgYXR0cmlidXRlcywgV2ViUGx1Z0luQXR0cmlidXRlc0tleSwK ICAgICAgICAgICAgIFtOU051bWJlciBudW1iZXJXaXRoSW50OmxvYWRNYW51YWxseSA/IFdlYlBs dWdJbk1vZGVGdWxsIDogV2ViUGx1Z0luTW9kZUVtYmVkXSwgV2ViUGx1Z0luTW9kZUtleSwKQEAg LTE2MjAsNyArMTYzMiw3IEBAIFBhc3NSZWZQdHI8V2lkZ2V0PiBXZWJGcmFtZUxvYWRlckNsaWVu dDoKIAogICAgIGlmIChwbHVnaW5QYWNrYWdlKSB7CiAgICAgICAgIGlmIChbcGx1Z2luUGFja2Fn ZSBpc0tpbmRPZkNsYXNzOltXZWJQbHVnaW5QYWNrYWdlIGNsYXNzXV0pCi0gICAgICAgICAgICB2 aWV3ID0gcGx1Z2luVmlldyhtX3dlYkZyYW1lLmdldCgpLCAoV2ViUGx1Z2luUGFja2FnZSAqKXBs dWdpblBhY2thZ2UsIGtpdChwYXJhbU5hbWVzKSwga2l0KHBhcmFtVmFsdWVzKSwgYmFzZVVSTCwg a2l0KGVsZW1lbnQpLCBsb2FkTWFudWFsbHkpOworICAgICAgICAgICAgdmlldyA9IHBsdWdpblZp ZXcobV93ZWJGcmFtZS5nZXQoKSwgKFdlYlBsdWdpblBhY2thZ2UgKilwbHVnaW5QYWNrYWdlLCBh dHRyaWJ1dGVLZXlzLCBraXQocGFyYW1WYWx1ZXMpLCBiYXNlVVJMLCBraXQoZWxlbWVudCksIGxv YWRNYW51YWxseSk7CiAgICAgICAgICAgICAKICNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQ SSkKICAgICAgICAgZWxzZSBpZiAoW3BsdWdpblBhY2thZ2UgaXNLaW5kT2ZDbGFzczpbV2ViTmV0 c2NhcGVQbHVnaW5QYWNrYWdlIGNsYXNzXV0pIHsKQEAgLTE2MzAsNyArMTY0Miw3IEBAIFBhc3NS ZWZQdHI8V2lkZ2V0PiBXZWJGcmFtZUxvYWRlckNsaWVudDoKICAgICAgICAgICAgICAgICBVUkw6 cGx1Z2luVVJMCiAgICAgICAgICAgICAgICAgYmFzZVVSTDpiYXNlVVJMCiAgICAgICAgICAgICAg ICAgTUlNRVR5cGU6TUlNRVR5cGUKLSAgICAgICAgICAgICAgICBhdHRyaWJ1dGVLZXlzOmtpdChw YXJhbU5hbWVzKQorICAgICAgICAgICAgICAgIGF0dHJpYnV0ZUtleXM6YXR0cmlidXRlS2V5cwog ICAgICAgICAgICAgICAgIGF0dHJpYnV0ZVZhbHVlczpraXQocGFyYW1WYWx1ZXMpCiAgICAgICAg ICAgICAgICAgbG9hZE1hbnVhbGx5OmxvYWRNYW51YWxseQogICAgICAgICAgICAgICAgIGVsZW1l bnQ6ZWxlbWVudF0gYXV0b3JlbGVhc2VdOwo=