44855 2010-08-29 23:58:58 -0700 REGRESSION(r66355): Fix warnings in html/DateComponents.cpp 2010-08-30 02:48:27 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 43191 1 ossy webkit-unassigned darin tkent oldest_to_newest 271324 0 ossy 2010-08-29 23:58:58 -0700 gcc warning: ../../../WebCore/html/DateComponents.cpp:642: warning: suggest parentheses around && within || 271325 1 65885 ossy 2010-08-29 23:59:55 -0700 Created attachment 65885 proposed fix 271326 2 65885 tkent 2010-08-30 00:03:44 -0700 Comment on attachment 65885 proposed fix Thanks! 271367 3 65885 ossy 2010-08-30 02:48:18 -0700 Comment on attachment 65885 proposed fix Clearing flags on attachment: 65885 Committed r66379: <http://trac.webkit.org/changeset/66379> 271368 4 ossy 2010-08-30 02:48:27 -0700 All reviewed patches have been landed. Closing bug. 65885 2010-08-29 23:59:55 -0700 2010-08-30 02:48:18 -0700 proposed fix 1.patch text/plain 1190 ossy SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjM2NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDgtMjkgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSRUdSRVNTSU9OKHI2NjM1NSk6IEZpeCB3YXJuaW5ncyBpbiBodG1sL0RhdGVDb21wb25lbnRz LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ4 NTUKKworICAgICAgICAqIGh0bWwvRGF0ZUNvbXBvbmVudHMuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RGF0ZUNvbXBvbmVudHM6OnNldE1pbGxpc2Vjb25kc1NpbmNlRXBvY2hGb3JXZWVrKTogU3Vn Z2VzdGVkIHBhcmVudGhlc2VzIGFkZGVkIGFyb3VuZCAmJiB3aXRoaW4gfHwKKwogMjAxMC0wOC0y OSAgTWFyYy1BbnRvaW5lIFJ1ZWwgIDxtYXJ1ZWxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpJbmRleDogV2ViQ29yZS9odG1sL0RhdGVDb21wb25lbnRz LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvRGF0ZUNvbXBvbmVudHMuY3BwCShyZXZp c2lvbiA2NjM1OCkKKysrIFdlYkNvcmUvaHRtbC9EYXRlQ29tcG9uZW50cy5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTYzOSw3ICs2MzksNyBAQAogICAgICAgICAgICAgbV95ZWFyKys7CiAgICAgICAg ICAgICBtX3dlZWsgPSAxOwogICAgICAgICB9Ci0gICAgICAgIGlmIChtX3llYXIgPiBtYXhpbXVt WWVhciB8fCBtX3llYXIgPT0gbWF4aW11bVllYXIgJiYgbV93ZWVrID4gbWF4aW11bVdlZWtJbk1h eGltdW1ZZWFyKQorICAgICAgICBpZiAobV95ZWFyID4gbWF4aW11bVllYXIgfHwgKG1feWVhciA9 PSBtYXhpbXVtWWVhciAmJiBtX3dlZWsgPiBtYXhpbXVtV2Vla0luTWF4aW11bVllYXIpKQogICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KICAgICBtX3R5cGUgPSBXZWVrOwo=