44843 2010-08-29 14:31:22 -0700 REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp 2010-08-30 02:46:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 43191 1 ossy webkit-unassigned abarth darin eric rniwa tkent webkit.review.bot oldest_to_newest 271215 0 ossy 2010-08-29 14:31:22 -0700 gcc warnings: ../../../WebCore/editing/ApplyStyleCommand.cpp:1209: warning: suggest parentheses around && within || ../../../WebCore/editing/ApplyStyleCommand.cpp:1210: warning: suggest parentheses around && within || 271216 1 65862 ossy 2010-08-29 14:33:29 -0700 Created attachment 65862 proposed fix 271219 2 65862 rniwa 2010-08-29 14:42:44 -0700 Comment on attachment 65862 proposed fix > WebCore/editing/ApplyStyleCommand.cpp:1210 > + || (equivalent.attribute && !element->hasAttribute(*equivalent.attribute))) Looks good to me. Sorry about the regression. 271221 3 ossy 2010-08-29 14:47:48 -0700 (In reply to comment #2) > Looks good to me. Sorry about the regression. Not problem, now it isn't a big problem, but we are going to treat warnings as errors on Qt port. (with gcc -Werror option) After that all warnings will cause a build fail. ( See https://bugs.webkit.org/show_bug.cgi?id=43191 ) 271224 4 65862 ossy 2010-08-29 15:09:17 -0700 Comment on attachment 65862 proposed fix Clearing flags on attachment: 65862 Committed r66338: <http://trac.webkit.org/changeset/66338> 271225 5 ossy 2010-08-29 15:09:26 -0700 All reviewed patches have been landed. Closing bug. 271229 6 webkit.review.bot 2010-08-29 15:51:44 -0700 http://trac.webkit.org/changeset/66338 might have broken Qt Linux Release 271317 7 65884 ossy 2010-08-29 23:52:14 -0700 Created attachment 65884 proposed fix 2 Crazy gcc, there are one more warning in line 1208, but it reported line 1209 : ../../../WebCore/editing/ApplyStyleCommand.cpp:1209: warning: suggest parentheses around && within || 271319 8 ossy 2010-08-29 23:53:01 -0700 (In reply to comment #6) > http://trac.webkit.org/changeset/66338 might have broken Qt Linux Release No, it isn't. 271366 9 65884 ossy 2010-08-30 02:46:31 -0700 Comment on attachment 65884 proposed fix 2 Landed in http://trac.webkit.org/changeset/66378 65862 2010-08-29 14:33:29 -0700 2010-08-29 15:09:16 -0700 proposed fix 1.patch text/plain 1591 ossy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YmUyYzhiYy4uYmUyNGFkZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0yOSAgQ3NhYmEgT3N6dHJv Z29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04ocjY2MzI0KTogRml4IHdhcm5pbmdzIGluIGVk aXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00NDg0MworCisgICAgICAgICogZWRpdGluZy9BcHBseVN0eWxl Q29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBcHBseVN0eWxlQ29tbWFuZDo6cmVtb3Zl SW1wbGljaXRseVN0eWxlZEVsZW1lbnQpOiBTdWdnZXN0ZWQgcGFyZW50aGVzZXMgYWRkZWQgYXJv dW5kICYmIHdpdGhpbiB8fAorCiAyMDEwLTA4LTI5ICBQYXdlbCBIYWpkYW4gIDxwaGFqZGFuLmpy QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAt LWdpdCBhL1dlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHAgYi9XZWJDb3JlL2Vk aXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwCmluZGV4IDkwOThkYTQuLmYzMWEwMGYgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHAKKysrIGIvV2ViQ29y ZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcApAQCAtMTIwNiw4ICsxMjA2LDggQEAgYm9v bCBBcHBseVN0eWxlQ29tbWFuZDo6cmVtb3ZlSW1wbGljaXRseVN0eWxlZEVsZW1lbnQoQ1NTTXV0 YWJsZVN0eWxlRGVjbGFyYXRpb24KICAgICAgICAgY29uc3QgSFRNTEVxdWl2YWxlbnQmIGVxdWl2 YWxlbnQgPSBIVE1MRXF1aXZhbGVudHNbaV07CiAgICAgICAgIEFTU0VSVChlcXVpdmFsZW50LmVs ZW1lbnQgfHwgZXF1aXZhbGVudC5hdHRyaWJ1dGUpOwogICAgICAgICBpZiAoZXh0cmFjdGVkU3R5 bGUgJiYgZXF1aXZhbGVudC5wdXNoRG93blR5cGUgPT0gU2hvdWxkTm90QmVQdXNoZWREb3duCi0g ICAgICAgICAgICB8fCBlcXVpdmFsZW50LmVsZW1lbnQgJiYgIWVsZW1lbnQtPmhhc1RhZ05hbWUo KmVxdWl2YWxlbnQuZWxlbWVudCkKLSAgICAgICAgICAgIHx8IGVxdWl2YWxlbnQuYXR0cmlidXRl ICYmICFlbGVtZW50LT5oYXNBdHRyaWJ1dGUoKmVxdWl2YWxlbnQuYXR0cmlidXRlKSkKKyAgICAg ICAgICAgIHx8IChlcXVpdmFsZW50LmVsZW1lbnQgJiYgIWVsZW1lbnQtPmhhc1RhZ05hbWUoKmVx dWl2YWxlbnQuZWxlbWVudCkpCisgICAgICAgICAgICB8fCAoZXF1aXZhbGVudC5hdHRyaWJ1dGUg JiYgIWVsZW1lbnQtPmhhc0F0dHJpYnV0ZSgqZXF1aXZhbGVudC5hdHRyaWJ1dGUpKSkKICAgICAg ICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgIFJlZlB0cjxDU1NWYWx1ZT4gc3R5bGVWYWx1ZSA9 IHN0eWxlLT5nZXRQcm9wZXJ0eUNTU1ZhbHVlKGVxdWl2YWxlbnQucHJvcGVydHlJRCk7Cg== 65884 2010-08-29 23:52:14 -0700 2010-08-30 02:46:31 -0700 proposed fix 2 1.patch text/plain 1431 ossy SW5kZXg6IGVkaXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGVkaXRp bmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwCShyZXZpc2lvbiA2NjM1OCkKKysrIGVkaXRpbmcvQXBw bHlTdHlsZUNvbW1hbmQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjA1LDcgKzEyMDUsNyBAQAog ICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgc2l6ZW9mKEhUTUxFcXVpdmFsZW50cykgLyBzaXpl b2YoSFRNTEVxdWl2YWxlbnQpOyBpKyspIHsKICAgICAgICAgY29uc3QgSFRNTEVxdWl2YWxlbnQm IGVxdWl2YWxlbnQgPSBIVE1MRXF1aXZhbGVudHNbaV07CiAgICAgICAgIEFTU0VSVChlcXVpdmFs ZW50LmVsZW1lbnQgfHwgZXF1aXZhbGVudC5hdHRyaWJ1dGUpOwotICAgICAgICBpZiAoZXh0cmFj dGVkU3R5bGUgJiYgZXF1aXZhbGVudC5wdXNoRG93blR5cGUgPT0gU2hvdWxkTm90QmVQdXNoZWRE b3duCisgICAgICAgIGlmICgoZXh0cmFjdGVkU3R5bGUgJiYgZXF1aXZhbGVudC5wdXNoRG93blR5 cGUgPT0gU2hvdWxkTm90QmVQdXNoZWREb3duKQogICAgICAgICAgICAgfHwgKGVxdWl2YWxlbnQu ZWxlbWVudCAmJiAhZWxlbWVudC0+aGFzVGFnTmFtZSgqZXF1aXZhbGVudC5lbGVtZW50KSkKICAg ICAgICAgICAgIHx8IChlcXVpdmFsZW50LmF0dHJpYnV0ZSAmJiAhZWxlbWVudC0+aGFzQXR0cmli dXRlKCplcXVpdmFsZW50LmF0dHJpYnV0ZSkpKQogICAgICAgICAgICAgY29udGludWU7CkluZGV4 OiBDaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gQ2hhbmdlTG9nCShyZXZpc2lvbiA2NjM2MSkKKysr IENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA4LTI5ICBD c2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTihyNjYzMjQpOiBGaXggd2Fy bmluZ3MgaW4gZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0ODQzCisKKyAgICAgICAgKiBlZGl0aW5n L0FwcGx5U3R5bGVDb21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFwcGx5U3R5bGVDb21t YW5kOjpyZW1vdmVJbXBsaWNpdGx5U3R5bGVkRWxlbWVudCk6IFN1Z2dlc3RlZCBwYXJlbnRoZXNl cyBhZGRlZCBhcm91bmQgJiYgd2l0aGluIHx8CisKIDIwMTAtMDgtMjkgIE1hcmMtQW50b2luZSBS dWVsICA8bWFydWVsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRh bXVyYS4K