44820 2010-08-28 10:30:31 -0700 [WINCE] Add ContextMenuClientWinCE 2010-08-31 10:38:44 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 paroga webkit-unassigned commit-queue oldest_to_newest 271017 0 paroga 2010-08-28 10:30:31 -0700 see patch 271019 1 65830 paroga 2010-08-28 10:31:01 -0700 Created attachment 65830 Patch 271999 2 65830 kenneth 2010-08-31 02:56:33 -0700 Comment on attachment 65830 Patch ContextMenuClient::ContextMenuClient(WebView *webView) * should be left aligned 272018 3 65830 commit-queue 2010-08-31 03:37:22 -0700 Comment on attachment 65830 Patch Rejecting patch 65830 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Last 500 characters of output: file(s). patching file WebKit/wince/WebCoreSupport/ContextMenuClientWinCE.cpp patching file WebKit/wince/WebCoreSupport/ContextMenuClientWinCE.h can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: webkit/wince/ChangeLog |index 73893df..75235ce 100644 |--- webkit/wince/ChangeLog |+++ webkit/wince/ChangeLog -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored Full output: http://queues.webkit.org/results/3834194 272199 4 65830 commit-queue 2010-08-31 10:38:39 -0700 Comment on attachment 65830 Patch Clearing flags on attachment: 65830 Committed r66503: <http://trac.webkit.org/changeset/66503> 272200 5 commit-queue 2010-08-31 10:38:44 -0700 All reviewed patches have been landed. Closing bug. 65830 2010-08-28 10:31:01 -0700 2010-08-31 10:38:39 -0700 Patch 0001-ContextMenuClientWinCE.patch text/plain 6605 paroga ZGlmZiAtLWdpdCBhL1dlYktpdC93aW5jZS9XZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVudUNsaWVu dFdpbkNFLmNwcCBiL1dlYktpdC93aW5jZS9XZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVudUNsaWVu dFdpbkNFLmNwcApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi45YzQzOWUyCi0t LSAvZGV2L251bGwKKysrIGIvV2ViS2l0L3dpbmNlL1dlYkNvcmVTdXBwb3J0L0NvbnRleHRNZW51 Q2xpZW50V2luQ0UuY3BwCkBAIC0wLDAgKzEsOTEgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIw MTAgUGF0cmljayBHYW5zdGVyZXIgPHBhcm9nYUBwYXJvZ2EuY29tPgorICoKKyAqIFJlZGlzdHJp YnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91 dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxv d2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNv dXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwg dGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAq IDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJv dmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0 aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9v ciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAq IFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgQU5EIElUUyBDT05UUklCVVRPUlMg IkFTIElTIiBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVE SU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRSBJTVBMSUVECisgKiBXQVJSQU5USUVTIE9GIE1F UkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCisg KiBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBPUiBJVFMgQ09OVFJJQlVUT1JT IEJFIExJQUJMRSBGT1IgQU5ZCisgKiBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVD SUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUworICogKElOQ0xVRElORywg QlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNF UlZJQ0VTOworICogTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElO VEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5ECisgKiBPTiBBTlkgVEhFT1JZIE9GIExJQUJJ TElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICog KElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9V VCBPRiBUSEUgVVNFIE9GCisgKiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhF IFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIK KyNpbmNsdWRlICJDb250ZXh0TWVudUNsaWVudFdpbkNFLmgiCisKKyNpbmNsdWRlICJDb250ZXh0 TWVudS5oIgorI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCisKK3VzaW5nIG5hbWVzcGFjZSBX ZWJDb3JlOworCituYW1lc3BhY2UgV2ViS2l0IHsKKworQ29udGV4dE1lbnVDbGllbnQ6OkNvbnRl eHRNZW51Q2xpZW50KFdlYlZpZXcgKndlYlZpZXcpCisgICAgOiBtX3dlYlZpZXcod2ViVmlldykK K3sKK30KKwordm9pZCBDb250ZXh0TWVudUNsaWVudDo6Y29udGV4dE1lbnVEZXN0cm95ZWQoKQor eworICAgIGRlbGV0ZSB0aGlzOworfQorCitQbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbiBDb250ZXh0 TWVudUNsaWVudDo6Z2V0Q3VzdG9tTWVudUZyb21EZWZhdWx0SXRlbXMoQ29udGV4dE1lbnUqIG1l bnUpCit7CisgICAgcmV0dXJuIG1lbnUtPnJlbGVhc2VQbGF0Zm9ybURlc2NyaXB0aW9uKCk7Cit9 CisKK3ZvaWQgQ29udGV4dE1lbnVDbGllbnQ6OmNvbnRleHRNZW51SXRlbVNlbGVjdGVkKENvbnRl eHRNZW51SXRlbSosIGNvbnN0IENvbnRleHRNZW51KikKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgp OworfQorCit2b2lkIENvbnRleHRNZW51Q2xpZW50Ojpkb3dubG9hZFVSTChjb25zdCBLVVJMJiB1 cmwpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKwordm9pZCBDb250ZXh0TWVudUNsaWVu dDo6Y29weUltYWdlVG9DbGlwYm9hcmQoY29uc3QgSGl0VGVzdFJlc3VsdCYpCit7CisgICAgbm90 SW1wbGVtZW50ZWQoKTsKK30KKwordm9pZCBDb250ZXh0TWVudUNsaWVudDo6c2VhcmNoV2l0aEdv b2dsZShjb25zdCBGcmFtZSopCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKwordm9pZCBD b250ZXh0TWVudUNsaWVudDo6bG9va1VwSW5EaWN0aW9uYXJ5KEZyYW1lKikKK3sKKyAgICBub3RJ bXBsZW1lbnRlZCgpOworfQorCit2b2lkIENvbnRleHRNZW51Q2xpZW50OjpzcGVhayhjb25zdCBT dHJpbmcmKQoreworICAgIG5vdEltcGxlbWVudGVkKCk7Cit9CisKK3ZvaWQgQ29udGV4dE1lbnVD bGllbnQ6OnN0b3BTcGVha2luZygpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKworYm9v bCBDb250ZXh0TWVudUNsaWVudDo6aXNTcGVha2luZygpCit7CisgICAgbm90SW1wbGVtZW50ZWQo KTsKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKK30gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0t Z2l0IGEvV2ViS2l0L3dpbmNlL1dlYkNvcmVTdXBwb3J0L0NvbnRleHRNZW51Q2xpZW50V2luQ0Uu aCBiL1dlYktpdC93aW5jZS9XZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVudUNsaWVudFdpbkNFLmgK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZThjZjE1NgotLS0gL2Rldi9udWxs CisrKyBiL1dlYktpdC93aW5jZS9XZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVudUNsaWVudFdpbkNF LmgKQEAgLTAsMCArMSw1NyBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAxMCBQYXRyaWNrIEdh bnN0ZXJlciA8cGFyb2dhQHBhcm9nYS5jb20+CisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVz dCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2Yg Y29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmli dXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQK KyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcg ZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVy aWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FS RSBJUyBQUk9WSURFRCBCWSBBUFBMRSBBTkQgSVRTIENPTlRSSUJVVE9SUyAiQVMgSVMiIEFORCBB TlkKKyAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1Qg TElNSVRFRCBUTywgVEhFIElNUExJRUQKKyAqIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZ IEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUKKyAqIERJU0NMQUlNRUQu IElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIE9SIElUUyBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZP UiBBTlkKKyAqIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFS WSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTCisgKiAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlU RUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7CisgKiBM T1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBI T1dFVkVSIENBVVNFRCBBTkQKKyAqIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVS IElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5F R0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0Ug T0YKKyAqIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkg T0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2lmbmRlZiBDb250ZXh0TWVudUNsaWVudFdpbkNFX2gK KyNkZWZpbmUgQ29udGV4dE1lbnVDbGllbnRXaW5DRV9oCisKKyNpbmNsdWRlICJDb250ZXh0TWVu dUNsaWVudC5oIgorCitjbGFzcyBXZWJWaWV3OworCituYW1lc3BhY2UgV2ViS2l0IHsKKworY2xh c3MgQ29udGV4dE1lbnVDbGllbnQgOiBwdWJsaWMgV2ViQ29yZTo6Q29udGV4dE1lbnVDbGllbnQg eworcHVibGljOgorICAgIENvbnRleHRNZW51Q2xpZW50KFdlYlZpZXcqKTsKKworICAgIHZpcnR1 YWwgdm9pZCBjb250ZXh0TWVudURlc3Ryb3llZCgpOworCisgICAgdmlydHVhbCBXZWJDb3JlOjpQ bGF0Zm9ybU1lbnVEZXNjcmlwdGlvbiBnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcyhXZWJD b3JlOjpDb250ZXh0TWVudSopOworICAgIHZpcnR1YWwgdm9pZCBjb250ZXh0TWVudUl0ZW1TZWxl Y3RlZChXZWJDb3JlOjpDb250ZXh0TWVudUl0ZW0qLCBjb25zdCBXZWJDb3JlOjpDb250ZXh0TWVu dSopOworCisgICAgdmlydHVhbCB2b2lkIGRvd25sb2FkVVJMKGNvbnN0IFdlYkNvcmU6OktVUkwm KTsKKyAgICB2aXJ0dWFsIHZvaWQgY29weUltYWdlVG9DbGlwYm9hcmQoY29uc3QgV2ViQ29yZTo6 SGl0VGVzdFJlc3VsdCYpOworICAgIHZpcnR1YWwgdm9pZCBzZWFyY2hXaXRoR29vZ2xlKGNvbnN0 IFdlYkNvcmU6OkZyYW1lKik7CisgICAgdmlydHVhbCB2b2lkIGxvb2tVcEluRGljdGlvbmFyeShX ZWJDb3JlOjpGcmFtZSopOworICAgIHZpcnR1YWwgdm9pZCBzcGVhayhjb25zdCBXVEY6OlN0cmlu ZyYpOworICAgIHZpcnR1YWwgdm9pZCBzdG9wU3BlYWtpbmcoKTsKKyAgICB2aXJ0dWFsIGJvb2wg aXNTcGVha2luZygpOworCitwcml2YXRlOgorICAgIFdlYlZpZXcqIG1fd2ViVmlldzsKK307CisK K30gLy8gbmFtZXNwYWNlIFdlYktpdAorCisjZW5kaWYgLy8gQ29udGV4dE1lbnVDbGllbnRXaW5D RV9oCmRpZmYgLS1naXQgYS93ZWJraXQvd2luY2UvQ2hhbmdlTG9nIGIvd2Via2l0L3dpbmNlL0No YW5nZUxvZwppbmRleCA3Mzg5M2RmLi43NTIzNWNlIDEwMDY0NAotLS0gYS93ZWJraXQvd2luY2Uv Q2hhbmdlTG9nCisrKyBiL3dlYmtpdC93aW5jZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAor MjAxMC0wOC0yOCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAcGFyb2dhLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgQ29udGV4dE1l bnVDbGllbnRXaW5DRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDQ4MjAKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0NvbnRleHRNZW51Q2xpZW50 V2luQ0UuY3BwOiBBZGRlZC4KKyAgICAgICAgKFdlYktpdDo6Q29udGV4dE1lbnVDbGllbnQ6OkNv bnRleHRNZW51Q2xpZW50KToKKyAgICAgICAgKFdlYktpdDo6Q29udGV4dE1lbnVDbGllbnQ6OmNv bnRleHRNZW51RGVzdHJveWVkKToKKyAgICAgICAgKFdlYktpdDo6Q29udGV4dE1lbnVDbGllbnQ6 OmdldEN1c3RvbU1lbnVGcm9tRGVmYXVsdEl0ZW1zKToKKyAgICAgICAgKFdlYktpdDo6Q29udGV4 dE1lbnVDbGllbnQ6OmNvbnRleHRNZW51SXRlbVNlbGVjdGVkKToKKyAgICAgICAgKFdlYktpdDo6 Q29udGV4dE1lbnVDbGllbnQ6OmRvd25sb2FkVVJMKToKKyAgICAgICAgKFdlYktpdDo6Q29udGV4 dE1lbnVDbGllbnQ6OmNvcHlJbWFnZVRvQ2xpcGJvYXJkKToKKyAgICAgICAgKFdlYktpdDo6Q29u dGV4dE1lbnVDbGllbnQ6OnNlYXJjaFdpdGhHb29nbGUpOgorICAgICAgICAoV2ViS2l0OjpDb250 ZXh0TWVudUNsaWVudDo6bG9va1VwSW5EaWN0aW9uYXJ5KToKKyAgICAgICAgKFdlYktpdDo6Q29u dGV4dE1lbnVDbGllbnQ6OnNwZWFrKToKKyAgICAgICAgKFdlYktpdDo6Q29udGV4dE1lbnVDbGll bnQ6OnN0b3BTcGVha2luZyk6CisgICAgICAgIChXZWJLaXQ6OkNvbnRleHRNZW51Q2xpZW50Ojpp c1NwZWFraW5nKToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVudUNsaWVudFdp bkNFLmg6IEFkZGVkLgorCiAyMDEwLTA4LTI4ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUBw YXJvZ2EuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgo=