44819 2010-08-28 10:28:31 -0700 [WINCE] Add InspectorClientWinCE 2010-08-31 13:05:01 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 paroga webkit-unassigned aroben commit-queue oldest_to_newest 271015 0 paroga 2010-08-28 10:28:31 -0700 see patch 271016 1 65829 paroga 2010-08-28 10:29:02 -0700 Created attachment 65829 Patch 272013 2 65829 commit-queue 2010-08-31 03:21:48 -0700 Comment on attachment 65829 Patch Rejecting patch 65829 from commit-queue. Unexpected failure when processing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 65829, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 66, in run if self._has_valid_reviewer(changelog_entry): File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 48, in _has_valid_reviewer if changelog_entry.reviewer(): AttributeError: 'NoneType' object has no attribute 'reviewer' 272136 3 aroben 2010-08-31 09:24:37 -0700 Committed r66490: <http://trac.webkit.org/changeset/66490> 272297 4 paroga 2010-08-31 13:05:01 -0700 (In reply to comment #2) > (From update of attachment 65829 [details]) > Rejecting patch 65829 from commit-queue. > > Unexpected failure when processing patch! Please file a bug against webkit-patch. bug 44976 65829 2010-08-28 10:29:02 -0700 2010-08-31 03:21:48 -0700 Patch 0001-InspectorClientWinCE.patch text/plain 6123 paroga ZGlmZiAtLWdpdCBhL1dlYktpdC93aW5jZS9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRX aW5DRS5jcHAgYi9XZWJLaXQvd2luY2UvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50V2lu Q0UuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmRlYmM2MTEKLS0tIC9k ZXYvbnVsbAorKysgYi9XZWJLaXQvd2luY2UvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50 V2luQ0UuY3BwCkBAIC0wLDAgKzEsODQgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTAgUGF0 cmljayBHYW5zdGVyZXIgPHBhcm9nYUBwYXJvZ2EuY29tPgorICoKKyAqIFJlZGlzdHJpYnV0aW9u IGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICog bW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBj b25kaXRpb25zCisgKiBhcmUgbWV0OgorICogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBj b2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBs aXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqIDIuIFJl ZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29w eXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9s bG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhl ciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAqIFRISVMg U09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgQU5EIElUUyBDT05UUklCVVRPUlMgIkFTIElT IiBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBC VVQgTk9UIExJTUlURUQgVE8sIFRIRSBJTVBMSUVECisgKiBXQVJSQU5USUVTIE9GIE1FUkNIQU5U QUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCisgKiBESVND TEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBPUiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJ QUJMRSBGT1IgQU5ZCisgKiBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBF WEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUworICogKElOQ0xVRElORywgQlVUIE5P VCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VT OworICogTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQ VElPTikgSE9XRVZFUiBDQVVTRUQgQU5ECisgKiBPTiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwg V0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICogKElOQ0xV RElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBU SEUgVVNFIE9GCisgKiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJ QklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNs dWRlICJJbnNwZWN0b3JDbGllbnRXaW5DRS5oIgorCisjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQu aCIKKwordXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CisKK25hbWVzcGFjZSBXZWJLaXQgeworCitJ bnNwZWN0b3JDbGllbnQ6Okluc3BlY3RvckNsaWVudChXZWJWaWV3KiB3ZWJWaWV3KQorICAgIDog bV9pbnNwZWN0ZWRXZWJWaWV3KHdlYlZpZXcpCit7Cit9CisKK0luc3BlY3RvckNsaWVudDo6fklu c3BlY3RvckNsaWVudCgpCit7Cit9CisKK3ZvaWQgSW5zcGVjdG9yQ2xpZW50OjppbnNwZWN0b3JE ZXN0cm95ZWQoKQoreworICAgIGRlbGV0ZSB0aGlzOworfQorCit2b2lkIEluc3BlY3RvckNsaWVu dDo6b3Blbkluc3BlY3RvckZyb250ZW5kKEluc3BlY3RvckNvbnRyb2xsZXIqIGNvbnRyb2xsZXIp Cit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKwordm9pZCBJbnNwZWN0b3JDbGllbnQ6OnJl bGVhc2VGcm9udGVuZFBhZ2UoKQoreworICAgIG5vdEltcGxlbWVudGVkKCk7Cit9CisKK3ZvaWQg SW5zcGVjdG9yQ2xpZW50OjpoaWdobGlnaHQoTm9kZSogbm9kZSkKK3sKKyAgICBub3RJbXBsZW1l bnRlZCgpOworfQorCit2b2lkIEluc3BlY3RvckNsaWVudDo6aGlkZUhpZ2hsaWdodCgpCit7Cisg ICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKwordm9pZCBJbnNwZWN0b3JDbGllbnQ6OnBvcHVsYXRl U2V0dGluZyhjb25zdCBTdHJpbmcmIGtleSwgU3RyaW5nKiB2YWx1ZSkKK3sKKyAgICBub3RJbXBs ZW1lbnRlZCgpOworfQorCit2b2lkIEluc3BlY3RvckNsaWVudDo6c3RvcmVTZXR0aW5nKGNvbnN0 IFN0cmluZyYga2V5LCBjb25zdCBTdHJpbmcmIHZhbHVlKQoreworICAgIG5vdEltcGxlbWVudGVk KCk7Cit9CisKK2Jvb2wgSW5zcGVjdG9yQ2xpZW50OjpzZW5kTWVzc2FnZVRvRnJvbnRlbmQoY29u c3QgU3RyaW5nJiBtZXNzYWdlKQoreworICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJu IGZhbHNlOworfQorCit9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1dlYktpdC93 aW5jZS9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRXaW5DRS5oIGIvV2ViS2l0L3dpbmNl L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudFdpbkNFLmgKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMC4uNDVmY2M1YgotLS0gL2Rldi9udWxsCisrKyBiL1dlYktpdC93aW5j ZS9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRXaW5DRS5oCkBAIC0wLDAgKzEsNTkgQEAK Ky8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTAgUGF0cmljayBHYW5zdGVyZXIgPHBhcm9nYUBwYXJv Z2EuY29tPgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5h cnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICog MS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBj b3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBm b2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqIDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9y bSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMg bGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisg KiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0 aGUgZGlzdHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQ TEUgQU5EIElUUyBDT05UUklCVVRPUlMgIkFTIElTIiBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElN UExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRSBJTVBM SUVECisgKiBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQ QVJUSUNVTEFSIFBVUlBPU0UgQVJFCisgKiBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBB UFBMRSBPUiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZCisgKiBESVJFQ1QsIElO RElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwg REFNQUdFUworICogKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBP RiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOworICogTE9TUyBPRiBVU0UsIERBVEEsIE9S IFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5ECisg KiBPTiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNU IExJQUJJTElUWSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lT RSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GCisgKiBUSElTIFNPRlRXQVJF LCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICov CisKKyNpZm5kZWYgSW5zcGVjdG9yQ2xpZW50V2luQ0VfaAorI2RlZmluZSBJbnNwZWN0b3JDbGll bnRXaW5DRV9oCisKKyNpbmNsdWRlICJJbnNwZWN0b3JDbGllbnQuaCIKKworY2xhc3MgV2ViVmll dzsKKworbmFtZXNwYWNlIFdlYktpdCB7CisKK2NsYXNzIEluc3BlY3RvckNsaWVudCA6IHB1Ymxp YyBXZWJDb3JlOjpJbnNwZWN0b3JDbGllbnQgeworcHVibGljOgorICAgIEluc3BlY3RvckNsaWVu dChXZWJWaWV3KiB3ZWJWaWV3KTsKKyAgICB+SW5zcGVjdG9yQ2xpZW50KCk7CisKKyAgICB2aXJ0 dWFsIHZvaWQgaW5zcGVjdG9yRGVzdHJveWVkKCk7CisKKyAgICB2aXJ0dWFsIHZvaWQgb3Blbklu c3BlY3RvckZyb250ZW5kKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXIqKTsKKworICAgIHZp cnR1YWwgdm9pZCBoaWdobGlnaHQoV2ViQ29yZTo6Tm9kZSopOworICAgIHZpcnR1YWwgdm9pZCBo aWRlSGlnaGxpZ2h0KCk7CisKKyAgICB2aXJ0dWFsIHZvaWQgcG9wdWxhdGVTZXR0aW5nKGNvbnN0 IFdURjo6U3RyaW5nJiBrZXksIFdURjo6U3RyaW5nKiB2YWx1ZSk7CisgICAgdmlydHVhbCB2b2lk IHN0b3JlU2V0dGluZyhjb25zdCBXVEY6OlN0cmluZyYga2V5LCBjb25zdCBXVEY6OlN0cmluZyYg dmFsdWUpOworCisgICAgdmlydHVhbCBib29sIHNlbmRNZXNzYWdlVG9Gcm9udGVuZChjb25zdCBX VEY6OlN0cmluZyYpOworCisgICAgdm9pZCByZWxlYXNlRnJvbnRlbmRQYWdlKCk7CisKK3ByaXZh dGU6CisgICAgV2ViVmlldyogbV9pbnNwZWN0ZWRXZWJWaWV3OworfTsKKworfSAvLyBuYW1lc3Bh Y2UgV2ViS2l0CisKKyNlbmRpZiAvLyBJbnNwZWN0b3JDbGllbnRXaW5DRV9oCmRpZmYgLS1naXQg YS93ZWJraXQvd2luY2UvQ2hhbmdlTG9nIGIvd2Via2l0L3dpbmNlL0NoYW5nZUxvZwpuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi43Mzg5M2RmCi0tLSAvZGV2L251bGwKKysrIGIv d2Via2l0L3dpbmNlL0NoYW5nZUxvZwpAQCAtMCwwICsxLDE5IEBACisyMDEwLTA4LTI4ICBQYXRy aWNrIEdhbnN0ZXJlciAgPHBhcm9nYUBwYXJvZ2EuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBJbnNwZWN0b3JDbGllbnRXaW5DRQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ4MTkKKworICAg ICAgICAqIFdlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudFdpbkNFLmNwcDogQWRkZWQuCisg ICAgICAgIChXZWJLaXQ6Okluc3BlY3RvckNsaWVudDo6SW5zcGVjdG9yQ2xpZW50KToKKyAgICAg ICAgKFdlYktpdDo6SW5zcGVjdG9yQ2xpZW50Ojp+SW5zcGVjdG9yQ2xpZW50KToKKyAgICAgICAg KFdlYktpdDo6SW5zcGVjdG9yQ2xpZW50OjppbnNwZWN0b3JEZXN0cm95ZWQpOgorICAgICAgICAo V2ViS2l0OjpJbnNwZWN0b3JDbGllbnQ6Om9wZW5JbnNwZWN0b3JGcm9udGVuZCk6CisgICAgICAg IChXZWJLaXQ6Okluc3BlY3RvckNsaWVudDo6cmVsZWFzZUZyb250ZW5kUGFnZSk6CisgICAgICAg IChXZWJLaXQ6Okluc3BlY3RvckNsaWVudDo6aGlnaGxpZ2h0KToKKyAgICAgICAgKFdlYktpdDo6 SW5zcGVjdG9yQ2xpZW50OjpoaWRlSGlnaGxpZ2h0KToKKyAgICAgICAgKFdlYktpdDo6SW5zcGVj dG9yQ2xpZW50Ojpwb3B1bGF0ZVNldHRpbmcpOgorICAgICAgICAoV2ViS2l0OjpJbnNwZWN0b3JD bGllbnQ6OnN0b3JlU2V0dGluZyk6CisgICAgICAgIChXZWJLaXQ6Okluc3BlY3RvckNsaWVudDo6 c2VuZE1lc3NhZ2VUb0Zyb250ZW5kKToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9JbnNwZWN0 b3JDbGllbnRXaW5DRS5oOiBBZGRlZC4K