44816 2010-08-28 00:17:26 -0700 Crash in InlineBox::root() under RenderTextControl::textWithHardLineBreaks() 2010-10-13 14:24:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz eric oldest_to_newest 270941 0 mitz 2010-08-28 00:17:26 -0700 <rdar://problem/7275077> Patch forthcoming. 270959 1 65815 mitz 2010-08-28 01:58:35 -0700 Created attachment 65815 Speculative fix 270997 2 65815 simon.fraser 2010-08-28 09:07:28 -0700 Comment on attachment 65815 Speculative fix r=me 293610 3 eric 2010-10-13 12:27:04 -0700 Attachment 65815 was posted by a committer and has review+, assigning to Dan Bernstein for commit. 293711 4 mitz 2010-10-13 14:24:38 -0700 http://trac.webkit.org/changeset/66309 65815 2010-08-28 01:58:35 -0700 2010-08-28 09:07:27 -0700 Speculative fix 7275077_r1.diff text/plain 2599 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjMwMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDgtMjggIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGVj dWxhdGl2ZSBmaXggZm9yIDxyZGFyOi8vcHJvYmxlbS83Mjc1MDc3PiBDcmFzaCBpbiBJbmxpbmVC b3g6OnJvb3QoKSB1bmRlciBSZW5kZXJUZXh0Q29udHJvbDo6dGV4dFdpdGhIYXJkTGluZUJyZWFr cygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDgx NgorCisgICAgICAgIE5vIHRlc3QgYmVjYXVzZSBJIGNvdWxkIG5vdCByZXByb2R1Y2UgdGhlIGNy YXNoLgorCisgICAgICAgIEluIGEgY29tbW9uIHZhcmlhbnQgb2YgdGhlIGNyYXNoLCBJbmxpbmVC b3g6OnJvb3QoKSBpcyBjYWxsZWQgd2l0aCB0aGlzID09IDEyLiBUaGlzIHN1Z2dlc3RzIHRoYXQK KyAgICAgICAgYSBSZW5kZXJJbmxpbmUqIHdhcyBjYXN0IGludG8gYSBSZW5kZXJCb3gqLCBzbyBS ZW5kZXJCb3g6OmlubGluZUJveFdyYXBwZXIoKSBpbnRlcnByZXRlZCB0aGUKKyAgICAgICAgbV9s aW5lSGVpZ2h0IGFuZCBtX3ZlcnRpY2FsUG9zaXRpb24gbWVtYmVycyBvZiBhIFJlbmRlcklubGlu ZSBhcyBhIHBvaW50ZXIgdG8gYW4gSW5saW5lQm94LgorCisgICAgICAgIFRoZSBjYXN0IGludG8g UmVuZGVyQm94KiBpbiB0ZXh0V2l0aEhhcmRMaW5lQnJlYWtzKCkgd2FzIGludHJvZHVjZWQgaW4g cjQwODgxIHdpdGggbm8gZXhhcGxhbmF0aW9uLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl clRleHRDb250cm9sLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRleHRDb250cm9sOjp0 ZXh0V2l0aEhhcmRMaW5lQnJlYWtzKTogRmV0Y2ggdGhlIGZpcnN0IGxpbmUgZGlyZWN0bHkgZnJv bSB0aGUgaW5uZXIKKyAgICAgICAgdGV4dCBibG9jayBpbnN0ZWFkIG9mIHJlbHlpbmcgb24gdGhl IGZpcnN0IGNoaWxkIGJlaW5nIGEgdGV4dCBub2RlLgorCiAyMDEwLTA4LTI4ICBNYXJjLUFudG9p bmUgUnVlbCAgPG1hcnVlbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGlt aXRyaSBHbGF6a292LgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmNw cAkocmV2aXNpb24gNjYyNTEpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJv bC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1NSwyNiArMzU1LDIyIEBAIFN0cmluZyBSZW5kZXJU ZXh0Q29udHJvbDo6dGV4dFdpdGhIYXJkTGkKIHsKICAgICBpZiAoIW1faW5uZXJUZXh0KQogICAg ICAgICByZXR1cm4gIiI7Ci0gICAgTm9kZSogZmlyc3RDaGlsZCA9IG1faW5uZXJUZXh0LT5maXJz dENoaWxkKCk7Ci0gICAgaWYgKCFmaXJzdENoaWxkKQotICAgICAgICByZXR1cm4gIiI7CiAKLSAg ICBSZW5kZXJPYmplY3QqIHJlbmRlcmVyID0gZmlyc3RDaGlsZC0+cmVuZGVyZXIoKTsKKyAgICBS ZW5kZXJCbG9jayogcmVuZGVyZXIgPSB0b1JlbmRlckJsb2NrKG1faW5uZXJUZXh0LT5yZW5kZXJl cigpKTsKICAgICBpZiAoIXJlbmRlcmVyKQogICAgICAgICByZXR1cm4gIiI7CiAKLSAgICBJbmxp bmVCb3gqIGJveCA9IHJlbmRlcmVyLT5pc1RleHQoKSA/IHRvUmVuZGVyVGV4dChyZW5kZXJlcikt PmZpcnN0VGV4dEJveCgpIDogdG9SZW5kZXJCb3gocmVuZGVyZXIpLT5pbmxpbmVCb3hXcmFwcGVy KCk7Ci0gICAgaWYgKCFib3gpCi0gICAgICAgIHJldHVybiAiIjsKLQogICAgIE5vZGUqIGJyZWFr Tm9kZTsKICAgICB1bnNpZ25lZCBicmVha09mZnNldDsKLSAgICBSb290SW5saW5lQm94KiBsaW5l ID0gYm94LT5yb290KCk7CisgICAgUm9vdElubGluZUJveCogbGluZSA9IHJlbmRlcmVyLT5maXJz dFJvb3RCb3goKTsKKyAgICBpZiAoIWxpbmUpCisgICAgICAgIHJldHVybiAiIjsKKwogICAgIGdl dE5leHRTb2Z0QnJlYWsobGluZSwgYnJlYWtOb2RlLCBicmVha09mZnNldCk7CiAKICAgICBWZWN0 b3I8VUNoYXI+IHJlc3VsdDsKIAotICAgIGZvciAoTm9kZSogbiA9IGZpcnN0Q2hpbGQ7IG47IG4g PSBuLT50cmF2ZXJzZU5leHROb2RlKG1faW5uZXJUZXh0LmdldCgpKSkgeworICAgIGZvciAoTm9k ZSogbiA9IG1faW5uZXJUZXh0LT5maXJzdENoaWxkKCk7IG47IG4gPSBuLT50cmF2ZXJzZU5leHRO b2RlKG1faW5uZXJUZXh0LmdldCgpKSkgewogICAgICAgICBpZiAobi0+aGFzVGFnTmFtZShiclRh ZykpCiAgICAgICAgICAgICByZXN1bHQuYXBwZW5kKCZuZXdsaW5lQ2hhcmFjdGVyLCAxKTsKICAg ICAgICAgZWxzZSBpZiAobi0+aXNUZXh0Tm9kZSgpKSB7Cg==