44811 2010-08-27 19:28:42 -0700 fast/loader/input-element-page-cache-crash.html fails on Chromium 2010-08-29 16:57:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mihaip mihaip commit-queue tony oldest_to_newest 270899 0 mihaip 2010-08-27 19:28:42 -0700 fast/loader/input-element-page-cache-crash.html fails on Chromium 270900 1 65804 mihaip 2010-08-27 19:31:22 -0700 Created attachment 65804 Patch 270901 2 mihaip 2010-08-27 19:33:03 -0700 Tony, since you're the gardener, can you take a look at this? 271032 3 65804 tony 2010-08-28 11:41:39 -0700 Comment on attachment 65804 Patch Should the test initialize sessionStorage.finishTest to false? As in, if I run the test twice in a row, will sessionStorage.finishTest be confused? 271033 4 tony 2010-08-28 11:42:07 -0700 Alternately, if another test used the same variable, could that confuse this test? 271184 5 65860 mihaip 2010-08-29 12:30:29 -0700 Created attachment 65860 Patch 271185 6 mihaip 2010-08-29 12:32:37 -0700 I had assumed that sessionStorage gets reset between tests, and I even tried using --iterations 2 when running this test to see if it passes if run twice. However, it turned out that the test output was the same whether it navigated to the page and back or just finished immediately. I added some extra logging to make sure that it actually goes through the steps, and sure enough it failed. I added a cleanup step at the end which removes the sessionStorage variable, and now it passes when run twice (and still passes with the Chromium DRT). 271231 7 65860 tony 2010-08-29 16:07:00 -0700 Comment on attachment 65860 Patch LGTM 271233 8 65860 commit-queue 2010-08-29 16:57:05 -0700 Comment on attachment 65860 Patch Clearing flags on attachment: 65860 Committed r66340: <http://trac.webkit.org/changeset/66340> 271234 9 commit-queue 2010-08-29 16:57:10 -0700 All reviewed patches have been landed. Closing bug. 65804 2010-08-27 19:31:22 -0700 2010-08-29 12:30:26 -0700 Patch bug-44811-20100827193121.patch text/plain 2396 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzY2U3MmVlMDU1NTAyNWFjY2Q3ZDNhNmQwYjUyN2YxZjBkOTFlZjE4Li4yZTZiMjE3 YzUxNmQyNDdjYjAzMzMzODNhOWNmYjY5YTU2MGM4MTcyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDgtMjcgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZmFzdC9sb2FkZXIv aW5wdXQtZWxlbWVudC1wYWdlLWNhY2hlLWNyYXNoLmh0bWwgZmFpbHMgb24gQ2hyb21pdW0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0ODExCisKKyAg ICAgICAgTWFrZSB0ZXN0IG5vdCByZWx5IG9uIHBhZ2UgY2FjaGUgYmVoYXZpb3IgKHdpbmRvdy5m aW5pc2hUZXN0IGJlaW5nCisgICAgICAgIHBlcnNpc3RlZCksIGluc3RlYWQgdXNlIHNlc3Npb25T dG9yYWdlLgorCisgICAgICAgICogZmFzdC9sb2FkZXIvaW5wdXQtZWxlbWVudC1wYWdlLWNhY2hl LWNyYXNoLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlv bnMudHh0OgorCiAyMDEwLTA4LTI3ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgTm90IHJldmlld2VkLCBhZGRpbmcgdHdvIG1vcmUgZmlsZXMgdG8gY2hyb21pdW0n cyB0ZXN0X2V4cGVjdGF0aW9ucy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVy L2lucHV0LWVsZW1lbnQtcGFnZS1jYWNoZS1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9s b2FkZXIvaW5wdXQtZWxlbWVudC1wYWdlLWNhY2hlLWNyYXNoLmh0bWwKaW5kZXggMjQ5MzI3MjEx OGU1ZDQxYTNmZTNlY2JjZGYxMmNmZjJmNDUxMzJkOS4uYTE5ZDFjNzQxYTU5MmRlYTRiZmNiMjk3 ZTM0N2FkODQ5YjJiZTA4YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvaW5w dXQtZWxlbWVudC1wYWdlLWNhY2hlLWNyYXNoLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9s b2FkZXIvaW5wdXQtZWxlbWVudC1wYWdlLWNhY2hlLWNyYXNoLmh0bWwKQEAgLTIwLDEyICsyMCwx MiBAQCBmdW5jdGlvbiBydW5UZXN0KCkKIAogZnVuY3Rpb24gcGFnZUhpZGRlbigpCiB7Ci0gICAg d2luZG93LmZpbmlzaFRlc3QgPSB0cnVlOworICAgIHNlc3Npb25TdG9yYWdlLmZpbmlzaFRlc3Qg PSB0cnVlOwogfQogCiBmdW5jdGlvbiBwYWdlU2hvd24oKQogewotICAgIGlmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIgJiYgd2luZG93LmZpbmlzaFRlc3QpCisgICAgaWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlciAmJiBzZXNzaW9uU3RvcmFnZS5maW5pc2hUZXN0KQogICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CiB9CiAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCBiODEz OWI2NTc1NjVmMzk2MjkwNzVjZjVhYzIwYzg2OGM5ZjBjYmRkLi5jYjU1ZjI3MDhiZjdhNjEzYTE5 YzMzYmMyZTIxZDVhZWUxN2ZlYmY4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC0yMzA1LDEyICsyMzA1LDYgQEAgQlVH Mjk3MzcgTUFDIDogc3ZnL2N1c3RvbS91c2UtZWxlbWVudEluc3RhbmNlLWV2ZW50LXRhcmdldC5z dmcgPSBJTUFHRQogQlVHMjk3MzcgTUFDIDogc3ZnL1czQy1TVkctMS4xL3N0cnVjdC1pbWFnZS0w Mi1iLnN2ZyA9IElNQUdFCiBCVUcyOTczNyBNQUMgOiBzdmcvZmlsdGVycy9zb3VyY2VBbHBoYS5z dmcgPSBJTUFHRQogCi0vLyBNb3JlIFdlYmtpdCBSb2xsIHRvIHI1MTg3NQotCi0vLyBXZWJLaXQg Um9sbCB0byByNTE5MTUKLUJVRzI5OTMwIDogZmFzdC9sb2FkZXIvaW5wdXQtZWxlbWVudC1wYWdl LWNhY2hlLWNyYXNoLmh0bWwgPSBUSU1FT1VUIFBBU1MgVEVYVAotCi0KIC8vIE5ldyB0ZXN0cyBj b3VydGVzeSBvZjogaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNTE5MzY6CiBCVUcz MDA0OCA6IHN2Zy9jc3MvY29tcG9zaXRlLXNoYWRvdy1leGFtcGxlLmh0bWwgPSBJTUFHRQogQlVH MzAwNDggOiBzdmcvY3NzL2NvbXBvc2l0ZS1zaGFkb3ctd2l0aC1vcGFjaXR5Lmh0bWwgPSBJTUFH RQo= 65860 2010-08-29 12:30:29 -0700 2010-08-29 16:57:05 -0700 Patch bug-44811-20100829123028.patch text/plain 3660 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZTkxZjY3ODg4Y2RmYjNkY2I3NWExMzAxMDdhNjNiNGUwNzk0OTk3Li44NmNhMGZh Y2M2OGFjNmZlNWU4ZWEwYmExMDU4MGViM2VmYTIzNjRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDgtMjkgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZmFzdC9sb2FkZXIv aW5wdXQtZWxlbWVudC1wYWdlLWNhY2hlLWNyYXNoLmh0bWwgZmFpbHMgb24gQ2hyb21pdW0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0ODExCisKKyAg ICAgICAgTWFrZSB0ZXN0IG5vdCByZWx5IG9uIHBhZ2UgY2FjaGUgYmVoYXZpb3IgKHdpbmRvdy5m aW5pc2hUZXN0IGJlaW5nCisgICAgICAgIHBlcnNpc3RlZCksIGluc3RlYWQgdXNlIHNlc3Npb25T dG9yYWdlLgorCisgICAgICAgICogZmFzdC9sb2FkZXIvaW5wdXQtZWxlbWVudC1wYWdlLWNhY2hl LWNyYXNoLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlv bnMudHh0OgorCiAyMDEwLTA4LTI4ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9sb2FkZXIvaW5wdXQtZWxlbWVudC1wYWdlLWNhY2hlLWNyYXNoLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2lucHV0LWVsZW1lbnQtcGFnZS1jYWNoZS1jcmFzaC1l eHBlY3RlZC50eHQKaW5kZXggMmFiNWUzNTA1NGM3YjFiZTIyY2JmYTIwZjdiZWYyOGFmYWUyYTU1 MS4uNGYxM2NjNTExZTNkODgwMTk3ZjBhNzRlY2FhNWQ1NWRlNDc4MDQyMyAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvaW5wdXQtZWxlbWVudC1wYWdlLWNhY2hlLWNyYXNoLWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9pbnB1dC1lbGVtZW50LXBh Z2UtY2FjaGUtY3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0xLDMgKzEsNSBAQAorQ09OU09MRSBNRVNT QUdFOiBsaW5lIDI0OiBuYXZpZ2F0aW5nIGF3YXkKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAzNTog bmF2aWdhdGVkIGJhY2sKIFRoaXMgdGVzdCBoYXMgYW4gaW5wdXQgZWxlbWVudCB0aGF0IHN0YXJ0 cyBvdXQgd2l0aCBhdXRvY29tcGxldGU9b2ZmLgogSXQgdGhlbiBjaGFuZ2VzIGF1dG9jb21wbGV0 ZSB0byBvbi4KIEl0IHRoZW4gcmVtb3ZlcyB0aGUgZWxlbWVudCBzbyBpdCBpcyBkZXN0cm95ZWQu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9pbnB1dC1lbGVtZW50LXBhZ2Ut Y2FjaGUtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2lucHV0LWVsZW1lbnQt cGFnZS1jYWNoZS1jcmFzaC5odG1sCmluZGV4IDI0OTMyNzIxMThlNWQ0MWEzZmUzZWNiY2RmMTJj ZmYyZjQ1MTMyZDkuLjg5MWQ5NDEwN2QzZjVhYTA0NTQ2ZGQ3MGNkMDU2ZjdmMDViZTMxYzYgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2lucHV0LWVsZW1lbnQtcGFnZS1jYWNo ZS1jcmFzaC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2lucHV0LWVsZW1lbnQt cGFnZS1jYWNoZS1jcmFzaC5odG1sCkBAIC0yMCwxOSArMjAsMzAgQEAgZnVuY3Rpb24gcnVuVGVz dCgpCiAKIGZ1bmN0aW9uIHBhZ2VIaWRkZW4oKQogewotICAgIHdpbmRvdy5maW5pc2hUZXN0ID0g dHJ1ZTsKKyAgICBpZiAoIXNlc3Npb25TdG9yYWdlLmZpbmlzaFRlc3QpIHsKKyAgICAgICAgY29u c29sZS5sb2coJ25hdmlnYXRpbmcgYXdheScpOworICAgICAgICBzZXNzaW9uU3RvcmFnZS5maW5p c2hUZXN0ID0gdHJ1ZTsKKyAgICB9IGVsc2UgeworICAgICAgICAvLyBDbGVhbiB1cCBhZnRlciBv dXJzZWx2ZXMKKyAgICAgICAgZGVsZXRlIHNlc3Npb25TdG9yYWdlLmZpbmlzaFRlc3Q7CisgICAg fQogfQogCiBmdW5jdGlvbiBwYWdlU2hvd24oKQogewotICAgIGlmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIgJiYgd2luZG93LmZpbmlzaFRlc3QpCi0gICAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICBpZiAoc2Vzc2lvblN0b3JhZ2UuZmluaXNoVGVzdCkg eworICAgICAgICBjb25zb2xlLmxvZygnbmF2aWdhdGVkIGJhY2snKTsKKyAgICAgICAgaWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9s bGVyLm5vdGlmeURvbmUoKTsKKyAgICB9IGVsc2UgeworICAgICAgICBydW5UZXN0KCk7CisgICAg fQogfQogCiA8L3NjcmlwdD4gICAgCiA8L2hlYWQ+CiAKLTxib2R5IG9ubG9hZD0icnVuVGVzdCgp OyIgb25wYWdlaGlkZT0icGFnZUhpZGRlbigpOyIgb25wYWdlc2hvdz0icGFnZVNob3duKCk7Ij4K Kzxib2R5IG9ucGFnZWhpZGU9InBhZ2VIaWRkZW4oKTsiIG9ucGFnZXNob3c9InBhZ2VTaG93bigp OyI+CiA8cHJlPlRoaXMgdGVzdCBoYXMgYW4gaW5wdXQgZWxlbWVudCB0aGF0IHN0YXJ0cyBvdXQg d2l0aCBhdXRvY29tcGxldGU9b2ZmLgogSXQgdGhlbiBjaGFuZ2VzIGF1dG9jb21wbGV0ZSB0byBv bi4KIEl0IHRoZW4gcmVtb3ZlcyB0aGUgZWxlbWVudCBzbyBpdCBpcyBkZXN0cm95ZWQuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50 eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQK aW5kZXggNWMwYTgzY2RkNjhjOTAyZDdhYmY4ZGMxMjE2MWRhNjc3ZTgwOGE4ZC4uNWRhYjM0MTAw YzliNjJlNGE2MTA5YmUzZDIzNDlkODBkMjJjNDYxYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtMjMwNywxMiArMjMw Nyw2IEBAIEJVRzI5NzM3IE1BQyA6IHN2Zy9jdXN0b20vdXNlLWVsZW1lbnRJbnN0YW5jZS1ldmVu dC10YXJnZXQuc3ZnID0gSU1BR0UKIEJVRzI5NzM3IE1BQyA6IHN2Zy9XM0MtU1ZHLTEuMS9zdHJ1 Y3QtaW1hZ2UtMDItYi5zdmcgPSBJTUFHRQogQlVHMjk3MzcgTUFDIDogc3ZnL2ZpbHRlcnMvc291 cmNlQWxwaGEuc3ZnID0gSU1BR0UKIAotLy8gTW9yZSBXZWJraXQgUm9sbCB0byByNTE4NzUKLQot Ly8gV2ViS2l0IFJvbGwgdG8gcjUxOTE1Ci1CVUcyOTkzMCA6IGZhc3QvbG9hZGVyL2lucHV0LWVs ZW1lbnQtcGFnZS1jYWNoZS1jcmFzaC5odG1sID0gVElNRU9VVCBQQVNTIFRFWFQKLQotCiAvLyBO ZXcgdGVzdHMgY291cnRlc3kgb2Y6IGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzUx OTM2OgogQlVHMzAwNDggOiBzdmcvY3NzL2NvbXBvc2l0ZS1zaGFkb3ctZXhhbXBsZS5odG1sID0g SU1BR0UKIEJVRzMwMDQ4IDogc3ZnL2Nzcy9jb21wb3NpdGUtc2hhZG93LXdpdGgtb3BhY2l0eS5o dG1sID0gSU1BR0UK