44809 2010-08-27 18:44:43 -0700 Support RegExp in V8 implementation of SerializedScriptValue 2010-10-29 05:50:46 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mihaip mihaip beidson commit-queue darin fishd levin vitalyr oldest_to_newest 270884 0 mihaip 2010-08-27 18:44:43 -0700 See bug 44718 for details (and for initial attempt in patch 65738). Depends on http://code.google.com/p/v8/issues/detail?id=852. 301524 1 72281 mihaip 2010-10-28 18:31:46 -0700 Created attachment 72281 Patch 301528 2 mihaip 2010-10-28 18:38:55 -0700 Trying my luck with webkit-patch suggest-reviewers. 301605 3 72281 abarth 2010-10-28 23:43:52 -0700 Comment on attachment 72281 Patch suggest-reviewers don't understand the politics of JSC/V8 reviewing. :) I'm not an expert on this code, but this looks reasonable to me. 301628 4 72281 commit-queue 2010-10-29 01:08:24 -0700 Comment on attachment 72281 Patch Clearing flags on attachment: 72281 Committed r70851: <http://trac.webkit.org/changeset/70851> 301629 5 commit-queue 2010-10-29 01:08:30 -0700 All reviewed patches have been landed. Closing bug. 301704 6 vitalyr 2010-10-29 05:50:46 -0700 (In reply to comment #1) > Created an attachment (id=72281) [details] > Patch LGTM! 72281 2010-10-28 18:31:46 -0700 2010-10-29 01:08:24 -0700 Patch bug-44809-20101028183144.patch text/plain 5096 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzMmU4MWM5ZjZhYzcwMDQxYmI1YWUwZDgzMDAzOTNkYTExMTA3MWJmLi4zYzU1ZjRi N2MwOTc3NTkwMTkzZDk4MjJjM2YzMWQwMTZjZDZlZDAwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMTAtMjggIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3VwcG9ydCBSZWdF eHAgaW4gVjggaW1wbGVtZW50YXRpb24gb2YgU2VyaWFsaXplZFNjcmlwdFZhbHVlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDgwOQorICAgICAgICAK KyAgICAgICAgZmFzdC9sb2FkZXIvc3RhdGVvYmplY3RzL3B1c2hzdGF0ZS1vYmplY3QtdHlwZXMu aHRtbCBub3cgcGFzc2VzLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBl Y3RhdGlvbnMudHh0OgorCiAyMDEwLTEwLTI4ICBEbWl0cnkgVGl0b3YgIDxkaW1pY2hAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVW5yZXZpZXdlZCBmaXggZm9yIHRlc3RfZXhw ZWN0YXRpb25zLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVz dF9leHBlY3RhdGlvbnMudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9l eHBlY3RhdGlvbnMudHh0CmluZGV4IGI2OTZmZGI0MjA4ZTA1NmFjYjY5ZDE2NDgwNjQ0Y2QyYjBm ZDhmY2MuLmEyMjQ5NmNmNWRiZGI3YWMwNzJhODMzMGI2N2VhYWI4NzE1YzJiNDIgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQK QEAgLTIxOTAsNyArMjE5MCw2IEBAIEJVRzI5MTY3IE1BQyBERUJVRyA6IGZhc3QvZG9tL3JlcGxh Y2VDaGlsZC5odG1sID0gSU1BR0UgUEFTUwogQlVHMjkyMzkgTElOVVggV0lOIDogZmFzdC9jc3Mv dmFyaWFibGVzL21pc3BsYWNlZC1pbXBvcnQtdGVzdC5odG1sID0gRkFJTAogCiAvLyBGYWlsdXJl cyBmcm9tIFdlYktpdCBtZXJnZSA1MTY0Mjo1MTY4MQotQlVHMjkzOTMgOiBmYXN0L2xvYWRlci9z dGF0ZW9iamVjdHMvcHVzaHN0YXRlLW9iamVjdC10eXBlcy5odG1sID0gVEVYVAogQlVHMjkzOTMg OiBmYXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvc3RhdGUtYXBpLW9uLWRldGFjaGVkLWZyYW1lLWNy YXNoLmh0bWwgPSBURVhUCiAKIC8vIEZhaWx1cmVzIGludHJvZHVjZWQgYnkgVVNFX05FV19CVUlM REVSIGluIFNraWEuCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDQwMjc0MDc2ODYzN2NjOWJmMzdkYzRhMWNiMjY5NjdiZDA2YTFkZGEuLjNj YTllMGI4YTg0NjZhZDJhZGVlODIwODA2ZGMwMDNlNGM1MDIzMjcgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIw MTAtMTAtMjggIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3VwcG9ydCBSZWdFeHAg aW4gVjggaW1wbGVtZW50YXRpb24gb2YgU2VyaWFsaXplZFNjcmlwdFZhbHVlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDgwOQorICAgICAgICAKKyAg ICAgICAgQWRkIFJlZ0V4cCBzZXJpYWxpemF0aW9uL2Rlc2VyaWFsaXphdGlvbiBub3cgdGhhdCBW OCBwcm92aWRlcyBBUEkgYWNjZXNzCisgICAgICAgIHRvIHRoZSBSZWdFeHAgdHlwZS4KKworICAg ICAgICAqIGJpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpaaWdaYWc6OldyaXRlcjo6d3JpdGVSZWdFeHApOgorICAgICAgICAoV2ViQ29yZTo6 WmlnWmFnOjpTZXJpYWxpemVyOjp3cml0ZVJlZ0V4cCk6CisgICAgICAgIChXZWJDb3JlOjpaaWda YWc6OlNlcmlhbGl6ZXI6OmRvU2VyaWFsaXplKToKKyAgICAgICAgKFdlYkNvcmU6OlppZ1phZzo6 UmVhZGVyOjpyZWFkKToKKyAgICAgICAgKFdlYkNvcmU6OlppZ1phZzo6UmVhZGVyOjpyZWFkUmVn RXhwKToKKwogMjAxMC0xMC0yOCAgSmlhIFB1ICA8anB1QGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92 OC9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9TZXJpYWxp emVkU2NyaXB0VmFsdWUuY3BwCmluZGV4IGZmOTIxNjcyNDlhM2JjODU5NzE2MWE1M2JlMjhmNjE1 MGI0OTgzYjQuLjM2ZmMxZjZhOGI2NmQ4ZmM2YzY2ODBiZWE4NDY1ZTYzYjM0NzViNjEgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAorKysg Yi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKQEAgLTgyLDYg KzgyLDcgQEAgZW51bSBTZXJpYWxpemF0aW9uVGFnIHsKICAgICBBcnJheVRhZyA9ICdbJywKICAg ICBPYmplY3RUYWcgPSAneycsCiAgICAgU3BhcnNlQXJyYXlUYWcgPSAnQCcsCisgICAgUmVnRXhw VGFnID0gJ1InLAogfTsKIAogc3RhdGljIGJvb2wgc2hvdWxkQ2hlY2tGb3JDeWNsZXMoaW50IGRl cHRoKQpAQCAtMjE5LDYgKzIyMCwxNCBAQCBwdWJsaWM6CiAgICAgICAgIGRvV3JpdGVVaW50MzIo cGl4ZWxEYXRhTGVuZ3RoKTsKICAgICAgICAgYXBwZW5kKHBpeGVsRGF0YSwgcGl4ZWxEYXRhTGVu Z3RoKTsKICAgICB9CisgICAgCisgICAgdm9pZCB3cml0ZVJlZ0V4cCh2ODo6TG9jYWw8djg6OlN0 cmluZz4gcGF0dGVybiwgdjg6OlJlZ0V4cDo6RmxhZ3MgZmxhZ3MpCisgICAgeworICAgICAgICBh cHBlbmQoUmVnRXhwVGFnKTsKKyAgICAgICAgdjg6OlN0cmluZzo6VXRmOFZhbHVlIHBhdHRlcm5V dGY4VmFsdWUocGF0dGVybik7CisgICAgICAgIGRvV3JpdGVTdHJpbmcoKnBhdHRlcm5VdGY4VmFs dWUsIHBhdHRlcm5VdGY4VmFsdWUubGVuZ3RoKCkpOworICAgICAgICBkb1dyaXRlVWludDMyKHN0 YXRpY19jYXN0PHVpbnQzMl90PihmbGFncykpOworICAgIH0gICAgCiAKICAgICB2b2lkIHdyaXRl QXJyYXkodWludDMyX3QgbGVuZ3RoKQogICAgIHsKQEAgLTYwNSw2ICs2MTQsMTIgQEAgcHJpdmF0 ZToKICAgICAgICAgV1RGOjpCeXRlQXJyYXkqIHBpeGVsQXJyYXkgPSBpbWFnZURhdGEtPmRhdGEo KS0+ZGF0YSgpOwogICAgICAgICBtX3dyaXRlci53cml0ZUltYWdlRGF0YShpbWFnZURhdGEtPndp ZHRoKCksIGltYWdlRGF0YS0+aGVpZ2h0KCksIHBpeGVsQXJyYXktPmRhdGEoKSwgcGl4ZWxBcnJh eS0+bGVuZ3RoKCkpOwogICAgIH0KKyAgICAKKyAgICB2b2lkIHdyaXRlUmVnRXhwKHY4OjpIYW5k bGU8djg6OlZhbHVlPiB2YWx1ZSkKKyAgICB7CisgICAgICAgIHY4OjpIYW5kbGU8djg6OlJlZ0V4 cD4gcmVnRXhwID0gdmFsdWUuQXM8djg6OlJlZ0V4cD4oKTsKKyAgICAgICAgbV93cml0ZXIud3Jp dGVSZWdFeHAocmVnRXhwLT5HZXRTb3VyY2UoKSwgcmVnRXhwLT5HZXRGbGFncygpKTsKKyAgICB9 CiAKICAgICBzdGF0aWMgU3RhdGVCYXNlKiBuZXdBcnJheVN0YXRlKHY4OjpIYW5kbGU8djg6OkFy cmF5PiBhcnJheSwgU3RhdGVCYXNlKiBuZXh0KQogICAgIHsKQEAgLTY1Niw2ICs2NzEsOCBAQCBT ZXJpYWxpemVyOjpTdGF0ZUJhc2UqIFNlcmlhbGl6ZXI6OmRvU2VyaWFsaXplKHY4OjpIYW5kbGU8 djg6OlZhbHVlPiB2YWx1ZSwgU3RhdAogICAgICAgICB3cml0ZUZpbGVMaXN0KHZhbHVlKTsKICAg ICBlbHNlIGlmIChWOEltYWdlRGF0YTo6SGFzSW5zdGFuY2UodmFsdWUpKQogICAgICAgICB3cml0 ZUltYWdlRGF0YSh2YWx1ZSk7CisgICAgZWxzZSBpZiAodmFsdWUtPklzUmVnRXhwKCkpCisgICAg ICAgIHdyaXRlUmVnRXhwKHZhbHVlKTsKICAgICBlbHNlIGlmICh2YWx1ZS0+SXNPYmplY3QoKSkK ICAgICAgICAgcmV0dXJuIHB1c2gobmV3T2JqZWN0U3RhdGUodmFsdWUuQXM8djg6Ok9iamVjdD4o KSwgbmV4dCkpOwogICAgIHJldHVybiAwOwpAQCAtNzUxLDYgKzc2OCwxMCBAQCBwdWJsaWM6CiAg ICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg IH0KKyAgICAgICAgY2FzZSBSZWdFeHBUYWc6CisgICAgICAgICAgICBpZiAoIXJlYWRSZWdFeHAo dmFsdWUpKQorICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgICAgIGJyZWFr OwogICAgICAgICBjYXNlIE9iamVjdFRhZzogewogICAgICAgICAgICAgdWludDMyX3QgbnVtUHJv cGVydGllczsKICAgICAgICAgICAgIGlmICghZG9SZWFkVWludDMyKCZudW1Qcm9wZXJ0aWVzKSkK QEAgLTg2Nyw2ICs4ODgsMTggQEAgcHJpdmF0ZToKICAgICAgICAgKnZhbHVlID0gdG9WOChpbWFn ZURhdGEpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CisgICAgCisgICAgYm9vbCByZWFk UmVnRXhwKHY4OjpIYW5kbGU8djg6OlZhbHVlPiogdmFsdWUpCisgICAgeworICAgICAgICB2ODo6 SGFuZGxlPHY4OjpWYWx1ZT4gcGF0dGVybjsKKyAgICAgICAgaWYgKCFyZWFkU3RyaW5nKCZwYXR0 ZXJuKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgdWludDMyX3QgZmxhZ3M7 CisgICAgICAgIGlmICghZG9SZWFkVWludDMyKCZmbGFncykpCisgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgICAgICp2YWx1ZSA9IHY4OjpSZWdFeHA6Ok5ldyhwYXR0ZXJuLkFzPHY4OjpT dHJpbmc+KCksIHN0YXRpY19jYXN0PHY4OjpSZWdFeHA6OkZsYWdzPihmbGFncykpOworICAgICAg ICByZXR1cm4gdHJ1ZTsKKyAgICB9CiAKICAgICBib29sIHJlYWRCbG9iKHY4OjpIYW5kbGU8djg6 OlZhbHVlPiogdmFsdWUpCiAgICAgewo=