44786 2010-08-27 12:31:51 -0700 [chromium] Preparatory patch to split libwebcore in multiple libraries. 2010-08-28 01:31:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P1 Normal --- 44796 1 maruel webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 270662 0 maruel 2010-08-27 12:31:51 -0700 Preparatory patch to split libwebcore in multiple libraries. Start with a webcore_prerequisites pseudo-target what will be the common target for all the other ones. 270663 1 65751 maruel 2010-08-27 12:32:41 -0700 Created attachment 65751 webcore.gyp patch 270667 2 webkit.review.bot 2010-08-27 12:35:55 -0700 Attachment 65751 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 270674 3 65753 maruel 2010-08-27 12:50:06 -0700 Created attachment 65753 no tabs 270690 4 65753 dglazkov 2010-08-27 13:08:06 -0700 Comment on attachment 65753 no tabs ok. 270953 5 65753 commit-queue 2010-08-28 01:31:36 -0700 Comment on attachment 65753 no tabs Clearing flags on attachment: 65753 Committed r66302: <http://trac.webkit.org/changeset/66302> 270954 6 commit-queue 2010-08-28 01:31:40 -0700 All reviewed patches have been landed. Closing bug. 65751 2010-08-27 12:32:41 -0700 2010-08-27 12:50:06 -0700 webcore.gyp patch webcore.gyp.patch text/plain 3552 maruel ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTBmNzIyYy4uZTk4NjA0MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0yNyAgTWFyYy1BbnRvaW5l IFJ1ZWwgIDxtYXJ1ZWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFByZXBhcmF0b3J5IHBhdGNoIHRvIHNwbGl0IGxpYndlYmNv cmUgaW4gbXVsdGlwbGUgbGlicmFyaWVzLgorCisJU3RhcnQgd2l0aCBhIHdlYmNvcmVfcHJlcmVx dWlzaXRlcyBwc2V1ZG8tdGFyZ2V0IHdoYXQgd2lsbCBiZSB0aGUgY29tbW9uCisJdGFyZ2V0IGZv ciBhbGwgdGhlIG90aGVyIG9uZXMuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cC9XZWJDb3JlLmd5 cDoKKwogMjAxMC0wOC0yNSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjY2MDc0LgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cCBiL1dlYkNvcmUvV2ViQ29yZS5neXAv V2ViQ29yZS5neXAKaW5kZXggYzYyNWY1Zi4uMzE3MzE4MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9X ZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAorKysgYi9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUu Z3lwCkBAIC04MDksOSArODA5LDEwIEBACiAgICAgICBdLAogICAgIH0sCiAgICAgewotICAgICAg J3RhcmdldF9uYW1lJzogJ3dlYmNvcmUnLAotICAgICAgJ3R5cGUnOiAnPChsaWJyYXJ5KScsCi0g ICAgICAnbXN2c19ndWlkJzogJzFDMTYzMzdCLUFDRjMtNEQwMy1BQTkwLTg1MUM1QjVFQURBNics CisgICAgICAjIFdlJ2xsIHNvb24gc3BsaXQgbGlid2ViY29yZSBpbiBtdWx0aXBsZSBzbWFsbGVy IGxpYnJhcmllcy4KKyAgICAgICMgd2ViY29yZV9wcmVyZXF1aXNpdGVzIHdpbGwgYmUgdGhlICdi YXNlJyB0YXJnZXQgb2YgZXZlcnkgc3ViLXRhcmdldC4KKyAgICAgICd0YXJnZXRfbmFtZSc6ICd3 ZWJjb3JlX3ByZXJlcXVpc2l0ZXMnLAorICAgICAgJ3R5cGUnOiAnbm9uZScsCiAgICAgICAnZGVw ZW5kZW5jaWVzJzogWwogICAgICAgICAnd2ViY29yZV9iaW5kaW5ncycsCiAgICAgICAgICcuLi8u Li9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lwOnBj cmUnLApAQCAtODI3LDE0ICs4MjgsNDUgQEAKICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2Rpcikv dGhpcmRfcGFydHkvc3FsaXRlL3NxbGl0ZS5neXA6c3FsaXRlJywKICAgICAgICAgJzwoY2hyb21p dW1fc3JjX2RpcikvdGhpcmRfcGFydHkvYW5nbGUvc3JjL2J1aWxkX2FuZ2xlLmd5cDp0cmFuc2xh dG9yX2NvbW1vbicsCiAgICAgICBdLAotICAgICAgJ2RlZmluZXMnOiBbCi0gICAgICAgICdXRUJD T1JFX05BVklHQVRPUl9WRU5ET1I9Ikdvb2dsZSBJbmMuIicsCisgICAgICAnZXhwb3J0X2RlcGVu ZGVudF9zZXR0aW5ncyc6IFsKKyAgICAgICAgJ3dlYmNvcmVfYmluZGluZ3MnLAorICAgICAgICAn Li4vLi4vSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5 cDpwY3JlJywKKyAgICAgICAgJy4uLy4uL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5 cC9KYXZhU2NyaXB0Q29yZS5neXA6d3RmJywKKyAgICAgICAgJzwoY2hyb21pdW1fc3JjX2Rpcikv YnVpbGQvdGVtcF9neXAvZ29vZ2xldXJsLmd5cDpnb29nbGV1cmwnLAorICAgICAgICAnPChjaHJv bWl1bV9zcmNfZGlyKS9za2lhL3NraWEuZ3lwOnNraWEnLAorICAgICAgICAnPChjaHJvbWl1bV9z cmNfZGlyKS90aGlyZF9wYXJ0eS9saWJqcGVnL2xpYmpwZWcuZ3lwOmxpYmpwZWcnLAorICAgICAg ICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9saWJwbmcvbGlicG5nLmd5cDpsaWJw bmcnLAorICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9saWJ4bWwvbGli eG1sLmd5cDpsaWJ4bWwnLAorICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0 eS9saWJ4c2x0L2xpYnhzbHQuZ3lwOmxpYnhzbHQnLAorICAgICAgICAnPChjaHJvbWl1bV9zcmNf ZGlyKS90aGlyZF9wYXJ0eS9ucGFwaS9ucGFwaS5neXA6bnBhcGknLAorICAgICAgICAnPChjaHJv bWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9vdHMvb3RzLmd5cDpvdHMnLAorICAgICAgICAnPChj aHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9zcWxpdGUvc3FsaXRlLmd5cDpzcWxpdGUnLAor ICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9hbmdsZS9zcmMvYnVpbGRf YW5nbGUuZ3lwOnRyYW5zbGF0b3JfY29tbW9uJywKICAgICAgIF0sCi0gICAgICAnaW5jbHVkZV9k aXJzJzogWwotICAgICAgICAnPChJTlRFUk1FRElBVEVfRElSKScsCi0gICAgICAgICc8QCh3ZWJj b3JlX2luY2x1ZGVfZGlycyknLAotICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9ncHUnLAot ICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9hbmdsZS9pbmNsdWRlL0dM U0xBTkcnLAorICAgICAgJ2RpcmVjdF9kZXBlbmRlbnRfc2V0dGluZ3MnOiB7CisgICAgICAgICdk ZWZpbmVzJzogWworICAgICAgICAgICdXRUJDT1JFX05BVklHQVRPUl9WRU5ET1I9Ikdvb2dsZSBJ bmMuIicsCisgICAgICAgIF0sCisgICAgICAgICdpbmNsdWRlX2RpcnMnOiBbCisgICAgICAgICAg JzwoSU5URVJNRURJQVRFX0RJUiknLAorICAgICAgICAgICc8QCh3ZWJjb3JlX2luY2x1ZGVfZGly cyknLAorICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL2dwdScsCisgICAgICAgICAgJzwo Y2hyb21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvYW5nbGUvaW5jbHVkZS9HTFNMQU5HJywKKyAg ICAgICAgXSwKKyAgICAgIH0sCisgICAgfSwKKyAgICB7CisgICAgICAndGFyZ2V0X25hbWUnOiAn d2ViY29yZScsCisgICAgICAndHlwZSc6ICc8KGxpYnJhcnkpJywKKyAgICAgICdtc3ZzX2d1aWQn OiAnMUMxNjMzN0ItQUNGMy00RDAzLUFBOTAtODUxQzVCNUVBREE2JywKKyAgICAgICdkZXBlbmRl bmNpZXMnOiBbCisgICAgICAgICd3ZWJjb3JlX3ByZXJlcXVpc2l0ZXMnLAorICAgICAgICAjIEV4 cG9ydGVkLgorICAgICAgICAnd2ViY29yZV9iaW5kaW5ncycsCisgICAgICAgICcuLi8uLi9KYXZh U2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lwOnd0ZicsCisg ICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL2J1aWxkL3RlbXBfZ3lwL2dvb2dsZXVybC5neXA6 Z29vZ2xldXJsJywKKyAgICAgICAgJzwoY2hyb21pdW1fc3JjX2Rpcikvc2tpYS9za2lhLmd5cDpz a2lhJywKKyAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvbnBhcGkvbnBh cGkuZ3lwOm5wYXBpJywKICAgICAgIF0sCiAgICAgICAnc291cmNlcyc6IFsKICAgICAgICAgJzxA KHdlYmNvcmVfZmlsZXMpJywK 65753 2010-08-27 12:50:06 -0700 2010-08-28 01:31:36 -0700 no tabs webcore.gyp.patch text/plain 3566 maruel ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTBmNzIyYy4uM2MxY2FjNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0yNyAgTWFyYy1BbnRvaW5l IFJ1ZWwgIDxtYXJ1ZWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFByZXBhcmF0b3J5IHBhdGNoIHRvIHNwbGl0IGxpYndlYmNv cmUgaW4gbXVsdGlwbGUgbGlicmFyaWVzLgorCisgICAgICAgIFN0YXJ0IHdpdGggYSB3ZWJjb3Jl X3ByZXJlcXVpc2l0ZXMgcHNldWRvLXRhcmdldCB3aGF0IHdpbGwgYmUgdGhlIGNvbW1vbgorICAg ICAgICB0YXJnZXQgZm9yIGFsbCB0aGUgb3RoZXIgb25lcy4KKworICAgICAgICAqIFdlYkNvcmUu Z3lwL1dlYkNvcmUuZ3lwOgorCiAyMDEwLTA4LTI1ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZp ZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjYw NzQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwIGIvV2ViQ29y ZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCBjNjI1ZjVmLi4zMTczMTgzIDEwMDY0NAot LS0gYS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCisrKyBiL1dlYkNvcmUvV2ViQ29y ZS5neXAvV2ViQ29yZS5neXAKQEAgLTgwOSw5ICs4MDksMTAgQEAKICAgICAgIF0sCiAgICAgfSwK ICAgICB7Ci0gICAgICAndGFyZ2V0X25hbWUnOiAnd2ViY29yZScsCi0gICAgICAndHlwZSc6ICc8 KGxpYnJhcnkpJywKLSAgICAgICdtc3ZzX2d1aWQnOiAnMUMxNjMzN0ItQUNGMy00RDAzLUFBOTAt ODUxQzVCNUVBREE2JywKKyAgICAgICMgV2UnbGwgc29vbiBzcGxpdCBsaWJ3ZWJjb3JlIGluIG11 bHRpcGxlIHNtYWxsZXIgbGlicmFyaWVzLgorICAgICAgIyB3ZWJjb3JlX3ByZXJlcXVpc2l0ZXMg d2lsbCBiZSB0aGUgJ2Jhc2UnIHRhcmdldCBvZiBldmVyeSBzdWItdGFyZ2V0LgorICAgICAgJ3Rh cmdldF9uYW1lJzogJ3dlYmNvcmVfcHJlcmVxdWlzaXRlcycsCisgICAgICAndHlwZSc6ICdub25l JywKICAgICAgICdkZXBlbmRlbmNpZXMnOiBbCiAgICAgICAgICd3ZWJjb3JlX2JpbmRpbmdzJywK ICAgICAgICAgJy4uLy4uL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2Ny aXB0Q29yZS5neXA6cGNyZScsCkBAIC04MjcsMTQgKzgyOCw0NSBAQAogICAgICAgICAnPChjaHJv bWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9zcWxpdGUvc3FsaXRlLmd5cDpzcWxpdGUnLAogICAg ICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9hbmdsZS9zcmMvYnVpbGRfYW5n bGUuZ3lwOnRyYW5zbGF0b3JfY29tbW9uJywKICAgICAgIF0sCi0gICAgICAnZGVmaW5lcyc6IFsK LSAgICAgICAgJ1dFQkNPUkVfTkFWSUdBVE9SX1ZFTkRPUj0iR29vZ2xlIEluYy4iJywKKyAgICAg ICdleHBvcnRfZGVwZW5kZW50X3NldHRpbmdzJzogWworICAgICAgICAnd2ViY29yZV9iaW5kaW5n cycsCisgICAgICAgICcuLi8uLi9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2 YVNjcmlwdENvcmUuZ3lwOnBjcmUnLAorICAgICAgICAnLi4vLi4vSmF2YVNjcmlwdENvcmUvSmF2 YVNjcmlwdENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cDp3dGYnLAorICAgICAgICAnPChjaHJv bWl1bV9zcmNfZGlyKS9idWlsZC90ZW1wX2d5cC9nb29nbGV1cmwuZ3lwOmdvb2dsZXVybCcsCisg ICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3NraWEvc2tpYS5neXA6c2tpYScsCisgICAgICAg ICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L2xpYmpwZWcvbGlianBlZy5neXA6bGli anBlZycsCisgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L2xpYnBuZy9s aWJwbmcuZ3lwOmxpYnBuZycsCisgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3Bh cnR5L2xpYnhtbC9saWJ4bWwuZ3lwOmxpYnhtbCcsCisgICAgICAgICc8KGNocm9taXVtX3NyY19k aXIpL3RoaXJkX3BhcnR5L2xpYnhzbHQvbGlieHNsdC5neXA6bGlieHNsdCcsCisgICAgICAgICc8 KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L25wYXBpL25wYXBpLmd5cDpucGFwaScsCisg ICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L290cy9vdHMuZ3lwOm90cycs CisgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L3NxbGl0ZS9zcWxpdGUu Z3lwOnNxbGl0ZScsCisgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L2Fu Z2xlL3NyYy9idWlsZF9hbmdsZS5neXA6dHJhbnNsYXRvcl9jb21tb24nLAogICAgICAgXSwKLSAg ICAgICdpbmNsdWRlX2RpcnMnOiBbCi0gICAgICAgICc8KElOVEVSTUVESUFURV9ESVIpJywKLSAg ICAgICAgJzxAKHdlYmNvcmVfaW5jbHVkZV9kaXJzKScsCi0gICAgICAgICc8KGNocm9taXVtX3Ny Y19kaXIpL2dwdScsCi0gICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L2Fu Z2xlL2luY2x1ZGUvR0xTTEFORycsCisgICAgICAnZGlyZWN0X2RlcGVuZGVudF9zZXR0aW5ncyc6 IHsKKyAgICAgICAgJ2RlZmluZXMnOiBbCisgICAgICAgICAgJ1dFQkNPUkVfTkFWSUdBVE9SX1ZF TkRPUj0iR29vZ2xlIEluYy4iJywKKyAgICAgICAgXSwKKyAgICAgICAgJ2luY2x1ZGVfZGlycyc6 IFsKKyAgICAgICAgICAnPChJTlRFUk1FRElBVEVfRElSKScsCisgICAgICAgICAgJzxAKHdlYmNv cmVfaW5jbHVkZV9kaXJzKScsCisgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvZ3B1JywK KyAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9hbmdsZS9pbmNsdWRl L0dMU0xBTkcnLAorICAgICAgICBdLAorICAgICAgfSwKKyAgICB9LAorICAgIHsKKyAgICAgICd0 YXJnZXRfbmFtZSc6ICd3ZWJjb3JlJywKKyAgICAgICd0eXBlJzogJzwobGlicmFyeSknLAorICAg ICAgJ21zdnNfZ3VpZCc6ICcxQzE2MzM3Qi1BQ0YzLTREMDMtQUE5MC04NTFDNUI1RUFEQTYnLAor ICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKKyAgICAgICAgJ3dlYmNvcmVfcHJlcmVxdWlzaXRlcycs CisgICAgICAgICMgRXhwb3J0ZWQuCisgICAgICAgICd3ZWJjb3JlX2JpbmRpbmdzJywKKyAgICAg ICAgJy4uLy4uL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29y ZS5neXA6d3RmJywKKyAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvYnVpbGQvdGVtcF9neXAv Z29vZ2xldXJsLmd5cDpnb29nbGV1cmwnLAorICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9z a2lhL3NraWEuZ3lwOnNraWEnLAorICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9w YXJ0eS9ucGFwaS9ucGFwaS5neXA6bnBhcGknLAogICAgICAgXSwKICAgICAgICdzb3VyY2VzJzog WwogICAgICAgICAnPEAod2ViY29yZV9maWxlcyknLAo=