44784 2010-08-27 12:28:00 -0700 [GTK] fast/history/history-subframe-with-name.html fails with GTK DRT 2011-02-07 09:44:30 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED Gtk P2 Normal --- 1 mihaip mrobinson abarth dbates dglazkov eric fishd gustavo mihaip mrobinson ossy webkit.review.bot oldest_to_newest 270657 0 mihaip 2010-08-27 12:28:00 -0700 http://trac.webkit.org/changeset/66238 added fast/history/history-subframe-with-name.htm, and it fails with this diff: --- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/history/history-subframe-with-name-expected.txt 2010-08-27 11:51:06.357907230 -0700 +++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/history/history-subframe-with-name-actual.txt 2010-08-27 11:51:06.357907230 -0700 @@ -9,6 +9,6 @@ PASS 2 is currentPageId PASS 3 is currentPageId PASS 2 is currentPageId -PASS 3 is currentPageId +FAIL 3 should be 2. Was 3. PASS Complete: navigated through all the states 270697 1 65757 mihaip 2010-08-27 13:23:08 -0700 Created attachment 65757 Patch 270699 2 65757 dglazkov 2010-08-27 13:24:04 -0700 Comment on attachment 65757 Patch ok. 270711 3 65757 dglazkov 2010-08-27 13:44:41 -0700 Comment on attachment 65757 Patch Clearing flags on attachment: 65757 Committed r66250: <http://trac.webkit.org/changeset/66250> 270712 4 dglazkov 2010-08-27 13:44:45 -0700 All reviewed patches have been landed. Closing bug. 270713 5 mihaip 2010-08-27 13:48:20 -0700 Unfortunately I'm not really able to investigate the GTK test failure (I don't have a machine that can run the GTK tests). Martin, do you think you could look into this? Let me know if you need any help with the changes that r66238 made or the new test (given that there's a bunch of other skipped history tests for GTK, it might just be missing DRT features). 270741 6 mrobinson 2010-08-27 14:17:18 -0700 Sure. I'll take a look later today. 274370 7 mrobinson 2010-09-04 11:21:27 -0700 I still haven't gotten very far on this. The WebKitGTK behavior is bewildering, to say the least. 275952 8 mihaip 2010-09-08 11:13:37 -0700 (In reply to comment #7) > I still haven't gotten very far on this. The WebKitGTK behavior is bewildering, to say the least. Would there be any race conditions from doing a history.forward() in an onload handler (since presumably the GTK DRT uses the GTK implementation of the back-forward list)? 345933 9 mrobinson 2011-02-04 17:10:17 -0800 (In reply to comment #8) > (In reply to comment #7) > > I still haven't gotten very far on this. The WebKitGTK behavior is bewildering, to say the least. > > Would there be any race conditions from doing a history.forward() in an onload handler (since presumably the GTK DRT uses the GTK implementation of the back-forward list)? The issue here seems to be this: 1. When the history item is for the second subframe is creatied, it has a unique name like "<!--framePath //<!--frame1-->-->". 2. window.name of the subframe changes and its unique name in the tree becomes "foo" (since there is no collision -- see the first conditional in FrameTree::uniqueChildName). 3. When HistoryController::itemsAreClones runs during back/forward navigation, the two history items do not look like clones because their frame trees contain a different set of names. So it appears that the problem is that the HistoryItem gets out of sync with the actual frame tree. I'm not sure why this does cause a problem on other ports. 345934 10 mrobinson 2011-02-04 17:10:42 -0800 CCing Daniel, since he has tangled recently with unique frame names. 346185 11 mrobinson 2011-02-05 14:03:44 -0800 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > I still haven't gotten very far on this. The WebKitGTK behavior is bewildering, to say the least. > > > > Would there be any race conditions from doing a history.forward() in an onload handler (since presumably the GTK DRT uses the GTK implementation of the back-forward list)? > > The issue here seems to be this: This turned out to be a huge red herring, since other ports function even with this issue. It may point to some ineffeciency though. The problem that GTK+ is having is that it is calling FrameLoader::loadURLIntoChildFrame on the child frame's loader as opposed to the parent frame. Frankly, I'm amazed that this worked at all. I should have a patch soon. 346321 12 mrobinson 2011-02-06 09:10:46 -0800 *** Bug 50678 has been marked as a duplicate of this bug. *** 346324 13 81412 mrobinson 2011-02-06 09:14:48 -0800 Created attachment 81412 Patch 346403 14 81412 dbates 2011-02-06 16:37:37 -0800 Comment on attachment 81412 Patch This makes sense to me. 346407 15 dbates 2011-02-06 17:05:58 -0800 Note, both the Haiku and EFL ports have a similar issue. That is, they use the child frame's loader to load the child frame instead of the parent frame's loader. 346604 16 81412 mrobinson 2011-02-07 08:35:41 -0800 Comment on attachment 81412 Patch Clearing flags on attachment: 81412 Committed r77818: <http://trac.webkit.org/changeset/77818> 346606 17 mrobinson 2011-02-07 08:35:46 -0800 All reviewed patches have been landed. Closing bug. 346623 18 webkit.review.bot 2011-02-07 09:30:34 -0800 http://trac.webkit.org/changeset/77818 might have broken Qt Linux Release, Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Linux ARMv7 Release, Qt Windows 32-bit Release, and Qt Windows 32-bit Debug 346635 19 ossy 2011-02-07 09:44:30 -0800 (In reply to comment #18) > http://trac.webkit.org/changeset/77818 might have broken Qt Linux Release, Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Linux ARMv7 Release, Qt Windows 32-bit Release, and Qt Windows 32-bit Debug 77819 is the culprit 65757 2010-08-27 13:23:08 -0700 2011-02-06 09:14:45 -0800 Patch bug-44784-20100827132307.patch text/plain 1243 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3NjhmMzM4MTgyMTM3ZDNlNWYzNzI0YjgzNjZiNDVlNmE4MDVjZDhlLi5iZjhjZjM5 MjJmODQ5YWFkMzkzZDdjMWMzOWQ0NWJiZjAyNTdlZDczIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDgtMjcgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gZmFzdC9o aXN0b3J5L2hpc3Rvcnktc3ViZnJhbWUtd2l0aC1uYW1lLmh0bWwgZmFpbHMgd2l0aCBHVEsgRFJU CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDc4NAor CisgICAgICAgIFNraXAgZmFzdC9oaXN0b3J5L2hpc3Rvcnktc3ViZnJhbWUtd2l0aC1uYW1lLmh0 bWwgZm9yIEdUSyB3aGlsZSB3ZSBmaWd1cmUgb3V0CisgICAgICAgIHdoeSBpdCBmYWlscyB0aGVy ZS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOgorCiAyMDEwLTA4LTI3ICBHYXZp biBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBPbGl2ZXIgSHVudC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9T a2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5kZXggNzc0Njg0MWRh NTM3Zjk4MzNmNjM5ODRmZjk5ZjU2ZWFiYTE0MWY5NC4uMmQ4Yjk3N2ZjZmQ3NWRkOGZkMWNlMWQ5 OTFhMTc1NDVkNGI5NjMzMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Nr aXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAgLTU5NDIsMyAr NTk0Miw2IEBAIGZhc3QvdGV4dC9oeXBoZW5hdGUtbG9jYWxlLmh0bWwKICMgZmFpbHMgb24gYW5k IG9mZiBvbiB0aGUgNjQtYml0cyBkZWJ1ZyBib3QKICMgc2VlIGFsc286IGh0dHBzOi8vYnVnemls bGEuZ25vbWUub3JnL3Nob3dfYnVnLmNnaT9pZD02MjgwMjAKIG1lZGlhL3ZpZGVvLWJ1ZmZlcmVk Lmh0bWwKKworIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ3ODQK K2Zhc3QvaGlzdG9yeS9oaXN0b3J5LXN1YmZyYW1lLXdpdGgtbmFtZS5odG1sCg== 81412 2011-02-06 09:14:48 -0800 2011-02-07 08:35:41 -0800 Patch bug-44784-20110206091447.patch text/plain 3454 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNmJmNTI3MWE4NGU0NjgwMDU2OTJkMjMzZjAwOTUxZmNjZGNjNGI4Li42MzFlOGVk ZDQ1ZTEwYjU2ZmVjZWZmY2JhOTA0OWRmZDFhOWMyZjJhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAK IDIwMTEtMDItMDYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIGZhc3Qv aGlzdG9yeS9oaXN0b3J5LXN1YmZyYW1lLXdpdGgtbmFtZS5odG1sIGZhaWxzIHdpdGggR1RLIERS VAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ3ODQK KworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOiBVbnNraXAgdGVzdHMgd2hpY2ggYXJl IG5vdyBwYXNzaW5nLgorCisyMDExLTAyLTA2ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25A aWdhbGlhLmNvbT4KKwogICAgICAgICBSZWNsYXNzaWZ5IGEgZmFpbGluZyB0ZXN0IGFuZCB1bnNr aXAgYW5vdGhlciB3aGljaCBzaG91bGQgYmUgcGFzc2luZyBub3cuCiAKICAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvU2tpcHBlZDogVXBkYXRlIHRoZSBza2lwcGVkIGxpc3QuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0 ay9Ta2lwcGVkCmluZGV4IDAzMTU2MDQzNjdhNmVhNDk3NjdiMzgwYzNkMzBmODFhYjQ0NTZkYjUu LmJlZDk5MmVkMmEyNGUxNGMxNGE1OGE1MmM3MmVlYjgzM2MxYzk5YzcgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2d0ay9Ta2lwcGVkCkBAIC00NTI2LDkgKzQ1MjYsNiBAQCBmYXN0L3RleHQvaHlwaGVuYXRlLWxv Y2FsZS5odG1sCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDM4 OQogbWVkaWEvdmlkZW8tdm9sdW1lLmh0bWwKIAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDQ3ODQKLWZhc3QvaGlzdG9yeS9oaXN0b3J5LXN1YmZyYW1lLXdpdGgt bmFtZS5odG1sCi0KICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0 OTMyCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdGguaXNQb2ludEluUGF0aC5lZGdlLmh0bWwK IApAQCAtNDYyOSwxMSArNDYyNiw2IEBAIG1lZGlhL2NvbnRyb2xzLWRyYWctdGltZWJhci5odG1s CiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDUxOAogbWVkaWEv Y29udHJvbHMtd2l0aG91dC1wcmVsb2FkLmh0bWwKIAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTA2NzgKLWZhc3QvaGlzdG9yeS9oaXN0b3J5LWJhY2staW5pdGlh bC12cy1maW5hbC11cmwuaHRtbAotaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3QtZnJhbWVzLWdv YmFjazEuaHRtbAotaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3RyZWRpcmVjdC1mcmFtZXMtZ29i YWNrMS5odG1sCi0KICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUw NzQwCiBlZGl0aW5nL3NwZWxsaW5nL3NwZWxsaW5nLWJhY2tzcGFjZS1iZXR3ZWVuLWxpbmVzLmh0 bWwKIGVkaXRpbmcvc3BlbGxpbmcvc3BlbGxjaGVjay1wYXN0ZS5odG1sCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggZjRjMzk0NjA1MGQ3MWRiY2FiNDJjOTkzYTJmZWUyNzE2OTRlMDFhNy4uYzZkOGVlNDU4 NDZlMjczNTIxMTI3YWYxYTY1ZDY3ZWNjMWZhZGQ2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9ndGsvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDExLTAyLTA2ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb R1RLXSBmYXN0L2hpc3RvcnkvaGlzdG9yeS1zdWJmcmFtZS13aXRoLW5hbWUuaHRtbCBmYWlscyB3 aXRoIEdUSyBEUlQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ0Nzg0CisKKyAgICAgICAgQ2FsbCBGcmFtZUxvYWRlcjo6bG9hZFVSTEludG9DaGlsZEZy YW1lIG9uIHRoZSBwYXJlbnQgZnJhbWUncyBsb2FkZXIsIG5vdCB0aGUgY2hpbGQncy4gCisKKyAg ICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHA6CisgICAgICAg IChXZWJLaXQ6OkZyYW1lTG9hZGVyQ2xpZW50OjpjcmVhdGVGcmFtZSk6IEZpeCB0aGUgY2FsbCB0 byBGcmFtZUxvYWRlcjo6bG9hZFVSTEludG9DaGlsZEZyYW1lLgorCiAyMDExLTAyLTA0ICBKb29u ZSBIdXIgIDxqb29uZS5odXJAY29sbGFib3JhLmNvLnVrPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IEZpeCBjb21waWxhdGlvbiB3YXJuaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsv V2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRHdGsuY3BwIGIvU291cmNlL1dlYktpdC9n dGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRHdGsuY3BwCmluZGV4IDEyNzgzNTlj YmY0ZWE1ZWMxOWM1ODE0NjNkOTczNTUxYTg4NDc0ZTQuLjEwYjAwODg3NjcwMTU4NzMwNzRiZGE5 NTBhMWVkZWYyZjg4NWE5NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVT dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9X ZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKQEAgLTYwNyw3ICs2MDcsNyBA QCBQYXNzUmVmUHRyPEZyYW1lPiBGcmFtZUxvYWRlckNsaWVudDo6Y3JlYXRlRnJhbWUoY29uc3Qg S1VSTCYgdXJsLCBjb25zdCBTdHJpbmcmCiAKICAgICBnX3NpZ25hbF9lbWl0X2J5X25hbWUod2Vi VmlldywgImZyYW1lLWNyZWF0ZWQiLCBraXRGcmFtZSk7CiAKLSAgICBjaGlsZEZyYW1lLT5sb2Fk ZXIoKS0+bG9hZFVSTEludG9DaGlsZEZyYW1lKHVybCwgcmVmZXJyZXIsIGNoaWxkRnJhbWUuZ2V0 KCkpOworICAgIHBhcmVudEZyYW1lLT5sb2FkZXIoKS0+bG9hZFVSTEludG9DaGlsZEZyYW1lKHVy bCwgcmVmZXJyZXIsIGNoaWxkRnJhbWUuZ2V0KCkpOwogCiAgICAgLy8gVGhlIGZyYW1lJ3Mgb25s b2FkIGhhbmRsZXIgbWF5IGhhdmUgcmVtb3ZlZCBpdCBmcm9tIHRoZSBkb2N1bWVudC4KICAgICBp ZiAoIWNoaWxkRnJhbWUtPnRyZWUoKS0+cGFyZW50KCkpCg==