<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>44777</bug_id>
          
          <creation_ts>2010-08-27 09:52:36 -0700</creation_ts>
          <short_desc>Add an ENABLE define for purgeable memory support</short_desc>
          <delta_ts>2010-08-28 00:59:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Pratik Solanki">psolanki</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ddkilzer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>270561</commentid>
    <comment_count>0</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2010-08-27 09:52:36 -0700</bug_when>
    <thetext>We current enable purgeable memory in PurgeableBufferMac.cpp via this if check

#ifndef BUILDING_ON_TIGER

and we disable it in PurgeableBuffer.h by doing

#if !OS(DARWIN) || defined(BUILDING_ON_TIGER) || PLATFORM(QT) || PLATFORM(GTK)

It would be better to have an ENABLE macro that we can define in Platform.h so we could simply use something like #if ENABLE(PURGEABLE_MEMORY)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>270566</commentid>
    <comment_count>1</comment_count>
      <attachid>65727</attachid>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2010-08-27 10:04:23 -0700</bug_when>
    <thetext>Created attachment 65727
add ENABLE_PURGEABLE_MEMORY</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>270947</commentid>
    <comment_count>2</comment_count>
      <attachid>65727</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-08-28 00:59:19 -0700</bug_when>
    <thetext>Comment on attachment 65727
add ENABLE_PURGEABLE_MEMORY

Clearing flags on attachment: 65727

Committed r66301: &lt;http://trac.webkit.org/changeset/66301&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>270948</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-08-28 00:59:23 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>65727</attachid>
            <date>2010-08-27 10:04:23 -0700</date>
            <delta_ts>2010-08-28 00:59:19 -0700</delta_ts>
            <desc>add ENABLE_PURGEABLE_MEMORY</desc>
            <filename>bug-44777.v1.patch</filename>
            <type>text/plain</type>
            <size>2711</size>
            <attacher name="Pratik Solanki">psolanki</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No
YW5nZUxvZwppbmRleCAzNGI2YzEzLi43M2M5MjM3IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg
QEAKKzIwMTAtMDgtMjcgIFByYXRpayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhbiBFTkFC
TEUgZGVmaW5lIGZvciBwdXJnZWFibGUgbWVtb3J5IHN1cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0Nzc3CisKKyAgICAgICAgKiB3dGYvUGxh
dGZvcm0uaDoKKwogMjAxMC0wOC0yNyAgQ2hhby15aW5nIEZ1ICA8ZnVAbWlwcy5jb20+CiAKICAg
ICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29y
ZS93dGYvUGxhdGZvcm0uaCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDJm
Mjc0ODUuLjEyNjk1NDAgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5o
CisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCkBAIC02MTYsNiArNjE2LDEwIEBA
CiAjZGVmaW5lIFdURl9QTEFURk9STV9DRiAxCiAjZW5kaWYKIAorI2lmIE9TKERBUldJTikgJiYg
IWRlZmluZWQoQlVJTERJTkdfT05fVElHRVIpICYmICFQTEFURk9STShHVEspICYmICFQTEFURk9S
TShRVCkKKyNkZWZpbmUgRU5BQkxFX1BVUkdFQUJMRV9NRU1PUlkgMQorI2VuZGlmCisKICNpZiBQ
TEFURk9STShJT1MpCiAjZGVmaW5lIEVOQUJMRV9DT05URVhUX01FTlVTIDAKICNkZWZpbmUgRU5B
QkxFX0RSQUdfU1VQUE9SVCAwCkBAIC04NTYsNiArODYwLDEwIEBACiAjZGVmaW5lIEVOQUJMRV9O
RVRTQ0FQRV9QTFVHSU5fQVBJIDEKICNlbmRpZgogCisjaWYgIWRlZmluZWQoRU5BQkxFX1BVUkdF
QUJMRV9NRU1PUlkpCisjZGVmaW5lIEVOQUJMRV9QVVJHRUFCTEVfTUVNT1JZIDAKKyNlbmRpZgor
CiAjaWYgIWRlZmluZWQoV1RGX1VTRV9QTFVHSU5fSE9TVF9QUk9DRVNTKQogI2RlZmluZSBXVEZf
VVNFX1BMVUdJTl9IT1NUX1BST0NFU1MgMAogI2VuZGlmCmRpZmYgLS1naXQgYS9XZWJDb3JlL0No
YW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGM3MDE3YjIuLmYxZDliNmQgMTAwNjQ0
Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg
KzEsMTMgQEAKKzIwMTAtMDgtMjcgIFByYXRpayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBh
biBFTkFCTEUgZGVmaW5lIGZvciBwdXJnZWFibGUgbWVtb3J5IHN1cHBvcnQKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0Nzc3CisKKyAgICAgICAgKiBw
bGF0Zm9ybS9QdXJnZWFibGVCdWZmZXIuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvUHVyZ2Vh
YmxlQnVmZmVyTWFjLmNwcDoKKwogMjAxMC0wOC0yNyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFu
QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5Lgpk
aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9QdXJnZWFibGVCdWZmZXIuaCBiL1dlYkNvcmUv
cGxhdGZvcm0vUHVyZ2VhYmxlQnVmZmVyLmgKaW5kZXggM2NhZjQ4Mi4uMzIzNDFjMiAxMDA2NDQK
LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9QdXJnZWFibGVCdWZmZXIuaAorKysgYi9XZWJDb3JlL3Bs
YXRmb3JtL1B1cmdlYWJsZUJ1ZmZlci5oCkBAIC02Myw3ICs2Myw3IEBAIG5hbWVzcGFjZSBXZWJD
b3JlIHsKICAgICAgICAgbXV0YWJsZSBTdGF0ZSBtX3N0YXRlOwogICAgIH07CiAKLSNpZiAhT1Mo
REFSV0lOKSB8fCBkZWZpbmVkKEJVSUxESU5HX09OX1RJR0VSKSB8fCBQTEFURk9STShRVCkgfHwg
UExBVEZPUk0oR1RLKQorI2lmICFFTkFCTEUoUFVSR0VBQkxFX01FTU9SWSkKICAgICBpbmxpbmUg
UGFzc093blB0cjxQdXJnZWFibGVCdWZmZXI+IFB1cmdlYWJsZUJ1ZmZlcjo6Y3JlYXRlKGNvbnN0
IGNoYXIqLCBzaXplX3QpIHsgcmV0dXJuIFBhc3NPd25QdHI8UHVyZ2VhYmxlQnVmZmVyPigpOyB9
CiAgICAgaW5saW5lIFB1cmdlYWJsZUJ1ZmZlcjo6flB1cmdlYWJsZUJ1ZmZlcigpIHsgfQogICAg
IGlubGluZSBjb25zdCBjaGFyKiBQdXJnZWFibGVCdWZmZXI6OmRhdGEoKSBjb25zdCB7IHJldHVy
biAwOyB9CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QdXJnZWFibGVCdWZmZXJN
YWMuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUHVyZ2VhYmxlQnVmZmVyTWFjLmNwcAppbmRl
eCBjZTAwNDk0Li41NGRlNGVkIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QdXJn
ZWFibGVCdWZmZXJNYWMuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1B1cmdlYWJsZUJ1
ZmZlck1hYy5jcHAKQEAgLTI1LDcgKzI1LDcgQEAKIAogI2luY2x1ZGUgImNvbmZpZy5oIgogCi0j
aWZuZGVmIEJVSUxESU5HX09OX1RJR0VSCisjaWYgRU5BQkxFKFBVUkdFQUJMRV9NRU1PUlkpCiAK
ICNpbmNsdWRlICJQdXJnZWFibGVCdWZmZXIuaCIKIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>